Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update eventDataIB and add eventReport, eventReports #11383

Merged
merged 1 commit into from
Nov 3, 2021
Merged

update eventDataIB and add eventReport, eventReports #11383

merged 1 commit into from
Nov 3, 2021

Conversation

yunhanw-google
Copy link
Contributor

Problem

Update EventDataIB/EventReportIB/EventReports encoding per latest IM spec and update the corresponding EventManagement.

Change overview

See above

Testing

Add unit tests for EventDataIB/EventReportIB/EventReports

@todo
Copy link

todo bot commented Nov 3, 2021

Update IsUrgent

connectedhomeip/src/app/EventManagement.cpp

Lines 319 to 329 in ed24591

// TODO: Update IsUrgent
// TODO: Update statusIB
eventStatusIBBuilder = eventReportBuilder.CreateEventStatus();
eventPathBuilder = eventStatusIBBuilder.CreatePath();
err = eventStatusIBBuilder.GetError();
SuccessOrExit(err);
eventPathBuilder.Node(apOptions->mpEventSchema->mNodeId)
.Endpoint(apOptions->mpEventSchema->mEndpointId)
.Cluster(apOptions->mpEventSchema->mClusterId)
.Event(apOptions->mpEventSchema->mEventId)
.IsUrgent(false)

This comment was generated by todo based on a TODO comment in ed24591 in #11383. cc @yunhanw-google.

@boring-cyborg boring-cyborg bot added the app label Nov 3, 2021
@todo
Copy link

todo bot commented Nov 3, 2021

Update statusIB

connectedhomeip/src/app/EventManagement.cpp

Lines 320 to 330 in ed24591

// TODO: Update statusIB
eventStatusIBBuilder = eventReportBuilder.CreateEventStatus();
eventPathBuilder = eventStatusIBBuilder.CreatePath();
err = eventStatusIBBuilder.GetError();
SuccessOrExit(err);
eventPathBuilder.Node(apOptions->mpEventSchema->mNodeId)
.Endpoint(apOptions->mpEventSchema->mEndpointId)
.Cluster(apOptions->mpEventSchema->mClusterId)
.Event(apOptions->mpEventSchema->mEventId)
.IsUrgent(false)
.EndOfEventPathIB();

This comment was generated by todo based on a TODO comment in ed24591 in #11383. cc @yunhanw-google.

@yunhanw-google yunhanw-google force-pushed the feature/update_event_data branch from ed24591 to 50fe96e Compare November 3, 2021 17:50
@github-actions
Copy link

github-actions bot commented Nov 3, 2021

PR #11383: Size comparison from fe62374 to 50fe96e

Increases (3 builds for k32w)
platform target config section fe62374 50fe96e change % change
k32w lock-app k32w061+debug (read/write) 591724 591956 232 0.0
.text 515716 515948 232 0.0
shell k32w061+debug (read/write) 657656 657888 232 0.0
.text 571024 571256 232 0.0
lighting-app k32w061+se05x+release (read/write) 699400 699648 248 0.0
.text 613872 614120 248 0.0
Full report (3 builds for k32w)
platform target config section fe62374 50fe96e change % change
k32w lock-app k32w061+debug (read/write) 591724 591956 232 0.0
.bss 68340 68340 0 0.0
.data 1868 1868 0 0.0
.text 515716 515948 232 0.0
shell k32w061+debug (read/write) 657656 657888 232 0.0
.bss 78992 78992 0 0.0
.data 1840 1840 0 0.0
.text 571024 571256 232 0.0
lighting-app k32w061+se05x+release (read/write) 699400 699648 248 0.0
.bss 77824 77824 0 0.0
.data 1904 1904 0 0.0
.text 613872 614120 248 0.0

turon
turon reviewed Nov 3, 2021
View reviewed changes
src/app/EventManagement.cpp Outdated Show resolved Hide resolved
@yunhanw-google yunhanw-google force-pushed the feature/update_event_data branch from 50fe96e to 27566a0 Compare November 3, 2021 19:12
@todo
Copy link

todo bot commented Nov 3, 2021

Update IsUrgent, issue 11386

connectedhomeip/src/app/EventManagement.cpp

Lines 319 to 329 in 27566a0

// TODO: Update IsUrgent, issue 11386
// TODO: Update statusIB, issue 11388
eventStatusIBBuilder = eventReportBuilder.CreateEventStatus();
eventPathBuilder = eventStatusIBBuilder.CreatePath();
err = eventStatusIBBuilder.GetError();
SuccessOrExit(err);
eventPathBuilder.Node(apOptions->mpEventSchema->mNodeId)
.Endpoint(apOptions->mpEventSchema->mEndpointId)
.Cluster(apOptions->mpEventSchema->mClusterId)
.Event(apOptions->mpEventSchema->mEventId)
.IsUrgent(false)

This comment was generated by todo based on a TODO comment in 27566a0 in #11383. cc @yunhanw-google.

@todo
Copy link

todo bot commented Nov 3, 2021

Update statusIB, issue 11388

connectedhomeip/src/app/EventManagement.cpp

Lines 320 to 330 in 27566a0

// TODO: Update statusIB, issue 11388
eventStatusIBBuilder = eventReportBuilder.CreateEventStatus();
eventPathBuilder = eventStatusIBBuilder.CreatePath();
err = eventStatusIBBuilder.GetError();
SuccessOrExit(err);
eventPathBuilder.Node(apOptions->mpEventSchema->mNodeId)
.Endpoint(apOptions->mpEventSchema->mEndpointId)
.Cluster(apOptions->mpEventSchema->mClusterId)
.Event(apOptions->mpEventSchema->mEventId)
.IsUrgent(false)
.EndOfEventPathIB();

This comment was generated by todo based on a TODO comment in 27566a0 in #11383. cc @yunhanw-google.

@yunhanw-google yunhanw-google requested a review from turon November 3, 2021 19:13
@github-actions
Copy link

github-actions bot commented Nov 3, 2021 •
edited
Loading

PR #11383: Size comparison from fe62374 to 27566a0

Increases above 0.2%:

platform target config section fe62374 27566a0 change % change
linux all-clusters-app debug (read only) 1691153 1696289 5136 0.3
.rodata 139925 140277 352 0.3
.text 1417810 1422594 4784 0.3
bridge-app debug+rpc (read only) 1287373 1292477 5104 0.4
.rodata 111460 111780 320 0.3
.text 1080021 1084805 4784 0.4
lighting-app debug+rpc (read only) 1548401 1553505 5104 0.3
.rodata 130129 130449 320 0.2
.text 1284690 1289474 4784 0.4
ota-provider-app debug (read only) 1243889 1249025 5136 0.4
.rodata 112456 112808 352 0.3
.text 1035330 1040114 4784 0.5
ota-requestor-app debug (read only) 1311169 1316337 5168 0.4
.rodata 123344 123728 384 0.3
.text 1090034 1094818 4784 0.4
tv-app debug (read only) 1810537 1815641 5104 0.3
.rodata 155528 155848 320 0.2
.text 1512722 1517506 4784 0.3
Increases (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section fe62374 27566a0 change % change
efr32 lighting-app BRD4161A (read only) 737152 737416 264 0.0
.text 737144 737408 264 0.0
BRD4161A+rpc (read only) 726332 726612 280 0.0
.text 726324 726604 280 0.0
lock-app BRD4161A (read only) 716416 716696 280 0.0
.text 716408 716688 280 0.0
window-app BRD4161A (read only) 717332 717596 264 0.0
.text 717324 717588 264 0.0
esp32 all-clusters-app c3devkit (read only) 880670 880818 148 0.0
(read/write) 1308064 1308104 40 0.0
.flash.rodata 199776 199816 40 0.0
.flash.text 880670 880818 148 0.0
m5stack (read only) 911823 911947 124 0.0
(read/write) 427828 427868 40 0.0
.flash.rodata 208476 208516 40 0.0
.flash.text 911823 911947 124 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699400 699632 232 0.0
.text 613872 614104 232 0.0
lock-app k32w061+debug (read/write) 591724 591956 232 0.0
.text 515716 515948 232 0.0
shell k32w061+debug (read/write) 657656 657888 232 0.0
.text 571024 571256 232 0.0
linux all-clusters-app debug (read only) 1691153 1696289 5136 0.3
.rodata 139925 140277 352 0.3
.text 1417810 1422594 4784 0.3
bridge-app debug+rpc (read only) 1287373 1292477 5104 0.4
.rodata 111460 111780 320 0.3
.text 1080021 1084805 4784 0.4
chip-tool debug (read only) 4422981 4428085 5104 0.1
.rodata 226384 226704 320 0.1
.text 3928277 3933061 4784 0.1
lighting-app debug+rpc (read only) 1548401 1553505 5104 0.3
.rodata 130129 130449 320 0.2
.text 1284690 1289474 4784 0.4
ota-provider-app debug (read only) 1243889 1249025 5136 0.4
.rodata 112456 112808 352 0.3
.text 1035330 1040114 4784 0.5
ota-requestor-app debug (read only) 1311169 1316337 5168 0.4
.rodata 123344 123728 384 0.3
.text 1090034 1094818 4784 0.4
tv-app debug (read only) 1810537 1815641 5104 0.3
.rodata 155528 155848 320 0.2
.text 1512722 1517506 4784 0.3
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2293160 2293192 32 0.0
.text 1255760 1255792 32 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2272728 2272760 32 0.0
.text 1235328 1235360 32 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2250448 2250480 32 0.0
.text 1213048 1213080 32 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861379 861607 228 0.0
rodata 96772 96808 36 0.0
text 577704 577900 196 0.0
nrf52840dk_nrf52840+rpc (read/write) 823755 823987 232 0.0
rodata 87948 87988 40 0.0
text 551888 552088 200 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786418 786646 228 0.0
rodata 92028 92064 36 0.0
text 507164 507364 200 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838083 838315 232 0.0
rodata 93140 93180 40 0.0
text 559180 559376 196 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763382 763610 228 0.0
rodata 88448 88484 36 0.0
text 488732 488932 200 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844195 844423 228 0.0
rodata 94852 94888 36 0.0
text 563360 563556 196 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837939 838167 228 0.0
rodata 93140 93176 36 0.0
text 558916 559112 196 0.0
p6 all-clusters-app default (read/write) 2300640 2300920 280 0.0
.text 1258904 1259184 280 0.0
lock-app default (read/write) 2213648 2213928 280 0.0
.text 1171912 1172192 280 0.0
qpg lighting-app qpg6100+debug (read only) 490700 490924 224 0.0
.text 485380 485604 224 0.0
lock-app qpg6100+debug (read only) 467040 467264 224 0.0
.text 461720 461944 224 0.0
telink lighting-app tlsr9518adk80d (read/write) 662894 663086 192 0.0
text 458058 458206 148 0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section fe62374 27566a0 change % change
efr32 lighting-app BRD4161A (read only) 737152 737416 264 0.0
(read/write) 114588 114588 0 0.0
.bss 112828 112828 0 0.0
.data 1756 1756 0 0.0
.text 737144 737408 264 0.0
BRD4161A+rpc (read only) 726332 726612 280 0.0
(read/write) 131204 131204 0 0.0
.bss 129332 129332 0 0.0
.data 1872 1872 0 0.0
.text 726324 726604 280 0.0
lock-app BRD4161A (read only) 716416 716696 280 0.0
(read/write) 112404 112404 0 0.0
.bss 110684 110684 0 0.0
.data 1716 1716 0 0.0
.text 716408 716688 280 0.0
window-app BRD4161A (read only) 717332 717596 264 0.0
(read/write) 112724 112724 0 0.0
.bss 111004 111004 0 0.0
.data 1720 1720 0 0.0
.text 717324 717588 264 0.0
esp32 all-clusters-app c3devkit (read only) 880670 880818 148 0.0
(read/write) 1308064 1308104 40 0.0
.dram0.bss 58584 58584 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 199776 199816 40 0.0
.flash.text 880670 880818 148 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 911823 911947 124 0.0
(read/write) 427828 427868 40 0.0
.dram0.bss 61088 61088 0 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 208476 208516 40 0.0
.flash.text 911823 911947 124 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699400 699632 232 0.0
.bss 77824 77824 0 0.0
.data 1904 1904 0 0.0
.text 613872 614104 232 0.0
lock-app k32w061+debug (read/write) 591724 591956 232 0.0
.bss 68340 68340 0 0.0
.data 1868 1868 0 0.0
.text 515716 515948 232 0.0
shell k32w061+debug (read/write) 657656 657888 232 0.0
.bss 78992 78992 0 0.0
.data 1840 1840 0 0.0
.text 571024 571256 232 0.0
linux all-clusters-app debug (read only) 1691153 1696289 5136 0.3
(read/write) 119696 119696 0 0.0
.bss 51120 51120 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62272 62272 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 139925 140277 352 0.3
.text 1417810 1422594 4784 0.3
bridge-app debug+rpc (read only) 1287373 1292477 5104 0.4
(read/write) 69320 69320 0 0.0
.bss 35024 35024 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27768 27768 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 111460 111780 320 0.3
.text 1080021 1084805 4784 0.4
chip-tool debug (read only) 4422981 4428085 5104 0.1
(read/write) 125888 125888 0 0.0
.bss 18224 18224 0 0.0
.data 2224 2224 0 0.0
.data.rel.ro 100032 100032 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 226384 226704 320 0.1
.text 3928277 3933061 4784 0.1
lighting-app debug+rpc (read only) 1548401 1553505 5104 0.3
(read/write) 102288 102288 0 0.0
.bss 40664 40664 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 55168 55168 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 130129 130449 320 0.2
.text 1284690 1289474 4784 0.4
ota-provider-app debug (read only) 1243889 1249025 5136 0.4
(read/write) 67488 67488 0 0.0
.bss 37088 37088 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24568 24568 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 112456 112808 352 0.3
.text 1035330 1040114 4784 0.5
ota-requestor-app debug (read only) 1311169 1316337 5168 0.4
(read/write) 76808 76808 0 0.0
.bss 45344 45344 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25512 25512 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 123344 123728 384 0.3
.text 1090034 1094818 4784 0.4
shell debug (read only) 786641 786641 0 0.0
(read/write) 57600 57600 0 0.0
.bss 16040 16040 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77839 77839 0 0.0
.text 607314 607314 0 0.0
tv-app debug (read only) 1810537 1815641 5104 0.3
(read/write) 289912 289912 0 0.0
.bss 222736 222736 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 58824 58824 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 155528 155848 320 0.2
.text 1512722 1517506 4784 0.3
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293160 2293192 32 0.0
.bss 179940 179940 0 0.0
.data 5216 5216 0 0.0
.heap 851288 851288 0 0.0
.text 1255760 1255792 32 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2272728 2272760 32 0.0
.bss 171980 171980 0 0.0
.data 5568 5568 0 0.0
.heap 858896 858896 0 0.0
.text 1235328 1235360 32 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250448 2250480 32 0.0
.bss 170876 170876 0 0.0
.data 5560 5560 0 0.0
.heap 860008 860008 0 0.0
.text 1213048 1213080 32 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048368 2048368 0 0.0
.bss 156224 156224 0 0.0
.data 4960 4960 0 0.0
.heap 875264 875264 0 0.0
.text 1010968 1010968 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861379 861607 228 0.0
bss 111288 111288 0 0.0
rodata 96772 96808 36 0.0
text 577704 577900 196 0.0
nrf52840dk_nrf52840+rpc (read/write) 823755 823987 232 0.0
bss 107640 107640 0 0.0
rodata 87948 87988 40 0.0
text 551888 552088 200 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786418 786646 228 0.0
bss 112664 112664 0 0.0
rodata 92028 92064 36 0.0
text 507164 507364 200 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838083 838315 232 0.0
bss 110324 110324 0 0.0
rodata 93140 93180 40 0.0
text 559180 559376 196 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763382 763610 228 0.0
bss 111732 111732 0 0.0
rodata 88448 88484 36 0.0
text 488732 488932 200 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844195 844423 228 0.0
bss 110460 110460 0 0.0
rodata 94852 94888 36 0.0
text 563360 563556 196 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837939 838167 228 0.0
bss 110360 110360 0 0.0
rodata 93140 93176 36 0.0
text 558916 559112 196 0.0
shell nrf52840dk_nrf52840 (read/write) 775975 775975 0 0.0
bss 109080 109080 0 0.0
rodata 72412 72412 0 0.0
text 519896 519896 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691010 691010 0 0.0
bss 110060 110060 0 0.0
rodata 67052 67052 0 0.0
text 440492 440492 0 0.0
p6 all-clusters-app default (read/write) 2300640 2300920 280 0.0
.bss 107880 107880 0 0.0
.data 2520 2520 0 0.0
.heap 922944 922944 0 0.0
.text 1258904 1259184 280 0.0
lock-app default (read/write) 2213648 2213928 280 0.0
.bss 95680 95680 0 0.0
.data 2392 2392 0 0.0
.heap 935272 935272 0 0.0
.text 1171912 1172192 280 0.0
qpg lighting-app qpg6100+debug (read only) 490700 490924 224 0.0
(read/write) 114140 114140 0 0.0
.bss 50968 50968 0 0.0
.data 1004 1004 0 0.0
.text 485380 485604 224 0.0
lock-app qpg6100+debug (read only) 467040 467264 224 0.0
(read/write) 114144 114144 0 0.0
.bss 49912 49912 0 0.0
.data 960 960 0 0.0
.text 461720 461944 224 0.0
persistent-storage-app qpg6100+debug (read only) 153212 153212 0 0.0
(read/write) 114140 114140 0 0.0
.bss 18920 18920 0 0.0
.data 356 356 0 0.0
.text 147892 147892 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662894 663086 192 0.0
bss 69100 69100 0 0.0
noinit 33216 33216 0 0.0
text 458058 458206 148 0.0

yufengwangca
yufengwangca approved these changes Nov 3, 2021
View reviewed changes
src/app/EventManagement.cpp Outdated Show resolved Hide resolved
src/app/EventManagement.cpp Outdated Show resolved Hide resolved
@yunhanw-google yunhanw-google force-pushed the feature/update_event_data branch from 27566a0 to 69f14e2 Compare November 3, 2021 21:48
@github-actions
Copy link

github-actions bot commented Nov 3, 2021 •
edited
Loading

PR #11383: Size comparison from 38fe11e to 69f14e2

Increases above 0.2%:

platform target config section 38fe11e 69f14e2 change % change
linux all-clusters-app debug (read only) 1691153 1696289 5136 0.3
.rodata 139925 140277 352 0.3
.text 1417810 1422594 4784 0.3
bridge-app debug+rpc (read only) 1287373 1292477 5104 0.4
.rodata 111460 111780 320 0.3
.text 1080021 1084805 4784 0.4
lighting-app debug+rpc (read only) 1548401 1553505 5104 0.3
.text 1284690 1289474 4784 0.4
ota-provider-app debug (read only) 1243889 1249025 5136 0.4
.rodata 112456 112808 352 0.3
.text 1035330 1040114 4784 0.5
ota-requestor-app debug (read only) 1311169 1316337 5168 0.4
.rodata 123344 123728 384 0.3
.text 1090034 1094818 4784 0.4
tv-app debug (read only) 1810537 1815641 5104 0.3
.text 1512722 1517506 4784 0.3
Increases (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 38fe11e 69f14e2 change % change
efr32 lighting-app BRD4161A (read only) 737168 737432 264 0.0
.text 737160 737424 264 0.0
BRD4161A+rpc (read only) 726364 726628 264 0.0
.text 726356 726620 264 0.0
lock-app BRD4161A (read only) 716432 716696 264 0.0
.text 716424 716688 264 0.0
window-app BRD4161A (read only) 717332 717612 280 0.0
.text 717324 717604 280 0.0
esp32 all-clusters-app c3devkit (read only) 880670 880818 148 0.0
(read/write) 1308064 1308104 40 0.0
.flash.rodata 199776 199816 40 0.0
.flash.text 880670 880818 148 0.0
m5stack (read only) 911823 911947 124 0.0
(read/write) 427828 427868 40 0.0
.flash.rodata 208476 208516 40 0.0
.flash.text 911823 911947 124 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699416 699648 232 0.0
.text 613888 614120 232 0.0
lock-app k32w061+debug (read/write) 591724 591956 232 0.0
.text 515716 515948 232 0.0
shell k32w061+debug (read/write) 657656 657904 248 0.0
.text 571024 571272 248 0.0
linux all-clusters-app debug (read only) 1691153 1696289 5136 0.3
.rodata 139925 140277 352 0.3
.text 1417810 1422594 4784 0.3
bridge-app debug+rpc (read only) 1287373 1292477 5104 0.4
.rodata 111460 111780 320 0.3
.text 1080021 1084805 4784 0.4
chip-tool debug (read only) 4422981 4428085 5104 0.1
.rodata 226384 226704 320 0.1
.text 3928277 3933061 4784 0.1
lighting-app debug+rpc (read only) 1548401 1553505 5104 0.3
.rodata 130129 130449 320 0.2
.text 1284690 1289474 4784 0.4
ota-provider-app debug (read only) 1243889 1249025 5136 0.4
.rodata 112456 112808 352 0.3
.text 1035330 1040114 4784 0.5
ota-requestor-app debug (read only) 1311169 1316337 5168 0.4
.rodata 123344 123728 384 0.3
.text 1090034 1094818 4784 0.4
tv-app debug (read only) 1810537 1815641 5104 0.3
.rodata 155528 155848 320 0.2
.text 1512722 1517506 4784 0.3
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2293160 2293192 32 0.0
.text 1255760 1255792 32 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2272728 2272760 32 0.0
.text 1235328 1235360 32 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2250448 2250480 32 0.0
.text 1213048 1213080 32 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861379 861623 244 0.0
rodata 96772 96808 36 0.0
text 577712 577912 200 0.0
nrf52840dk_nrf52840+rpc (read/write) 823755 824003 248 0.0
rodata 87948 87988 40 0.0
text 551896 552100 204 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786418 786662 244 0.0
rodata 92028 92064 36 0.0
text 507168 507372 204 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838083 838331 248 0.0
rodata 93140 93180 40 0.0
text 559188 559388 200 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763382 763626 244 0.0
rodata 88448 88484 36 0.0
text 488736 488940 204 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844195 844439 244 0.0
rodata 94852 94888 36 0.0
text 563368 563568 200 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837955 838183 228 0.0
rodata 93140 93176 36 0.0
text 558924 559124 200 0.0
p6 all-clusters-app default (read/write) 2300656 2300920 264 0.0
.text 1258920 1259184 264 0.0
lock-app default (read/write) 2213648 2213928 280 0.0
.text 1171912 1172192 280 0.0
qpg lighting-app qpg6100+debug (read only) 490708 490932 224 0.0
.text 485388 485612 224 0.0
lock-app qpg6100+debug (read only) 467048 467280 232 0.0
.text 461728 461960 232 0.1
telink lighting-app tlsr9518adk80d (read/write) 662894 663086 192 0.0
text 458058 458206 148 0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 38fe11e 69f14e2 change % change
efr32 lighting-app BRD4161A (read only) 737168 737432 264 0.0
(read/write) 114588 114588 0 0.0
.bss 112828 112828 0 0.0
.data 1756 1756 0 0.0
.text 737160 737424 264 0.0
BRD4161A+rpc (read only) 726364 726628 264 0.0
(read/write) 131204 131204 0 0.0
.bss 129332 129332 0 0.0
.data 1872 1872 0 0.0
.text 726356 726620 264 0.0
lock-app BRD4161A (read only) 716432 716696 264 0.0
(read/write) 112404 112404 0 0.0
.bss 110684 110684 0 0.0
.data 1716 1716 0 0.0
.text 716424 716688 264 0.0
window-app BRD4161A (read only) 717332 717612 280 0.0
(read/write) 112724 112724 0 0.0
.bss 111004 111004 0 0.0
.data 1720 1720 0 0.0
.text 717324 717604 280 0.0
esp32 all-clusters-app c3devkit (read only) 880670 880818 148 0.0
(read/write) 1308064 1308104 40 0.0
.dram0.bss 58584 58584 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 199776 199816 40 0.0
.flash.text 880670 880818 148 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 911823 911947 124 0.0
(read/write) 427828 427868 40 0.0
.dram0.bss 61088 61088 0 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 208476 208516 40 0.0
.flash.text 911823 911947 124 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699416 699648 232 0.0
.bss 77824 77824 0 0.0
.data 1904 1904 0 0.0
.text 613888 614120 232 0.0
lock-app k32w061+debug (read/write) 591724 591956 232 0.0
.bss 68340 68340 0 0.0
.data 1868 1868 0 0.0
.text 515716 515948 232 0.0
shell k32w061+debug (read/write) 657656 657904 248 0.0
.bss 78992 78992 0 0.0
.data 1840 1840 0 0.0
.text 571024 571272 248 0.0
linux all-clusters-app debug (read only) 1691153 1696289 5136 0.3
(read/write) 119696 119696 0 0.0
.bss 51120 51120 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62272 62272 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 139925 140277 352 0.3
.text 1417810 1422594 4784 0.3
bridge-app debug+rpc (read only) 1287373 1292477 5104 0.4
(read/write) 69320 69320 0 0.0
.bss 35024 35024 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27768 27768 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 111460 111780 320 0.3
.text 1080021 1084805 4784 0.4
chip-tool debug (read only) 4422981 4428085 5104 0.1
(read/write) 125888 125888 0 0.0
.bss 18224 18224 0 0.0
.data 2224 2224 0 0.0
.data.rel.ro 100032 100032 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 226384 226704 320 0.1
.text 3928277 3933061 4784 0.1
lighting-app debug+rpc (read only) 1548401 1553505 5104 0.3
(read/write) 102288 102288 0 0.0
.bss 40664 40664 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 55168 55168 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 130129 130449 320 0.2
.text 1284690 1289474 4784 0.4
ota-provider-app debug (read only) 1243889 1249025 5136 0.4
(read/write) 67488 67488 0 0.0
.bss 37088 37088 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24568 24568 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 112456 112808 352 0.3
.text 1035330 1040114 4784 0.5
ota-requestor-app debug (read only) 1311169 1316337 5168 0.4
(read/write) 76808 76808 0 0.0
.bss 45344 45344 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25512 25512 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 123344 123728 384 0.3
.text 1090034 1094818 4784 0.4
shell debug (read only) 786641 786641 0 0.0
(read/write) 57600 57600 0 0.0
.bss 16040 16040 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77839 77839 0 0.0
.text 607314 607314 0 0.0
tv-app debug (read only) 1810537 1815641 5104 0.3
(read/write) 289912 289912 0 0.0
.bss 222736 222736 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 58824 58824 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 155528 155848 320 0.2
.text 1512722 1517506 4784 0.3
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293160 2293192 32 0.0
.bss 179940 179940 0 0.0
.data 5216 5216 0 0.0
.heap 851288 851288 0 0.0
.text 1255760 1255792 32 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2272728 2272760 32 0.0
.bss 171980 171980 0 0.0
.data 5568 5568 0 0.0
.heap 858896 858896 0 0.0
.text 1235328 1235360 32 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250448 2250480 32 0.0
.bss 170876 170876 0 0.0
.data 5560 5560 0 0.0
.heap 860008 860008 0 0.0
.text 1213048 1213080 32 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048368 2048368 0 0.0
.bss 156224 156224 0 0.0
.data 4960 4960 0 0.0
.heap 875264 875264 0 0.0
.text 1010968 1010968 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861379 861623 244 0.0
bss 111288 111288 0 0.0
rodata 96772 96808 36 0.0
text 577712 577912 200 0.0
nrf52840dk_nrf52840+rpc (read/write) 823755 824003 248 0.0
bss 107640 107640 0 0.0
rodata 87948 87988 40 0.0
text 551896 552100 204 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786418 786662 244 0.0
bss 112664 112664 0 0.0
rodata 92028 92064 36 0.0
text 507168 507372 204 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838083 838331 248 0.0
bss 110324 110324 0 0.0
rodata 93140 93180 40 0.0
text 559188 559388 200 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763382 763626 244 0.0
bss 111732 111732 0 0.0
rodata 88448 88484 36 0.0
text 488736 488940 204 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844195 844439 244 0.0
bss 110460 110460 0 0.0
rodata 94852 94888 36 0.0
text 563368 563568 200 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837955 838183 228 0.0
bss 110360 110360 0 0.0
rodata 93140 93176 36 0.0
text 558924 559124 200 0.0
shell nrf52840dk_nrf52840 (read/write) 775975 775975 0 0.0
bss 109080 109080 0 0.0
rodata 72412 72412 0 0.0
text 519904 519904 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691010 691010 0 0.0
bss 110060 110060 0 0.0
rodata 67052 67052 0 0.0
text 440496 440496 0 0.0
p6 all-clusters-app default (read/write) 2300656 2300920 264 0.0
.bss 107880 107880 0 0.0
.data 2520 2520 0 0.0
.heap 922944 922944 0 0.0
.text 1258920 1259184 264 0.0
lock-app default (read/write) 2213648 2213928 280 0.0
.bss 95680 95680 0 0.0
.data 2392 2392 0 0.0
.heap 935272 935272 0 0.0
.text 1171912 1172192 280 0.0
qpg lighting-app qpg6100+debug (read only) 490708 490932 224 0.0
(read/write) 114140 114140 0 0.0
.bss 50968 50968 0 0.0
.data 1004 1004 0 0.0
.text 485388 485612 224 0.0
lock-app qpg6100+debug (read only) 467048 467280 232 0.0
(read/write) 114144 114144 0 0.0
.bss 49912 49912 0 0.0
.data 960 960 0 0.0
.text 461728 461960 232 0.1
persistent-storage-app qpg6100+debug (read only) 153212 153212 0 0.0
(read/write) 114140 114140 0 0.0
.bss 18920 18920 0 0.0
.data 356 356 0 0.0
.text 147892 147892 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662894 663086 192 0.0
bss 69100 69100 0 0.0
noinit 33216 33216 0 0.0
text 458058 458206 148 0.0

@yunhanw-google yunhanw-google merged commit 3bec0f9 into project-chip:master Nov 3, 2021
This was referenced Nov 3, 2021
Closed
Closed
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@yunhanw-google
update eventDataIB and add eventReport, eventReports (project-chip#11383
08b7f39 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@yufengwangca yufengwangca yufengwangca approved these changes

@LuDuda LuDuda LuDuda approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@turon turon Awaiting requested review from turon

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yunhanw-google @turon @LuDuda @yufengwangca @jmartinez-silabs