Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove UnauthenticatedSession::mLocalMessageCounter #11375

Merged
merged 1 commit into from
Nov 3, 2021
Merged

Remove UnauthenticatedSession::mLocalMessageCounter #11375

merged 1 commit into from
Nov 3, 2021

Conversation

kghost
Copy link
Contributor

@kghost kghost commented Nov 3, 2021

Problem

Unauthenticated session counter is no longer defined in specs.

Change overview

Remove UnauthenticatedSession::mLocalMessageCounter, use the global counter instead.

Testing

Verified by unit-tests

@github-actions
Copy link

github-actions bot commented Nov 3, 2021 •
edited
Loading

PR #11375: Size comparison from 4947759 to acae28c

Increases (16 builds for mbed, nrfconnect, p6, telink)
platform target config section 4947759 acae28c change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 851256 851288 32 0.0
lighting-app CY8CPROTO_062_4343W+release .heap 858864 858896 32 0.0
lock-app CY8CPROTO_062_4343W+release .heap 859976 860008 32 0.0
shell CY8CPROTO_062_4343W+release .heap 875232 875264 32 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 text 577692 577696 4 0.0
nrf52840dk_nrf52840+rpc text 551876 551880 4 0.0
nrf5340dk_nrf5340_cpuapp text 507152 507156 4 0.0
lock-app nrf52840dk_nrf52840 text 559168 559172 4 0.0
nrf5340dk_nrf5340_cpuapp text 488720 488724 4 0.0
pump-app nrf52840dk_nrf52840 text 563348 563352 4 0.0
pump-controller-app nrf52840dk_nrf52840 text 558904 558908 4 0.0
shell nrf52840dk_nrf52840 text 519884 519888 4 0.0
nrf5340dk_nrf5340_cpuapp text 440480 440484 4 0.0
p6 all-clusters-app default .heap 922912 922944 32 0.0
lock-app default .heap 935240 935272 32 0.0
telink lighting-app tlsr9518adk80d text 458028 458042 14 0.0
Decreases (35 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 4947759 acae28c change % change
efr32 lighting-app BRD4161A (read only) 737248 737136 -112 -0.0
(read/write) 114620 114588 -32 -0.0
.bss 112860 112828 -32 -0.0
.text 737240 737128 -112 -0.0
BRD4161A+rpc (read only) 726428 726316 -112 -0.0
(read/write) 131236 131204 -32 -0.0
.bss 129364 129332 -32 -0.0
.text 726420 726308 -112 -0.0
lock-app BRD4161A (read only) 716528 716400 -128 -0.0
(read/write) 112436 112404 -32 -0.0
.bss 110716 110684 -32 -0.0
.text 716520 716392 -128 -0.0
window-app BRD4161A (read only) 717428 717316 -112 -0.0
(read/write) 112756 112724 -32 -0.0
.bss 111036 111004 -32 -0.0
.text 717420 717308 -112 -0.0
esp32 all-clusters-app c3devkit (read only) 880742 880650 -92 -0.0
(read/write) 1308096 1308064 -32 -0.0
.dram0.bss 58616 58584 -32 -0.1
.flash.text 880742 880650 -92 -0.0
m5stack (read only) 911831 911719 -112 -0.0
(read/write) 427860 427828 -32 -0.0
.dram0.bss 61120 61088 -32 -0.1
.flash.text 911831 911719 -112 -0.0
k32w lighting-app k32w061+se05x+release (read/write) 699528 699400 -128 -0.0
.bss 77856 77824 -32 -0.0
.text 613968 613872 -96 -0.0
lock-app k32w061+debug (read/write) 591836 591708 -128 -0.0
.bss 68372 68340 -32 -0.0
.text 515796 515700 -96 -0.0
shell k32w061+debug (read/write) 424916 424788 -128 -0.0
.bss 63296 63264 -32 -0.1
.text 359248 359152 -96 -0.0
linux all-clusters-app debug (read only) 1690937 1690825 -112 -0.0
(read/write) 119760 119696 -64 -0.1
.bss 51184 51120 -64 -0.1
.text 1417714 1417602 -112 -0.0
bridge-app debug+rpc (read only) 1287325 1287213 -112 -0.0
(read/write) 69384 69320 -64 -0.1
.bss 35088 35024 -64 -0.2
.text 1079973 1079861 -112 -0.0
chip-tool debug (read only) 4351269 4350973 -296 -0.0
.rodata 219560 219376 -184 -0.1
.text 3865669 3865557 -112 -0.0
lighting-app debug+rpc (read only) 1548297 1548073 -224 -0.0
(read/write) 102352 102288 -64 -0.1
.bss 40728 40664 -64 -0.2
.rodata 130129 130033 -96 -0.1
.text 1284610 1284482 -128 -0.0
ota-provider-app debug (read only) 1243689 1243561 -128 -0.0
(read/write) 67552 67488 -64 -0.1
.bss 37152 37088 -64 -0.2
.text 1035250 1035122 -128 -0.0
ota-requestor-app debug (read only) 1311049 1310841 -208 -0.0
(read/write) 76872 76808 -64 -0.1
.bss 45408 45344 -64 -0.1
.rodata 123328 123248 -80 -0.1
.text 1089954 1089826 -128 -0.0
shell debug (read only) 786593 786465 -128 -0.0
(read/write) 57664 57600 -64 -0.1
.bss 16104 16040 -64 -0.4
.text 607266 607138 -128 -0.0
tv-app debug (read only) 1810545 1810209 -336 -0.0
(read/write) 289944 289880 -64 -0.0
.bss 222768 222704 -64 -0.0
.rodata 155640 155432 -208 -0.1
.text 1512642 1512514 -128 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2293224 2293160 -64 -0.0
.bss 179972 179940 -32 -0.0
.text 1255824 1255760 -64 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2272792 2272728 -64 -0.0
.bss 172012 171980 -32 -0.0
.text 1235392 1235328 -64 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2250512 2250384 -128 -0.0
.bss 170908 170876 -32 -0.0
.text 1213112 1212984 -128 -0.0
shell CY8CPROTO_062_4343W+release (read/write) 2048496 2048368 -128 -0.0
.bss 156256 156224 -32 -0.0
.text 1011096 1010968 -128 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861395 861363 -32 -0.0
bss 111320 111288 -32 -0.0
nrf52840dk_nrf52840+rpc (read/write) 823771 823739 -32 -0.0
bss 107672 107640 -32 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786434 786402 -32 -0.0
bss 112696 112664 -32 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 838099 838067 -32 -0.0
bss 110356 110324 -32 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763398 763366 -32 -0.0
bss 111764 111732 -32 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 844211 844179 -32 -0.0
bss 110492 110460 -32 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837955 837939 -16 -0.0
bss 110392 110360 -32 -0.0
shell nrf52840dk_nrf52840 (read/write) 775991 775959 -32 -0.0
bss 109112 109080 -32 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691026 690994 -32 -0.0
bss 110092 110060 -32 -0.0
p6 all-clusters-app default (read/write) 2300752 2300624 -128 -0.0
.bss 107912 107880 -32 -0.0
.text 1259016 1258888 -128 -0.0
lock-app default (read/write) 2213744 2213632 -112 -0.0
.bss 95712 95680 -32 -0.0
.text 1172008 1171896 -112 -0.0
qpg lighting-app qpg6100+debug (read only) 490784 490692 -92 -0.0
.bss 50416 50384 -32 -0.1
.text 485464 485372 -92 -0.0
lock-app qpg6100+debug (read only) 467120 467032 -88 -0.0
.bss 49360 49328 -32 -0.1
.text 461800 461712 -88 -0.0
telink lighting-app tlsr9518adk80d (read/write) 662894 662878 -16 -0.0
bss 69132 69100 -32 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 4947759 acae28c change % change
efr32 lighting-app BRD4161A (read only) 737248 737136 -112 -0.0
(read/write) 114620 114588 -32 -0.0
.bss 112860 112828 -32 -0.0
.data 1756 1756 0 0.0
.text 737240 737128 -112 -0.0
BRD4161A+rpc (read only) 726428 726316 -112 -0.0
(read/write) 131236 131204 -32 -0.0
.bss 129364 129332 -32 -0.0
.data 1872 1872 0 0.0
.text 726420 726308 -112 -0.0
lock-app BRD4161A (read only) 716528 716400 -128 -0.0
(read/write) 112436 112404 -32 -0.0
.bss 110716 110684 -32 -0.0
.data 1716 1716 0 0.0
.text 716520 716392 -128 -0.0
window-app BRD4161A (read only) 717428 717316 -112 -0.0
(read/write) 112756 112724 -32 -0.0
.bss 111036 111004 -32 -0.0
.data 1720 1720 0 0.0
.text 717420 717308 -112 -0.0
esp32 all-clusters-app c3devkit (read only) 880742 880650 -92 -0.0
(read/write) 1308096 1308064 -32 -0.0
.dram0.bss 58616 58584 -32 -0.1
.dram0.data 16464 16464 0 0.0
.flash.rodata 199776 199776 0 0.0
.flash.text 880742 880650 -92 -0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 911831 911719 -112 -0.0
(read/write) 427860 427828 -32 -0.0
.dram0.bss 61120 61088 -32 -0.1
.dram0.data 32100 32100 0 0.0
.flash.rodata 208476 208476 0 0.0
.flash.text 911831 911719 -112 -0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699528 699400 -128 -0.0
.bss 77856 77824 -32 -0.0
.data 1904 1904 0 0.0
.text 613968 613872 -96 -0.0
lock-app k32w061+debug (read/write) 591836 591708 -128 -0.0
.bss 68372 68340 -32 -0.0
.data 1868 1868 0 0.0
.text 515796 515700 -96 -0.0
shell k32w061+debug (read/write) 424916 424788 -128 -0.0
.bss 63296 63264 -32 -0.1
.data 668 668 0 0.0
.text 359248 359152 -96 -0.0
linux all-clusters-app debug (read only) 1690937 1690825 -112 -0.0
(read/write) 119760 119696 -64 -0.1
.bss 51184 51120 -64 -0.1
.data 1042 1042 0 0.0
.data.rel.ro 62272 62272 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 139829 139829 0 0.0
.text 1417714 1417602 -112 -0.0
bridge-app debug+rpc (read only) 1287325 1287213 -112 -0.0
(read/write) 69384 69320 -64 -0.1
.bss 35088 35024 -64 -0.2
.data 1568 1568 0 0.0
.data.rel.ro 27768 27768 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 111460 111460 0 0.0
.text 1079973 1079861 -112 -0.0
chip-tool debug (read only) 4351269 4350973 -296 -0.0
(read/write) 124896 124896 0 0.0
.bss 18224 18224 0 0.0
.data 2224 2224 0 0.0
.data.rel.ro 99040 99040 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 219560 219376 -184 -0.1
.text 3865669 3865557 -112 -0.0
lighting-app debug+rpc (read only) 1548297 1548073 -224 -0.0
(read/write) 102352 102288 -64 -0.1
.bss 40728 40664 -64 -0.2
.data 1170 1170 0 0.0
.data.rel.ro 55168 55168 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 130129 130033 -96 -0.1
.text 1284610 1284482 -128 -0.0
ota-provider-app debug (read only) 1243689 1243561 -128 -0.0
(read/write) 67552 67488 -64 -0.1
.bss 37152 37088 -64 -0.2
.data 752 752 0 0.0
.data.rel.ro 24568 24568 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 112360 112360 0 0.0
.text 1035250 1035122 -128 -0.0
ota-requestor-app debug (read only) 1311049 1310841 -208 -0.0
(read/write) 76872 76808 -64 -0.1
.bss 45408 45344 -64 -0.1
.data 816 816 0 0.0
.data.rel.ro 25512 25512 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 123328 123248 -80 -0.1
.text 1089954 1089826 -128 -0.0
shell debug (read only) 786593 786465 -128 -0.0
(read/write) 57664 57600 -64 -0.1
.bss 16104 16040 -64 -0.4
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77839 77839 0 0.0
.text 607266 607138 -128 -0.0
tv-app debug (read only) 1810545 1810209 -336 -0.0
(read/write) 289944 289880 -64 -0.0
.bss 222768 222704 -64 -0.0
.data 2704 2704 0 0.0
.data.rel.ro 58824 58824 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 155640 155432 -208 -0.1
.text 1512642 1512514 -128 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293224 2293160 -64 -0.0
.bss 179972 179940 -32 -0.0
.data 5216 5216 0 0.0
.heap 851256 851288 32 0.0
.text 1255824 1255760 -64 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2272792 2272728 -64 -0.0
.bss 172012 171980 -32 -0.0
.data 5568 5568 0 0.0
.heap 858864 858896 32 0.0
.text 1235392 1235328 -64 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250512 2250384 -128 -0.0
.bss 170908 170876 -32 -0.0
.data 5560 5560 0 0.0
.heap 859976 860008 32 0.0
.text 1213112 1212984 -128 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048496 2048368 -128 -0.0
.bss 156256 156224 -32 -0.0
.data 4960 4960 0 0.0
.heap 875232 875264 32 0.0
.text 1011096 1010968 -128 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861395 861363 -32 -0.0
bss 111320 111288 -32 -0.0
rodata 96772 96772 0 0.0
text 577692 577696 4 0.0
nrf52840dk_nrf52840+rpc (read/write) 823771 823739 -32 -0.0
bss 107672 107640 -32 -0.0
rodata 87948 87948 0 0.0
text 551876 551880 4 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786434 786402 -32 -0.0
bss 112696 112664 -32 -0.0
rodata 92028 92028 0 0.0
text 507152 507156 4 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838099 838067 -32 -0.0
bss 110356 110324 -32 -0.0
rodata 93140 93140 0 0.0
text 559168 559172 4 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763398 763366 -32 -0.0
bss 111764 111732 -32 -0.0
rodata 88448 88448 0 0.0
text 488720 488724 4 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844211 844179 -32 -0.0
bss 110492 110460 -32 -0.0
rodata 94852 94852 0 0.0
text 563348 563352 4 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837955 837939 -16 -0.0
bss 110392 110360 -32 -0.0
rodata 93140 93140 0 0.0
text 558904 558908 4 0.0
shell nrf52840dk_nrf52840 (read/write) 775991 775959 -32 -0.0
bss 109112 109080 -32 -0.0
rodata 72412 72412 0 0.0
text 519884 519888 4 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691026 690994 -32 -0.0
bss 110092 110060 -32 -0.0
rodata 67052 67052 0 0.0
text 440480 440484 4 0.0
p6 all-clusters-app default (read/write) 2300752 2300624 -128 -0.0
.bss 107912 107880 -32 -0.0
.data 2520 2520 0 0.0
.heap 922912 922944 32 0.0
.text 1259016 1258888 -128 -0.0
lock-app default (read/write) 2213744 2213632 -112 -0.0
.bss 95712 95680 -32 -0.0
.data 2392 2392 0 0.0
.heap 935240 935272 32 0.0
.text 1172008 1171896 -112 -0.0
qpg lighting-app qpg6100+debug (read only) 490784 490692 -92 -0.0
(read/write) 114140 114140 0 0.0
.bss 50416 50384 -32 -0.1
.data 1004 1004 0 0.0
.text 485464 485372 -92 -0.0
lock-app qpg6100+debug (read only) 467120 467032 -88 -0.0
(read/write) 114144 114144 0 0.0
.bss 49360 49328 -32 -0.1
.data 960 960 0 0.0
.text 461800 461712 -88 -0.0
persistent-storage-app qpg6100+debug (read only) 153212 153212 0 0.0
(read/write) 114140 114140 0 0.0
.bss 18336 18336 0 0.0
.data 356 356 0 0.0
.text 147892 147892 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662894 662878 -16 -0.0
bss 69132 69100 -32 -0.0
noinit 33216 33216 0 0.0
text 458028 458042 14 0.0

@andy31415 andy31415 merged commit fe62374 into project-chip:master Nov 3, 2021
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@kghost
Remove UnauthenticatedSession::mLocalMessageCounter (project-chip#11375)
75e6f71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@msandstedt msandstedt msandstedt approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
review - approved transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kghost @andy31415 @msandstedt @Damian-Nordic