Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cluster command detail page #11354

Merged
merged 14 commits into from
Nov 6, 2021
Merged

Cluster command detail page #11354

merged 14 commits into from
Nov 6, 2021

Conversation

JasonLiuZhuoCheng
Copy link
Contributor

Change overview

Command detail page includes two autoCompleteTextView: clusterAutocomplete and commandAutoComplete. Based on the user input, these two field will display a list of possible options starting with the user's input. After selecting the commands, depending on the command, it will display a list of parameters for user to fill in. After filling in the parameters and hit the invoke button, it will display a "command success"/"command failed" with the corresponding callback value and type.

Testing

manually tested

@restyled-io restyled-io bot mentioned this pull request Nov 3, 2021
Closed
@github-actions
Copy link

github-actions bot commented Nov 3, 2021 •
edited
Loading

PR #11354: Size comparison from d920345 to d1d2091

Decreases (1 build for esp32)
platform target config section d920345 d1d2091 change % change
esp32 all-clusters-app m5stack (read only) 911895 911819 -76 -0.0
.flash.text 911895 911819 -76 -0.0
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section d920345 d1d2091 change % change
efr32 lighting-app BRD4161A (read only) 737248 737248 0 0.0
(read/write) 114620 114620 0 0.0
.bss 112860 112860 0 0.0
.data 1756 1756 0 0.0
.text 737240 737240 0 0.0
BRD4161A+rpc (read only) 724672 724672 0 0.0
(read/write) 131220 131220 0 0.0
.bss 129364 129364 0 0.0
.data 1856 1856 0 0.0
.text 724664 724664 0 0.0
lock-app BRD4161A (read only) 716528 716528 0 0.0
(read/write) 112436 112436 0 0.0
.bss 110716 110716 0 0.0
.data 1716 1716 0 0.0
.text 716520 716520 0 0.0
window-app BRD4161A (read only) 717428 717428 0 0.0
(read/write) 112756 112756 0 0.0
.bss 111036 111036 0 0.0
.data 1720 1720 0 0.0
.text 717420 717420 0 0.0
esp32 all-clusters-app c3devkit (read only) 880718 880718 0 0.0
(read/write) 1308128 1308128 0 0.0
.dram0.bss 58616 58616 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 199808 199808 0 0.0
.flash.text 880718 880718 0 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 911895 911819 -76 -0.0
(read/write) 427892 427892 0 0.0
.dram0.bss 61120 61120 0 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 208508 208508 0 0.0
.flash.text 911895 911819 -76 -0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699528 699528 0 0.0
.bss 77856 77856 0 0.0
.data 1904 1904 0 0.0
.text 613968 613968 0 0.0
lock-app k32w061+debug (read/write) 591836 591836 0 0.0
.bss 68372 68372 0 0.0
.data 1868 1868 0 0.0
.text 515796 515796 0 0.0
shell k32w061+debug (read/write) 424916 424916 0 0.0
.bss 63296 63296 0 0.0
.data 668 668 0 0.0
.text 359248 359248 0 0.0
linux all-clusters-app debug (read only) 1690937 1690937 0 0.0
(read/write) 119760 119760 0 0.0
.bss 51184 51184 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62272 62272 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 139861 139861 0 0.0
.text 1417682 1417682 0 0.0
bridge-app debug+rpc (read only) 1287325 1287325 0 0.0
(read/write) 69384 69384 0 0.0
.bss 35088 35088 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27768 27768 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 111460 111460 0 0.0
.text 1079973 1079973 0 0.0
chip-tool debug (read only) 4351269 4351269 0 0.0
(read/write) 124896 124896 0 0.0
.bss 18224 18224 0 0.0
.data 2224 2224 0 0.0
.data.rel.ro 99040 99040 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 219560 219560 0 0.0
.text 3865669 3865669 0 0.0
lighting-app debug+rpc (read only) 1543193 1543193 0 0.0
(read/write) 101712 101712 0 0.0
.bss 40728 40728 0 0.0
.data 1138 1138 0 0.0
.data.rel.ro 54560 54560 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 129553 129553 0 0.0
.text 1280946 1280946 0 0.0
ota-provider-app debug (read only) 1243689 1243689 0 0.0
(read/write) 67552 67552 0 0.0
.bss 37152 37152 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24568 24568 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 112360 112360 0 0.0
.text 1035250 1035250 0 0.0
ota-requestor-app debug (read only) 1311049 1311049 0 0.0
(read/write) 76872 76872 0 0.0
.bss 45408 45408 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25512 25512 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 123328 123328 0 0.0
.text 1089954 1089954 0 0.0
shell debug (read only) 786593 786593 0 0.0
(read/write) 57664 57664 0 0.0
.bss 16104 16104 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77839 77839 0 0.0
.text 607266 607266 0 0.0
tv-app debug (read only) 1810545 1810545 0 0.0
(read/write) 289944 289944 0 0.0
.bss 222768 222768 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 58824 58824 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 155640 155640 0 0.0
.text 1512642 1512642 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293248 2293248 0 0.0
.bss 179972 179972 0 0.0
.data 5216 5216 0 0.0
.heap 851256 851256 0 0.0
.text 1255848 1255848 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2272216 2272216 0 0.0
.bss 172012 172012 0 0.0
.data 5568 5568 0 0.0
.heap 858864 858864 0 0.0
.text 1234816 1234816 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2249872 2249872 0 0.0
.bss 170908 170908 0 0.0
.data 5560 5560 0 0.0
.heap 859976 859976 0 0.0
.text 1212472 1212472 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048496 2048496 0 0.0
.bss 156256 156256 0 0.0
.data 4960 4960 0 0.0
.heap 875232 875232 0 0.0
.text 1011096 1011096 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861395 861395 0 0.0
bss 111320 111320 0 0.0
rodata 96772 96772 0 0.0
text 577692 577692 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 822267 822267 0 0.0
bss 107560 107560 0 0.0
rodata 87564 87564 0 0.0
text 550864 550864 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786434 786434 0 0.0
bss 112696 112696 0 0.0
rodata 92028 92028 0 0.0
text 507152 507152 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838099 838099 0 0.0
bss 110356 110356 0 0.0
rodata 93140 93140 0 0.0
text 559168 559168 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763398 763398 0 0.0
bss 111764 111764 0 0.0
rodata 88448 88448 0 0.0
text 488720 488720 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844211 844211 0 0.0
bss 110492 110492 0 0.0
rodata 94852 94852 0 0.0
text 563348 563348 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837955 837955 0 0.0
bss 110392 110392 0 0.0
rodata 93140 93140 0 0.0
text 558904 558904 0 0.0
shell nrf52840dk_nrf52840 (read/write) 775991 775991 0 0.0
bss 109112 109112 0 0.0
rodata 72412 72412 0 0.0
text 519884 519884 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691026 691026 0 0.0
bss 110092 110092 0 0.0
rodata 67052 67052 0 0.0
text 440480 440480 0 0.0
p6 lock-app default (read/write) 2168104 2168104 0 0.0
.bss 66360 66360 0 0.0
.data 2416 2416 0 0.0
.heap 964568 964568 0 0.0
.text 1126368 1126368 0 0.0
qpg lighting-app qpg6100+debug (read only) 490784 490784 0 0.0
(read/write) 114140 114140 0 0.0
.bss 50416 50416 0 0.0
.data 1004 1004 0 0.0
.text 485464 485464 0 0.0
lock-app qpg6100+debug (read only) 467120 467120 0 0.0
(read/write) 114144 114144 0 0.0
.bss 49360 49360 0 0.0
.data 960 960 0 0.0
.text 461800 461800 0 0.0
persistent-storage-app qpg6100+debug (read only) 153212 153212 0 0.0
(read/write) 114140 114140 0 0.0
.bss 18336 18336 0 0.0
.data 356 356 0 0.0
.text 147892 147892 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662894 662894 0 0.0
bss 69132 69132 0 0.0
noinit 33216 33216 0 0.0
text 458028 458028 0 0.0

@JasonLiuZhuoCheng JasonLiuZhuoCheng force-pushed the cluster-command-detail-page branch from c68ff2d to f7466c7 Compare November 3, 2021 20:00
@JasonLiuZhuoCheng JasonLiuZhuoCheng marked this pull request as ready for review November 3, 2021 20:00
@github-actions
Copy link

github-actions bot commented Nov 3, 2021 •
edited
Loading

PR #11354: Size comparison from 38fe11e to 13471a8

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 38fe11e 13471a8 change % change
efr32 lighting-app BRD4161A (read only) 737168 737168 0 0.0
(read/write) 114588 114588 0 0.0
.bss 112828 112828 0 0.0
.data 1756 1756 0 0.0
.text 737160 737160 0 0.0
BRD4161A+rpc (read only) 726364 726364 0 0.0
(read/write) 131204 131204 0 0.0
.bss 129332 129332 0 0.0
.data 1872 1872 0 0.0
.text 726356 726356 0 0.0
lock-app BRD4161A (read only) 716432 716432 0 0.0
(read/write) 112404 112404 0 0.0
.bss 110684 110684 0 0.0
.data 1716 1716 0 0.0
.text 716424 716424 0 0.0
window-app BRD4161A (read only) 717332 717332 0 0.0
(read/write) 112724 112724 0 0.0
.bss 111004 111004 0 0.0
.data 1720 1720 0 0.0
.text 717324 717324 0 0.0
esp32 all-clusters-app c3devkit (read only) 880670 880670 0 0.0
(read/write) 1308064 1308064 0 0.0
.dram0.bss 58584 58584 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 199776 199776 0 0.0
.flash.text 880670 880670 0 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 911823 911823 0 0.0
(read/write) 427828 427828 0 0.0
.dram0.bss 61088 61088 0 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 208476 208476 0 0.0
.flash.text 911823 911823 0 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699416 699416 0 0.0
.bss 77824 77824 0 0.0
.data 1904 1904 0 0.0
.text 613888 613888 0 0.0
lock-app k32w061+debug (read/write) 591724 591724 0 0.0
.bss 68340 68340 0 0.0
.data 1868 1868 0 0.0
.text 515716 515716 0 0.0
shell k32w061+debug (read/write) 657656 657656 0 0.0
.bss 78992 78992 0 0.0
.data 1840 1840 0 0.0
.text 571024 571024 0 0.0
linux all-clusters-app debug (read only) 1691153 1691153 0 0.0
(read/write) 119696 119696 0 0.0
.bss 51120 51120 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62272 62272 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 139925 139925 0 0.0
.text 1417810 1417810 0 0.0
bridge-app debug+rpc (read only) 1287373 1287373 0 0.0
(read/write) 69320 69320 0 0.0
.bss 35024 35024 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27768 27768 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 111460 111460 0 0.0
.text 1080021 1080021 0 0.0
chip-tool debug (read only) 4422981 4422981 0 0.0
(read/write) 125888 125888 0 0.0
.bss 18224 18224 0 0.0
.data 2224 2224 0 0.0
.data.rel.ro 100032 100032 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 226384 226384 0 0.0
.text 3928277 3928277 0 0.0
lighting-app debug+rpc (read only) 1548401 1548401 0 0.0
(read/write) 102288 102288 0 0.0
.bss 40664 40664 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 55168 55168 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 130129 130129 0 0.0
.text 1284690 1284690 0 0.0
ota-provider-app debug (read only) 1243889 1243889 0 0.0
(read/write) 67488 67488 0 0.0
.bss 37088 37088 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24568 24568 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 112456 112456 0 0.0
.text 1035330 1035330 0 0.0
ota-requestor-app debug (read only) 1311169 1311169 0 0.0
(read/write) 76808 76808 0 0.0
.bss 45344 45344 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25512 25512 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 123344 123344 0 0.0
.text 1090034 1090034 0 0.0
shell debug (read only) 786641 786641 0 0.0
(read/write) 57600 57600 0 0.0
.bss 16040 16040 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77839 77839 0 0.0
.text 607314 607314 0 0.0
tv-app debug (read only) 1810537 1810537 0 0.0
(read/write) 289912 289912 0 0.0
.bss 222736 222736 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 58824 58824 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 155528 155528 0 0.0
.text 1512722 1512722 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293160 2293160 0 0.0
.bss 179940 179940 0 0.0
.data 5216 5216 0 0.0
.heap 851288 851288 0 0.0
.text 1255760 1255760 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2272728 2272728 0 0.0
.bss 171980 171980 0 0.0
.data 5568 5568 0 0.0
.heap 858896 858896 0 0.0
.text 1235328 1235328 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250448 2250448 0 0.0
.bss 170876 170876 0 0.0
.data 5560 5560 0 0.0
.heap 860008 860008 0 0.0
.text 1213048 1213048 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048368 2048368 0 0.0
.bss 156224 156224 0 0.0
.data 4960 4960 0 0.0
.heap 875264 875264 0 0.0
.text 1010968 1010968 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861379 861379 0 0.0
bss 111288 111288 0 0.0
rodata 96772 96772 0 0.0
text 577712 577712 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 823755 823755 0 0.0
bss 107640 107640 0 0.0
rodata 87948 87948 0 0.0
text 551896 551896 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786418 786418 0 0.0
bss 112664 112664 0 0.0
rodata 92028 92028 0 0.0
text 507168 507168 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838083 838083 0 0.0
bss 110324 110324 0 0.0
rodata 93140 93140 0 0.0
text 559188 559188 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763382 763382 0 0.0
bss 111732 111732 0 0.0
rodata 88448 88448 0 0.0
text 488736 488736 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844195 844195 0 0.0
bss 110460 110460 0 0.0
rodata 94852 94852 0 0.0
text 563368 563368 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837955 837955 0 0.0
bss 110360 110360 0 0.0
rodata 93140 93140 0 0.0
text 558924 558924 0 0.0
shell nrf52840dk_nrf52840 (read/write) 775975 775975 0 0.0
bss 109080 109080 0 0.0
rodata 72412 72412 0 0.0
text 519904 519904 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691010 691010 0 0.0
bss 110060 110060 0 0.0
rodata 67052 67052 0 0.0
text 440496 440496 0 0.0
p6 all-clusters-app default (read/write) 2300656 2300656 0 0.0
.bss 107880 107880 0 0.0
.data 2520 2520 0 0.0
.heap 922944 922944 0 0.0
.text 1258920 1258920 0 0.0
lock-app default (read/write) 2213648 2213648 0 0.0
.bss 95680 95680 0 0.0
.data 2392 2392 0 0.0
.heap 935272 935272 0 0.0
.text 1171912 1171912 0 0.0
qpg lighting-app qpg6100+debug (read only) 490708 490708 0 0.0
(read/write) 114140 114140 0 0.0
.bss 50968 50968 0 0.0
.data 1004 1004 0 0.0
.text 485388 485388 0 0.0
lock-app qpg6100+debug (read only) 467048 467048 0 0.0
(read/write) 114144 114144 0 0.0
.bss 49912 49912 0 0.0
.data 960 960 0 0.0
.text 461728 461728 0 0.0
persistent-storage-app qpg6100+debug (read only) 153212 153212 0 0.0
(read/write) 114140 114140 0 0.0
.bss 18920 18920 0 0.0
.data 356 356 0 0.0
.text 147892 147892 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662894 662894 0 0.0
bss 69100 69100 0 0.0
noinit 33216 33216 0 0.0
text 458058 458058 0 0.0

austinh0
austinh0 suggested changes Nov 4, 2021
View reviewed changes
...java/com/google/chip/chiptool/clusterclient/clusterinteraction/ClusterInteractionFragment.kt Outdated Show resolved Hide resolved
src/android/CHIPTool/app/src/main/res/layout/callback_item.xml Outdated Show resolved Hide resolved
src/android/CHIPTool/app/src/main/res/layout/callback_item.xml Outdated Show resolved Hide resolved
src/android/CHIPTool/app/src/main/res/layout/cluster_detail_fragment.xml Outdated Show resolved Hide resolved
src/android/CHIPTool/app/src/main/res/layout/cluster_detail_fragment.xml Outdated Show resolved Hide resolved
...main/java/com/google/chip/chiptool/clusterclient/clusterinteraction/ClusterDetailFragment.kt Outdated Show resolved Hide resolved
...main/java/com/google/chip/chiptool/clusterclient/clusterinteraction/ClusterDetailFragment.kt Outdated Show resolved Hide resolved
...main/java/com/google/chip/chiptool/clusterclient/clusterinteraction/ClusterDetailFragment.kt Outdated Show resolved Hide resolved
...main/java/com/google/chip/chiptool/clusterclient/clusterinteraction/ClusterDetailFragment.kt Outdated Show resolved Hide resolved
...main/java/com/google/chip/chiptool/clusterclient/clusterinteraction/ClusterDetailFragment.kt Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Nov 4, 2021 •
edited
Loading

PR #11354: Size comparison from 38fe11e to 993110b

Increases above 0.2%:

platform target config section 38fe11e 993110b change % change
linux all-clusters-app debug (read only) 1691153 1697761 6608 0.4
.rodata 139925 140469 544 0.4
.text 1417810 1423874 6064 0.4
bridge-app debug+rpc (read only) 1287373 1292477 5104 0.4
.rodata 111460 111780 320 0.3
.text 1080021 1084805 4784 0.4
chip-tool debug .rodata 226384 226992 608 0.3
lighting-app debug+rpc (read only) 1548401 1553505 5104 0.3
.text 1284690 1289474 4784 0.4
ota-provider-app debug (read only) 1243889 1251761 7872 0.6
.rodata 112456 113032 576 0.5
.text 1035330 1042626 7296 0.7
ota-requestor-app debug (read only) 1311169 1329497 18328 1.4
.data.rel.ro 25512 25576 64 0.3
.rodata 123344 124464 1120 0.9
.text 1090034 1106978 16944 1.6
tv-app debug (read only) 1810537 1817113 6576 0.4
.rodata 155528 156040 512 0.3
.text 1512722 1518786 6064 0.4
Increases (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 38fe11e 993110b change % change
efr32 lighting-app BRD4161A (read only) 737168 737432 264 0.0
.text 737160 737424 264 0.0
BRD4161A+rpc (read only) 726364 726628 264 0.0
.text 726356 726620 264 0.0
lock-app BRD4161A (read only) 716432 716696 264 0.0
.text 716424 716688 264 0.0
window-app BRD4161A (read only) 717332 717612 280 0.0
.text 717324 717604 280 0.0
esp32 all-clusters-app c3devkit (read only) 880670 880890 220 0.0
(read/write) 1308064 1308120 56 0.0
.flash.rodata 199776 199832 56 0.0
.flash.text 880670 880890 220 0.0
m5stack (read only) 911823 912007 184 0.0
(read/write) 427828 427876 48 0.0
.flash.rodata 208476 208524 48 0.0
.flash.text 911823 912007 184 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699416 699648 232 0.0
.text 613888 614120 232 0.0
lock-app k32w061+debug (read/write) 591724 591956 232 0.0
.text 515716 515948 232 0.0
shell k32w061+debug (read/write) 657656 657904 248 0.0
.text 571024 571272 248 0.0
linux all-clusters-app debug (read only) 1691153 1697761 6608 0.4
.rodata 139925 140469 544 0.4
.text 1417810 1423874 6064 0.4
bridge-app debug+rpc (read only) 1287373 1292477 5104 0.4
.rodata 111460 111780 320 0.3
.text 1080021 1084805 4784 0.4
chip-tool debug (read only) 4422981 4429253 6272 0.1
.rodata 226384 226992 608 0.3
.text 3928277 3933941 5664 0.1
lighting-app debug+rpc (read only) 1548401 1553505 5104 0.3
.rodata 130129 130449 320 0.2
.text 1284690 1289474 4784 0.4
ota-provider-app debug (read only) 1243889 1251761 7872 0.6
.rodata 112456 113032 576 0.5
.text 1035330 1042626 7296 0.7
ota-requestor-app debug (read only) 1311169 1329497 18328 1.4
.data.rel.ro 25512 25576 64 0.3
.got 3984 3992 8 0.2
.rodata 123344 124464 1120 0.9
.text 1090034 1106978 16944 1.6
tv-app debug (read only) 1810537 1817113 6576 0.4
.rodata 155528 156040 512 0.3
.text 1512722 1518786 6064 0.4
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2293160 2293328 168 0.0
.text 1255760 1255928 168 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2272728 2272760 32 0.0
.text 1235328 1235360 32 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2250448 2250480 32 0.0
.text 1213048 1213080 32 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861379 861623 244 0.0
rodata 96772 96808 36 0.0
text 577712 577912 200 0.0
nrf52840dk_nrf52840+rpc (read/write) 823755 824003 248 0.0
rodata 87948 87988 40 0.0
text 551896 552100 204 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786418 786662 244 0.0
rodata 92028 92064 36 0.0
text 507168 507372 204 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838083 838331 248 0.0
rodata 93140 93180 40 0.0
text 559188 559388 200 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763382 763626 244 0.0
rodata 88448 88484 36 0.0
text 488736 488940 204 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844195 844439 244 0.0
rodata 94852 94888 36 0.0
text 563368 563568 200 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837955 838183 228 0.0
rodata 93140 93176 36 0.0
text 558924 559124 200 0.0
p6 all-clusters-app default (read/write) 2300656 2301080 424 0.0
.text 1258920 1259344 424 0.0
lock-app default (read/write) 2213648 2213928 280 0.0
.text 1171912 1172192 280 0.0
qpg lighting-app qpg6100+debug (read only) 490708 490932 224 0.0
.text 485388 485612 224 0.0
lock-app qpg6100+debug (read only) 467048 467280 232 0.0
.text 461728 461960 232 0.1
telink lighting-app tlsr9518adk80d (read/write) 662894 663086 192 0.0
text 458058 458206 148 0.0
Decreases (1 build for linux)
platform target config section 38fe11e 993110b change % change
linux ota-requestor-app debug (read/write) 76808 76744 -64 -0.1
.bss 45344 45216 -128 -0.3
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 38fe11e 993110b change % change
efr32 lighting-app BRD4161A (read only) 737168 737432 264 0.0
(read/write) 114588 114588 0 0.0
.bss 112828 112828 0 0.0
.data 1756 1756 0 0.0
.text 737160 737424 264 0.0
BRD4161A+rpc (read only) 726364 726628 264 0.0
(read/write) 131204 131204 0 0.0
.bss 129332 129332 0 0.0
.data 1872 1872 0 0.0
.text 726356 726620 264 0.0
lock-app BRD4161A (read only) 716432 716696 264 0.0
(read/write) 112404 112404 0 0.0
.bss 110684 110684 0 0.0
.data 1716 1716 0 0.0
.text 716424 716688 264 0.0
window-app BRD4161A (read only) 717332 717612 280 0.0
(read/write) 112724 112724 0 0.0
.bss 111004 111004 0 0.0
.data 1720 1720 0 0.0
.text 717324 717604 280 0.0
esp32 all-clusters-app c3devkit (read only) 880670 880890 220 0.0
(read/write) 1308064 1308120 56 0.0
.dram0.bss 58584 58584 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 199776 199832 56 0.0
.flash.text 880670 880890 220 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 911823 912007 184 0.0
(read/write) 427828 427876 48 0.0
.dram0.bss 61088 61088 0 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 208476 208524 48 0.0
.flash.text 911823 912007 184 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699416 699648 232 0.0
.bss 77824 77824 0 0.0
.data 1904 1904 0 0.0
.text 613888 614120 232 0.0
lock-app k32w061+debug (read/write) 591724 591956 232 0.0
.bss 68340 68340 0 0.0
.data 1868 1868 0 0.0
.text 515716 515948 232 0.0
shell k32w061+debug (read/write) 657656 657904 248 0.0
.bss 78992 78992 0 0.0
.data 1840 1840 0 0.0
.text 571024 571272 248 0.0
linux all-clusters-app debug (read only) 1691153 1697761 6608 0.4
(read/write) 119696 119696 0 0.0
.bss 51120 51120 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62272 62272 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 139925 140469 544 0.4
.text 1417810 1423874 6064 0.4
bridge-app debug+rpc (read only) 1287373 1292477 5104 0.4
(read/write) 69320 69320 0 0.0
.bss 35024 35024 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27768 27768 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 111460 111780 320 0.3
.text 1080021 1084805 4784 0.4
chip-tool debug (read only) 4422981 4429253 6272 0.1
(read/write) 125888 125888 0 0.0
.bss 18224 18224 0 0.0
.data 2224 2224 0 0.0
.data.rel.ro 100032 100032 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 226384 226992 608 0.3
.text 3928277 3933941 5664 0.1
lighting-app debug+rpc (read only) 1548401 1553505 5104 0.3
(read/write) 102288 102288 0 0.0
.bss 40664 40664 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 55168 55168 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 130129 130449 320 0.2
.text 1284690 1289474 4784 0.4
ota-provider-app debug (read only) 1243889 1251761 7872 0.6
(read/write) 67488 67488 0 0.0
.bss 37088 37088 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24568 24568 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 112456 113032 576 0.5
.text 1035330 1042626 7296 0.7
ota-requestor-app debug (read only) 1311169 1329497 18328 1.4
(read/write) 76808 76744 -64 -0.1
.bss 45344 45216 -128 -0.3
.data 816 816 0 0.0
.data.rel.ro 25512 25576 64 0.3
.dynamic 592 592 0 0.0
.got 3984 3992 8 0.2
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 123344 124464 1120 0.9
.text 1090034 1106978 16944 1.6
shell debug (read only) 786641 786641 0 0.0
(read/write) 57600 57600 0 0.0
.bss 16040 16040 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77839 77839 0 0.0
.text 607314 607314 0 0.0
tv-app debug (read only) 1810537 1817113 6576 0.4
(read/write) 289912 289912 0 0.0
.bss 222736 222736 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 58824 58824 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 155528 156040 512 0.3
.text 1512722 1518786 6064 0.4
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293160 2293328 168 0.0
.bss 179940 179940 0 0.0
.data 5216 5216 0 0.0
.heap 851288 851288 0 0.0
.text 1255760 1255928 168 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2272728 2272760 32 0.0
.bss 171980 171980 0 0.0
.data 5568 5568 0 0.0
.heap 858896 858896 0 0.0
.text 1235328 1235360 32 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250448 2250480 32 0.0
.bss 170876 170876 0 0.0
.data 5560 5560 0 0.0
.heap 860008 860008 0 0.0
.text 1213048 1213080 32 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048368 2048368 0 0.0
.bss 156224 156224 0 0.0
.data 4960 4960 0 0.0
.heap 875264 875264 0 0.0
.text 1010968 1010968 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861379 861623 244 0.0
bss 111288 111288 0 0.0
rodata 96772 96808 36 0.0
text 577712 577912 200 0.0
nrf52840dk_nrf52840+rpc (read/write) 823755 824003 248 0.0
bss 107640 107640 0 0.0
rodata 87948 87988 40 0.0
text 551896 552100 204 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786418 786662 244 0.0
bss 112664 112664 0 0.0
rodata 92028 92064 36 0.0
text 507168 507372 204 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838083 838331 248 0.0
bss 110324 110324 0 0.0
rodata 93140 93180 40 0.0
text 559188 559388 200 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763382 763626 244 0.0
bss 111732 111732 0 0.0
rodata 88448 88484 36 0.0
text 488736 488940 204 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844195 844439 244 0.0
bss 110460 110460 0 0.0
rodata 94852 94888 36 0.0
text 563368 563568 200 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837955 838183 228 0.0
bss 110360 110360 0 0.0
rodata 93140 93176 36 0.0
text 558924 559124 200 0.0
shell nrf52840dk_nrf52840 (read/write) 775975 775975 0 0.0
bss 109080 109080 0 0.0
rodata 72412 72412 0 0.0
text 519904 519904 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691010 691010 0 0.0
bss 110060 110060 0 0.0
rodata 67052 67052 0 0.0
text 440496 440496 0 0.0
p6 all-clusters-app default (read/write) 2300656 2301080 424 0.0
.bss 107880 107880 0 0.0
.data 2520 2520 0 0.0
.heap 922944 922944 0 0.0
.text 1258920 1259344 424 0.0
lock-app default (read/write) 2213648 2213928 280 0.0
.bss 95680 95680 0 0.0
.data 2392 2392 0 0.0
.heap 935272 935272 0 0.0
.text 1171912 1172192 280 0.0
qpg lighting-app qpg6100+debug (read only) 490708 490932 224 0.0
(read/write) 114140 114140 0 0.0
.bss 50968 50968 0 0.0
.data 1004 1004 0 0.0
.text 485388 485612 224 0.0
lock-app qpg6100+debug (read only) 467048 467280 232 0.0
(read/write) 114144 114144 0 0.0
.bss 49912 49912 0 0.0
.data 960 960 0 0.0
.text 461728 461960 232 0.1
persistent-storage-app qpg6100+debug (read only) 153212 153212 0 0.0
(read/write) 114140 114140 0 0.0
.bss 18920 18920 0 0.0
.data 356 356 0 0.0
.text 147892 147892 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662894 663086 192 0.0
bss 69100 69100 0 0.0
noinit 33216 33216 0 0.0
text 458058 458206 148 0.0

@woody-apple
Copy link
Contributor

Fast tracking, given this is a platform change

@JasonLiuZhuoCheng JasonLiuZhuoCheng force-pushed the cluster-command-detail-page branch from 7320cd0 to 7a0a726 Compare November 4, 2021 19:16
@github-actions
Copy link

github-actions bot commented Nov 4, 2021 •
edited
Loading

PR #11354: Size comparison from 29747a2 to d419b40

Decreases (1 build for esp32)
platform target config section 29747a2 d419b40 change % change
esp32 all-clusters-app m5stack (read only) 912095 912019 -76 -0.0
.flash.text 912095 912019 -76 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 29747a2 d419b40 change % change
efr32 lighting-app BRD4161A (read only) 744860 744860 0 0.0
(read/write) 115696 115696 0 0.0
.bss 113924 113924 0 0.0
.data 1772 1772 0 0.0
.text 744852 744852 0 0.0
BRD4161A+rpc (read only) 732392 732392 0 0.0
(read/write) 132316 132316 0 0.0
.bss 130428 130428 0 0.0
.data 1888 1888 0 0.0
.text 732384 732384 0 0.0
lock-app BRD4161A (read only) 724128 724128 0 0.0
(read/write) 113516 113516 0 0.0
.bss 111780 111780 0 0.0
.data 1732 1732 0 0.0
.text 724120 724120 0 0.0
window-app BRD4161A (read only) 725024 725024 0 0.0
(read/write) 113836 113836 0 0.0
.bss 112100 112100 0 0.0
.data 1736 1736 0 0.0
.text 725016 725016 0 0.0
esp32 all-clusters-app c3devkit (read only) 880814 880814 0 0.0
(read/write) 1305592 1305592 0 0.0
.dram0.bss 57528 57528 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 198360 198360 0 0.0
.flash.text 880814 880814 0 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 912095 912019 -76 -0.0
(read/write) 425380 425380 0 0.0
.dram0.bss 60032 60032 0 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 207084 207084 0 0.0
.flash.text 912095 912019 -76 -0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699240 699240 0 0.0
.bss 77784 77784 0 0.0
.data 1904 1904 0 0.0
.text 613752 613752 0 0.0
lock-app k32w061+debug (read/write) 592044 592044 0 0.0
.bss 68316 68316 0 0.0
.data 1872 1872 0 0.0
.text 516056 516056 0 0.0
shell k32w061+debug (read/write) 657536 657536 0 0.0
.bss 78952 78952 0 0.0
.data 1840 1840 0 0.0
.text 570944 570944 0 0.0
linux all-clusters-app debug (read only) 1703025 1703025 0 0.0
(read/write) 118656 118656 0 0.0
.bss 50000 50000 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62336 62336 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 138997 138997 0 0.0
.text 1430562 1430562 0 0.0
bridge-app debug+rpc (read only) 1291093 1291093 0 0.0
(read/write) 69232 69232 0 0.0
.bss 34928 34928 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27768 27768 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110852 110852 0 0.0
.text 1084325 1084325 0 0.0
chip-tool debug (read only) 4433685 4433685 0 0.0
(read/write) 125864 125864 0 0.0
.bss 18128 18128 0 0.0
.data 2224 2224 0 0.0
.data.rel.ro 100096 100096 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 432 0 0.0
.rodata 226192 226192 0 0.0
.text 3939029 3939029 0 0.0
lighting-app debug+rpc (read only) 1552089 1552089 0 0.0
(read/write) 102200 102200 0 0.0
.bss 40568 40568 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 55168 55168 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129489 129489 0 0.0
.text 1288994 1288994 0 0.0
ota-provider-app debug (read only) 1250377 1250377 0 0.0
(read/write) 67400 67400 0 0.0
.bss 36992 36992 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24568 24568 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112104 112104 0 0.0
.text 1042146 1042146 0 0.0
ota-requestor-app debug (read only) 1328705 1328705 0 0.0
(read/write) 76656 76656 0 0.0
.bss 45120 45120 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25576 25576 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 124112 124112 0 0.0
.text 1106514 1106514 0 0.0
shell debug (read only) 786873 786873 0 0.0
(read/write) 57608 57608 0 0.0
.bss 16040 16040 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77903 77903 0 0.0
.text 607458 607458 0 0.0
tv-app debug (read only) 1815729 1815729 0 0.0
(read/write) 289824 289824 0 0.0
.bss 222640 222640 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 58824 58824 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155112 155112 0 0.0
.text 1518306 1518306 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2292664 2292664 0 0.0
.bss 178876 178876 0 0.0
.data 5216 5216 0 0.0
.heap 852352 852352 0 0.0
.text 1255264 1255264 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2272992 2272992 0 0.0
.bss 171948 171948 0 0.0
.data 5568 5568 0 0.0
.heap 858928 858928 0 0.0
.text 1235592 1235592 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250712 2250712 0 0.0
.bss 170844 170844 0 0.0
.data 5560 5560 0 0.0
.heap 860040 860040 0 0.0
.text 1213312 1213312 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048400 2048400 0 0.0
.bss 156224 156224 0 0.0
.data 4960 4960 0 0.0
.heap 875264 875264 0 0.0
.text 1011000 1011000 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861303 861303 0 0.0
bss 111248 111248 0 0.0
rodata 96808 96808 0 0.0
text 577624 577624 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 823651 823651 0 0.0
bss 107600 107600 0 0.0
rodata 87988 87988 0 0.0
text 551772 551772 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786326 786326 0 0.0
bss 112624 112624 0 0.0
rodata 92064 92064 0 0.0
text 507080 507080 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838011 838011 0 0.0
bss 110284 110284 0 0.0
rodata 93180 93180 0 0.0
text 559100 559100 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763306 763306 0 0.0
bss 111692 111692 0 0.0
rodata 88484 88484 0 0.0
text 488648 488648 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844119 844119 0 0.0
bss 110420 110420 0 0.0
rodata 94888 94888 0 0.0
text 563280 563280 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837863 837863 0 0.0
bss 110320 110320 0 0.0
rodata 93176 93176 0 0.0
text 558836 558836 0 0.0
shell nrf52840dk_nrf52840 (read/write) 775755 775755 0 0.0
bss 109072 109072 0 0.0
rodata 72432 72432 0 0.0
text 519664 519664 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690794 690794 0 0.0
bss 110052 110052 0 0.0
rodata 67076 67076 0 0.0
text 440256 440256 0 0.0
p6 all-clusters-app default (read/write) 2299176 2299176 0 0.0
.bss 106824 106824 0 0.0
.data 2520 2520 0 0.0
.heap 924000 924000 0 0.0
.text 1257440 1257440 0 0.0
lock-app default (read/write) 2212896 2212896 0 0.0
.bss 95648 95648 0 0.0
.data 2392 2392 0 0.0
.heap 935304 935304 0 0.0
.text 1171160 1171160 0 0.0
qpg lighting-app qpg6100+debug (read only) 490628 490628 0 0.0
(read/write) 114140 114140 0 0.0
.bss 50944 50944 0 0.0
.data 1004 1004 0 0.0
.text 485308 485308 0 0.0
lock-app qpg6100+debug (read only) 466952 466952 0 0.0
(read/write) 114144 114144 0 0.0
.bss 49888 49888 0 0.0
.data 960 960 0 0.0
.text 461632 461632 0 0.0
persistent-storage-app qpg6100+debug (read only) 153212 153212 0 0.0
(read/write) 114140 114140 0 0.0
.bss 18912 18912 0 0.0
.data 356 356 0 0.0
.text 147892 147892 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662982 662982 0 0.0
bss 69064 69064 0 0.0
noinit 33216 33216 0 0.0
text 458134 458134 0 0.0

@JasonLiuZhuoCheng JasonLiuZhuoCheng force-pushed the cluster-command-detail-page branch from d419b40 to 651c293 Compare November 4, 2021 21:32
@github-actions
Copy link

github-actions bot commented Nov 4, 2021 •
edited
Loading

PR #11354: Size comparison from f874ab3 to 651c293

Full report (28 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section f874ab3 651c293 change % change
efr32 lighting-app BRD4161A (read only) 744860 744860 0 0.0
(read/write) 115696 115696 0 0.0
.bss 113924 113924 0 0.0
.data 1772 1772 0 0.0
.text 744852 744852 0 0.0
BRD4161A+rpc (read only) 732392 732392 0 0.0
(read/write) 132316 132316 0 0.0
.bss 130428 130428 0 0.0
.data 1888 1888 0 0.0
.text 732384 732384 0 0.0
lock-app BRD4161A (read only) 724128 724128 0 0.0
(read/write) 113516 113516 0 0.0
.bss 111780 111780 0 0.0
.data 1732 1732 0 0.0
.text 724120 724120 0 0.0
window-app BRD4161A (read only) 725024 725024 0 0.0
(read/write) 113836 113836 0 0.0
.bss 112100 112100 0 0.0
.data 1736 1736 0 0.0
.text 725016 725016 0 0.0
esp32 all-clusters-app c3devkit (read only) 880814 880814 0 0.0
(read/write) 1305592 1305592 0 0.0
.dram0.bss 57528 57528 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 198360 198360 0 0.0
.flash.text 880814 880814 0 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 912095 912095 0 0.0
(read/write) 425380 425380 0 0.0
.dram0.bss 60032 60032 0 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 207084 207084 0 0.0
.flash.text 912095 912095 0 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699240 699240 0 0.0
.bss 77784 77784 0 0.0
.data 1904 1904 0 0.0
.text 613752 613752 0 0.0
lock-app k32w061+debug (read/write) 592044 592044 0 0.0
.bss 68316 68316 0 0.0
.data 1872 1872 0 0.0
.text 516056 516056 0 0.0
shell k32w061+debug (read/write) 657536 657536 0 0.0
.bss 78952 78952 0 0.0
.data 1840 1840 0 0.0
.text 570944 570944 0 0.0
linux all-clusters-app debug (read only) 1703025 1703025 0 0.0
(read/write) 118656 118656 0 0.0
.bss 50000 50000 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62336 62336 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 138997 138997 0 0.0
.text 1430562 1430562 0 0.0
bridge-app debug+rpc (read only) 1291093 1291093 0 0.0
(read/write) 69232 69232 0 0.0
.bss 34928 34928 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27768 27768 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110852 110852 0 0.0
.text 1084325 1084325 0 0.0
chip-tool debug (read only) 4508773 4508773 0 0.0
(read/write) 125864 125864 0 0.0
.bss 18128 18128 0 0.0
.data 2224 2224 0 0.0
.data.rel.ro 100096 100096 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 432 0 0.0
.rodata 231728 231728 0 0.0
.text 4008581 4008581 0 0.0
lighting-app debug+rpc (read only) 1552089 1552089 0 0.0
(read/write) 102200 102200 0 0.0
.bss 40568 40568 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 55168 55168 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129489 129489 0 0.0
.text 1288994 1288994 0 0.0
ota-provider-app debug (read only) 1250377 1250377 0 0.0
(read/write) 67400 67400 0 0.0
.bss 36992 36992 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24568 24568 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112104 112104 0 0.0
.text 1042146 1042146 0 0.0
ota-requestor-app debug (read only) 1328705 1328705 0 0.0
(read/write) 76656 76656 0 0.0
.bss 45120 45120 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25576 25576 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 124112 124112 0 0.0
.text 1106514 1106514 0 0.0
shell debug (read only) 786873 786873 0 0.0
(read/write) 57608 57608 0 0.0
.bss 16040 16040 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77903 77903 0 0.0
.text 607458 607458 0 0.0
tv-app debug (read only) 1815729 1815729 0 0.0
(read/write) 289824 289824 0 0.0
.bss 222640 222640 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 58824 58824 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155112 155112 0 0.0
.text 1518306 1518306 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2292664 2292664 0 0.0
.bss 178876 178876 0 0.0
.data 5216 5216 0 0.0
.heap 852352 852352 0 0.0
.text 1255264 1255264 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2272992 2272992 0 0.0
.bss 171948 171948 0 0.0
.data 5568 5568 0 0.0
.heap 858928 858928 0 0.0
.text 1235592 1235592 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250712 2250712 0 0.0
.bss 170844 170844 0 0.0
.data 5560 5560 0 0.0
.heap 860040 860040 0 0.0
.text 1213312 1213312 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048400 2048400 0 0.0
.bss 156224 156224 0 0.0
.data 4960 4960 0 0.0
.heap 875264 875264 0 0.0
.text 1011000 1011000 0 0.0
p6 all-clusters-app default (read/write) 2299176 2299176 0 0.0
.bss 106824 106824 0 0.0
.data 2520 2520 0 0.0
.heap 924000 924000 0 0.0
.text 1257440 1257440 0 0.0
lock-app default (read/write) 2212896 2212896 0 0.0
.bss 95648 95648 0 0.0
.data 2392 2392 0 0.0
.heap 935304 935304 0 0.0
.text 1171160 1171160 0 0.0
qpg lighting-app qpg6100+debug (read only) 490628 490628 0 0.0
(read/write) 114140 114140 0 0.0
.bss 50944 50944 0 0.0
.data 1004 1004 0 0.0
.text 485308 485308 0 0.0
lock-app qpg6100+debug (read only) 466952 466952 0 0.0
(read/write) 114144 114144 0 0.0
.bss 49888 49888 0 0.0
.data 960 960 0 0.0
.text 461632 461632 0 0.0
persistent-storage-app qpg6100+debug (read only) 153212 153212 0 0.0
(read/write) 114140 114140 0 0.0
.bss 18912 18912 0 0.0
.data 356 356 0 0.0
.text 147892 147892 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662982 662982 0 0.0
bss 69064 69064 0 0.0
noinit 33216 33216 0 0.0
text 458134 458134 0 0.0

@JasonLiuZhuoCheng JasonLiuZhuoCheng force-pushed the cluster-command-detail-page branch from 651c293 to 6b13e70 Compare November 4, 2021 23:39
@JasonLiuZhuoCheng JasonLiuZhuoCheng force-pushed the cluster-command-detail-page branch from 6b13e70 to 422df1f Compare November 5, 2021 13:39
@woody-apple woody-apple merged commit 6b32d93 into project-chip:master Nov 6, 2021
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@JasonLiuZhuoCheng @restyled-commits
Cluster command detail page (project-chip#11354)
3360b5d 
* try to find a state where m5stack doesn't bootloop

* add back class description

* select different cluster, command will remove previous displayed parameter

* add responseValueInfo class instead of string split

* remove unused variable

* Restyled by whitespace

* Restyled by google-java-format

* Restyled by gn

* fix parameter response ui alignment issue

* resolve comments

* fix format

* regenerate clusterInfoMapping.java

* resolve comments

* merge with master to get pass the check

Co-authored-by: Restyled.io <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austinh0 austinh0 austinh0 approved these changes

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
android controller fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JasonLiuZhuoCheng @woody-apple @austinh0 @restyled-commits