Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Android add discover" #11329

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Conversation

woody-apple
Copy link
Contributor

Reverts #10682

@todo
Copy link

todo bot commented Nov 2, 2021

Implement DNS-SD browse for Android

// TODO: Implement DNS-SD browse for Android
return CHIP_ERROR_NOT_IMPLEMENTED;
}
CHIP_ERROR ChipDnssdResolve(DnssdService * service, Inet::InterfaceId interface, DnssdResolveCallback callback, void * context)


This comment was generated by todo based on a TODO comment in b35ba23 in #11329. cc @project-chip.

@github-actions
Copy link

github-actions bot commented Nov 2, 2021

PR #11329: Size comparison from 1f6c6e6 to b35ba23

Increases (1 build for esp32)
platform target config section 1f6c6e6 b35ba23 change % change
esp32 all-clusters-app m5stack (read only) 911507 911583 76 0.0
.flash.text 911507 911583 76 0.0
Full report (14 builds for esp32, k32w, mbed, qpg, telink)
platform target config section 1f6c6e6 b35ba23 change % change
esp32 all-clusters-app c3devkit (read only) 880486 880486 0 0.0
(read/write) 1307776 1307776 0 0.0
.dram0.bss 58592 58592 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 199488 199488 0 0.0
.flash.text 880486 880486 0 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 911507 911583 76 0.0
(read/write) 427544 427544 0 0.0
.dram0.bss 61088 61088 0 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 208192 208192 0 0.0
.flash.text 911507 911583 76 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699048 699048 0 0.0
.bss 77848 77848 0 0.0
.data 1908 1908 0 0.0
.text 613492 613492 0 0.0
lock-app k32w061+debug (read/write) 591356 591356 0 0.0
.bss 68364 68364 0 0.0
.data 1872 1872 0 0.0
.text 515320 515320 0 0.0
shell k32w061+debug (read/write) 424748 424748 0 0.0
.bss 63288 63288 0 0.0
.data 672 672 0 0.0
.text 359084 359084 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2292664 2292664 0 0.0
.bss 179956 179956 0 0.0
.data 5224 5224 0 0.0
.heap 851264 851264 0 0.0
.text 1255264 1255264 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2271608 2271608 0 0.0
.bss 172004 172004 0 0.0
.data 5576 5576 0 0.0
.heap 858864 858864 0 0.0
.text 1234208 1234208 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2249328 2249328 0 0.0
.bss 170900 170900 0 0.0
.data 5560 5560 0 0.0
.heap 859984 859984 0 0.0
.text 1211928 1211928 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048392 2048392 0 0.0
.bss 156248 156248 0 0.0
.data 4968 4968 0 0.0
.heap 875232 875232 0 0.0
.text 1010992 1010992 0 0.0
qpg lighting-app qpg6100+debug (read only) 490328 490328 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50408 50408 0 0.0
.data 1008 1008 0 0.0
.text 485008 485008 0 0.0
lock-app qpg6100+debug (read only) 466668 466668 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49352 49352 0 0.0
.data 964 964 0 0.0
.text 461348 461348 0 0.0
persistent-storage-app qpg6100+debug (read only) 155796 155796 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27760 27760 0 0.0
.data 372 372 0 0.0
.text 150476 150476 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662382 662382 0 0.0
bss 69116 69116 0 0.0
noinit 33216 33216 0 0.0
text 457774 457774 0 0.0

@woody-apple woody-apple added the hotfix urgent fix needed, can bypass review label Nov 2, 2021
@andy31415 andy31415 merged commit f384213 into master Nov 2, 2021
@andy31415 andy31415 deleted the revert-10682-android_add_discover branch November 2, 2021 18:35
@joonhaengHeo
Copy link
Contributor

@andy31415 Can I know the reason for the revert?

@austinh0
Copy link
Contributor

@joonhaengHeo There was a merge conflict where ThrowError in CHIPDeviceController-JNI.cpp was moved to a different file.

@joonhaengHeo
Copy link
Contributor

@austinh0 Thank you for your response.
Do you plan on merging your code?
Otherwise, please comment on whether it is better for me to request again later.

PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants