Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename several IM message with Message postfix #11289

Merged
merged 2 commits into from
Nov 2, 2021
Merged

Rename several IM message with Message postfix #11289

merged 2 commits into from
Nov 2, 2021

Conversation

yunhanw-google
Copy link
Contributor

Problem

Update SubscribeRequest/Response, ReadRequest, ReportData, StatusResponse， WriteRequest/Response with Message postfix

Change overview

See above

Testing

The existing presubmit test covers.

@boring-cyborg boring-cyborg bot added the app label Nov 1, 2021
@andy31415
Copy link
Contributor

fast track: rename only with approval from domain owner

@github-actions
Copy link

github-actions bot commented Nov 1, 2021

PR #11289: Size comparison from ed04737 to 3d86bbb

Increases (6 builds for k32w, p6, qpg, telink)
platform target config section ed04737 3d86bbb change % change
k32w lock-app k32w061+debug (read/write) 590540 590564 24 0.0
.text 514688 514712 24 0.0
lighting-app k32w061+se05x+release (read/write) 698244 698272 28 0.0
.text 612856 612884 28 0.0
p6 lock-app default (read/write) 2166576 2166600 24 0.0
.text 1124840 1124864 24 0.0
qpg lighting-app qpg6100+debug (read only) 489696 489712 16 0.0
.text 484376 484392 16 0.0
lock-app qpg6100+debug (read only) 466024 466040 16 0.0
.text 460704 460720 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 661634 661662 28 0.0
Full report (8 builds for k32w, p6, qpg, telink)
platform target config section ed04737 3d86bbb change % change
k32w lock-app k32w061+debug (read/write) 590540 590564 24 0.0
.bss 68188 68188 0 0.0
.data 1864 1864 0 0.0
.text 514688 514712 24 0.0
shell k32w061+debug (read/write) 424772 424772 0 0.0
.bss 63280 63280 0 0.0
.data 672 672 0 0.0
.text 359116 359116 0 0.0
lighting-app k32w061+se05x+release (read/write) 698244 698272 28 0.0
.bss 77688 77688 0 0.0
.data 1900 1900 0 0.0
.text 612856 612884 28 0.0
p6 lock-app default (read/write) 2166576 2166600 24 0.0
.bss 66184 66184 0 0.0
.data 2416 2416 0 0.0
.heap 964744 964744 0 0.0
.text 1124840 1124864 24 0.0
qpg lighting-app qpg6100+debug (read only) 489696 489712 16 0.0
(read/write) 114144 114144 0 0.0
.bss 50320 50320 0 0.0
.data 1000 1000 0 0.0
.text 484376 484392 16 0.0
lock-app qpg6100+debug (read only) 466024 466040 16 0.0
(read/write) 114140 114140 0 0.0
.bss 49272 49272 0 0.0
.data 956 956 0 0.0
.text 460704 460720 16 0.0
persistent-storage-app qpg6100+debug (read only) 155820 155820 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 150500 150500 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 661634 661662 28 0.0
bss 68960 68960 0 0.0
noinit 33216 33216 0 0.0
text 457376 457376 0 0.0

@yunhanw-google yunhanw-google force-pushed the feature/update_im_message_naming branch from 3d86bbb to 4c92a8c Compare November 1, 2021 22:26
@restyled-io restyled-io bot mentioned this pull request Nov 1, 2021
Closed
@yunhanw-google
Rename several IM message with Message postfix
894dc81 
-- Per IM spec, need to update SubscribeRequest/Response, ReadRequest, ReportData, StatusResponse wtih Message postfix
@yunhanw-google yunhanw-google force-pushed the feature/update_im_message_naming branch from 4c92a8c to 894dc81 Compare November 1, 2021 22:39
bzbarsky-apple
bzbarsky-apple requested changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check every line touched carefully, but for a number of those I did check adding "Message" does not make sense to me.

Updating the parser bits and the bits that deal with actual messages makes sense. Changing higher-level APIs that really are operating on the level of "write request", not messages, does not make sense.

@github-actions
Copy link

github-actions bot commented Nov 1, 2021 •
edited
Loading

PR #11289: Size comparison from 2fe9024 to 894dc81

Increases (6 builds for k32w, p6, qpg, telink)
platform target config section 2fe9024 894dc81 change % change
k32w lighting-app k32w061+se05x+release (read/write) 698212 698240 28 0.0
.text 612824 612852 28 0.0
lock-app k32w061+debug (read/write) 590508 590532 24 0.0
.text 514656 514680 24 0.0
p6 lock-app default (read/write) 2166544 2166568 24 0.0
.text 1124808 1124832 24 0.0
qpg lighting-app qpg6100+debug (read only) 489664 489680 16 0.0
.text 484344 484360 16 0.0
lock-app qpg6100+debug (read only) 465992 466008 16 0.0
.text 460672 460688 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 661586 661614 28 0.0
Full report (8 builds for k32w, p6, qpg, telink)
platform target config section 2fe9024 894dc81 change % change
k32w lighting-app k32w061+se05x+release (read/write) 698212 698240 28 0.0
.bss 77688 77688 0 0.0
.data 1900 1900 0 0.0
.text 612824 612852 28 0.0
lock-app k32w061+debug (read/write) 590508 590532 24 0.0
.bss 68188 68188 0 0.0
.data 1864 1864 0 0.0
.text 514656 514680 24 0.0
shell k32w061+debug (read/write) 424772 424772 0 0.0
.bss 63280 63280 0 0.0
.data 672 672 0 0.0
.text 359116 359116 0 0.0
p6 lock-app default (read/write) 2166544 2166568 24 0.0
.bss 66184 66184 0 0.0
.data 2416 2416 0 0.0
.heap 964744 964744 0 0.0
.text 1124808 1124832 24 0.0
qpg lighting-app qpg6100+debug (read only) 489664 489680 16 0.0
(read/write) 114144 114144 0 0.0
.bss 50320 50320 0 0.0
.data 1000 1000 0 0.0
.text 484344 484360 16 0.0
lock-app qpg6100+debug (read only) 465992 466008 16 0.0
(read/write) 114140 114140 0 0.0
.bss 49272 49272 0 0.0
.data 956 956 0 0.0
.text 460672 460688 16 0.0
persistent-storage-app qpg6100+debug (read only) 155820 155820 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 150500 150500 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 661586 661614 28 0.0
bss 68960 68960 0 0.0
noinit 33216 33216 0 0.0
text 457328 457328 0 0.0

@bzbarsky-apple
Copy link
Contributor

To be clear: Please go through all the changes and undo the ones that don't make sense. I mentioned some of them in my review comments, but I did not do a complete careful read. I'd really prefer to only have to do that once....

@yunhanw-google
Copy link
Contributor Author

@bzbarsky-apple agree on your suggestion, just updated, thanks

@yunhanw-google yunhanw-google force-pushed the feature/update_im_message_naming branch 5 times, most recently from 335b127 to bfd75ff Compare November 1, 2021 23:23
@restyled-io restyled-io bot mentioned this pull request Nov 1, 2021
Closed
@yunhanw-google yunhanw-google force-pushed the feature/update_im_message_naming branch from bfd75ff to 7e4cda1 Compare November 1, 2021 23:27
@github-actions
Copy link

github-actions bot commented Nov 1, 2021 •
edited
Loading

PR #11289: Size comparison from 2fe9024 to 7e4cda1

Increases (17 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section 2fe9024 7e4cda1 change % change
efr32 lighting-app BRD4161A (read only) 735380 735400 20 0.0
.text 735372 735392 20 0.0
BRD4161A+rpc (read only) 722820 722840 20 0.0
(read/write) 131048 131052 4 0.0
.text 722812 722832 20 0.0
lock-app BRD4161A (read only) 714664 714684 20 0.0
.text 714656 714676 20 0.0
window-app BRD4161A (read only) 715576 715596 20 0.0
.text 715568 715588 20 0.0
k32w lighting-app k32w061+se05x+release (read/write) 698212 698232 20 0.0
.text 612824 612844 20 0.0
lock-app k32w061+debug (read/write) 590508 590524 16 0.0
.text 514656 514672 16 0.0
linux all-clusters-app debug (read only) 1684009 1684105 96 0.0
.rodata 137749 137845 96 0.1
bridge-app debug+rpc (read only) 1278437 1278533 96 0.0
.rodata 109508 109604 96 0.1
chip-tool debug (read only) 4312861 4312957 96 0.0
.rodata 217424 217520 96 0.0
lighting-app debug+rpc (read only) 1537409 1537505 96 0.0
.rodata 127665 127761 96 0.1
ota-provider-app debug (read only) 1236329 1236425 96 0.0
.rodata 110280 110376 96 0.1
ota-requestor-app debug (read only) 1293601 1293697 96 0.0
.rodata 121504 121600 96 0.1
tv-app debug (read only) 1770809 1770905 96 0.0
.rodata 153080 153176 96 0.1
p6 lock-app default (read/write) 2166544 2166560 16 0.0
.text 1124808 1124824 16 0.0
qpg lighting-app qpg6100+debug (read only) 489664 489680 16 0.0
.text 484344 484360 16 0.0
lock-app qpg6100+debug (read only) 465992 466008 16 0.0
.text 460672 460688 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 661586 661606 20 0.0
Decreases (1 build for efr32)
platform target config section 2fe9024 7e4cda1 change % change
efr32 window-app BRD4161A (read/write) 112588 112584 -4 -0.0
Full report (20 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section 2fe9024 7e4cda1 change % change
efr32 lighting-app BRD4161A (read only) 735380 735400 20 0.0
(read/write) 114444 114444 0 0.0
.bss 112692 112692 0 0.0
.data 1752 1752 0 0.0
.text 735372 735392 20 0.0
BRD4161A+rpc (read only) 722820 722840 20 0.0
(read/write) 131048 131052 4 0.0
.bss 129196 129196 0 0.0
.data 1852 1852 0 0.0
.text 722812 722832 20 0.0
lock-app BRD4161A (read only) 714664 714684 20 0.0
(read/write) 112260 112260 0 0.0
.bss 110548 110548 0 0.0
.data 1712 1712 0 0.0
.text 714656 714676 20 0.0
window-app BRD4161A (read only) 715576 715596 20 0.0
(read/write) 112588 112584 -4 -0.0
.bss 110868 110868 0 0.0
.data 1716 1716 0 0.0
.text 715568 715588 20 0.0
k32w lighting-app k32w061+se05x+release (read/write) 698212 698232 20 0.0
.bss 77688 77688 0 0.0
.data 1900 1900 0 0.0
.text 612824 612844 20 0.0
lock-app k32w061+debug (read/write) 590508 590524 16 0.0
.bss 68188 68188 0 0.0
.data 1864 1864 0 0.0
.text 514656 514672 16 0.0
shell k32w061+debug (read/write) 424772 424772 0 0.0
.bss 63280 63280 0 0.0
.data 672 672 0 0.0
.text 359116 359116 0 0.0
linux all-clusters-app debug (read only) 1684009 1684105 96 0.0
(read/write) 118992 118992 0 0.0
.bss 50608 50608 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62112 62112 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 137749 137845 96 0.1
.text 1413202 1413202 0 0.0
bridge-app debug+rpc (read only) 1278437 1278533 96 0.0
(read/write) 84104 84104 0 0.0
.bss 50768 50768 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27368 27368 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 109508 109604 96 0.1
.text 1073685 1073685 0 0.0
chip-tool debug (read only) 4312861 4312957 96 0.0
(read/write) 123552 123552 0 0.0
.bss 17680 17680 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 98880 98880 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 217424 217520 96 0.0
.text 3829781 3829781 0 0.0
lighting-app debug+rpc (read only) 1537409 1537505 96 0.0
(read/write) 100976 100976 0 0.0
.bss 40152 40152 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 54448 54448 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 127665 127761 96 0.1
.text 1277362 1277362 0 0.0
ota-provider-app debug (read only) 1236329 1236425 96 0.0
(read/write) 67072 67072 0 0.0
.bss 36608 36608 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24616 24616 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110280 110376 96 0.1
.text 1029922 1029922 0 0.0
ota-requestor-app debug (read only) 1293601 1293697 96 0.0
(read/write) 76392 76392 0 0.0
.bss 44864 44864 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25576 25576 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 121504 121600 96 0.1
.text 1074306 1074306 0 0.0
shell debug (read only) 785041 785041 0 0.0
(read/write) 57664 57664 0 0.0
.bss 16072 16072 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36848 36848 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77295 77295 0 0.0
.text 606210 606210 0 0.0
tv-app debug (read only) 1770809 1770905 96 0.0
(read/write) 288536 288536 0 0.0
.bss 222192 222192 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58672 58672 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 153080 153176 96 0.1
.text 1475826 1475826 0 0.0
p6 lock-app default (read/write) 2166544 2166560 16 0.0
.bss 66184 66184 0 0.0
.data 2416 2416 0 0.0
.heap 964744 964744 0 0.0
.text 1124808 1124824 16 0.0
qpg lighting-app qpg6100+debug (read only) 489664 489680 16 0.0
(read/write) 114144 114144 0 0.0
.bss 50320 50320 0 0.0
.data 1000 1000 0 0.0
.text 484344 484360 16 0.0
lock-app qpg6100+debug (read only) 465992 466008 16 0.0
(read/write) 114140 114140 0 0.0
.bss 49272 49272 0 0.0
.data 956 956 0 0.0
.text 460672 460688 16 0.0
persistent-storage-app qpg6100+debug (read only) 155820 155820 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 150500 150500 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 661586 661606 20 0.0
bss 68960 68960 0 0.0
noinit 33216 33216 0 0.0
text 457328 457328 0 0.0

@yunhanw-google yunhanw-google force-pushed the feature/update_im_message_naming branch 2 times, most recently from aff4b78 to 4666576 Compare November 2, 2021 00:13
@restyled-io restyled-io bot mentioned this pull request Nov 2, 2021
Closed
@yunhanw-google yunhanw-google force-pushed the feature/update_im_message_naming branch from 4666576 to 056e3f7 Compare November 2, 2021 00:16
@github-actions
Copy link

github-actions bot commented Nov 2, 2021 •
edited
Loading

PR #11289: Size comparison from 2fe9024 to 056e3f7

Increases (29 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 2fe9024 056e3f7 change % change
efr32 lighting-app BRD4161A (read only) 735380 735400 20 0.0
.text 735372 735392 20 0.0
BRD4161A+rpc (read only) 722820 722840 20 0.0
(read/write) 131048 131052 4 0.0
.text 722812 722832 20 0.0
lock-app BRD4161A (read only) 714664 714684 20 0.0
.text 714656 714676 20 0.0
window-app BRD4161A (read only) 715576 715596 20 0.0
.text 715568 715588 20 0.0
esp32 all-clusters-app c3devkit (read/write) 1307528 1307552 24 0.0
.flash.rodata 199400 199424 24 0.0
m5stack (read/write) 427296 427312 16 0.0
.flash.rodata 208112 208128 16 0.0
k32w lighting-app k32w061+se05x+release (read/write) 698212 698232 20 0.0
.text 612824 612844 20 0.0
lock-app k32w061+debug (read/write) 590508 590524 16 0.0
.text 514656 514672 16 0.0
linux all-clusters-app debug (read only) 1684009 1684105 96 0.0
.rodata 137749 137845 96 0.1
bridge-app debug+rpc (read only) 1278437 1278533 96 0.0
.rodata 109508 109604 96 0.1
chip-tool debug (read only) 4312861 4312925 64 0.0
.rodata 217424 217488 64 0.0
lighting-app debug+rpc (read only) 1537409 1537505 96 0.0
.rodata 127665 127761 96 0.1
ota-provider-app debug (read only) 1236329 1236425 96 0.0
.rodata 110280 110376 96 0.1
ota-requestor-app debug (read only) 1293601 1293697 96 0.0
.rodata 121504 121600 96 0.1
tv-app debug (read only) 1770809 1770905 96 0.0
.rodata 153080 153176 96 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2293560 2293608 48 0.0
.text 1256160 1256208 48 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2272688 2272736 48 0.0
.text 1235288 1235336 48 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2250344 2250392 48 0.0
.text 1212944 1212992 48 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860155 860175 20 0.0
rodata 96340 96360 20 0.0
nrf52840dk_nrf52840+rpc (read/write) 820975 820999 24 0.0
rodata 87112 87136 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 785194 785218 24 0.0
rodata 91580 91604 24 0.0
lock-app nrf52840dk_nrf52840 (read/write) 836863 836883 20 0.0
rodata 92696 92716 20 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 762158 762178 20 0.0
rodata 88000 88020 20 0.0
pump-app nrf52840dk_nrf52840 (read/write) 842843 842863 20 0.0
rodata 94404 94424 20 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 836715 836739 24 0.0
rodata 92692 92716 24 0.0
p6 lock-app default (read/write) 2166544 2166560 16 0.0
.text 1124808 1124824 16 0.0
qpg lighting-app qpg6100+debug (read only) 489664 489680 16 0.0
.text 484344 484360 16 0.0
lock-app qpg6100+debug (read only) 465992 466008 16 0.0
.text 460672 460688 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 661586 661606 20 0.0
Decreases (1 build for efr32)
platform target config section 2fe9024 056e3f7 change % change
efr32 window-app BRD4161A (read/write) 112588 112584 -4 -0.0
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 2fe9024 056e3f7 change % change
efr32 lighting-app BRD4161A (read only) 735380 735400 20 0.0
(read/write) 114444 114444 0 0.0
.bss 112692 112692 0 0.0
.data 1752 1752 0 0.0
.text 735372 735392 20 0.0
BRD4161A+rpc (read only) 722820 722840 20 0.0
(read/write) 131048 131052 4 0.0
.bss 129196 129196 0 0.0
.data 1852 1852 0 0.0
.text 722812 722832 20 0.0
lock-app BRD4161A (read only) 714664 714684 20 0.0
(read/write) 112260 112260 0 0.0
.bss 110548 110548 0 0.0
.data 1712 1712 0 0.0
.text 714656 714676 20 0.0
window-app BRD4161A (read only) 715576 715596 20 0.0
(read/write) 112588 112584 -4 -0.0
.bss 110868 110868 0 0.0
.data 1716 1716 0 0.0
.text 715568 715588 20 0.0
esp32 all-clusters-app c3devkit (read only) 880170 880170 0 0.0
(read/write) 1307528 1307552 24 0.0
.dram0.bss 58424 58424 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 199400 199424 24 0.0
.flash.text 880170 880170 0 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 911115 911115 0 0.0
(read/write) 427296 427312 16 0.0
.dram0.bss 60920 60920 0 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 208112 208128 16 0.0
.flash.text 911115 911115 0 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 698212 698232 20 0.0
.bss 77688 77688 0 0.0
.data 1900 1900 0 0.0
.text 612824 612844 20 0.0
lock-app k32w061+debug (read/write) 590508 590524 16 0.0
.bss 68188 68188 0 0.0
.data 1864 1864 0 0.0
.text 514656 514672 16 0.0
shell k32w061+debug (read/write) 424772 424772 0 0.0
.bss 63280 63280 0 0.0
.data 672 672 0 0.0
.text 359116 359116 0 0.0
linux all-clusters-app debug (read only) 1684009 1684105 96 0.0
(read/write) 118992 118992 0 0.0
.bss 50608 50608 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62112 62112 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 137749 137845 96 0.1
.text 1413202 1413202 0 0.0
bridge-app debug+rpc (read only) 1278437 1278533 96 0.0
(read/write) 84104 84104 0 0.0
.bss 50768 50768 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27368 27368 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 109508 109604 96 0.1
.text 1073685 1073685 0 0.0
chip-tool debug (read only) 4312861 4312925 64 0.0
(read/write) 123552 123552 0 0.0
.bss 17680 17680 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 98880 98880 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 217424 217488 64 0.0
.text 3829781 3829781 0 0.0
lighting-app debug+rpc (read only) 1537409 1537505 96 0.0
(read/write) 100976 100976 0 0.0
.bss 40152 40152 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 54448 54448 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 127665 127761 96 0.1
.text 1277362 1277362 0 0.0
ota-provider-app debug (read only) 1236329 1236425 96 0.0
(read/write) 67072 67072 0 0.0
.bss 36608 36608 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24616 24616 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110280 110376 96 0.1
.text 1029922 1029922 0 0.0
ota-requestor-app debug (read only) 1293601 1293697 96 0.0
(read/write) 76392 76392 0 0.0
.bss 44864 44864 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25576 25576 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 121504 121600 96 0.1
.text 1074306 1074306 0 0.0
shell debug (read only) 785041 785041 0 0.0
(read/write) 57664 57664 0 0.0
.bss 16072 16072 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36848 36848 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77295 77295 0 0.0
.text 606210 606210 0 0.0
tv-app debug (read only) 1770809 1770905 96 0.0
(read/write) 288536 288536 0 0.0
.bss 222192 222192 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58672 58672 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 153080 153176 96 0.1
.text 1475826 1475826 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293560 2293608 48 0.0
.bss 179796 179796 0 0.0
.data 5216 5216 0 0.0
.heap 851432 851432 0 0.0
.text 1256160 1256208 48 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2272688 2272736 48 0.0
.bss 171836 171836 0 0.0
.data 5568 5568 0 0.0
.heap 859040 859040 0 0.0
.text 1235288 1235336 48 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250344 2250392 48 0.0
.bss 170740 170740 0 0.0
.data 5552 5552 0 0.0
.heap 860152 860152 0 0.0
.text 1212944 1212992 48 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048328 2048328 0 0.0
.bss 156232 156232 0 0.0
.data 4968 4968 0 0.0
.heap 875248 875248 0 0.0
.text 1010928 1010928 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860155 860175 20 0.0
bss 111148 111148 0 0.0
rodata 96340 96360 20 0.0
text 577052 577052 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 820975 820999 24 0.0
bss 107392 107392 0 0.0
rodata 87112 87136 24 0.0
text 550224 550224 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 785194 785218 24 0.0
bss 112524 112524 0 0.0
rodata 91580 91604 24 0.0
text 506520 506520 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 836863 836883 20 0.0
bss 110184 110184 0 0.0
rodata 92696 92716 20 0.0
text 558532 558532 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 762158 762178 20 0.0
bss 111596 111596 0 0.0
rodata 88000 88020 20 0.0
text 488092 488092 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 842843 842863 20 0.0
bss 110320 110320 0 0.0
rodata 94404 94424 20 0.0
text 562588 562588 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 836715 836739 24 0.0
bss 110220 110220 0 0.0
rodata 92692 92716 24 0.0
text 558268 558268 0 0.0
shell nrf52840dk_nrf52840 (read/write) 775903 775903 0 0.0
bss 109096 109096 0 0.0
rodata 72404 72404 0 0.0
text 519792 519792 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690906 690906 0 0.0
bss 110080 110080 0 0.0
rodata 67044 67044 0 0.0
text 440400 440400 0 0.0
p6 lock-app default (read/write) 2166544 2166560 16 0.0
.bss 66184 66184 0 0.0
.data 2416 2416 0 0.0
.heap 964744 964744 0 0.0
.text 1124808 1124824 16 0.0
qpg lighting-app qpg6100+debug (read only) 489664 489680 16 0.0
(read/write) 114144 114144 0 0.0
.bss 50320 50320 0 0.0
.data 1000 1000 0 0.0
.text 484344 484360 16 0.0
lock-app qpg6100+debug (read only) 465992 466008 16 0.0
(read/write) 114140 114140 0 0.0
.bss 49272 49272 0 0.0
.data 956 956 0 0.0
.text 460672 460688 16 0.0
persistent-storage-app qpg6100+debug (read only) 155820 155820 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 150500 150500 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 661586 661606 20 0.0
bss 68960 68960 0 0.0
noinit 33216 33216 0 0.0
text 457328 457328 0 0.0

@yunhanw-google yunhanw-google merged commit 12ec702 into project-chip:master Nov 2, 2021
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@yunhanw-google
Rename several IM message with Message postfix (project-chip#11289)
12fea50 
* Rename several IM message with Message postfix

-- Per IM spec, need to update SubscribeRequest/Response, ReadRequest, ReportData, StatusResponse wtih Message postfix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
app fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yunhanw-google @andy31415 @bzbarsky-apple @mrjerryjohns