Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Descriptor cluster must be handled by the AttributeAccessInterface in the bridge-app (#11182) #11260

Merged
merged 3 commits into from
Nov 2, 2021
Merged

Descriptor cluster must be handled by the AttributeAccessInterface in the bridge-app (#11182) #11260

merged 3 commits into from
Nov 2, 2021

Conversation

pjzander-signify
Copy link
Contributor

Problem

The handling of the descriptor cluster in the bridge-app should be done completely via the AttributeAccessInterface.
The implementation in the bridge-app can be removed.

Change overview

  • The cluster revision attribute is also returned by descriptor cluster implementation. Now all the attributes are implemented in the descriptor cluster.
  • The handling of reading the descriptor cluster attributes is removed completely from the bridge-app since it is not necessary anymore.

Testing

  • Manual tested with the chip-tool and the bridge-app.
  • Passed all Github workflows.

@github-actions
Copy link

github-actions bot commented Nov 1, 2021 •
edited
Loading

PR #11260: Size comparison from 8dcf5d7 to 78c2cc8

Increases (22 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 8dcf5d7 78c2cc8 change % change
efr32 lighting-app BRD4161A (read only) 736636 736700 64 0.0
.text 736628 736692 64 0.0
BRD4161A+rpc (read only) 724076 724140 64 0.0
.text 724068 724132 64 0.0
lock-app BRD4161A (read only) 715932 715996 64 0.0
.text 715924 715988 64 0.0
window-app BRD4161A (read only) 716836 716884 48 0.0
.text 716828 716876 48 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699128 699160 32 0.0
.text 613708 613740 32 0.0
lock-app k32w061+debug (read/write) 591432 591464 32 0.0
.text 515548 515580 32 0.0
linux all-clusters-app debug (read only) 1687001 1687145 144 0.0
.text 1415874 1416018 144 0.0
lighting-app debug+rpc (read only) 1540865 1541025 160 0.0
.text 1280370 1280530 160 0.0
tv-app debug (read only) 1773337 1773497 160 0.0
.text 1477682 1477842 160 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 851400 851408 8 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2274336 2274400 64 0.0
.text 1236936 1237000 64 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861267 861315 48 0.0
text 577612 577652 40 0.0
nrf52840dk_nrf52840+rpc (read/write) 822095 822143 48 0.0
text 550784 550824 40 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786306 786338 32 0.0
text 507080 507120 40 0.0
lock-app nrf52840dk_nrf52840 (read/write) 837975 838007 32 0.0
text 559092 559132 40 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763270 763318 48 0.0
text 488652 488692 40 0.0
pump-app nrf52840dk_nrf52840 (read/write) 842643 842675 32 0.0
text 562300 562340 40 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837947 837995 48 0.0
text 558932 558972 40 0.0
p6 lock-app default (read/write) 2167872 2167936 64 0.0
.text 1126136 1126200 64 0.0
qpg lighting-app qpg6100+debug (read only) 490500 490532 32 0.0
.text 485180 485212 32 0.0
lock-app qpg6100+debug (read only) 466844 466892 48 0.0
.text 461524 461572 48 0.0
telink lighting-app tlsr9518adk80d (read/write) 662890 662930 40 0.0
text 458036 458074 38 0.0
Decreases (3 builds for linux, mbed)
platform target config section 8dcf5d7 78c2cc8 change % change
linux all-clusters-app debug (read/write) 119024 118992 -32 -0.0
.bss 50640 50608 -32 -0.1
bridge-app debug+rpc (read only) 1281957 1281701 -256 -0.0
(read/write) 84136 67880 -16256 -19.3
.bss 50800 34544 -16256 -32.0
.text 1076693 1076437 -256 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 179828 179820 -8 -0.0
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 8dcf5d7 78c2cc8 change % change
efr32 lighting-app BRD4161A (read only) 736636 736700 64 0.0
(read/write) 114476 114476 0 0.0
.bss 112724 112724 0 0.0
.data 1752 1752 0 0.0
.text 736628 736692 64 0.0
BRD4161A+rpc (read only) 724076 724140 64 0.0
(read/write) 131080 131080 0 0.0
.bss 129228 129228 0 0.0
.data 1852 1852 0 0.0
.text 724068 724132 64 0.0
lock-app BRD4161A (read only) 715932 715996 64 0.0
(read/write) 112292 112292 0 0.0
.bss 110580 110580 0 0.0
.data 1712 1712 0 0.0
.text 715924 715988 64 0.0
window-app BRD4161A (read only) 716836 716884 48 0.0
(read/write) 112616 112616 0 0.0
.bss 110900 110900 0 0.0
.data 1716 1716 0 0.0
.text 716828 716876 48 0.0
esp32 all-clusters-app c3devkit (read only) 880562 880562 0 0.0
(read/write) 1307800 1307800 0 0.0
.dram0.bss 58456 58456 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 199640 199640 0 0.0
.flash.text 880562 880562 0 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 911451 911451 0 0.0
(read/write) 427560 427560 0 0.0
.dram0.bss 60952 60952 0 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 208344 208344 0 0.0
.flash.text 911451 911451 0 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699128 699160 32 0.0
.bss 77720 77720 0 0.0
.data 1900 1900 0 0.0
.text 613708 613740 32 0.0
lock-app k32w061+debug (read/write) 591432 591464 32 0.0
.bss 68220 68220 0 0.0
.data 1864 1864 0 0.0
.text 515548 515580 32 0.0
shell k32w061+debug (read/write) 424988 424988 0 0.0
.bss 63280 63280 0 0.0
.data 672 672 0 0.0
.text 359332 359332 0 0.0
linux all-clusters-app debug (read only) 1687001 1687145 144 0.0
(read/write) 119024 118992 -32 -0.0
.bss 50640 50608 -32 -0.1
.data 1010 1010 0 0.0
.data.rel.ro 62112 62112 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 138069 138069 0 0.0
.text 1415874 1416018 144 0.0
bridge-app debug+rpc (read only) 1281957 1281701 -256 -0.0
(read/write) 84136 67880 -16256 -19.3
.bss 50800 34544 -16256 -32.0
.data 976 976 0 0.0
.data.rel.ro 27368 27368 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 110020 110020 0 0.0
.text 1076693 1076437 -256 -0.0
chip-tool debug (read only) 4314925 4314925 0 0.0
(read/write) 123648 123648 0 0.0
.bss 17712 17712 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 98928 98928 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 217360 217360 0 0.0
.text 3831621 3831621 0 0.0
lighting-app debug+rpc (read only) 1540865 1541025 160 0.0
(read/write) 101008 101008 0 0.0
.bss 40184 40184 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 54448 54448 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128113 128113 0 0.0
.text 1280370 1280530 160 0.0
ota-provider-app debug (read only) 1239033 1239033 0 0.0
(read/write) 67104 67104 0 0.0
.bss 36640 36640 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24616 24616 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110408 110408 0 0.0
.text 1032498 1032498 0 0.0
ota-requestor-app debug (read only) 1302033 1302033 0 0.0
(read/write) 76360 76360 0 0.0
.bss 44896 44896 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25528 25528 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 127072 127072 0 0.0
.text 1077170 1077170 0 0.0
shell debug (read only) 786145 786145 0 0.0
(read/write) 57664 57664 0 0.0
.bss 16072 16072 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36848 36848 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77423 77423 0 0.0
.text 607186 607186 0 0.0
tv-app debug (read only) 1773337 1773497 160 0.0
(read/write) 288600 288600 0 0.0
.bss 222224 222224 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58704 58704 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 153464 153464 0 0.0
.text 1477682 1477842 160 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2294952 2294952 0 0.0
.bss 179828 179820 -8 -0.0
.data 5216 5216 0 0.0
.heap 851400 851408 8 0.0
.text 1257552 1257552 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2274336 2274400 64 0.0
.bss 171868 171868 0 0.0
.data 5568 5568 0 0.0
.heap 859008 859008 0 0.0
.text 1236936 1237000 64 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2252056 2252056 0 0.0
.bss 170772 170772 0 0.0
.data 5552 5552 0 0.0
.heap 860120 860120 0 0.0
.text 1214656 1214656 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048656 2048656 0 0.0
.bss 156232 156232 0 0.0
.data 4968 4968 0 0.0
.heap 875248 875248 0 0.0
.text 1011256 1011256 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861267 861315 48 0.0
bss 111180 111180 0 0.0
rodata 96860 96860 0 0.0
text 577612 577652 40 0.0
nrf52840dk_nrf52840+rpc (read/write) 822095 822143 48 0.0
bss 107424 107424 0 0.0
rodata 87640 87640 0 0.0
text 550784 550824 40 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786306 786338 32 0.0
bss 112556 112556 0 0.0
rodata 92100 92100 0 0.0
text 507080 507120 40 0.0
lock-app nrf52840dk_nrf52840 (read/write) 837975 838007 32 0.0
bss 110216 110216 0 0.0
rodata 93216 93216 0 0.0
text 559092 559132 40 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763270 763318 48 0.0
bss 111628 111628 0 0.0
rodata 88520 88520 0 0.0
text 488652 488692 40 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 842643 842675 32 0.0
bss 110352 110352 0 0.0
rodata 94460 94460 0 0.0
text 562300 562340 40 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837947 837995 48 0.0
bss 110252 110252 0 0.0
rodata 93236 93236 0 0.0
text 558932 558972 40 0.0
shell nrf52840dk_nrf52840 (read/write) 776179 776179 0 0.0
bss 109096 109096 0 0.0
rodata 72536 72536 0 0.0
text 519936 519936 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691202 691202 0 0.0
bss 110080 110080 0 0.0
rodata 67180 67180 0 0.0
text 440548 440548 0 0.0
p6 lock-app default (read/write) 2167872 2167936 64 0.0
.bss 66216 66216 0 0.0
.data 2416 2416 0 0.0
.heap 964712 964712 0 0.0
.text 1126136 1126200 64 0.0
qpg lighting-app qpg6100+debug (read only) 490500 490532 32 0.0
(read/write) 114144 114144 0 0.0
.bss 50336 50336 0 0.0
.data 1000 1000 0 0.0
.text 485180 485212 32 0.0
lock-app qpg6100+debug (read only) 466844 466892 48 0.0
(read/write) 114140 114140 0 0.0
.bss 49288 49288 0 0.0
.data 956 956 0 0.0
.text 461524 461572 48 0.0
persistent-storage-app qpg6100+debug (read only) 155820 155820 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 150500 150500 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662890 662930 40 0.0
bss 68992 68992 0 0.0
noinit 33216 33216 0 0.0
text 458036 458074 38 0.0

@github-actions
Copy link

github-actions bot commented Nov 2, 2021 •
edited
Loading

PR #11260: Size comparison from 12ec702 to 273b2c4

Increases (22 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 12ec702 273b2c4 change % change
efr32 lighting-app BRD4161A (read only) 735400 735464 64 0.0
.text 735392 735456 64 0.0
BRD4161A+rpc (read only) 722840 722904 64 0.0
.text 722832 722896 64 0.0
lock-app BRD4161A (read only) 714684 714748 64 0.0
.text 714676 714740 64 0.0
window-app BRD4161A (read only) 715596 715660 64 0.0
.text 715588 715652 64 0.0
k32w lighting-app k32w061+se05x+release (read/write) 698232 698256 24 0.0
.text 612844 612876 32 0.0
lock-app k32w061+debug (read/write) 590524 590556 32 0.0
.text 514672 514704 32 0.0
linux all-clusters-app debug (read only) 1684105 1684249 144 0.0
.text 1413202 1413346 144 0.0
lighting-app debug+rpc (read only) 1537505 1537665 160 0.0
.text 1277362 1277522 160 0.0
tv-app debug (read only) 1770905 1771049 144 0.0
.text 1475826 1475970 144 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2293608 2293672 64 0.0
.heap 851432 851440 8 0.0
.text 1256208 1256272 64 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2250392 2250456 64 0.0
.heap 860152 860160 8 0.0
.text 1212992 1213056 64 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860175 860223 48 0.0
text 577052 577092 40 0.0
nrf52840dk_nrf52840+rpc (read/write) 820999 821047 48 0.0
text 550224 550264 40 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 785218 785250 32 0.0
text 506520 506560 40 0.0
lock-app nrf52840dk_nrf52840 (read/write) 836883 836915 32 0.0
text 558532 558572 40 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 762178 762226 48 0.0
text 488092 488132 40 0.0
pump-app nrf52840dk_nrf52840 (read/write) 842863 842895 32 0.0
text 562588 562628 40 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 836739 836771 32 0.0
text 558268 558308 40 0.0
p6 lock-app default (read/write) 2166560 2166608 48 0.0
.heap 964744 964752 8 0.0
.text 1124824 1124872 48 0.0
qpg lighting-app qpg6100+debug (read only) 489680 489712 32 0.0
.text 484360 484392 32 0.0
lock-app qpg6100+debug (read only) 466008 466056 48 0.0
.text 460688 460736 48 0.0
telink lighting-app tlsr9518adk80d (read/write) 661606 661646 40 0.0
text 457328 457366 38 0.0
Decreases (21 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 12ec702 273b2c4 change % change
efr32 lighting-app BRD4161A (read/write) 114444 114436 -8 -0.0
.bss 112692 112684 -8 -0.0
BRD4161A+rpc (read/write) 131052 131044 -8 -0.0
.bss 129196 129188 -8 -0.0
lock-app BRD4161A (read/write) 112260 112252 -8 -0.0
.bss 110548 110540 -8 -0.0
window-app BRD4161A (read/write) 112584 112576 -8 -0.0
.bss 110868 110860 -8 -0.0
esp32 all-clusters-app c3devkit (read/write) 1307552 1307536 -16 -0.0
.dram0.bss 58424 58416 -8 -0.0
m5stack (read only) 911115 911039 -76 -0.0
(read/write) 427312 427304 -8 -0.0
.dram0.bss 60920 60912 -8 -0.0
.flash.text 911115 911039 -76 -0.0
k32w lighting-app k32w061+se05x+release .bss 77688 77680 -8 -0.0
linux all-clusters-app debug (read/write) 118992 118960 -32 -0.0
.bss 50608 50576 -32 -0.1
bridge-app debug+rpc (read only) 1278533 1278277 -256 -0.0
(read/write) 84104 67848 -16256 -19.3
.bss 50768 34512 -16256 -32.0
.text 1073685 1073429 -256 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 179796 179788 -8 -0.0
lock-app CY8CPROTO_062_4343W+release .bss 170740 170732 -8 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 bss 111148 111144 -4 -0.0
nrf52840dk_nrf52840+rpc bss 107392 107388 -4 -0.0
nrf5340dk_nrf5340_cpuapp bss 112524 112520 -4 -0.0
lock-app nrf52840dk_nrf52840 bss 110184 110180 -4 -0.0
nrf5340dk_nrf5340_cpuapp bss 111596 111592 -4 -0.0
pump-app nrf52840dk_nrf52840 bss 110320 110316 -4 -0.0
pump-controller-app nrf52840dk_nrf52840 bss 110220 110216 -4 -0.0
p6 lock-app default .bss 66184 66176 -8 -0.0
qpg lock-app qpg6100+debug .bss 49272 49264 -8 -0.0
telink lighting-app tlsr9518adk80d bss 68960 68956 -4 -0.0
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 12ec702 273b2c4 change % change
efr32 lighting-app BRD4161A (read only) 735400 735464 64 0.0
(read/write) 114444 114436 -8 -0.0
.bss 112692 112684 -8 -0.0
.data 1752 1752 0 0.0
.text 735392 735456 64 0.0
BRD4161A+rpc (read only) 722840 722904 64 0.0
(read/write) 131052 131044 -8 -0.0
.bss 129196 129188 -8 -0.0
.data 1852 1852 0 0.0
.text 722832 722896 64 0.0
lock-app BRD4161A (read only) 714684 714748 64 0.0
(read/write) 112260 112252 -8 -0.0
.bss 110548 110540 -8 -0.0
.data 1712 1712 0 0.0
.text 714676 714740 64 0.0
window-app BRD4161A (read only) 715596 715660 64 0.0
(read/write) 112584 112576 -8 -0.0
.bss 110868 110860 -8 -0.0
.data 1716 1716 0 0.0
.text 715588 715652 64 0.0
esp32 all-clusters-app c3devkit (read only) 880170 880170 0 0.0
(read/write) 1307552 1307536 -16 -0.0
.dram0.bss 58424 58416 -8 -0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 199424 199424 0 0.0
.flash.text 880170 880170 0 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 911115 911039 -76 -0.0
(read/write) 427312 427304 -8 -0.0
.dram0.bss 60920 60912 -8 -0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 208128 208128 0 0.0
.flash.text 911115 911039 -76 -0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 698232 698256 24 0.0
.bss 77688 77680 -8 -0.0
.data 1900 1900 0 0.0
.text 612844 612876 32 0.0
lock-app k32w061+debug (read/write) 590524 590556 32 0.0
.bss 68188 68188 0 0.0
.data 1864 1864 0 0.0
.text 514672 514704 32 0.0
shell k32w061+debug (read/write) 424772 424772 0 0.0
.bss 63280 63280 0 0.0
.data 672 672 0 0.0
.text 359116 359116 0 0.0
linux all-clusters-app debug (read only) 1684105 1684249 144 0.0
(read/write) 118992 118960 -32 -0.0
.bss 50608 50576 -32 -0.1
.data 1010 1010 0 0.0
.data.rel.ro 62112 62112 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 137845 137845 0 0.0
.text 1413202 1413346 144 0.0
bridge-app debug+rpc (read only) 1278533 1278277 -256 -0.0
(read/write) 84104 67848 -16256 -19.3
.bss 50768 34512 -16256 -32.0
.data 976 976 0 0.0
.data.rel.ro 27368 27368 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 109604 109604 0 0.0
.text 1073685 1073429 -256 -0.0
chip-tool debug (read only) 4312925 4312925 0 0.0
(read/write) 123552 123552 0 0.0
.bss 17680 17680 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 98880 98880 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 217488 217488 0 0.0
.text 3829781 3829781 0 0.0
lighting-app debug+rpc (read only) 1537505 1537665 160 0.0
(read/write) 100976 100976 0 0.0
.bss 40152 40152 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 54448 54448 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 127761 127761 0 0.0
.text 1277362 1277522 160 0.0
ota-provider-app debug (read only) 1236425 1236425 0 0.0
(read/write) 67072 67072 0 0.0
.bss 36608 36608 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24616 24616 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110376 110376 0 0.0
.text 1029922 1029922 0 0.0
ota-requestor-app debug (read only) 1293697 1293697 0 0.0
(read/write) 76392 76392 0 0.0
.bss 44864 44864 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25576 25576 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 121600 121600 0 0.0
.text 1074306 1074306 0 0.0
shell debug (read only) 785041 785041 0 0.0
(read/write) 57664 57664 0 0.0
.bss 16072 16072 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36848 36848 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77295 77295 0 0.0
.text 606210 606210 0 0.0
tv-app debug (read only) 1770905 1771049 144 0.0
(read/write) 288536 288536 0 0.0
.bss 222192 222192 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58672 58672 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 153176 153176 0 0.0
.text 1475826 1475970 144 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293608 2293672 64 0.0
.bss 179796 179788 -8 -0.0
.data 5216 5216 0 0.0
.heap 851432 851440 8 0.0
.text 1256208 1256272 64 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2272736 2272736 0 0.0
.bss 171836 171836 0 0.0
.data 5568 5568 0 0.0
.heap 859040 859040 0 0.0
.text 1235336 1235336 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250392 2250456 64 0.0
.bss 170740 170732 -8 -0.0
.data 5552 5552 0 0.0
.heap 860152 860160 8 0.0
.text 1212992 1213056 64 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048328 2048328 0 0.0
.bss 156232 156232 0 0.0
.data 4968 4968 0 0.0
.heap 875248 875248 0 0.0
.text 1010928 1010928 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860175 860223 48 0.0
bss 111148 111144 -4 -0.0
rodata 96360 96360 0 0.0
text 577052 577092 40 0.0
nrf52840dk_nrf52840+rpc (read/write) 820999 821047 48 0.0
bss 107392 107388 -4 -0.0
rodata 87136 87136 0 0.0
text 550224 550264 40 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 785218 785250 32 0.0
bss 112524 112520 -4 -0.0
rodata 91604 91604 0 0.0
text 506520 506560 40 0.0
lock-app nrf52840dk_nrf52840 (read/write) 836883 836915 32 0.0
bss 110184 110180 -4 -0.0
rodata 92716 92716 0 0.0
text 558532 558572 40 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 762178 762226 48 0.0
bss 111596 111592 -4 -0.0
rodata 88020 88020 0 0.0
text 488092 488132 40 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 842863 842895 32 0.0
bss 110320 110316 -4 -0.0
rodata 94424 94424 0 0.0
text 562588 562628 40 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 836739 836771 32 0.0
bss 110220 110216 -4 -0.0
rodata 92716 92716 0 0.0
text 558268 558308 40 0.0
shell nrf52840dk_nrf52840 (read/write) 775903 775903 0 0.0
bss 109096 109096 0 0.0
rodata 72404 72404 0 0.0
text 519792 519792 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690906 690906 0 0.0
bss 110080 110080 0 0.0
rodata 67044 67044 0 0.0
text 440400 440400 0 0.0
p6 lock-app default (read/write) 2166560 2166608 48 0.0
.bss 66184 66176 -8 -0.0
.data 2416 2416 0 0.0
.heap 964744 964752 8 0.0
.text 1124824 1124872 48 0.0
qpg lighting-app qpg6100+debug (read only) 489680 489712 32 0.0
(read/write) 114144 114144 0 0.0
.bss 50320 50320 0 0.0
.data 1000 1000 0 0.0
.text 484360 484392 32 0.0
lock-app qpg6100+debug (read only) 466008 466056 48 0.0
(read/write) 114140 114140 0 0.0
.bss 49272 49264 -8 -0.0
.data 956 956 0 0.0
.text 460688 460736 48 0.0
persistent-storage-app qpg6100+debug (read only) 155820 155820 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 150500 150500 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 661606 661646 40 0.0
bss 68960 68956 -4 -0.0
noinit 33216 33216 0 0.0
text 457328 457366 38 0.0

@bzbarsky-apple
Copy link
Contributor

@msandstedt @saurabhst @jepenven-silabs @jmartinez-silabs @LuDuda @Damian-Nordic Please take a look?

@bzbarsky-apple bzbarsky-apple merged commit 8008baf into project-chip:master Nov 2, 2021
@pjzander-signify pjzander-signify deleted the issue_11182 branch November 2, 2021 16:05
@pjzander-signify pjzander-signify linked an issue Nov 3, 2021 that may be closed by this pull request
Descriptor cluster must be handled by the AttributeAccessInterface in the bridge-app #11182
Closed
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@pjzander-signify
Descriptor cluster must be handled by the AttributeAccessInterface in…
2b1bb49 
… the bridge-app (project-chip#11182) (project-chip#11260)

* Add the cluster revision attribute to the AttributeAccessInterface of the descriptor cluster

* Remove the handling of the descriptor clusters from the main

* Mark all the descriptor cluster server side attributes as external
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app controller examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Descriptor cluster must be handled by the AttributeAccessInterface in the bridge-app
5 participants
@pjzander-signify @bzbarsky-apple @andy31415 @mrjerryjohns @jmartinez-silabs