Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging for OTA QueryImage, AnnounceOTAProvider, and BDX Output Event Type #11241

Merged
merged 3 commits into from
Nov 1, 2021
Merged

Add logging for OTA QueryImage, AnnounceOTAProvider, and BDX Output Event Type #11241

merged 3 commits into from
Nov 1, 2021

Conversation

carol-apple
Copy link
Contributor

Problem

Fixes: #11074
The above issue requires certain OTA logs to be printed in order to to be parsed and to validate test cases. Current logging does not exist.

Change overview

This PR adds the parameters to QueryImage and AnnounceOTAProvider commands. In addition, it also logs the type of BDX output event rather than printing its numerical value.

Testing

Launch the ota-provider app and ota-requestor-app and initiate a BDX transfer between the two apps

  • Verify that the parameters to QueryImage is logged
  • Verify that the parameters to AnnounceOTAProvider is logged
  • Verify that the BDX output event type is logged

@restyled-io restyled-io bot mentioned this pull request Oct 30, 2021
Closed
@carol-apple carol-apple force-pushed the test_add_ota_logging_te7 branch from 5a2249a to 0995871 Compare October 30, 2021 03:21
@carol-apple carol-apple changed the title Add logging for OTA QueryImage, AnnounceOTAProvider, and BDX Add logging for OTA QueryImage, AnnounceOTAProvider, and BDX Output Event Type Oct 30, 2021
@carol-apple carol-apple requested a review from holbrookt October 30, 2021 03:22
@carol-apple carol-apple force-pushed the test_add_ota_logging_te7 branch from 0995871 to 573bebd Compare October 30, 2021 03:25
@github-actions
Copy link

github-actions bot commented Oct 30, 2021 •
edited
Loading

PR #11241: Size comparison from bf585f8 to 573bebd

Increases above 0.2%:

platform target config section bf585f8 573bebd change % change
linux ota-provider-app debug .rodata 110408 110760 352 0.3
Increases (7 builds for esp32, linux, mbed)
platform target config section bf585f8 573bebd change % change
esp32 all-clusters-app c3devkit (read only) 880562 880722 160 0.0
(read/write) 1307800 1307984 184 0.0
.flash.rodata 199640 199824 184 0.1
.flash.text 880562 880722 160 0.0
m5stack (read only) 911451 911579 128 0.0
(read/write) 427560 427736 176 0.0
.flash.rodata 208344 208520 176 0.1
.flash.text 911451 911579 128 0.0
linux all-clusters-app debug (read only) 1687001 1687513 512 0.0
.rodata 138069 138229 160 0.1
.text 1415874 1416226 352 0.0
ota-provider-app debug (read only) 1239033 1239929 896 0.1
.rodata 110408 110760 352 0.3
.text 1032498 1033042 544 0.1
ota-requestor-app debug (read only) 1302033 1302737 704 0.1
.rodata 127072 127360 288 0.2
.text 1077170 1077586 416 0.0
tv-app debug (read only) 1773337 1773849 512 0.0
.rodata 153464 153624 160 0.1
.text 1477682 1478034 352 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2294952 2295264 312 0.0
.text 1257552 1257864 312 0.0
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section bf585f8 573bebd change % change
efr32 lighting-app BRD4161A (read only) 736636 736636 0 0.0
(read/write) 114476 114476 0 0.0
.bss 112724 112724 0 0.0
.data 1752 1752 0 0.0
.text 736628 736628 0 0.0
BRD4161A+rpc (read only) 724076 724076 0 0.0
(read/write) 131080 131080 0 0.0
.bss 129228 129228 0 0.0
.data 1852 1852 0 0.0
.text 724068 724068 0 0.0
lock-app BRD4161A (read only) 715932 715932 0 0.0
(read/write) 112292 112292 0 0.0
.bss 110580 110580 0 0.0
.data 1712 1712 0 0.0
.text 715924 715924 0 0.0
window-app BRD4161A (read only) 716836 716836 0 0.0
(read/write) 112616 112616 0 0.0
.bss 110900 110900 0 0.0
.data 1716 1716 0 0.0
.text 716828 716828 0 0.0
esp32 all-clusters-app c3devkit (read only) 880562 880722 160 0.0
(read/write) 1307800 1307984 184 0.0
.dram0.bss 58456 58456 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 199640 199824 184 0.1
.flash.text 880562 880722 160 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 911451 911579 128 0.0
(read/write) 427560 427736 176 0.0
.dram0.bss 60952 60952 0 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 208344 208520 176 0.1
.flash.text 911451 911579 128 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699128 699128 0 0.0
.bss 77720 77720 0 0.0
.data 1900 1900 0 0.0
.text 613708 613708 0 0.0
lock-app k32w061+debug (read/write) 591432 591432 0 0.0
.bss 68220 68220 0 0.0
.data 1864 1864 0 0.0
.text 515548 515548 0 0.0
shell k32w061+debug (read/write) 424988 424988 0 0.0
.bss 63280 63280 0 0.0
.data 672 672 0 0.0
.text 359332 359332 0 0.0
linux all-clusters-app debug (read only) 1687001 1687513 512 0.0
(read/write) 119024 119024 0 0.0
.bss 50640 50640 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62112 62112 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 138069 138229 160 0.1
.text 1415874 1416226 352 0.0
bridge-app debug+rpc (read only) 1281957 1281957 0 0.0
(read/write) 84136 84136 0 0.0
.bss 50800 50800 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27368 27368 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 110020 110020 0 0.0
.text 1076693 1076693 0 0.0
chip-tool debug (read only) 4314925 4314925 0 0.0
(read/write) 123648 123648 0 0.0
.bss 17712 17712 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 98928 98928 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 217360 217360 0 0.0
.text 3831621 3831621 0 0.0
lighting-app debug+rpc (read only) 1540865 1540865 0 0.0
(read/write) 101008 101008 0 0.0
.bss 40184 40184 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 54448 54448 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128113 128113 0 0.0
.text 1280370 1280370 0 0.0
ota-provider-app debug (read only) 1239033 1239929 896 0.1
(read/write) 67104 67104 0 0.0
.bss 36640 36640 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24616 24616 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110408 110760 352 0.3
.text 1032498 1033042 544 0.1
ota-requestor-app debug (read only) 1302033 1302737 704 0.1
(read/write) 76360 76360 0 0.0
.bss 44896 44896 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25528 25528 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 127072 127360 288 0.2
.text 1077170 1077586 416 0.0
shell debug (read only) 786145 786145 0 0.0
(read/write) 57664 57664 0 0.0
.bss 16072 16072 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36848 36848 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77423 77423 0 0.0
.text 607186 607186 0 0.0
tv-app debug (read only) 1773337 1773849 512 0.0
(read/write) 288600 288600 0 0.0
.bss 222224 222224 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58704 58704 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 153464 153624 160 0.1
.text 1477682 1478034 352 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2294952 2295264 312 0.0
.bss 179828 179828 0 0.0
.data 5216 5216 0 0.0
.heap 851400 851400 0 0.0
.text 1257552 1257864 312 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2274336 2274336 0 0.0
.bss 171868 171868 0 0.0
.data 5568 5568 0 0.0
.heap 859008 859008 0 0.0
.text 1236936 1236936 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2252056 2252056 0 0.0
.bss 170772 170772 0 0.0
.data 5552 5552 0 0.0
.heap 860120 860120 0 0.0
.text 1214656 1214656 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048656 2048656 0 0.0
.bss 156232 156232 0 0.0
.data 4968 4968 0 0.0
.heap 875248 875248 0 0.0
.text 1011256 1011256 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861267 861267 0 0.0
bss 111180 111180 0 0.0
rodata 96860 96860 0 0.0
text 577612 577612 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 822095 822095 0 0.0
bss 107424 107424 0 0.0
rodata 87640 87640 0 0.0
text 550784 550784 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786306 786306 0 0.0
bss 112556 112556 0 0.0
rodata 92100 92100 0 0.0
text 507080 507080 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 837975 837975 0 0.0
bss 110216 110216 0 0.0
rodata 93216 93216 0 0.0
text 559092 559092 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763270 763270 0 0.0
bss 111628 111628 0 0.0
rodata 88520 88520 0 0.0
text 488652 488652 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 842643 842643 0 0.0
bss 110352 110352 0 0.0
rodata 94460 94460 0 0.0
text 562300 562300 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837947 837947 0 0.0
bss 110252 110252 0 0.0
rodata 93236 93236 0 0.0
text 558932 558932 0 0.0
shell nrf52840dk_nrf52840 (read/write) 776179 776179 0 0.0
bss 109096 109096 0 0.0
rodata 72536 72536 0 0.0
text 519936 519936 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691202 691202 0 0.0
bss 110080 110080 0 0.0
rodata 67180 67180 0 0.0
text 440548 440548 0 0.0
p6 lock-app default (read/write) 2167872 2167872 0 0.0
.bss 66216 66216 0 0.0
.data 2416 2416 0 0.0
.heap 964712 964712 0 0.0
.text 1126136 1126136 0 0.0
qpg lighting-app qpg6100+debug (read only) 490500 490500 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50336 50336 0 0.0
.data 1000 1000 0 0.0
.text 485180 485180 0 0.0
lock-app qpg6100+debug (read only) 466844 466844 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49288 49288 0 0.0
.data 956 956 0 0.0
.text 461524 461524 0 0.0
persistent-storage-app qpg6100+debug (read only) 155820 155820 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 150500 150500 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662890 662890 0 0.0
bss 68992 68992 0 0.0
noinit 33216 33216 0 0.0
text 458036 458036 0 0.0

@carol-apple carol-apple force-pushed the test_add_ota_logging_te7 branch from 573bebd to 8d9bb0e Compare November 1, 2021 03:02
@github-actions
Copy link

github-actions bot commented Nov 1, 2021 •
edited
Loading

PR #11241: Size comparison from 8dcf5d7 to 8d9bb0e

Increases above 0.2%:

platform target config section 8dcf5d7 8d9bb0e change % change
linux ota-provider-app debug .rodata 110408 110760 352 0.3
Increases (5 builds for linux, mbed)
platform target config section 8dcf5d7 8d9bb0e change % change
linux all-clusters-app debug (read only) 1687001 1687513 512 0.0
.rodata 138069 138229 160 0.1
.text 1415874 1416226 352 0.0
ota-provider-app debug (read only) 1239033 1239929 896 0.1
.rodata 110408 110760 352 0.3
.text 1032498 1033042 544 0.1
ota-requestor-app debug (read only) 1302033 1302753 720 0.1
.rodata 127072 127360 288 0.2
.text 1077170 1077602 432 0.0
tv-app debug (read only) 1773337 1773849 512 0.0
.rodata 153464 153624 160 0.1
.text 1477682 1478034 352 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2294952 2295264 312 0.0
.text 1257552 1257864 312 0.0
Full report (35 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 8dcf5d7 8d9bb0e change % change
efr32 lighting-app BRD4161A (read only) 736636 736636 0 0.0
(read/write) 114476 114476 0 0.0
.bss 112724 112724 0 0.0
.data 1752 1752 0 0.0
.text 736628 736628 0 0.0
BRD4161A+rpc (read only) 724076 724076 0 0.0
(read/write) 131080 131080 0 0.0
.bss 129228 129228 0 0.0
.data 1852 1852 0 0.0
.text 724068 724068 0 0.0
lock-app BRD4161A (read only) 715932 715932 0 0.0
(read/write) 112292 112292 0 0.0
.bss 110580 110580 0 0.0
.data 1712 1712 0 0.0
.text 715924 715924 0 0.0
window-app BRD4161A (read only) 716836 716836 0 0.0
(read/write) 112616 112616 0 0.0
.bss 110900 110900 0 0.0
.data 1716 1716 0 0.0
.text 716828 716828 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699128 699128 0 0.0
.bss 77720 77720 0 0.0
.data 1900 1900 0 0.0
.text 613708 613708 0 0.0
lock-app k32w061+debug (read/write) 591432 591432 0 0.0
.bss 68220 68220 0 0.0
.data 1864 1864 0 0.0
.text 515548 515548 0 0.0
shell k32w061+debug (read/write) 424988 424988 0 0.0
.bss 63280 63280 0 0.0
.data 672 672 0 0.0
.text 359332 359332 0 0.0
linux all-clusters-app debug (read only) 1687001 1687513 512 0.0
(read/write) 119024 119024 0 0.0
.bss 50640 50640 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62112 62112 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 138069 138229 160 0.1
.text 1415874 1416226 352 0.0
bridge-app debug+rpc (read only) 1281957 1281957 0 0.0
(read/write) 84136 84136 0 0.0
.bss 50800 50800 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27368 27368 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 110020 110020 0 0.0
.text 1076693 1076693 0 0.0
chip-tool debug (read only) 4314925 4314925 0 0.0
(read/write) 123648 123648 0 0.0
.bss 17712 17712 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 98928 98928 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 217360 217360 0 0.0
.text 3831621 3831621 0 0.0
lighting-app debug+rpc (read only) 1540865 1540865 0 0.0
(read/write) 101008 101008 0 0.0
.bss 40184 40184 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 54448 54448 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128113 128113 0 0.0
.text 1280370 1280370 0 0.0
ota-provider-app debug (read only) 1239033 1239929 896 0.1
(read/write) 67104 67104 0 0.0
.bss 36640 36640 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24616 24616 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110408 110760 352 0.3
.text 1032498 1033042 544 0.1
ota-requestor-app debug (read only) 1302033 1302753 720 0.1
(read/write) 76360 76360 0 0.0
.bss 44896 44896 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25528 25528 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 127072 127360 288 0.2
.text 1077170 1077602 432 0.0
shell debug (read only) 786145 786145 0 0.0
(read/write) 57664 57664 0 0.0
.bss 16072 16072 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36848 36848 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77423 77423 0 0.0
.text 607186 607186 0 0.0
tv-app debug (read only) 1773337 1773849 512 0.0
(read/write) 288600 288600 0 0.0
.bss 222224 222224 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58704 58704 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 153464 153624 160 0.1
.text 1477682 1478034 352 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2294952 2295264 312 0.0
.bss 179828 179828 0 0.0
.data 5216 5216 0 0.0
.heap 851400 851400 0 0.0
.text 1257552 1257864 312 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2274336 2274336 0 0.0
.bss 171868 171868 0 0.0
.data 5568 5568 0 0.0
.heap 859008 859008 0 0.0
.text 1236936 1236936 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2252056 2252056 0 0.0
.bss 170772 170772 0 0.0
.data 5552 5552 0 0.0
.heap 860120 860120 0 0.0
.text 1214656 1214656 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048656 2048656 0 0.0
.bss 156232 156232 0 0.0
.data 4968 4968 0 0.0
.heap 875248 875248 0 0.0
.text 1011256 1011256 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861267 861267 0 0.0
bss 111180 111180 0 0.0
rodata 96860 96860 0 0.0
text 577612 577612 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 822095 822095 0 0.0
bss 107424 107424 0 0.0
rodata 87640 87640 0 0.0
text 550784 550784 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786306 786306 0 0.0
bss 112556 112556 0 0.0
rodata 92100 92100 0 0.0
text 507080 507080 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 837975 837975 0 0.0
bss 110216 110216 0 0.0
rodata 93216 93216 0 0.0
text 559092 559092 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763270 763270 0 0.0
bss 111628 111628 0 0.0
rodata 88520 88520 0 0.0
text 488652 488652 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 842643 842643 0 0.0
bss 110352 110352 0 0.0
rodata 94460 94460 0 0.0
text 562300 562300 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837947 837947 0 0.0
bss 110252 110252 0 0.0
rodata 93236 93236 0 0.0
text 558932 558932 0 0.0
shell nrf52840dk_nrf52840 (read/write) 776179 776179 0 0.0
bss 109096 109096 0 0.0
rodata 72536 72536 0 0.0
text 519936 519936 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691202 691202 0 0.0
bss 110080 110080 0 0.0
rodata 67180 67180 0 0.0
text 440548 440548 0 0.0
p6 lock-app default (read/write) 2167872 2167872 0 0.0
.bss 66216 66216 0 0.0
.data 2416 2416 0 0.0
.heap 964712 964712 0 0.0
.text 1126136 1126136 0 0.0
qpg lighting-app qpg6100+debug (read only) 490500 490500 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50336 50336 0 0.0
.data 1000 1000 0 0.0
.text 485180 485180 0 0.0
lock-app qpg6100+debug (read only) 466844 466844 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49288 49288 0 0.0
.data 956 956 0 0.0
.text 461524 461524 0 0.0
persistent-storage-app qpg6100+debug (read only) 155820 155820 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 150500 150500 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662890 662890 0 0.0
bss 68992 68992 0 0.0
noinit 33216 33216 0 0.0
text 458036 458036 0 0.0

@carol-apple carol-apple force-pushed the test_add_ota_logging_te7 branch from 8d9bb0e to 9b9725d Compare November 1, 2021 16:59
@github-actions
Copy link

github-actions bot commented Nov 1, 2021 •
edited
Loading

PR #11241: Size comparison from 1722625 to 9b9725d

Increases above 0.2%:

platform target config section 1722625e 9b9725d change % change
linux ota-provider-app debug .rodata 110056 110440 384 0.3
ota-requestor-app debug .rodata 121344 121664 320 0.3
Increases (7 builds for esp32, linux, mbed)
platform target config section 1722625e 9b9725d change % change
esp32 all-clusters-app c3devkit (read only) 880122 880282 160 0.0
(read/write) 1307472 1307664 192 0.0
.flash.rodata 199344 199536 192 0.1
.flash.text 880122 880282 160 0.0
m5stack (read only) 910983 911127 144 0.0
(read/write) 427248 427432 184 0.0
.flash.rodata 208064 208248 184 0.1
.flash.text 910983 911127 144 0.0
linux all-clusters-app debug (read only) 1684409 1684905 496 0.0
.rodata 137749 137909 160 0.1
.text 1413602 1413938 336 0.0
ota-provider-app debug (read only) 1236329 1237241 912 0.1
.rodata 110056 110440 384 0.3
.text 1030146 1030674 528 0.1
ota-requestor-app debug (read only) 1293777 1294497 720 0.1
.rodata 121344 121664 320 0.3
.text 1074642 1075042 400 0.0
tv-app debug (read only) 1771177 1771673 496 0.0
.rodata 153048 153208 160 0.1
.text 1476226 1476562 336 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2293672 2293984 312 0.0
.text 1256272 1256584 312 0.0
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 1722625e 9b9725d change % change
efr32 lighting-app BRD4161A (read only) 735656 735656 0 0.0
(read/write) 114444 114444 0 0.0
.bss 112692 112692 0 0.0
.data 1752 1752 0 0.0
.text 735648 735648 0 0.0
BRD4161A+rpc (read only) 723096 723096 0 0.0
(read/write) 131052 131052 0 0.0
.bss 129196 129196 0 0.0
.data 1852 1852 0 0.0
.text 723088 723088 0 0.0
lock-app BRD4161A (read only) 714940 714940 0 0.0
(read/write) 112260 112260 0 0.0
.bss 110548 110548 0 0.0
.data 1712 1712 0 0.0
.text 714932 714932 0 0.0
window-app BRD4161A (read only) 715852 715852 0 0.0
(read/write) 112584 112584 0 0.0
.bss 110868 110868 0 0.0
.data 1716 1716 0 0.0
.text 715844 715844 0 0.0
esp32 all-clusters-app c3devkit (read only) 880122 880282 160 0.0
(read/write) 1307472 1307664 192 0.0
.dram0.bss 58424 58424 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 199344 199536 192 0.1
.flash.text 880122 880282 160 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 910983 911127 144 0.0
(read/write) 427248 427432 184 0.0
.dram0.bss 60920 60920 0 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 208064 208248 184 0.1
.flash.text 910983 911127 144 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 698460 698460 0 0.0
.bss 77688 77688 0 0.0
.data 1900 1900 0 0.0
.text 613072 613072 0 0.0
lock-app k32w061+debug (read/write) 590756 590756 0 0.0
.bss 68188 68188 0 0.0
.data 1864 1864 0 0.0
.text 514904 514904 0 0.0
shell k32w061+debug (read/write) 424988 424988 0 0.0
.bss 63280 63280 0 0.0
.data 672 672 0 0.0
.text 359332 359332 0 0.0
linux all-clusters-app debug (read only) 1684409 1684905 496 0.0
(read/write) 118992 118992 0 0.0
.bss 50608 50608 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62112 62112 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 137749 137909 160 0.1
.text 1413602 1413938 336 0.0
bridge-app debug+rpc (read only) 1279349 1279349 0 0.0
(read/write) 84104 84104 0 0.0
.bss 50768 50768 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27368 27368 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 109668 109668 0 0.0
.text 1074437 1074437 0 0.0
chip-tool debug (read only) 4313901 4313901 0 0.0
(read/write) 123552 123552 0 0.0
.bss 17680 17680 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 98880 98880 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 217552 217552 0 0.0
.text 3830693 3830693 0 0.0
lighting-app debug+rpc (read only) 1538289 1538289 0 0.0
(read/write) 100976 100976 0 0.0
.bss 40152 40152 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 54448 54448 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 127793 127793 0 0.0
.text 1278114 1278114 0 0.0
ota-provider-app debug (read only) 1236329 1237241 912 0.1
(read/write) 67072 67072 0 0.0
.bss 36608 36608 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24616 24616 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110056 110440 384 0.3
.text 1030146 1030674 528 0.1
ota-requestor-app debug (read only) 1293777 1294497 720 0.1
(read/write) 76392 76392 0 0.0
.bss 44864 44864 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25576 25576 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 121344 121664 320 0.3
.text 1074642 1075042 400 0.0
shell debug (read only) 785665 785665 0 0.0
(read/write) 57664 57664 0 0.0
.bss 16072 16072 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36848 36848 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77423 77423 0 0.0
.text 606706 606706 0 0.0
tv-app debug (read only) 1771177 1771673 496 0.0
(read/write) 288536 288536 0 0.0
.bss 222192 222192 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58672 58672 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 153048 153208 160 0.1
.text 1476226 1476562 336 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293672 2293984 312 0.0
.bss 179796 179796 0 0.0
.data 5216 5216 0 0.0
.heap 851432 851432 0 0.0
.text 1256272 1256584 312 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2273112 2273112 0 0.0
.bss 171836 171836 0 0.0
.data 5568 5568 0 0.0
.heap 859040 859040 0 0.0
.text 1235712 1235712 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250768 2250768 0 0.0
.bss 170740 170740 0 0.0
.data 5552 5552 0 0.0
.heap 860152 860152 0 0.0
.text 1213368 1213368 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048592 2048592 0 0.0
.bss 156232 156232 0 0.0
.data 4968 4968 0 0.0
.heap 875248 875248 0 0.0
.text 1011192 1011192 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860399 860399 0 0.0
bss 111148 111148 0 0.0
rodata 96472 96472 0 0.0
text 577160 577160 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 821223 821223 0 0.0
bss 107392 107392 0 0.0
rodata 87248 87248 0 0.0
text 550336 550336 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 785426 785426 0 0.0
bss 112524 112524 0 0.0
rodata 91716 91716 0 0.0
text 506628 506628 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 837091 837091 0 0.0
bss 110184 110184 0 0.0
rodata 92828 92828 0 0.0
text 558640 558640 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 762402 762402 0 0.0
bss 111596 111596 0 0.0
rodata 88132 88132 0 0.0
text 488200 488200 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 841779 841779 0 0.0
bss 110320 110320 0 0.0
rodata 94076 94076 0 0.0
text 561852 561852 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837083 837083 0 0.0
bss 110220 110220 0 0.0
rodata 92852 92852 0 0.0
text 558484 558484 0 0.0
shell nrf52840dk_nrf52840 (read/write) 776099 776099 0 0.0
bss 109096 109096 0 0.0
rodata 72536 72536 0 0.0
text 519868 519868 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691122 691122 0 0.0
bss 110080 110080 0 0.0
rodata 67180 67180 0 0.0
text 440476 440476 0 0.0
p6 lock-app default (read/write) 2166800 2166800 0 0.0
.bss 66184 66184 0 0.0
.data 2416 2416 0 0.0
.heap 964744 964744 0 0.0
.text 1125064 1125064 0 0.0
qpg lighting-app qpg6100+debug (read only) 489828 489828 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50320 50320 0 0.0
.data 1000 1000 0 0.0
.text 484508 484508 0 0.0
lock-app qpg6100+debug (read only) 466156 466156 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49272 49272 0 0.0
.data 956 956 0 0.0
.text 460836 460836 0 0.0
persistent-storage-app qpg6100+debug (read only) 155820 155820 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 150500 150500 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 661838 661838 0 0.0
bss 68960 68960 0 0.0
noinit 33216 33216 0 0.0
text 457442 457442 0 0.0

@andy31415 andy31415 merged commit 79ba23d into project-chip:master Nov 1, 2021
andy31415 pushed a commit that referenced this pull request Nov 3, 2021
@carol-apple @andreilitvin
Add logging for OTA QueryImage, AnnounceOTAProvider, and BDX Output E…
bc859b7 
…vent Type (#11241)

* Add logging for OTA QueryImage, AnnounceOTAProvider, and BDX Output Event Type

- These logs are to be parsed from testing side for test validation

* Use suggested format specifiers

* Only print the size of TLV fields
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@carol-apple
Add logging for OTA QueryImage, AnnounceOTAProvider, and BDX Output E…
45bf9b3 
…vent Type (project-chip#11241)

* Add logging for OTA QueryImage, AnnounceOTAProvider, and BDX Output Event Type

- These logs are to be parsed from testing side for test validation

* Use suggested format specifiers

* Only print the size of TLV fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@selissia selissia selissia approved these changes

@dhrishi dhrishi dhrishi approved these changes

@msandstedt msandstedt msandstedt approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@holbrookt holbrookt Awaiting requested review from holbrookt

Assignees
No one assigned
Labels
app examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OTA transfer logs using reference apps does not include parsed QueryImage command and BDX messages
7 participants
@carol-apple @msandstedt @dhrishi @selissia @bzbarsky-apple @andy31415 @franck-apple