Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop writing to the Ember global attribute store for the fabrics list #11236

Merged
merged 2 commits into from
Nov 1, 2021
Merged

Stop writing to the Ember global attribute store for the fabrics list #11236

merged 2 commits into from
Nov 1, 2021

Conversation

yufengwangca
Copy link
Contributor

Problem

What is being fixed? Examples:

Change overview

Stop writing to the Ember global attribute store for the fabrics list

Testing

How was this tested? (at least one bullet point required)

  • Remove fabriclist from client: "./chip-tool operationalcredentials remove-fabric 0 12344321 0"
  • Confirm the change is notified to the reporting engine from the server side log

@boring-cyborg boring-cyborg bot added the app label Oct 29, 2021
@yufengwangca yufengwangca marked this pull request as draft October 29, 2021 21:39
@github-actions
Copy link

github-actions bot commented Oct 29, 2021 •
edited
Loading

PR #11236: Size comparison from 345723d to 96d544c

Increases (1 build for efr32)
platform target config section 345723d 96d544c change % change
efr32 lighting-app BRD4161A+rpc (read/write) 131096 131100 4 0.0
Decreases (28 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 345723d 96d544c change % change
efr32 lighting-app BRD4161A (read only) 701348 699920 -1428 -0.2
.text 701340 699912 -1428 -0.2
BRD4161A+rpc (read only) 727300 725872 -1428 -0.2
.text 727292 725864 -1428 -0.2
lock-app BRD4161A (read only) 680576 679148 -1428 -0.2
.text 680568 679140 -1428 -0.2
window-app BRD4161A (read only) 681488 680060 -1428 -0.2
(read/write) 112020 112016 -4 -0.0
.text 681480 680052 -1428 -0.2
esp32 all-clusters-app c3devkit (read only) 877674 877002 -672 -0.1
(read/write) 1307072 1306496 -576 -0.0
.flash.rodata 199088 198512 -576 -0.3
.flash.text 877674 877002 -672 -0.1
m5stack (read only) 908859 908383 -476 -0.1
(read/write) 426852 426292 -560 -0.1
.flash.rodata 207812 207252 -560 -0.3
.flash.text 908859 908383 -476 -0.1
k32w lighting-app k32w061+se05x+release (read/write) 699128 697984 -1144 -0.2
.text 613708 612564 -1144 -0.2
lock-app k32w061+debug (read/write) 591432 590284 -1148 -0.2
.text 515548 514400 -1148 -0.2
linux all-clusters-app debug (read only) 1666489 1663737 -2752 -0.2
.rodata 137013 136405 -608 -0.4
.text 1397282 1395138 -2144 -0.2
bridge-app debug+rpc (read only) 1281957 1279205 -2752 -0.2
.rodata 110020 109412 -608 -0.6
.text 1076693 1074549 -2144 -0.2
lighting-app debug+rpc (read only) 1540865 1538145 -2720 -0.2
.rodata 128113 127537 -576 -0.4
.text 1280370 1278226 -2144 -0.2
ota-provider-app debug (read only) 1239033 1236185 -2848 -0.2
.rodata 110408 109800 -608 -0.6
.text 1032498 1030258 -2240 -0.2
ota-requestor-app debug (read only) 1302033 1299217 -2816 -0.2
.rodata 127072 126496 -576 -0.5
.text 1077170 1074930 -2240 -0.2
tv-app debug (read only) 1773337 1770585 -2752 -0.2
.rodata 153464 152856 -608 -0.4
.text 1477682 1475538 -2144 -0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2291992 2290848 -1144 -0.0
.text 1254592 1253448 -1144 -0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2274336 2273192 -1144 -0.1
.text 1236936 1235792 -1144 -0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2252056 2250912 -1144 -0.1
.text 1214656 1213512 -1144 -0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861263 860151 -1112 -0.1
rodata 96856 96304 -552 -0.6
text 577612 577048 -564 -0.1
nrf52840dk_nrf52840+rpc (read/write) 822091 820971 -1120 -0.1
rodata 87636 87076 -560 -0.6
text 550784 550220 -564 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 786306 785174 -1132 -0.1
rodata 92100 91544 -556 -0.6
text 507080 506516 -564 -0.1
lock-app nrf52840dk_nrf52840 (read/write) 837971 836843 -1128 -0.1
rodata 93212 92660 -552 -0.6
text 559092 558528 -564 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 763266 762154 -1112 -0.1
rodata 88516 87964 -552 -0.6
text 488652 488088 -564 -0.1
pump-app nrf52840dk_nrf52840 (read/write) 842643 841527 -1116 -0.1
rodata 94460 93904 -556 -0.6
text 562300 561736 -564 -0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 837947 836831 -1116 -0.1
rodata 93236 92680 -556 -0.6
text 558932 558368 -564 -0.1
p6 lock-app default (read/write) 2167872 2166432 -1440 -0.1
.text 1126136 1124696 -1440 -0.1
qpg lighting-app qpg6100+debug (read only) 490500 489352 -1148 -0.2
.text 485180 484032 -1148 -0.2
lock-app qpg6100+debug (read only) 466840 465712 -1128 -0.2
.text 461520 460392 -1128 -0.2
telink lighting-app tlsr9518adk80d (read/write) 662890 661614 -1276 -0.2
text 458036 457330 -706 -0.2
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 345723d 96d544c change % change
efr32 lighting-app BRD4161A (read only) 701348 699920 -1428 -0.2
(read/write) 113876 113876 0 0.0
.bss 112124 112124 0 0.0
.data 1752 1752 0 0.0
.text 701340 699912 -1428 -0.2
BRD4161A+rpc (read only) 727300 725872 -1428 -0.2
(read/write) 131096 131100 4 0.0
.bss 129244 129244 0 0.0
.data 1852 1852 0 0.0
.text 727292 725864 -1428 -0.2
lock-app BRD4161A (read only) 680576 679148 -1428 -0.2
(read/write) 111692 111692 0 0.0
.bss 109980 109980 0 0.0
.data 1712 1712 0 0.0
.text 680568 679140 -1428 -0.2
window-app BRD4161A (read only) 681488 680060 -1428 -0.2
(read/write) 112020 112016 -4 -0.0
.bss 110300 110300 0 0.0
.data 1716 1716 0 0.0
.text 681480 680052 -1428 -0.2
esp32 all-clusters-app c3devkit (read only) 877674 877002 -672 -0.1
(read/write) 1307072 1306496 -576 -0.0
.dram0.bss 58296 58296 0 0.0
.dram0.data 16448 16448 0 0.0
.flash.rodata 199088 198512 -576 -0.3
.flash.text 877674 877002 -672 -0.1
.iram0.text 57554 57554 0 0.0
m5stack (read only) 908859 908383 -476 -0.1
(read/write) 426852 426292 -560 -0.1
.dram0.bss 60792 60792 0 0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 207812 207252 -560 -0.3
.flash.text 908859 908383 -476 -0.1
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699128 697984 -1144 -0.2
.bss 77720 77720 0 0.0
.data 1900 1900 0 0.0
.text 613708 612564 -1144 -0.2
lock-app k32w061+debug (read/write) 591432 590284 -1148 -0.2
.bss 68220 68220 0 0.0
.data 1864 1864 0 0.0
.text 515548 514400 -1148 -0.2
shell k32w061+debug (read/write) 424988 424988 0 0.0
.bss 63280 63280 0 0.0
.data 672 672 0 0.0
.text 359332 359332 0 0.0
linux all-clusters-app debug (read only) 1666489 1663737 -2752 -0.2
(read/write) 118080 118080 0 0.0
.bss 50320 50320 0 0.0
.data 978 978 0 0.0
.data.rel.ro 61536 61536 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 137013 136405 -608 -0.4
.text 1397282 1395138 -2144 -0.2
bridge-app debug+rpc (read only) 1281957 1279205 -2752 -0.2
(read/write) 84136 84136 0 0.0
.bss 50800 50800 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27368 27368 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 110020 109412 -608 -0.6
.text 1076693 1074549 -2144 -0.2
chip-tool debug (read only) 4288501 4288501 0 0.0
(read/write) 122752 122752 0 0.0
.bss 17680 17680 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 98080 98080 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 216304 216304 0 0.0
.text 3808053 3808053 0 0.0
lighting-app debug+rpc (read only) 1540865 1538145 -2720 -0.2
(read/write) 101008 101008 0 0.0
.bss 40184 40184 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 54448 54448 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128113 127537 -576 -0.4
.text 1280370 1278226 -2144 -0.2
ota-provider-app debug (read only) 1239033 1236185 -2848 -0.2
(read/write) 67104 67104 0 0.0
.bss 36640 36640 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24616 24616 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110408 109800 -608 -0.6
.text 1032498 1030258 -2240 -0.2
ota-requestor-app debug (read only) 1302033 1299217 -2816 -0.2
(read/write) 76360 76360 0 0.0
.bss 44896 44896 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25528 25528 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 127072 126496 -576 -0.5
.text 1077170 1074930 -2240 -0.2
shell debug (read only) 786145 786145 0 0.0
(read/write) 57664 57664 0 0.0
.bss 16072 16072 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36848 36848 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77423 77423 0 0.0
.text 607186 607186 0 0.0
tv-app debug (read only) 1773337 1770585 -2752 -0.2
(read/write) 288600 288600 0 0.0
.bss 222224 222224 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58704 58704 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 153464 152856 -608 -0.4
.text 1477682 1475538 -2144 -0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2291992 2290848 -1144 -0.0
.bss 179668 179668 0 0.0
.data 5192 5192 0 0.0
.heap 851584 851584 0 0.0
.text 1254592 1253448 -1144 -0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2274336 2273192 -1144 -0.1
.bss 171868 171868 0 0.0
.data 5568 5568 0 0.0
.heap 859008 859008 0 0.0
.text 1236936 1235792 -1144 -0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2252056 2250912 -1144 -0.1
.bss 170772 170772 0 0.0
.data 5552 5552 0 0.0
.heap 860120 860120 0 0.0
.text 1214656 1213512 -1144 -0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048656 2048656 0 0.0
.bss 156232 156232 0 0.0
.data 4968 4968 0 0.0
.heap 875248 875248 0 0.0
.text 1011256 1011256 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861263 860151 -1112 -0.1
bss 111180 111180 0 0.0
rodata 96856 96304 -552 -0.6
text 577612 577048 -564 -0.1
nrf52840dk_nrf52840+rpc (read/write) 822091 820971 -1120 -0.1
bss 107424 107424 0 0.0
rodata 87636 87076 -560 -0.6
text 550784 550220 -564 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 786306 785174 -1132 -0.1
bss 112556 112556 0 0.0
rodata 92100 91544 -556 -0.6
text 507080 506516 -564 -0.1
lock-app nrf52840dk_nrf52840 (read/write) 837971 836843 -1128 -0.1
bss 110216 110216 0 0.0
rodata 93212 92660 -552 -0.6
text 559092 558528 -564 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 763266 762154 -1112 -0.1
bss 111628 111628 0 0.0
rodata 88516 87964 -552 -0.6
text 488652 488088 -564 -0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 842643 841527 -1116 -0.1
bss 110352 110352 0 0.0
rodata 94460 93904 -556 -0.6
text 562300 561736 -564 -0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 837947 836831 -1116 -0.1
bss 110252 110252 0 0.0
rodata 93236 92680 -556 -0.6
text 558932 558368 -564 -0.1
shell nrf52840dk_nrf52840 (read/write) 776179 776179 0 0.0
bss 109096 109096 0 0.0
rodata 72536 72536 0 0.0
text 519936 519936 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691202 691202 0 0.0
bss 110080 110080 0 0.0
rodata 67180 67180 0 0.0
text 440548 440548 0 0.0
p6 lock-app default (read/write) 2167872 2166432 -1440 -0.1
.bss 66216 66216 0 0.0
.data 2416 2416 0 0.0
.heap 964712 964712 0 0.0
.text 1126136 1124696 -1440 -0.1
qpg lighting-app qpg6100+debug (read only) 490500 489352 -1148 -0.2
(read/write) 114144 114144 0 0.0
.bss 50336 50336 0 0.0
.data 1000 1000 0 0.0
.text 485180 484032 -1148 -0.2
lock-app qpg6100+debug (read only) 466840 465712 -1128 -0.2
(read/write) 114140 114140 0 0.0
.bss 49288 49288 0 0.0
.data 956 956 0 0.0
.text 461520 460392 -1128 -0.2
persistent-storage-app qpg6100+debug (read only) 155820 155820 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 150500 150500 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662890 661614 -1276 -0.2
bss 68992 68992 0 0.0
noinit 33216 33216 0 0.0
text 458036 457330 -706 -0.2

@yufengwangca yufengwangca marked this pull request as ready for review October 29, 2021 22:21
@bzbarsky-apple
Copy link
Contributor

/rebase

@andy31415
Copy link
Contributor

1 day fast track: refactor mostly removing code, have checkmark by domain owner

@andy31415 andy31415 merged commit 1073bb2 into project-chip:master Nov 1, 2021
@yufengwangca yufengwangca deleted the pr/cluster/opcreds branch November 1, 2021 16:51
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@yufengwangca
Stop writing to the Ember global attribute store for the fabrics list (…
60e6d0e 
…project-chip#11236)

* Stop writing to the Ember global attribute store for the fabrics list

* Address review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pan-apple pan-apple pan-apple approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
app fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

writeFabricsIntoFabricsListAttribute writing to the Ember global attribute store for the fabrics list
4 participants
@yufengwangca @bzbarsky-apple @andy31415 @pan-apple