Collapse InetLayerBasis into EndPointBasis #11212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem
For historical reasons, Inet EndPoints had unnecessarily deep
class hierarchy, originally:
InetLayerBasis
EndPointBasis
TCPEndPoint
IPEndPointBasis
UDPEndPoint
Previous PRs project-chip#11135 and project-chip#11145 merged `IPEndPointBasis` with `UDPEndPoint`.
#### Change overview
This change merges `InetLayerBasis` with `EndPointBasis`, so that the
EndPoint class hierarchy is now:
EndPointBasis
TCPEndPoint
UDPEndPoint
#### Testing
CI; no changes to functionality.
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux and
tecimovic
pullapprove
bot
requested review from
vivien-apple,
wbschiller,
woody-apple,
yufengwangca and
yunhanw-google
|
PR #11212: Size comparison from 2c1dceb to c445afc Increases above 0.2%:
Increases (12 builds for efr32, esp32, k32w, p6, qpg)
Decreases (9 builds for linux, p6)
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Oct 29, 2021
andy31415
approved these changes
Oct 29, 2021
|
PR #11212: Size comparison from 2c1dceb to 86c71f4 Increases above 0.2%:
Increases (13 builds for esp32, k32w, linux, mbed, nrfconnect, p6, qpg)
Decreases (33 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
emargolis
approved these changes
Nov 1, 2021
Damian-Nordic
approved these changes
Nov 2, 2021
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
* Collapse InetLayerBasis into EndPointBasis
#### Problem
For historical reasons, Inet EndPoints had unnecessarily deep
class hierarchy, originally:
InetLayerBasis
EndPointBasis
TCPEndPoint
IPEndPointBasis
UDPEndPoint
Previous PRs project-chip#11135 and project-chip#11145 merged `IPEndPointBasis` with `UDPEndPoint`.
#### Change overview
This change merges `InetLayerBasis` with `EndPointBasis`, so that the
EndPoint class hierarchy is now:
EndPointBasis
TCPEndPoint
UDPEndPoint
#### Testing
CI; no changes to functionality.
* reorder members to avoid structure size increase on some platforms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
For historical reasons, Inet EndPoints had an unnecessarily deep
class hierarchy, originally:
Previous PRs #11135 and #11145 merged
IPEndPointBasiswithUDPEndPoint.Change overview
This change merges
InetLayerBasiswithEndPointBasis, so that theEndPoint class hierarchy becomes:
Testing
CI; no changes to functionality.