Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle Unblacklist nrf52840 for RPC builds #11207

Closed
wants to merge 3 commits into from
Closed

Restyle Unblacklist nrf52840 for RPC builds #11207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6249049
Unblacklist rpc builds for nrf52840. Only nrf5340 fails compilation
andy31415 Oct 29, 2021
057a099
fix unit tests
andy31415 Oct 29, 2021
e83f0d6
Restyled by autopep8
restyled-commits Oct 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion scripts/build/build/targets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,11 +164,18 @@ def NrfTargets():
for target in targets:
yield target.Extend('lock', app=NrfApp.LOCK)
yield target.Extend('light', app=NrfApp.LIGHT)
yield target.Extend('light-rpc', app=NrfApp.LIGHT, enable_rpcs=True).GlobBlacklist('Compile failure due to pw_build args not forwarded to proto compiler. https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/66760')
yield target.Extend('shell', app=NrfApp.SHELL)
yield target.Extend('pump', app=NrfApp.PUMP)
yield target.Extend('pump-controller', app=NrfApp.PUMP_CONTROLLER)

rpc = target.Extend('light-rpc', app=NrfApp.LIGHT, enable_rpcs=True)

if '-nrf5340-' in rpc.name:
rpc = rpc.GlobBlacklist(
'Compile failure due to pw_build args not forwarded to proto compiler. https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/66760')

yield rpc


def AndroidTargets():
target = Target('android', AndroidBuilder)
Expand Down
2 changes: 1 addition & 1 deletion scripts/build/testdata/all_targets_except_host.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ esp32-m5stack-all-clusters-rpc
esp32-m5stack-all-clusters-rpc-ipv6only
infineon-p6-lock
nrf-nrf52840-light
nrf-nrf52840-light-rpc (NOGLOB: Compile failure due to pw_build args not forwarded to proto compiler. https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/66760)
nrf-nrf52840-light-rpc
nrf-nrf52840-lock
nrf-nrf52840-pump
nrf-nrf52840-pump-controller
Expand Down
1 change: 1 addition & 0 deletions scripts/build/testdata/glob_star_targets_except_host.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ esp32-m5stack-all-clusters-rpc
esp32-m5stack-all-clusters-rpc-ipv6only
infineon-p6-lock
nrf-nrf52840-light
nrf-nrf52840-light-rpc
nrf-nrf52840-lock
nrf-nrf52840-pump
nrf-nrf52840-pump-controller
Expand Down