-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pw_trace functionality to esp32 all cluster app #11203
Merged
andy31415
merged 1 commit into
project-chip:master
from
yyzhong-g:add_trace_rpc_service_esp32
Nov 1, 2021
Merged
Add pw_trace functionality to esp32 all cluster app #11203
andy31415
merged 1 commit into
project-chip:master
from
yyzhong-g:add_trace_rpc_service_esp32
Nov 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add pw_trace rpc service to Rpc.cpp.
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
selissia and
tcarmelveilleux
October 29, 2021 16:17
pullapprove
bot
requested review from
tecimovic,
vivien-apple,
wbschiller,
woody-apple and
yufengwangca
October 29, 2021 16:17
andy31415
approved these changes
Oct 29, 2021
rgoliver
approved these changes
Oct 29, 2021
bzbarsky-apple
approved these changes
Oct 29, 2021
PR #11203: Size comparison from e4407c4 to 3f8649e Decreases (1 build for esp32)
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Oct 29, 2021
1 day fast track: small change, affects example app only (not main SDK code) |
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
Add pw_trace rpc service to Rpc.cpp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pw_trace rpc service to Rpc.cpp.
Problem
Integrate pw_trace module into esp32 all-cluster-app
Change overview
Add pw::trace::TraceService to Rpc.cc
Testing
build esp32 all cluster app with RPC on and off.