Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[K32W0][THREADIP-3665] Improve shell application #11194

Merged
merged 7 commits into from
Nov 3, 2021
Merged

[K32W0][THREADIP-3665] Improve shell application #11194

merged 7 commits into from
Nov 3, 2021

Conversation

doru91
Copy link
Contributor

@doru91 doru91 commented Oct 29, 2021

Problem

Shell application lacked a method for commissioning it to a Thread/Matter network:

Change overview

  • add commissioning support;
  • run the shell functionality in a dedicated task.

Testing

Manual testing using chip-device-ctrl and TE6 branch.

@restyled-io restyled-io bot mentioned this pull request Oct 29, 2021
Closed
@github-actions
Copy link

github-actions bot commented Oct 29, 2021 •
edited
Loading

PR #11194: Size comparison from 06f9a38 to bf8eb0c

Full report (34 builds for efr32, esp32, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 06f9a38 bf8eb0c change % change
efr32 lighting-app BRD4161A (read only) 738120 738120 0 0.0
(read/write) 115428 115428 0 0.0
.bss 113676 113676 0 0.0
.data 1752 1752 0 0.0
.text 738112 738112 0 0.0
BRD4161A+rpc (read only) 725560 725560 0 0.0
(read/write) 132036 132036 0 0.0
.bss 130180 130180 0 0.0
.data 1852 1852 0 0.0
.text 725552 725552 0 0.0
lock-app BRD4161A (read only) 717400 717400 0 0.0
(read/write) 113244 113244 0 0.0
.bss 111532 111532 0 0.0
.data 1712 1712 0 0.0
.text 717392 717392 0 0.0
window-app BRD4161A (read only) 718304 718304 0 0.0
(read/write) 113572 113572 0 0.0
.bss 111852 111852 0 0.0
.data 1716 1716 0 0.0
.text 718296 718296 0 0.0
esp32 all-clusters-app c3devkit (read only) 876382 876382 0 0.0
(read/write) 1308944 1308944 0 0.0
.dram0.bss 59248 59248 0 0.0
.dram0.data 16448 16448 0 0.0
.flash.rodata 200016 200016 0 0.0
.flash.text 876382 876382 0 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 907659 907659 0 0.0
(read/write) 428724 428724 0 0.0
.dram0.bss 61744 61744 0 0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 208732 208732 0 0.0
.flash.text 907659 907659 0 0.0
.iram0.text 125115 125115 0 0.0
linux all-clusters-app debug (read only) 1655073 1655073 0 0.0
(read/write) 119104 119104 0 0.0
.bss 51376 51376 0 0.0
.data 978 978 0 0.0
.data.rel.ro 61504 61504 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 138069 138069 0 0.0
.text 1384738 1384738 0 0.0
bridge-app debug+rpc (read only) 1283341 1283341 0 0.0
(read/write) 85160 85160 0 0.0
.bss 51856 51856 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27336 27336 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 111044 111044 0 0.0
.text 1076981 1076981 0 0.0
chip-tool debug (read only) 4266229 4266229 0 0.0
(read/write) 122176 122176 0 0.0
.bss 17680 17680 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 97504 97504 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 214704 214704 0 0.0
.text 3788725 3788725 0 0.0
lighting-app debug+rpc (read only) 1542281 1542281 0 0.0
(read/write) 102000 102000 0 0.0
.bss 41208 41208 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 54416 54416 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 129169 129169 0 0.0
.text 1280658 1280658 0 0.0
ota-provider-app debug (read only) 1239849 1239849 0 0.0
(read/write) 67872 67872 0 0.0
.bss 37440 37440 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24584 24584 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 111208 111208 0 0.0
.text 1032466 1032466 0 0.0
ota-requestor-app debug (read only) 1301465 1301465 0 0.0
(read/write) 76616 76616 0 0.0
.bss 45216 45216 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25464 25464 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 127424 127424 0 0.0
.text 1076226 1076226 0 0.0
shell debug (read only) 787153 787153 0 0.0
(read/write) 57760 57760 0 0.0
.bss 16168 16168 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36848 36848 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77519 77519 0 0.0
.text 608098 608098 0 0.0
tv-app debug (read only) 1774929 1774929 0 0.0
(read/write) 289624 289624 0 0.0
.bss 223280 223280 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58672 58672 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 154488 154488 0 0.0
.text 1478178 1478178 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2291400 2291400 0 0.0
.bss 180620 180620 0 0.0
.data 5192 5192 0 0.0
.heap 850632 850632 0 0.0
.text 1254000 1254000 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2275608 2275608 0 0.0
.bss 172820 172820 0 0.0
.data 5568 5568 0 0.0
.heap 858056 858056 0 0.0
.text 1238208 1238208 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2253328 2253328 0 0.0
.bss 171724 171724 0 0.0
.data 5552 5552 0 0.0
.heap 859168 859168 0 0.0
.text 1215928 1215928 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048976 2048976 0 0.0
.bss 156208 156208 0 0.0
.data 4968 4968 0 0.0
.heap 875272 875272 0 0.0
.text 1011576 1011576 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 863535 863535 0 0.0
bss 112132 112132 0 0.0
rodata 97816 97816 0 0.0
text 577960 577960 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 824363 824363 0 0.0
bss 108372 108372 0 0.0
rodata 88596 88596 0 0.0
text 551136 551136 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 788526 788526 0 0.0
bss 113504 113504 0 0.0
rodata 93056 93056 0 0.0
text 507428 507428 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 840211 840211 0 0.0
bss 111168 111168 0 0.0
rodata 94172 94172 0 0.0
text 559444 559444 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 765506 765506 0 0.0
bss 112576 112576 0 0.0
rodata 89476 89476 0 0.0
text 489004 489004 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844911 844911 0 0.0
bss 111304 111304 0 0.0
rodata 95416 95416 0 0.0
text 562656 562656 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 840199 840199 0 0.0
bss 111200 111200 0 0.0
rodata 94192 94192 0 0.0
text 559288 559288 0 0.0
shell nrf52840dk_nrf52840 (read/write) 776435 776435 0 0.0
bss 109072 109072 0 0.0
rodata 72536 72536 0 0.0
text 520236 520236 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691490 691490 0 0.0
bss 110056 110056 0 0.0
rodata 67180 67180 0 0.0
text 440848 440848 0 0.0
p6 lock-app default (read/write) 2169744 2169744 0 0.0
.bss 67168 67168 0 0.0
.data 2416 2416 0 0.0
.heap 963760 963760 0 0.0
.text 1128008 1128008 0 0.0
qpg lighting-app qpg6100+debug (read only) 491224 491224 0 0.0
(read/write) 114144 114144 0 0.0
.bss 51288 51288 0 0.0
.data 1000 1000 0 0.0
.text 485904 485904 0 0.0
lock-app qpg6100+debug (read only) 467556 467556 0 0.0
(read/write) 114140 114140 0 0.0
.bss 50240 50240 0 0.0
.data 956 956 0 0.0
.text 462236 462236 0 0.0
persistent-storage-app qpg6100+debug (read only) 155236 155236 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 149916 149916 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 665202 665202 0 0.0
bss 69944 69944 0 0.0
noinit 33216 33216 0 0.0
text 458454 458454 0 0.0

@woody-apple
Copy link
Contributor

/rebase

doru91 and others added 4 commits November 3, 2021 00:17
@doru91
[K32W0][THREADIP-3665] Improve shell application
4e5e34e 
Shell application lacked a method for commissioning it to a Thread/Matter network:
* add commissioning support;
* run the shell functionality in a dedicated task.

Signed-off-by: Doru Gucea <[email protected]>
@restyled-commits @doru91
Restyled by clang-format
e5ccd6d
@restyled-commits @doru91
Restyled by gn
2720804
@doru91
[K32W] DIsable ot cli for the moment
55a64c9 
Otherwise, the app won't fit into RAM0.

Signed-off-by: Doru Gucea <[email protected]>
@restyled-io restyled-io bot mentioned this pull request Nov 3, 2021
Closed
@doru91
[K32W0] Fix variable type
7130af1 
Signed-off-by: Doru Gucea <[email protected]>
@github-actions
Copy link

github-actions bot commented Nov 3, 2021 •
edited
Loading

PR #11194: Size comparison from d5810e5 to 7130af1

Full report (18 builds for efr32, linux, p6, qpg, telink)
platform target config section d5810e5 7130af1 change % change
efr32 lighting-app BRD4161A (read only) 737248 737248 0 0.0
(read/write) 114620 114620 0 0.0
.bss 112860 112860 0 0.0
.data 1756 1756 0 0.0
.text 737240 737240 0 0.0
BRD4161A+rpc (read only) 724672 724672 0 0.0
(read/write) 131220 131220 0 0.0
.bss 129364 129364 0 0.0
.data 1856 1856 0 0.0
.text 724664 724664 0 0.0
lock-app BRD4161A (read only) 716528 716528 0 0.0
(read/write) 112436 112436 0 0.0
.bss 110716 110716 0 0.0
.data 1716 1716 0 0.0
.text 716520 716520 0 0.0
window-app BRD4161A (read only) 717428 717428 0 0.0
(read/write) 112756 112756 0 0.0
.bss 111036 111036 0 0.0
.data 1720 1720 0 0.0
.text 717420 717420 0 0.0
linux all-clusters-app debug (read only) 1690937 1690937 0 0.0
(read/write) 119760 119760 0 0.0
.bss 51184 51184 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62272 62272 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 139829 139829 0 0.0
.text 1417714 1417714 0 0.0
bridge-app debug+rpc (read only) 1287325 1287325 0 0.0
(read/write) 69384 69384 0 0.0
.bss 35088 35088 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27768 27768 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 111460 111460 0 0.0
.text 1079973 1079973 0 0.0
chip-tool debug (read only) 4351269 4351269 0 0.0
(read/write) 124896 124896 0 0.0
.bss 18224 18224 0 0.0
.data 2224 2224 0 0.0
.data.rel.ro 99040 99040 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 219560 219560 0 0.0
.text 3865669 3865669 0 0.0
lighting-app debug+rpc (read only) 1543193 1543193 0 0.0
(read/write) 101712 101712 0 0.0
.bss 40728 40728 0 0.0
.data 1138 1138 0 0.0
.data.rel.ro 54560 54560 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 129553 129553 0 0.0
.text 1280946 1280946 0 0.0
ota-provider-app debug (read only) 1243689 1243689 0 0.0
(read/write) 67552 67552 0 0.0
.bss 37152 37152 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24568 24568 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 112360 112360 0 0.0
.text 1035250 1035250 0 0.0
ota-requestor-app debug (read only) 1311049 1311049 0 0.0
(read/write) 76872 76872 0 0.0
.bss 45408 45408 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25512 25512 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 123328 123328 0 0.0
.text 1089954 1089954 0 0.0
shell debug (read only) 786593 786593 0 0.0
(read/write) 57664 57664 0 0.0
.bss 16104 16104 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77839 77839 0 0.0
.text 607266 607266 0 0.0
tv-app debug (read only) 1810545 1810545 0 0.0
(read/write) 289944 289944 0 0.0
.bss 222768 222768 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 58824 58824 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 155640 155640 0 0.0
.text 1512642 1512642 0 0.0
p6 all-clusters-app default (read/write) 2300752 2300752 0 0.0
.bss 107912 107912 0 0.0
.data 2520 2520 0 0.0
.heap 922912 922912 0 0.0
.text 1259016 1259016 0 0.0
lock-app default (read/write) 2213744 2213744 0 0.0
.bss 95712 95712 0 0.0
.data 2392 2392 0 0.0
.heap 935240 935240 0 0.0
.text 1172008 1172008 0 0.0
qpg lighting-app qpg6100+debug (read only) 490784 490784 0 0.0
(read/write) 114140 114140 0 0.0
.bss 50416 50416 0 0.0
.data 1004 1004 0 0.0
.text 485464 485464 0 0.0
lock-app qpg6100+debug (read only) 467120 467120 0 0.0
(read/write) 114144 114144 0 0.0
.bss 49360 49360 0 0.0
.data 960 960 0 0.0
.text 461800 461800 0 0.0
persistent-storage-app qpg6100+debug (read only) 153212 153212 0 0.0
(read/write) 114140 114140 0 0.0
.bss 18336 18336 0 0.0
.data 356 356 0 0.0
.text 147892 147892 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662894 662894 0 0.0
bss 69132 69132 0 0.0
noinit 33216 33216 0 0.0
text 458028 458028 0 0.0

@boring-cyborg boring-cyborg bot added the scripts label Nov 3, 2021
@github-actions
Copy link

github-actions bot commented Nov 3, 2021 •
edited
Loading

PR #11194: Size comparison from d5810e5 to 2fc63c0

Increases above 0.2%:

platform target config section d5810e5 2fc63c0 change % change
k32w shell k32w061+debug (read/write) 424916 657800 232884 54.8
.bss 63296 79056 15760 24.9
.data 668 1840 1172 175.4
.text 359248 571104 211856 59.0
Increases (1 build for k32w)
platform target config section d5810e5 2fc63c0 change % change
k32w shell k32w061+debug (read/write) 424916 657800 232884 54.8
.bss 63296 79056 15760 24.9
.data 668 1840 1172 175.4
.text 359248 571104 211856 59.0
Decreases (1 build for k32w)
platform target config section d5810e5 2fc63c0 change % change
k32w lock-app k32w061+debug (read/write) 591836 585680 -6156 -1.0
.bss 68372 67796 -576 -0.8
.text 515796 510216 -5580 -1.1
Full report (21 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section d5810e5 2fc63c0 change % change
efr32 lighting-app BRD4161A (read only) 737248 737248 0 0.0
(read/write) 114620 114620 0 0.0
.bss 112860 112860 0 0.0
.data 1756 1756 0 0.0
.text 737240 737240 0 0.0
BRD4161A+rpc (read only) 724672 724672 0 0.0
(read/write) 131220 131220 0 0.0
.bss 129364 129364 0 0.0
.data 1856 1856 0 0.0
.text 724664 724664 0 0.0
lock-app BRD4161A (read only) 716528 716528 0 0.0
(read/write) 112436 112436 0 0.0
.bss 110716 110716 0 0.0
.data 1716 1716 0 0.0
.text 716520 716520 0 0.0
window-app BRD4161A (read only) 717428 717428 0 0.0
(read/write) 112756 112756 0 0.0
.bss 111036 111036 0 0.0
.data 1720 1720 0 0.0
.text 717420 717420 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699528 699528 0 0.0
.bss 77856 77856 0 0.0
.data 1904 1904 0 0.0
.text 613968 613968 0 0.0
lock-app k32w061+debug (read/write) 591836 585680 -6156 -1.0
.bss 68372 67796 -576 -0.8
.data 1868 1868 0 0.0
.text 515796 510216 -5580 -1.1
shell k32w061+debug (read/write) 424916 657800 232884 54.8
.bss 63296 79056 15760 24.9
.data 668 1840 1172 175.4
.text 359248 571104 211856 59.0
linux all-clusters-app debug (read only) 1690937 1690937 0 0.0
(read/write) 119760 119760 0 0.0
.bss 51184 51184 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62272 62272 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 139829 139829 0 0.0
.text 1417714 1417714 0 0.0
bridge-app debug+rpc (read only) 1287325 1287325 0 0.0
(read/write) 69384 69384 0 0.0
.bss 35088 35088 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27768 27768 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 111460 111460 0 0.0
.text 1079973 1079973 0 0.0
chip-tool debug (read only) 4351269 4351269 0 0.0
(read/write) 124896 124896 0 0.0
.bss 18224 18224 0 0.0
.data 2224 2224 0 0.0
.data.rel.ro 99040 99040 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 219560 219560 0 0.0
.text 3865669 3865669 0 0.0
lighting-app debug+rpc (read only) 1543193 1543193 0 0.0
(read/write) 101712 101712 0 0.0
.bss 40728 40728 0 0.0
.data 1138 1138 0 0.0
.data.rel.ro 54560 54560 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 129553 129553 0 0.0
.text 1280946 1280946 0 0.0
ota-provider-app debug (read only) 1243689 1243689 0 0.0
(read/write) 67552 67552 0 0.0
.bss 37152 37152 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24568 24568 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 112360 112360 0 0.0
.text 1035250 1035250 0 0.0
ota-requestor-app debug (read only) 1311049 1311049 0 0.0
(read/write) 76872 76872 0 0.0
.bss 45408 45408 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25512 25512 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 123328 123328 0 0.0
.text 1089954 1089954 0 0.0
shell debug (read only) 786593 786593 0 0.0
(read/write) 57664 57664 0 0.0
.bss 16104 16104 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77839 77839 0 0.0
.text 607266 607266 0 0.0
tv-app debug (read only) 1810545 1810545 0 0.0
(read/write) 289944 289944 0 0.0
.bss 222768 222768 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 58824 58824 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 155640 155640 0 0.0
.text 1512642 1512642 0 0.0
p6 all-clusters-app default (read/write) 2300752 2300752 0 0.0
.bss 107912 107912 0 0.0
.data 2520 2520 0 0.0
.heap 922912 922912 0 0.0
.text 1259016 1259016 0 0.0
lock-app default (read/write) 2213744 2213744 0 0.0
.bss 95712 95712 0 0.0
.data 2392 2392 0 0.0
.heap 935240 935240 0 0.0
.text 1172008 1172008 0 0.0
qpg lighting-app qpg6100+debug (read only) 490784 490784 0 0.0
(read/write) 114140 114140 0 0.0
.bss 50416 50416 0 0.0
.data 1004 1004 0 0.0
.text 485464 485464 0 0.0
lock-app qpg6100+debug (read only) 467120 467120 0 0.0
(read/write) 114144 114144 0 0.0
.bss 49360 49360 0 0.0
.data 960 960 0 0.0
.text 461800 461800 0 0.0
persistent-storage-app qpg6100+debug (read only) 153212 153212 0 0.0
(read/write) 114140 114140 0 0.0
.bss 18336 18336 0 0.0
.data 356 356 0 0.0
.text 147892 147892 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662894 662894 0 0.0
bss 69132 69132 0 0.0
noinit 33216 33216 0 0.0
text 458028 458028 0 0.0

@doru91
Copy link
Contributor Author

doru91 commented Nov 3, 2021

/rebase

Rebased.

@github-actions
Copy link

github-actions bot commented Nov 3, 2021 •
edited
Loading

PR #11194: Size comparison from d5810e5 to 8a0224f

Increases above 0.2%:

platform target config section d5810e5 8a0224f change % change
k32w shell k32w061+debug (read/write) 424916 657800 232884 54.8
.bss 63296 79056 15760 24.9
.data 668 1840 1172 175.4
.text 359248 571104 211856 59.0
Increases (1 build for k32w)
platform target config section d5810e5 8a0224f change % change
k32w shell k32w061+debug (read/write) 424916 657800 232884 54.8
.bss 63296 79056 15760 24.9
.data 668 1840 1172 175.4
.text 359248 571104 211856 59.0
Decreases (1 build for esp32)
platform target config section d5810e5 8a0224f change % change
esp32 all-clusters-app m5stack (read only) 911907 911831 -76 -0.0
.flash.text 911907 911831 -76 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section d5810e5 8a0224f change % change
efr32 lighting-app BRD4161A (read only) 737248 737248 0 0.0
(read/write) 114620 114620 0 0.0
.bss 112860 112860 0 0.0
.data 1756 1756 0 0.0
.text 737240 737240 0 0.0
BRD4161A+rpc (read only) 724672 724672 0 0.0
(read/write) 131220 131220 0 0.0
.bss 129364 129364 0 0.0
.data 1856 1856 0 0.0
.text 724664 724664 0 0.0
lock-app BRD4161A (read only) 716528 716528 0 0.0
(read/write) 112436 112436 0 0.0
.bss 110716 110716 0 0.0
.data 1716 1716 0 0.0
.text 716520 716520 0 0.0
window-app BRD4161A (read only) 717428 717428 0 0.0
(read/write) 112756 112756 0 0.0
.bss 111036 111036 0 0.0
.data 1720 1720 0 0.0
.text 717420 717420 0 0.0
esp32 all-clusters-app c3devkit (read only) 880742 880742 0 0.0
(read/write) 1308096 1308096 0 0.0
.dram0.bss 58616 58616 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 199776 199776 0 0.0
.flash.text 880742 880742 0 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 911907 911831 -76 -0.0
(read/write) 427860 427860 0 0.0
.dram0.bss 61120 61120 0 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 208476 208476 0 0.0
.flash.text 911907 911831 -76 -0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699528 699528 0 0.0
.bss 77856 77856 0 0.0
.data 1904 1904 0 0.0
.text 613968 613968 0 0.0
lock-app k32w061+debug (read/write) 591836 591836 0 0.0
.bss 68372 68372 0 0.0
.data 1868 1868 0 0.0
.text 515796 515796 0 0.0
shell k32w061+debug (read/write) 424916 657800 232884 54.8
.bss 63296 79056 15760 24.9
.data 668 1840 1172 175.4
.text 359248 571104 211856 59.0
linux all-clusters-app debug (read only) 1690937 1690937 0 0.0
(read/write) 119760 119760 0 0.0
.bss 51184 51184 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62272 62272 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 139829 139829 0 0.0
.text 1417714 1417714 0 0.0
bridge-app debug+rpc (read only) 1287325 1287325 0 0.0
(read/write) 69384 69384 0 0.0
.bss 35088 35088 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27768 27768 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 111460 111460 0 0.0
.text 1079973 1079973 0 0.0
chip-tool debug (read only) 4351269 4351269 0 0.0
(read/write) 124896 124896 0 0.0
.bss 18224 18224 0 0.0
.data 2224 2224 0 0.0
.data.rel.ro 99040 99040 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 219560 219560 0 0.0
.text 3865669 3865669 0 0.0
lighting-app debug+rpc (read only) 1543193 1543193 0 0.0
(read/write) 101712 101712 0 0.0
.bss 40728 40728 0 0.0
.data 1138 1138 0 0.0
.data.rel.ro 54560 54560 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 129553 129553 0 0.0
.text 1280946 1280946 0 0.0
ota-provider-app debug (read only) 1243689 1243689 0 0.0
(read/write) 67552 67552 0 0.0
.bss 37152 37152 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24568 24568 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 112360 112360 0 0.0
.text 1035250 1035250 0 0.0
ota-requestor-app debug (read only) 1311049 1311049 0 0.0
(read/write) 76872 76872 0 0.0
.bss 45408 45408 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25512 25512 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 123328 123328 0 0.0
.text 1089954 1089954 0 0.0
shell debug (read only) 786593 786593 0 0.0
(read/write) 57664 57664 0 0.0
.bss 16104 16104 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77839 77839 0 0.0
.text 607266 607266 0 0.0
tv-app debug (read only) 1810545 1810545 0 0.0
(read/write) 289944 289944 0 0.0
.bss 222768 222768 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 58824 58824 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 155640 155640 0 0.0
.text 1512642 1512642 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293224 2293224 0 0.0
.bss 179972 179972 0 0.0
.data 5216 5216 0 0.0
.heap 851256 851256 0 0.0
.text 1255824 1255824 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2272216 2272216 0 0.0
.bss 172012 172012 0 0.0
.data 5568 5568 0 0.0
.heap 858864 858864 0 0.0
.text 1234816 1234816 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2249872 2249872 0 0.0
.bss 170908 170908 0 0.0
.data 5560 5560 0 0.0
.heap 859976 859976 0 0.0
.text 1212472 1212472 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048496 2048496 0 0.0
.bss 156256 156256 0 0.0
.data 4960 4960 0 0.0
.heap 875232 875232 0 0.0
.text 1011096 1011096 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861395 861395 0 0.0
bss 111320 111320 0 0.0
rodata 96772 96772 0 0.0
text 577692 577692 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 822267 822267 0 0.0
bss 107560 107560 0 0.0
rodata 87564 87564 0 0.0
text 550864 550864 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786434 786434 0 0.0
bss 112696 112696 0 0.0
rodata 92028 92028 0 0.0
text 507152 507152 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838099 838099 0 0.0
bss 110356 110356 0 0.0
rodata 93140 93140 0 0.0
text 559168 559168 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763398 763398 0 0.0
bss 111764 111764 0 0.0
rodata 88448 88448 0 0.0
text 488720 488720 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844211 844211 0 0.0
bss 110492 110492 0 0.0
rodata 94852 94852 0 0.0
text 563348 563348 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837955 837955 0 0.0
bss 110392 110392 0 0.0
rodata 93140 93140 0 0.0
text 558904 558904 0 0.0
shell nrf52840dk_nrf52840 (read/write) 775991 775991 0 0.0
bss 109112 109112 0 0.0
rodata 72412 72412 0 0.0
text 519884 519884 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691026 691026 0 0.0
bss 110092 110092 0 0.0
rodata 67052 67052 0 0.0
text 440480 440480 0 0.0
p6 all-clusters-app default (read/write) 2300752 2300752 0 0.0
.bss 107912 107912 0 0.0
.data 2520 2520 0 0.0
.heap 922912 922912 0 0.0
.text 1259016 1259016 0 0.0
lock-app default (read/write) 2213744 2213744 0 0.0
.bss 95712 95712 0 0.0
.data 2392 2392 0 0.0
.heap 935240 935240 0 0.0
.text 1172008 1172008 0 0.0
qpg lighting-app qpg6100+debug (read only) 490784 490784 0 0.0
(read/write) 114140 114140 0 0.0
.bss 50416 50416 0 0.0
.data 1004 1004 0 0.0
.text 485464 485464 0 0.0
lock-app qpg6100+debug (read only) 467120 467120 0 0.0
(read/write) 114144 114144 0 0.0
.bss 49360 49360 0 0.0
.data 960 960 0 0.0
.text 461800 461800 0 0.0
persistent-storage-app qpg6100+debug (read only) 153212 153212 0 0.0
(read/write) 114140 114140 0 0.0
.bss 18336 18336 0 0.0
.data 356 356 0 0.0
.text 147892 147892 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662894 662894 0 0.0
bss 69132 69132 0 0.0
noinit 33216 33216 0 0.0
text 458028 458028 0 0.0

@andy31415 andy31415 merged commit 784fe58 into project-chip:master Nov 3, 2021
doru91 added a commit to doru91/connectedhomeip that referenced this pull request Nov 18, 2021
@doru91 @restyled-commits
[K32W0][THREADIP-3665] Improve shell application (project-chip#11194)
9fa8cd8 
* [K32W0][THREADIP-3665] Improve shell application

Shell application lacked a method for commissioning it to a Thread/Matter network:
* add commissioning support;
* run the shell functionality in a dedicated task.

Signed-off-by: Doru Gucea <[email protected]>

* Restyled by clang-format

* Restyled by gn

* [K32W] DIsable ot cli for the moment

Otherwise, the app won't fit into RAM0.

Signed-off-by: Doru Gucea <[email protected]>

* Restyled by clang-format

* [K32W0] Fix variable type

Signed-off-by: Doru Gucea <[email protected]>

* [K32W0] Disable low power build for the shell app

Signed-off-by: Doru Gucea <[email protected]>

Co-authored-by: Restyled.io <[email protected]>
andy31415 pushed a commit that referenced this pull request Nov 18, 2021
@doru91 @restyled-commits @andreilitvin
[K32W0][THREADIP-3665] Improve shell application (#11194)
794a5fb 
* [K32W0][THREADIP-3665] Improve shell application

Shell application lacked a method for commissioning it to a Thread/Matter network:
* add commissioning support;
* run the shell functionality in a dedicated task.

Signed-off-by: Doru Gucea <[email protected]>

* Restyled by clang-format

* Restyled by gn

* [K32W] DIsable ot cli for the moment

Otherwise, the app won't fit into RAM0.

Signed-off-by: Doru Gucea <[email protected]>

* Restyled by clang-format

* [K32W0] Fix variable type

Signed-off-by: Doru Gucea <[email protected]>

* [K32W0] Disable low power build for the shell app

Signed-off-by: Doru Gucea <[email protected]>

Co-authored-by: Restyled.io <[email protected]>
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@doru91 @restyled-commits
[K32W0][THREADIP-3665] Improve shell application (project-chip#11194)
5698e82 
* [K32W0][THREADIP-3665] Improve shell application

Shell application lacked a method for commissioning it to a Thread/Matter network:
* add commissioning support;
* run the shell functionality in a dedicated task.

Signed-off-by: Doru Gucea <[email protected]>

* Restyled by clang-format

* Restyled by gn

* [K32W] DIsable ot cli for the moment

Otherwise, the app won't fit into RAM0.

Signed-off-by: Doru Gucea <[email protected]>

* Restyled by clang-format

* [K32W0] Fix variable type

Signed-off-by: Doru Gucea <[email protected]>

* [K32W0] Disable low power build for the shell app

Signed-off-by: Doru Gucea <[email protected]>

Co-authored-by: Restyled.io <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

Assignees
No one assigned
Labels
examples github review - approved scripts workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@doru91 @woody-apple @andy31415 @Damian-Nordic @jmartinez-silabs @restyled-commits