Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[K32W0][THREADIP-3663] Add Software Diagnosis Cluster #11190

Merged
merged 2 commits into from
Oct 29, 2021
Merged

[K32W0][THREADIP-3663] Add Software Diagnosis Cluster #11190

merged 2 commits into from
Oct 29, 2021

Conversation

doru91
Copy link
Contributor

@doru91 doru91 commented Oct 29, 2021

Signed-off-by: Doru Gucea [email protected]

Problem

Software Diagnosis Cluster was missing from K32W implementation.

Change overview

Add Add Software Diagnosis Cluster implementation.

Testing

Manual testing using chip-device-ctrl and TE6 branch.

@restyled-io restyled-io bot mentioned this pull request Oct 29, 2021
Closed
@github-actions
Copy link

github-actions bot commented Oct 29, 2021 •
edited
Loading

PR #11190: Size comparison from 7f05fb6 to 9a27cf2

Increases (2 builds for k32w)
platform target config section 7f05fb6 9a27cf2 change % change
k32w lighting-app k32w061+se05x+release (read/write) 701656 701720 64 0.0
.text 615268 615332 64 0.0
lock-app k32w061+debug (read/write) 593612 593676 64 0.0
.text 516776 516840 64 0.0
Full report (16 builds for k32w, linux, p6, qpg, telink)
platform target config section 7f05fb6 9a27cf2 change % change
k32w lighting-app k32w061+se05x+release (read/write) 701656 701720 64 0.0
.bss 78688 78688 0 0.0
.data 1900 1900 0 0.0
.text 615268 615332 64 0.0
lock-app k32w061+debug (read/write) 593612 593676 64 0.0
.bss 69172 69172 0 0.0
.data 1864 1864 0 0.0
.text 516776 516840 64 0.0
shell k32w061+debug (read/write) 425252 425252 0 0.0
.bss 63256 63256 0 0.0
.data 672 672 0 0.0
.text 359620 359620 0 0.0
linux all-clusters-app debug (read only) 1655073 1655073 0 0.0
(read/write) 119104 119104 0 0.0
.bss 51376 51376 0 0.0
.data 978 978 0 0.0
.data.rel.ro 61504 61504 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 138069 138069 0 0.0
.text 1384738 1384738 0 0.0
bridge-app debug+rpc (read only) 1283341 1283341 0 0.0
(read/write) 85160 85160 0 0.0
.bss 51856 51856 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27336 27336 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 111044 111044 0 0.0
.text 1076981 1076981 0 0.0
chip-tool debug (read only) 4266229 4266229 0 0.0
(read/write) 122176 122176 0 0.0
.bss 17680 17680 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 97504 97504 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 214704 214704 0 0.0
.text 3788725 3788725 0 0.0
lighting-app debug+rpc (read only) 1542281 1542281 0 0.0
(read/write) 102000 102000 0 0.0
.bss 41208 41208 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 54416 54416 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 129169 129169 0 0.0
.text 1280658 1280658 0 0.0
ota-provider-app debug (read only) 1239849 1239849 0 0.0
(read/write) 67872 67872 0 0.0
.bss 37440 37440 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24584 24584 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 111208 111208 0 0.0
.text 1032466 1032466 0 0.0
ota-requestor-app debug (read only) 1301465 1301465 0 0.0
(read/write) 76616 76616 0 0.0
.bss 45216 45216 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25464 25464 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 127424 127424 0 0.0
.text 1076226 1076226 0 0.0
shell debug (read only) 787153 787153 0 0.0
(read/write) 57760 57760 0 0.0
.bss 16168 16168 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36848 36848 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77519 77519 0 0.0
.text 608098 608098 0 0.0
tv-app debug (read only) 1774929 1774929 0 0.0
(read/write) 289624 289624 0 0.0
.bss 223280 223280 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58672 58672 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 154488 154488 0 0.0
.text 1478178 1478178 0 0.0
p6 lock-app default (read/write) 2169744 2169744 0 0.0
.bss 67168 67168 0 0.0
.data 2416 2416 0 0.0
.heap 963760 963760 0 0.0
.text 1128008 1128008 0 0.0
qpg lighting-app qpg6100+debug (read only) 491224 491224 0 0.0
(read/write) 114144 114144 0 0.0
.bss 51288 51288 0 0.0
.data 1000 1000 0 0.0
.text 485904 485904 0 0.0
lock-app qpg6100+debug (read only) 467556 467556 0 0.0
(read/write) 114140 114140 0 0.0
.bss 50240 50240 0 0.0
.data 956 956 0 0.0
.text 462236 462236 0 0.0
persistent-storage-app qpg6100+debug (read only) 155236 155236 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 149916 149916 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 665202 665202 0 0.0
bss 69944 69944 0 0.0
noinit 33216 33216 0 0.0
text 458454 458454 0 0.0

@andy31415
Copy link
Contributor

/rebase

@woody-apple woody-apple force-pushed the integrate/software_diagnosis_cluster branch from 9a27cf2 to 85ada09 Compare October 29, 2021 16:40
@andy31415
Copy link
Contributor

fast track: small change, platform specific change made by platform owner

@andy31415 andy31415 merged commit 732f246 into project-chip:master Oct 29, 2021
doru91 added a commit to doru91/connectedhomeip that referenced this pull request Nov 12, 2021
@doru91 @restyled-commits
[K32W0] Add Software Diagnosis Cluster (project-chip#11190)
6df986b 
Signed-off-by: Doru Gucea <[email protected]>

* Restyled by clang-format

Co-authored-by: Restyled.io <[email protected]>
Signed-off-by: Doru Gucea <[email protected]>
doru91 added a commit to doru91/connectedhomeip that referenced this pull request Nov 12, 2021
@doru91 @restyled-commits
[K32W0] Add Software Diagnosis Cluster (project-chip#11190)
a4cde8e 
Signed-off-by: Doru Gucea <[email protected]>

* Restyled by clang-format

Co-authored-by: Restyled.io <[email protected]>
Signed-off-by: Doru Gucea <[email protected]>
andy31415 pushed a commit that referenced this pull request Nov 12, 2021
@doru91 @restyled-commits @andreilitvin
[K32W0][THREADIP-3663] Add Software Diagnosis Cluster (#11190)
630cb85 
* [K32W0][THREADIP-3663] Add Software Diagnosis Center

Signed-off-by: Doru Gucea <[email protected]>

* Restyled by clang-format

Co-authored-by: Restyled.io <[email protected]>
andy31415 pushed a commit that referenced this pull request Nov 12, 2021
@doru91 @restyled-commits @andreilitvin
[K32W0] Add Software Diagnosis Cluster (#11190)
f8f47a7 
Signed-off-by: Doru Gucea <[email protected]>

* Restyled by clang-format

Co-authored-by: Restyled.io <[email protected]>
Signed-off-by: Doru Gucea <[email protected]>
pankore pushed a commit to pankore/connectedhomeip that referenced this pull request Nov 24, 2021
@doru91 @restyled-commits @pankore
[K32W0] Add Software Diagnosis Cluster (project-chip#11190)
3b869a9 
Signed-off-by: Doru Gucea <[email protected]>

* Restyled by clang-format

Co-authored-by: Restyled.io <[email protected]>
Signed-off-by: Doru Gucea <[email protected]>
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@doru91 @restyled-commits
[K32W0][THREADIP-3663] Add Software Diagnosis Cluster (project-chip#1…
5baf09e 
…1190)

* [K32W0][THREADIP-3663] Add Software Diagnosis Center

Signed-off-by: Doru Gucea <[email protected]>

* Restyled by clang-format

Co-authored-by: Restyled.io <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saurabhst saurabhst saurabhst approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
examples fast track platform review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@doru91 @andy31415 @saurabhst @restyled-commits