Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply comments for PR 10985 #11189

Merged
merged 2 commits into from
Nov 1, 2021
Merged

Apply comments for PR 10985 #11189

merged 2 commits into from
Nov 1, 2021

Conversation

jepenven-silabs
Copy link
Contributor

Problem

Some issues needed to be fixed following the merge of PR #10985
See #11072 for full details.

Change overview

As discussed with @bzbarsky-apple apply the requested changes

Testing

Tested with Unit test.
Unit test for MCSP Message Header state added (session Group ID with a Destination Node ID)

@todo
Copy link

todo bot commented Oct 29, 2021

Commit Group Message Counter

connectedhomeip/src/transport/SessionManager.cpp

Lines 514 to 524 in 957fcbd

// TODO: Commit Group Message Counter
if (mCB != nullptr)
{
// TODO: Update Session Handle for Group messages.
// SessionHandle session(state->GetPeerNodeId(), state->GetLocalSessionId(), state->GetPeerSessionId(),
// state->GetFabricIndex());
// mCB->OnMessageReceived(packetHeader, payloadHeader, session, peerAddress, isDuplicate, std::move(msg));
}
exit:

This comment was generated by todo based on a TODO comment in 957fcbd in #11189. cc @jepenven-silabs.

@github-actions
Copy link

github-actions bot commented Oct 29, 2021 •
edited
Loading

PR #11189: Size comparison from 1e27d92 to 957fcbd

Decreases (25 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 1e27d92 957fcbd change % change
efr32 lighting-app BRD4161A (read only) 738120 737876 -244 -0.0
.text 738112 737868 -244 -0.0
BRD4161A+rpc (read only) 725560 725316 -244 -0.0
(read/write) 132036 132032 -4 -0.0
.text 725552 725308 -244 -0.0
lock-app BRD4161A (read only) 717400 717172 -228 -0.0
.text 717392 717164 -228 -0.0
window-app BRD4161A (read only) 718304 718076 -228 -0.0
(read/write) 113572 113568 -4 -0.0
.text 718296 718068 -228 -0.0
esp32 all-clusters-app c3devkit (read only) 876382 876318 -64 -0.0
(read/write) 1308944 1308816 -128 -0.0
.flash.rodata 200016 199888 -128 -0.1
.flash.text 876382 876318 -64 -0.0
m5stack (read only) 907747 907599 -148 -0.0
(read/write) 428724 428588 -136 -0.0
.flash.rodata 208732 208596 -136 -0.1
.flash.text 907747 907599 -148 -0.0
k32w lighting-app k32w061+se05x+release (read/write) 701656 701456 -200 -0.0
.text 615268 615068 -200 -0.0
lock-app k32w061+debug (read/write) 593612 593396 -216 -0.0
.text 516776 516560 -216 -0.0
shell k32w061+debug (read/write) 425252 425052 -200 -0.0
.text 359620 359420 -200 -0.1
linux all-clusters-app debug (read only) 1655073 1654417 -656 -0.0
.rodata 138069 137909 -160 -0.1
.text 1384738 1384242 -496 -0.0
bridge-app debug+rpc (read only) 1283341 1282685 -656 -0.1
.rodata 111044 110884 -160 -0.1
.text 1076981 1076485 -496 -0.0
chip-tool debug (read only) 4266229 4265573 -656 -0.0
.rodata 214704 214544 -160 -0.1
.text 3788725 3788229 -496 -0.0
lighting-app debug+rpc (read only) 1542281 1541657 -624 -0.0
.rodata 129169 129041 -128 -0.1
.text 1280658 1280162 -496 -0.0
ota-provider-app debug (read only) 1239849 1239193 -656 -0.1
.rodata 111208 111048 -160 -0.1
.text 1032466 1031970 -496 -0.0
ota-requestor-app debug (read only) 1301465 1300841 -624 -0.0
.rodata 127424 127296 -128 -0.1
.text 1076226 1075730 -496 -0.0
shell debug (read only) 787153 786529 -624 -0.1
.rodata 77519 77391 -128 -0.2
.text 608098 607602 -496 -0.1
tv-app debug (read only) 1774929 1774305 -624 -0.0
.rodata 154488 154360 -128 -0.1
.text 1478178 1477682 -496 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2291400 2291136 -264 -0.0
.text 1254000 1253736 -264 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2275608 2275408 -200 -0.0
.text 1238208 1238008 -200 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2253328 2253064 -264 -0.0
.text 1215928 1215664 -264 -0.0
shell CY8CPROTO_062_4343W+release (read/write) 2048976 2048712 -264 -0.0
.text 1011576 1011312 -264 -0.0
p6 lock-app default (read/write) 2169744 2169512 -232 -0.0
.text 1128008 1127776 -232 -0.0
qpg lighting-app qpg6100+debug (read only) 491224 491092 -132 -0.0
.text 485904 485772 -132 -0.0
lock-app qpg6100+debug (read only) 467556 467424 -132 -0.0
.text 462236 462104 -132 -0.0
telink lighting-app tlsr9518adk80d (read/write) 665202 665006 -196 -0.0
text 458454 458388 -66 -0.0
Full report (27 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 1e27d92 957fcbd change % change
efr32 lighting-app BRD4161A (read only) 738120 737876 -244 -0.0
(read/write) 115428 115428 0 0.0
.bss 113676 113676 0 0.0
.data 1752 1752 0 0.0
.text 738112 737868 -244 -0.0
BRD4161A+rpc (read only) 725560 725316 -244 -0.0
(read/write) 132036 132032 -4 -0.0
.bss 130180 130180 0 0.0
.data 1852 1852 0 0.0
.text 725552 725308 -244 -0.0
lock-app BRD4161A (read only) 717400 717172 -228 -0.0
(read/write) 113244 113244 0 0.0
.bss 111532 111532 0 0.0
.data 1712 1712 0 0.0
.text 717392 717164 -228 -0.0
window-app BRD4161A (read only) 718304 718076 -228 -0.0
(read/write) 113572 113568 -4 -0.0
.bss 111852 111852 0 0.0
.data 1716 1716 0 0.0
.text 718296 718068 -228 -0.0
esp32 all-clusters-app c3devkit (read only) 876382 876318 -64 -0.0
(read/write) 1308944 1308816 -128 -0.0
.dram0.bss 59248 59248 0 0.0
.dram0.data 16448 16448 0 0.0
.flash.rodata 200016 199888 -128 -0.1
.flash.text 876382 876318 -64 -0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 907747 907599 -148 -0.0
(read/write) 428724 428588 -136 -0.0
.dram0.bss 61744 61744 0 0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 208732 208596 -136 -0.1
.flash.text 907747 907599 -148 -0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 701656 701456 -200 -0.0
.bss 78688 78688 0 0.0
.data 1900 1900 0 0.0
.text 615268 615068 -200 -0.0
lock-app k32w061+debug (read/write) 593612 593396 -216 -0.0
.bss 69172 69172 0 0.0
.data 1864 1864 0 0.0
.text 516776 516560 -216 -0.0
shell k32w061+debug (read/write) 425252 425052 -200 -0.0
.bss 63256 63256 0 0.0
.data 672 672 0 0.0
.text 359620 359420 -200 -0.1
linux all-clusters-app debug (read only) 1655073 1654417 -656 -0.0
(read/write) 119104 119104 0 0.0
.bss 51376 51376 0 0.0
.data 978 978 0 0.0
.data.rel.ro 61504 61504 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 138069 137909 -160 -0.1
.text 1384738 1384242 -496 -0.0
bridge-app debug+rpc (read only) 1283341 1282685 -656 -0.1
(read/write) 85160 85160 0 0.0
.bss 51856 51856 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27336 27336 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 111044 110884 -160 -0.1
.text 1076981 1076485 -496 -0.0
chip-tool debug (read only) 4266229 4265573 -656 -0.0
(read/write) 122176 122176 0 0.0
.bss 17680 17680 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 97504 97504 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 214704 214544 -160 -0.1
.text 3788725 3788229 -496 -0.0
lighting-app debug+rpc (read only) 1542281 1541657 -624 -0.0
(read/write) 102000 102000 0 0.0
.bss 41208 41208 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 54416 54416 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 129169 129041 -128 -0.1
.text 1280658 1280162 -496 -0.0
ota-provider-app debug (read only) 1239849 1239193 -656 -0.1
(read/write) 67872 67872 0 0.0
.bss 37440 37440 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24584 24584 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 111208 111048 -160 -0.1
.text 1032466 1031970 -496 -0.0
ota-requestor-app debug (read only) 1301465 1300841 -624 -0.0
(read/write) 76616 76616 0 0.0
.bss 45216 45216 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25464 25464 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 127424 127296 -128 -0.1
.text 1076226 1075730 -496 -0.0
shell debug (read only) 787153 786529 -624 -0.1
(read/write) 57760 57760 0 0.0
.bss 16168 16168 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36848 36848 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77519 77391 -128 -0.2
.text 608098 607602 -496 -0.1
tv-app debug (read only) 1774929 1774305 -624 -0.0
(read/write) 289624 289624 0 0.0
.bss 223280 223280 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58672 58672 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 154488 154360 -128 -0.1
.text 1478178 1477682 -496 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2291400 2291136 -264 -0.0
.bss 180620 180620 0 0.0
.data 5192 5192 0 0.0
.heap 850632 850632 0 0.0
.text 1254000 1253736 -264 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2275608 2275408 -200 -0.0
.bss 172820 172820 0 0.0
.data 5568 5568 0 0.0
.heap 858056 858056 0 0.0
.text 1238208 1238008 -200 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2253328 2253064 -264 -0.0
.bss 171724 171724 0 0.0
.data 5552 5552 0 0.0
.heap 859168 859168 0 0.0
.text 1215928 1215664 -264 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048976 2048712 -264 -0.0
.bss 156208 156208 0 0.0
.data 4968 4968 0 0.0
.heap 875272 875272 0 0.0
.text 1011576 1011312 -264 -0.0
p6 lock-app default (read/write) 2169744 2169512 -232 -0.0
.bss 67168 67168 0 0.0
.data 2416 2416 0 0.0
.heap 963760 963760 0 0.0
.text 1128008 1127776 -232 -0.0
qpg lighting-app qpg6100+debug (read only) 491224 491092 -132 -0.0
(read/write) 114144 114144 0 0.0
.bss 51288 51288 0 0.0
.data 1000 1000 0 0.0
.text 485904 485772 -132 -0.0
lock-app qpg6100+debug (read only) 467556 467424 -132 -0.0
(read/write) 114140 114140 0 0.0
.bss 50240 50240 0 0.0
.data 956 956 0 0.0
.text 462236 462104 -132 -0.0
persistent-storage-app qpg6100+debug (read only) 155236 155236 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 149916 149916 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 665202 665006 -196 -0.0
bss 69944 69944 0 0.0
noinit 33216 33216 0 0.0
text 458454 458388 -66 -0.0

@jepenven-silabs jepenven-silabs linked an issue Oct 29, 2021 that may be closed by this pull request
Post-landing review comments for PR 10985 #11072
Closed
@jepenven-silabs jepenven-silabs force-pushed the secure_msg_dispatch_fixes branch from 957fcbd to 8d795cc Compare November 1, 2021 15:45
@andy31415
Copy link
Contributor

andy31415 commented Nov 1, 2021 •
edited
Loading

fast track: cleanup PR approved by original requester.

@andy31415
Copy link
Contributor

@jepenven-silabs - it seems latest changes broke compilation.

@jepenven-silabs
Copy link
Contributor Author

@jepenven-silabs - it seems latest changes broke compilation.

Strange, since it was only a rebase on master with a small conflict fix. Working on it

@github-actions
Copy link

github-actions bot commented Nov 1, 2021 •
edited
Loading

PR #11189: Size comparison from 68e4b18 to 4916686

Increases (2 builds for efr32, linux)
platform target config section 68e4b18 4916686 change % change
efr32 window-app BRD4161A (read/write) 112584 112588 4 0.0
linux chip-tool debug .rodata 217328 217424 96 0.0
Decreases (34 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 68e4b18 4916686 change % change
efr32 lighting-app BRD4161A (read only) 736668 735428 -1240 -0.2
.text 736660 735420 -1240 -0.2
BRD4161A+rpc (read only) 724108 722852 -1256 -0.2
.text 724100 722844 -1256 -0.2
lock-app BRD4161A (read only) 715964 714712 -1252 -0.2
.text 715956 714704 -1252 -0.2
window-app BRD4161A (read only) 716868 715608 -1260 -0.2
.text 716860 715600 -1260 -0.2
esp32 all-clusters-app c3devkit (read only) 880610 880058 -552 -0.1
(read/write) 1307768 1307336 -432 -0.0
.flash.rodata 199640 199208 -432 -0.2
.flash.text 880610 880058 -552 -0.1
m5stack (read only) 911459 910935 -524 -0.1
(read/write) 427528 427112 -416 -0.1
.flash.rodata 208344 207928 -416 -0.2
.flash.text 911459 910935 -524 -0.1
k32w lighting-app k32w061+se05x+release (read/write) 699144 698244 -900 -0.1
.text 613756 612856 -900 -0.1
lock-app k32w061+debug (read/write) 591448 590540 -908 -0.2
.text 515596 514688 -908 -0.2
shell k32w061+debug (read/write) 424988 424772 -216 -0.1
.text 359332 359116 -216 -0.1
linux all-clusters-app debug (read only) 1686969 1683785 -3184 -0.2
.rodata 138069 137621 -448 -0.3
.text 1415842 1413106 -2736 -0.2
bridge-app debug+rpc (read only) 1281941 1278693 -3248 -0.3
.rodata 110020 109508 -512 -0.5
.text 1076677 1073941 -2736 -0.3
chip-tool debug (read only) 4313789 4313277 -512 -0.0
.text 3830805 3830197 -608 -0.0
lighting-app debug+rpc (read only) 1540849 1537665 -3184 -0.2
.rodata 128113 127665 -448 -0.3
.text 1280354 1277618 -2736 -0.2
ota-provider-app debug (read only) 1239017 1235705 -3312 -0.3
.rodata 110408 109928 -480 -0.4
.text 1032482 1029650 -2832 -0.3
ota-requestor-app debug (read only) 1296465 1293137 -3328 -0.3
.rodata 121696 121184 -512 -0.4
.text 1076978 1074162 -2816 -0.3
shell debug (read only) 786145 785041 -1104 -0.1
.rodata 77423 77295 -128 -0.2
.text 607186 606210 -976 -0.2
tv-app debug (read only) 1773817 1770569 -3248 -0.2
.rodata 153432 152920 -512 -0.3
.text 1478482 1475746 -2736 -0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2294952 2293472 -1480 -0.1
.text 1257552 1256072 -1480 -0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2274336 2272856 -1480 -0.1
.text 1236936 1235456 -1480 -0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2252056 2250576 -1480 -0.1
.text 1214656 1213176 -1480 -0.1
shell CY8CPROTO_062_4343W+release (read/write) 2048656 2048328 -328 -0.0
.text 1011256 1010928 -328 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861283 860187 -1096 -0.1
rodata 96860 96340 -520 -0.5
text 577656 577084 -572 -0.1
nrf52840dk_nrf52840+rpc (read/write) 822111 821007 -1104 -0.1
rodata 87640 87112 -528 -0.6
text 550832 550260 -572 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 786306 785226 -1080 -0.1
rodata 92100 91580 -520 -0.6
text 507124 506552 -572 -0.1
lock-app nrf52840dk_nrf52840 (read/write) 837975 836895 -1080 -0.1
rodata 93216 92696 -520 -0.6
text 559136 558564 -572 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 763286 762190 -1096 -0.1
rodata 88520 88000 -520 -0.6
text 488696 488124 -572 -0.1
pump-app nrf52840dk_nrf52840 (read/write) 842659 841563 -1096 -0.1
rodata 94460 93940 -520 -0.6
text 562348 561776 -572 -0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 837963 836883 -1080 -0.1
rodata 93236 92716 -520 -0.6
text 558980 558408 -572 -0.1
shell nrf52840dk_nrf52840 (read/write) 776179 775903 -276 -0.0
rodata 72536 72404 -132 -0.2
text 519936 519792 -144 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691202 690906 -296 -0.0
rodata 67180 67044 -136 -0.2
text 440548 440400 -148 -0.0
p6 lock-app default (read/write) 2167904 2166576 -1328 -0.1
.text 1126168 1124840 -1328 -0.1
qpg lighting-app qpg6100+debug (read only) 490540 489696 -844 -0.2
.text 485220 484376 -844 -0.2
lock-app qpg6100+debug (read only) 466884 466024 -860 -0.2
.text 461564 460704 -860 -0.2
telink lighting-app tlsr9518adk80d (read/write) 662906 661634 -1272 -0.2
text 458088 457376 -712 -0.2
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 68e4b18 4916686 change % change
efr32 lighting-app BRD4161A (read only) 736668 735428 -1240 -0.2
(read/write) 114444 114444 0 0.0
.bss 112692 112692 0 0.0
.data 1752 1752 0 0.0
.text 736660 735420 -1240 -0.2
BRD4161A+rpc (read only) 724108 722852 -1256 -0.2
(read/write) 131048 131048 0 0.0
.bss 129196 129196 0 0.0
.data 1852 1852 0 0.0
.text 724100 722844 -1256 -0.2
lock-app BRD4161A (read only) 715964 714712 -1252 -0.2
(read/write) 112260 112260 0 0.0
.bss 110548 110548 0 0.0
.data 1712 1712 0 0.0
.text 715956 714704 -1252 -0.2
window-app BRD4161A (read only) 716868 715608 -1260 -0.2
(read/write) 112584 112588 4 0.0
.bss 110868 110868 0 0.0
.data 1716 1716 0 0.0
.text 716860 715600 -1260 -0.2
esp32 all-clusters-app c3devkit (read only) 880610 880058 -552 -0.1
(read/write) 1307768 1307336 -432 -0.0
.dram0.bss 58424 58424 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 199640 199208 -432 -0.2
.flash.text 880610 880058 -552 -0.1
.iram0.text 57554 57554 0 0.0
m5stack (read only) 911459 910935 -524 -0.1
(read/write) 427528 427112 -416 -0.1
.dram0.bss 60920 60920 0 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 208344 207928 -416 -0.2
.flash.text 911459 910935 -524 -0.1
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699144 698244 -900 -0.1
.bss 77688 77688 0 0.0
.data 1900 1900 0 0.0
.text 613756 612856 -900 -0.1
lock-app k32w061+debug (read/write) 591448 590540 -908 -0.2
.bss 68188 68188 0 0.0
.data 1864 1864 0 0.0
.text 515596 514688 -908 -0.2
shell k32w061+debug (read/write) 424988 424772 -216 -0.1
.bss 63280 63280 0 0.0
.data 672 672 0 0.0
.text 359332 359116 -216 -0.1
linux all-clusters-app debug (read only) 1686969 1683785 -3184 -0.2
(read/write) 118992 118992 0 0.0
.bss 50608 50608 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62112 62112 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 138069 137621 -448 -0.3
.text 1415842 1413106 -2736 -0.2
bridge-app debug+rpc (read only) 1281941 1278693 -3248 -0.3
(read/write) 84104 84104 0 0.0
.bss 50768 50768 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27368 27368 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 110020 109508 -512 -0.5
.text 1076677 1073941 -2736 -0.3
chip-tool debug (read only) 4313789 4313277 -512 -0.0
(read/write) 123552 123552 0 0.0
.bss 17680 17680 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 98880 98880 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 217328 217424 96 0.0
.text 3830805 3830197 -608 -0.0
lighting-app debug+rpc (read only) 1540849 1537665 -3184 -0.2
(read/write) 100976 100976 0 0.0
.bss 40152 40152 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 54448 54448 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128113 127665 -448 -0.3
.text 1280354 1277618 -2736 -0.2
ota-provider-app debug (read only) 1239017 1235705 -3312 -0.3
(read/write) 67072 67072 0 0.0
.bss 36608 36608 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24616 24616 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110408 109928 -480 -0.4
.text 1032482 1029650 -2832 -0.3
ota-requestor-app debug (read only) 1296465 1293137 -3328 -0.3
(read/write) 76392 76392 0 0.0
.bss 44864 44864 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25576 25576 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 121696 121184 -512 -0.4
.text 1076978 1074162 -2816 -0.3
shell debug (read only) 786145 785041 -1104 -0.1
(read/write) 57664 57664 0 0.0
.bss 16072 16072 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36848 36848 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77423 77295 -128 -0.2
.text 607186 606210 -976 -0.2
tv-app debug (read only) 1773817 1770569 -3248 -0.2
(read/write) 288536 288536 0 0.0
.bss 222192 222192 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58672 58672 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 153432 152920 -512 -0.3
.text 1478482 1475746 -2736 -0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2294952 2293472 -1480 -0.1
.bss 179796 179796 0 0.0
.data 5216 5216 0 0.0
.heap 851432 851432 0 0.0
.text 1257552 1256072 -1480 -0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2274336 2272856 -1480 -0.1
.bss 171836 171836 0 0.0
.data 5568 5568 0 0.0
.heap 859040 859040 0 0.0
.text 1236936 1235456 -1480 -0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2252056 2250576 -1480 -0.1
.bss 170740 170740 0 0.0
.data 5552 5552 0 0.0
.heap 860152 860152 0 0.0
.text 1214656 1213176 -1480 -0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048656 2048328 -328 -0.0
.bss 156232 156232 0 0.0
.data 4968 4968 0 0.0
.heap 875248 875248 0 0.0
.text 1011256 1010928 -328 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861283 860187 -1096 -0.1
bss 111148 111148 0 0.0
rodata 96860 96340 -520 -0.5
text 577656 577084 -572 -0.1
nrf52840dk_nrf52840+rpc (read/write) 822111 821007 -1104 -0.1
bss 107392 107392 0 0.0
rodata 87640 87112 -528 -0.6
text 550832 550260 -572 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 786306 785226 -1080 -0.1
bss 112524 112524 0 0.0
rodata 92100 91580 -520 -0.6
text 507124 506552 -572 -0.1
lock-app nrf52840dk_nrf52840 (read/write) 837975 836895 -1080 -0.1
bss 110184 110184 0 0.0
rodata 93216 92696 -520 -0.6
text 559136 558564 -572 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 763286 762190 -1096 -0.1
bss 111596 111596 0 0.0
rodata 88520 88000 -520 -0.6
text 488696 488124 -572 -0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 842659 841563 -1096 -0.1
bss 110320 110320 0 0.0
rodata 94460 93940 -520 -0.6
text 562348 561776 -572 -0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 837963 836883 -1080 -0.1
bss 110220 110220 0 0.0
rodata 93236 92716 -520 -0.6
text 558980 558408 -572 -0.1
shell nrf52840dk_nrf52840 (read/write) 776179 775903 -276 -0.0
bss 109096 109096 0 0.0
rodata 72536 72404 -132 -0.2
text 519936 519792 -144 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691202 690906 -296 -0.0
bss 110080 110080 0 0.0
rodata 67180 67044 -136 -0.2
text 440548 440400 -148 -0.0
p6 lock-app default (read/write) 2167904 2166576 -1328 -0.1
.bss 66184 66184 0 0.0
.data 2416 2416 0 0.0
.heap 964744 964744 0 0.0
.text 1126168 1124840 -1328 -0.1
qpg lighting-app qpg6100+debug (read only) 490540 489696 -844 -0.2
(read/write) 114144 114144 0 0.0
.bss 50320 50320 0 0.0
.data 1000 1000 0 0.0
.text 485220 484376 -844 -0.2
lock-app qpg6100+debug (read only) 466884 466024 -860 -0.2
(read/write) 114140 114140 0 0.0
.bss 49272 49272 0 0.0
.data 956 956 0 0.0
.text 461564 460704 -860 -0.2
persistent-storage-app qpg6100+debug (read only) 155820 155820 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 150500 150500 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662906 661634 -1272 -0.2
bss 68960 68960 0 0.0
noinit 33216 33216 0 0.0
text 458088 457376 -712 -0.2

@jepenven-silabs jepenven-silabs merged commit fe47096 into project-chip:master Nov 1, 2021
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@jepenven-silabs
Apply comments for PR 10985 (project-chip#11189)
c537817 
* Apply comments for PR 10985
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@electrocucaracha electrocucaracha electrocucaracha left review comments

@rcasallas-silabs rcasallas-silabs rcasallas-silabs approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
fast track review - pending transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Post-landing review comments for PR 10985
6 participants
@jepenven-silabs @andy31415 @electrocucaracha @bzbarsky-apple @jmartinez-silabs @rcasallas-silabs