Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle [im] Fix wildcard path support per spec #11175

Closed
wants to merge 2 commits into from

Conversation

restyled-io[bot]
Copy link
Contributor

@restyled-io restyled-io bot commented Oct 29, 2021

A duplicate of #11115 with additional commits that automatically address
incorrect style, created by Restyled.

⚠️ Even though this PR is not a Fork, it contains outside contributions.
Please review accordingly.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions
    ```console
    git remote add upstream https://github.com/project-chip/connectedhomeip.git
    git fetch upstream pull/<this PR number>/head
    git merge --ff-only FETCH_HEAD
    git push
    ```
    

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

@todo
Copy link

todo bot commented Oct 29, 2021

The cluster info should be breaked into AttributeInfo and EventInfo.

// TODO: The cluster info should be breaked into AttributeInfo and EventInfo.
// Note: The change will happen after #11171 with a better linked list.
struct ClusterInfo
{
bool IsAttributePathSupersetOf(const ClusterInfo & other) const
{
VerifyOrReturnError(!mEndpointId.HasValue() || mEndpointId == other.mEndpointId, false);
VerifyOrReturnError(!mClusterId.HasValue() || mClusterId == other.mClusterId, false);
VerifyOrReturnError(!mFieldId.HasValue() || mFieldId == other.mFieldId, false);
VerifyOrReturnError(!mListIndex.HasValue() || mListIndex == other.mListIndex, false);


This comment was generated by todo based on a TODO comment in 845b78c in #11175. cc @project-chip.

@todo
Copy link

todo bot commented Oct 29, 2021

(#8364): Support wildcard paths here, should check if we have got valid input when implementing wildcard read.

// TODO(#8364): Support wildcard paths here, should check if we have got valid input when implementing wildcard read.
SuccessOrExit(err = path.GetNodeId(clusterInfo.mNodeId));
SuccessOrExit(err = path.GetEndpointId(clusterInfo.mEndpointId));
SuccessOrExit(err = path.GetClusterId(clusterInfo.mClusterId));
SuccessOrExit(err = path.GetFieldId(clusterInfo.mFieldId));
SuccessOrExit(err = path.GetListIndex(clusterInfo.mListIndex));
VerifyOrExit(!clusterInfo.mListIndex.HasValue() || clusterInfo.mFieldId.HasValue(),
err = CHIP_ERROR_IM_MALFORMED_ATTRIBUTE_PATH);
// TODO(#8364): We assume the path is a concrete path here, will be removed when implementing the wildcard read.


This comment was generated by todo based on a TODO comment in 845b78c in #11175. cc @project-chip.

@todo
Copy link

todo bot commented Oct 29, 2021

(#8364): We assume the path is a concrete path here, will be removed when implementing the wildcard read.

// TODO(#8364): We assume the path is a concrete path here, will be removed when implementing the wildcard read.
VerifyOrExit(clusterInfo.mEndpointId.HasValue() && clusterInfo.mClusterId.HasValue() && clusterInfo.mFieldId.HasValue(),
err = CHIP_ERROR_IM_MALFORMED_ATTRIBUTE_PATH);
SuccessOrExit(err);
err = InteractionModelEngine::GetInstance()->PushFront(mpAttributeClusterInfoList, clusterInfo);
SuccessOrExit(err);


This comment was generated by todo based on a TODO comment in 845b78c in #11175. cc @project-chip.

@todo
Copy link

todo bot commented Oct 29, 2021

We assume the path is a concrete path here, will be removed when implementing the wildcard event read.

// TODO: We assume the path is a concrete path here, will be removed when implementing the wildcard event read.
VerifyOrExit(clusterInfo.mEndpointId.HasValue() && clusterInfo.mClusterId.HasValue(),
err = CHIP_ERROR_IM_MALFORMED_ATTRIBUTE_PATH);
SuccessOrExit(err);
err = InteractionModelEngine::GetInstance()->PushFront(mpEventClusterInfoList, clusterInfo);
SuccessOrExit(err);


This comment was generated by todo based on a TODO comment in 845b78c in #11175. cc @project-chip.

@todo
Copy link

todo bot commented Oct 29, 2021

We assume the path is a concrete path here, will be changed when implementing the wildcard event read.

// TODO: We assume the path is a concrete path here, will be changed when implementing the wildcard event read.
ConcreteAttributePath path(aClusterInfo.mEndpointId.Value(), aClusterInfo.mClusterId.Value(), aClusterInfo.mFieldId.Value());
AttributeDataElement::Builder attributeDataElementBuilder = aAttributeDataList.CreateAttributeDataElementBuilder();
AttributePath::Builder attributePathBuilder = attributeDataElementBuilder.CreateAttributePathBuilder();
attributePathBuilder.NodeId(aClusterInfo.mNodeId.ValueOr(kUndefinedNodeId))
.EndpointId(aClusterInfo.mEndpointId.Value())
.ClusterId(aClusterInfo.mClusterId.Value())
.FieldId(aClusterInfo.mFieldId.Value())
.EndOfAttributePath();
err = attributePathBuilder.GetError();
SuccessOrExit(err);


This comment was generated by todo based on a TODO comment in 845b78c in #11175. cc @project-chip.

@restyled-io restyled-io bot closed this Oct 29, 2021
@restyled-io restyled-io bot deleted the restyled/im/cluster-info-wildcard branch October 29, 2021 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants