-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Groups cluster server implemented using the Group Data provider. #11132
Merged
bzbarsky-apple
merged 6 commits into
project-chip:master
from
rcasallas-silabs:groups_cluster_server
Nov 19, 2021
Merged
Groups cluster server implemented using the Group Data provider. #11132
bzbarsky-apple
merged 6 commits into
project-chip:master
from
rcasallas-silabs:groups_cluster_server
Nov 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
mlepage-google,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple and
saurabhst
October 28, 2021 14:01
bzbarsky-apple
approved these changes
Nov 17, 2021
@msandstedt @saurabhst @LuDuda @Damian-Nordic @jepenven-silabs @jmartinez-silabs Please take a look? |
jmartinez-silabs
approved these changes
Nov 17, 2021
rcasallas-silabs
force-pushed
the
groups_cluster_server
branch
from
November 17, 2021 16:31
ec4222d
to
16a793d
Compare
PR #11132: Size comparison from 4efa5de to 16a793d Increases above 0.2%:
Increases (3 builds for linux, p6)
Decreases (1 build for p6)
Full report (21 builds for efr32, k32w, linux, p6, qpg, telink)
|
rcasallas-silabs
force-pushed
the
groups_cluster_server
branch
from
November 18, 2021 09:35
16a793d
to
764fb1f
Compare
PR #11132: Size comparison from 2a7eaf0 to 764fb1f Increases above 0.2%:
Increases (3 builds for linux, p6)
Decreases (1 build for p6)
Full report (21 builds for efr32, k32w, linux, p6, qpg, telink)
|
rcasallas-silabs
force-pushed
the
groups_cluster_server
branch
from
November 19, 2021 18:19
764fb1f
to
aa6282a
Compare
rcasallas-silabs
force-pushed
the
groups_cluster_server
branch
from
November 19, 2021 18:32
aa6282a
to
ed04e83
Compare
PR #11132: Size comparison from 1adaf7a to ed04e83 Increases above 0.2%:
Increases (6 builds for esp32, linux, mbed, p6)
Decreases (2 builds for mbed, p6)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the Groups clusters server is implemented using the Ember binding table. The group related data should be stored and retrieved using the new Group data provider.
Change overview
Testing