-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QPG610x] Multi-Fabric Pool config changes #11119
Merged
woody-apple
merged 1 commit into
project-chip:master
from
jimlyall-q:multi-fabric_config-changes
Nov 3, 2021
Merged
[QPG610x] Multi-Fabric Pool config changes #11119
woody-apple
merged 1 commit into
project-chip:master
from
jimlyall-q:multi-fabric_config-changes
Nov 3, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst and
selissia
October 28, 2021 09:20
pullapprove
bot
requested review from
tecimovic,
vivien-apple,
wbschiller,
woody-apple and
yufengwangca
October 28, 2021 09:20
PR #11119: Size comparison from 36329e1 to 9307f9e Increases above 0.2%:
Increases (34 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (7 builds for esp32, mbed, p6)
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
msandstedt
reviewed
Oct 28, 2021
Running against which git hash? There was an unauthenticated session leak that was fixed recently.... @jimlyall-q See #10754 merged about a week ago. |
jmartinez-silabs
approved these changes
Oct 28, 2021
jimlyall-q
force-pushed
the
multi-fabric_config-changes
branch
from
October 29, 2021 10:45
9307f9e
to
ec2c897
Compare
PR #11119: Size comparison from 1e27d92 to ec2c897 Increases above 0.2%:
Increases (3 builds for qpg)
Decreases (1 build for esp32)
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Nov 2, 2021
emargolis
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
Change overview
Pool size changes to allow for available buffers
Testing
How was this tested? (at least one bullet point required)