-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use BitMapPool for SecureSessionTable #11110
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kghost
force-pushed
the
session-use-pool
branch
from
October 28, 2021 04:15
ecbb070
to
16c747b
Compare
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
erjiaqing,
franck-apple,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
mlepage-google,
msandstedt,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux and
tecimovic
October 28, 2021 04:15
pullapprove
bot
requested review from
turon,
vivien-apple,
wbschiller,
woody-apple,
yufengwangca and
yunhanw-google
October 28, 2021 04:16
PR #11110: Size comparison from 36329e1 to 16c747b Increases (26 builds for efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
Decreases (34 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Damian-Nordic
approved these changes
Oct 28, 2021
kghost
force-pushed
the
session-use-pool
branch
from
October 28, 2021 15:01
16c747b
to
a2b61a5
Compare
PR #11110: Size comparison from 79fac66 to a2b61a5 Increases (26 builds for efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
Decreases (34 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Oct 28, 2021
kghost
force-pushed
the
session-use-pool
branch
from
October 28, 2021 17:34
a2b61a5
to
97da3b9
Compare
PR #11110: Size comparison from 149e582 to 97da3b9 Increases (26 builds for efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
Decreases (34 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
kghost
force-pushed
the
session-use-pool
branch
from
October 28, 2021 18:59
97da3b9
to
e588ea9
Compare
PR #11110: Size comparison from 313cb4b to e588ea9 Increases (26 builds for efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
Decreases (34 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
approved these changes
Oct 29, 2021
kghost
force-pushed
the
session-use-pool
branch
from
October 29, 2021 06:52
e588ea9
to
9901df4
Compare
PR #11110: Size comparison from 1e27d92 to 9901df4 Increases (26 builds for efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
Decreases (34 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
emargolis
approved these changes
Oct 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Use BitMapPool for SecureSessionTable
BitMapPool
provides a more robust API than a array. constructors and destructors are called according to the lifecycle of the secure session object, so we can make some of its field to const.BitMapPool
will also have a POSIX implementation w/o capacity limitation using dynamic malloc.Change overview
Change sessions in
SecureSessionTable
into a BitMapPoolTesting
Verified by unit-tests