Make it possible to call Encode/Decode on a subclass of a cluster-object struct. #11014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect struct. Our enable_if machinery for Encode/Decode only worked for structs of type T if there was a T::Encode method. That made it impossible to subclass a struct (e.g. with the subclass providing backing storage for the struct's Spans) and call Encode on the subclass instance without jumping through some sort of testing hoops. This change changes our test from "T::Encode exists with the right signature" to "an instance of T has a .Encode that when called with the right arguments returns the right return type", which lets subclassing work as desired.
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
emargolis,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tecimovic,
vivien-apple and
wbschiller
pullapprove
bot
requested review from
woody-apple,
yufengwangca and
yunhanw-google
|
PR #11014: Size comparison from 4b1bc90 to 25b1796 Increases (1 build for esp32)
Full report (36 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Oct 27, 2021
yunhanw-google
approved these changes
Oct 27, 2021
mrjerryjohns
approved these changes
Oct 27, 2021
msandstedt
approved these changes
Oct 27, 2021
JasonLiuZhuoCheng
pushed a commit
to JasonLiuZhuoCheng/connectedhomeip
that referenced
this pull request
Oct 28, 2021
…ect struct. (project-chip#11014) Our enable_if machinery for Encode/Decode only worked for structs of type T if there was a T::Encode method. That made it impossible to subclass a struct (e.g. with the subclass providing backing storage for the struct's Spans) and call Encode on the subclass instance without jumping through some sort of testing hoops. This change changes our test from "T::Encode exists with the right signature" to "an instance of T has a .Encode that when called with the right arguments returns the right return type", which lets subclassing work as desired.
carol-apple
pushed a commit
to carol-apple/connectedhomeip
that referenced
this pull request
Oct 28, 2021
…ect struct. (project-chip#11014) Our enable_if machinery for Encode/Decode only worked for structs of type T if there was a T::Encode method. That made it impossible to subclass a struct (e.g. with the subclass providing backing storage for the struct's Spans) and call Encode on the subclass instance without jumping through some sort of testing hoops. This change changes our test from "T::Encode exists with the right signature" to "an instance of T has a .Encode that when called with the right arguments returns the right return type", which lets subclassing work as desired.
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
…ect struct. (project-chip#11014) Our enable_if machinery for Encode/Decode only worked for structs of type T if there was a T::Encode method. That made it impossible to subclass a struct (e.g. with the subclass providing backing storage for the struct's Spans) and call Encode on the subclass instance without jumping through some sort of testing hoops. This change changes our test from "T::Encode exists with the right signature" to "an instance of T has a .Encode that when called with the right arguments returns the right return type", which lets subclassing work as desired.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our enable_if machinery for Encode/Decode only worked for structs of
type T if there was a T::Encode method. That made it impossible to
subclass a struct (e.g. with the subclass providing backing storage
for the struct's Spans) and call Encode on the subclass instance
without jumping through some sort of testing hoops.
This change changes our test from "T::Encode exists with the right
signature" to "an instance of T has a .Encode that when called with
the right arguments returns the right return type", which lets
subclassing work as desired.
Problem
See above.
Change overview
See above.
Testing
Tree compiles.