Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Bridged Actions cluster (#10694) #10989

Merged
merged 5 commits into from
Oct 27, 2021
Merged

Add Bridged Actions cluster (#10694) #10989

merged 5 commits into from
Oct 27, 2021

Conversation

pjzander-signify
Copy link
Contributor

Problem

Implementation of issue #10694.
For bridged devices a Bridged Actions Cluster is required.
For the specification see: Connected Home over IP Specification, paragraph 9.14.

Change overview

  • Add a cluster description file for the Bridged Actions cluster.
  • Add the attributes and commands to the zap-file of chip-tool.
  • Add the attributes to the zap-file of the all-clusters-app.

Testing

  • Manual tested with the chip-tool and the bridge-app
  • Passed all Github workflows.

bzbarsky-apple
bzbarsky-apple reviewed Oct 27, 2021
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably best to mark the list-type attributes as external in the .zap file and register an attribute access interface for them, right?

@woody-apple
Copy link
Contributor

/rebase

@github-actions
Copy link

Size increase report for "esp32-example-build" from 4e2eeab

File Section File VM
chip-all-clusters-app.elf .flash.rodata 600 600
chip-all-clusters-app.elf .dram0.bss 0 512
chip-all-clusters-app.elf .flash.text 496 496
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,60352
.debug_line,0,14063
.debug_loc,0,11096
.debug_str,0,10920
.debug_ranges,0,3688
.debug_frame,0,1544
.flash.rodata,600,600
.dram0.bss,512,0
.flash.text,496,496
.debug_aranges,0,256
.strtab,0,97
.symtab,0,32
.shstrtab,0,3
.riscv.attributes,0,1
[Unmapped],0,-1096

@github-actions
Copy link

github-actions bot commented Oct 27, 2021 •
edited
Loading

PR #10989: Size comparison from b03b897 to 7b65177

Increases above 0.2%:

platform target config section b03b897 7b65177 change % change
linux all-clusters-app debug (read/write) 117472 118624 1152 1.0
.bss 50320 51344 1024 2.0
.data.rel.ro 60928 61056 128 0.2
.rodata 135477 136501 1024 0.8
chip-tool debug (read only) 4173517 4261925 88408 2.1
(read/write) 120896 122112 1216 1.0
.data.rel.ro 96208 97424 1216 1.3
.rodata 212400 213904 1504 0.7
.text 3701221 3785365 84144 2.3
lighting-app debug+rpc .rodata 127793 128785 992 0.8
Increases (3 builds for linux)
platform target config section b03b897 7b65177 change % change
linux all-clusters-app debug (read only) 1635553 1638497 2944 0.2
(read/write) 117472 118624 1152 1.0
.bss 50320 51344 1024 2.0
.data.rel.ro 60928 61056 128 0.2
.rodata 135477 136501 1024 0.8
.text 1368338 1370162 1824 0.1
chip-tool debug (read only) 4173517 4261925 88408 2.1
(read/write) 120896 122112 1216 1.0
.data.rel.ro 96208 97424 1216 1.3
.rodata 212400 213904 1504 0.7
.text 3701221 3785365 84144 2.3
lighting-app debug+rpc (read/write) 101520 101552 32 0.0
.data.rel.ro 53968 53984 16 0.0
.rodata 127793 128785 992 0.8
Decreases (6 builds for efr32, k32w, linux, qpg, telink)
platform target config section b03b897 7b65177 change % change
efr32 lighting-app BRD4161A (read only) 737080 736552 -528 -0.1
.text 737072 736544 -528 -0.1
BRD4161A+rpc (read only) 724508 723980 -528 -0.1
.text 724500 723972 -528 -0.1
k32w lighting-app k32w061+se05x+release (read/write) 701160 700904 -256 -0.0
.text 614740 614484 -256 -0.0
linux lighting-app debug+rpc (read only) 1528521 1526457 -2064 -0.1
.text 1268706 1265650 -3056 -0.2
qpg lighting-app qpg6100+debug (read only) 491328 491056 -272 -0.1
.text 486008 485736 -272 -0.1
telink lighting-app tlsr9518adk80d (read/write) 664606 664302 -304 -0.0
text 458202 457898 -304 -0.1
Full report (20 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section b03b897 7b65177 change % change
efr32 lighting-app BRD4161A (read only) 737080 736552 -528 -0.1
(read/write) 115444 115444 0 0.0
.bss 113692 113692 0 0.0
.data 1752 1752 0 0.0
.text 737072 736544 -528 -0.1
BRD4161A+rpc (read only) 724508 723980 -528 -0.1
(read/write) 132048 132048 0 0.0
.bss 130196 130196 0 0.0
.data 1852 1852 0 0.0
.text 724500 723972 -528 -0.1
lock-app BRD4161A (read only) 716344 716344 0 0.0
(read/write) 113260 113260 0 0.0
.bss 111548 111548 0 0.0
.data 1712 1712 0 0.0
.text 716336 716336 0 0.0
window-app BRD4161A (read only) 717264 717264 0 0.0
(read/write) 113588 113588 0 0.0
.bss 111868 111868 0 0.0
.data 1716 1716 0 0.0
.text 717256 717256 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 701160 700904 -256 -0.0
.bss 78720 78720 0 0.0
.data 1900 1900 0 0.0
.text 614740 614484 -256 -0.0
lock-app k32w061+debug (read/write) 592964 592964 0 0.0
.bss 69196 69196 0 0.0
.data 1864 1864 0 0.0
.text 516104 516104 0 0.0
shell k32w061+debug (read/write) 425252 425252 0 0.0
.bss 63256 63256 0 0.0
.data 672 672 0 0.0
.text 359620 359620 0 0.0
linux all-clusters-app debug (read only) 1635553 1638497 2944 0.2
(read/write) 117472 118624 1152 1.0
.bss 50320 51344 1024 2.0
.data 978 978 0 0.0
.data.rel.ro 60928 61056 128 0.2
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 135477 136501 1024 0.8
.text 1368338 1370162 1824 0.1
bridge-app debug+rpc (read only) 1276829 1276829 0 0.0
(read/write) 85096 85096 0 0.0
.bss 51856 51856 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27272 27272 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 110620 110620 0 0.0
.text 1070869 1070869 0 0.0
chip-tool debug (read only) 4173517 4261925 88408 2.1
(read/write) 120896 122112 1216 1.0
.bss 17680 17680 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 96208 97424 1216 1.3
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 212400 213904 1504 0.7
.text 3701221 3785365 84144 2.3
lighting-app debug+rpc (read only) 1528521 1526457 -2064 -0.1
(read/write) 101520 101552 32 0.0
.bss 41176 41176 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 53968 53984 16 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 127793 128785 992 0.8
.text 1268706 1265650 -3056 -0.2
ota-provider-app debug (read only) 1236097 1236097 0 0.0
(read/write) 67776 67776 0 0.0
.bss 37440 37440 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24488 24488 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110920 110920 0 0.0
.text 1029218 1029218 0 0.0
ota-requestor-app debug (read only) 1293249 1293249 0 0.0
(read/write) 76296 76296 0 0.0
.bss 44992 44992 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25352 25352 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 127744 127744 0 0.0
.text 1067906 1067906 0 0.0
shell debug (read only) 779929 779929 0 0.0
(read/write) 57376 57376 0 0.0
.bss 16136 16136 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36496 36496 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 76463 76463 0 0.0
.text 602338 602338 0 0.0
tv-app debug (read only) 1755353 1755353 0 0.0
(read/write) 281432 281432 0 0.0
.bss 215568 215568 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58192 58192 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 152888 152888 0 0.0
.text 1460754 1460754 0 0.0
p6 lock-app default (read/write) 2169160 2169160 0 0.0
.bss 67184 67184 0 0.0
.data 2416 2416 0 0.0
.heap 963744 963744 0 0.0
.text 1127424 1127424 0 0.0
qpg lighting-app qpg6100+debug (read only) 491328 491056 -272 -0.1
(read/write) 114144 114144 0 0.0
.bss 52416 52416 0 0.0
.data 1000 1000 0 0.0
.text 486008 485736 -272 -0.1
lock-app qpg6100+debug (read only) 467548 467548 0 0.0
(read/write) 114140 114140 0 0.0
.bss 51368 51368 0 0.0
.data 956 956 0 0.0
.text 462228 462228 0 0.0
persistent-storage-app qpg6100+debug (read only) 155244 155244 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 149924 149924 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 664606 664302 -304 -0.0
bss 69944 69944 0 0.0
noinit 33216 33216 0 0.0
text 458202 457898 -304 -0.1

@github-actions
Copy link

github-actions bot commented Oct 27, 2021 •
edited
Loading

PR #10989: Size comparison from 837bd28 to c21d6ed

Increases above 0.2%:

platform target config section 837bd28 c21d6ed change % change
esp32 all-clusters-app c3devkit .dram0.bss 58248 59272 1024 1.8
.flash.rodata 198568 199672 1104 0.6
m5stack (read/write) 426312 428456 2144 0.5
.dram0.bss 60752 61784 1032 1.7
.flash.rodata 207312 208424 1112 0.5
linux all-clusters-app debug (read/write) 117472 118624 1152 1.0
.bss 50320 51344 1024 2.0
.rodata 135477 136501 1024 0.8
chip-tool debug (read only) 4178413 4266805 88392 2.1
(read/write) 120896 122112 1216 1.0
.data.rel.ro 96208 97424 1216 1.3
.rodata 212496 213968 1472 0.7
.text 3706021 3790181 84160 2.3
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 179612 180644 1032 0.6
Increases (5 builds for esp32, linux, mbed)
platform target config section 837bd28 c21d6ed change % change
esp32 all-clusters-app c3devkit (read only) 875950 876446 496 0.1
(read/write) 1306520 1308648 2128 0.2
.dram0.bss 58248 59272 1024 1.8
.flash.rodata 198568 199672 1104 0.6
.flash.text 875950 876446 496 0.1
m5stack (read only) 907123 907519 396 0.0
(read/write) 426312 428456 2144 0.5
.dram0.bss 60752 61784 1032 1.7
.flash.rodata 207312 208424 1112 0.5
.flash.text 907123 907519 396 0.0
linux all-clusters-app debug (read only) 1635553 1638497 2944 0.2
(read/write) 117472 118624 1152 1.0
.bss 50320 51344 1024 2.0
.data.rel.ro 60928 61056 128 0.2
.rodata 135477 136501 1024 0.8
.text 1368338 1370162 1824 0.1
chip-tool debug (read only) 4178413 4266805 88392 2.1
(read/write) 120896 122112 1216 1.0
.data.rel.ro 96208 97424 1216 1.3
.rodata 212496 213968 1472 0.7
.text 3706021 3790181 84160 2.3
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2288776 2290328 1552 0.1
.bss 179612 180644 1032 0.6
.text 1251376 1252928 1552 0.1
Decreases (1 build for mbed)
platform target config section 837bd28 c21d6ed change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 851640 850608 -1032 -0.1
Full report (36 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 837bd28 c21d6ed change % change
efr32 lighting-app BRD4161A (read only) 737080 737080 0 0.0
(read/write) 115444 115444 0 0.0
.bss 113692 113692 0 0.0
.data 1752 1752 0 0.0
.text 737072 737072 0 0.0
BRD4161A+rpc (read only) 724508 724508 0 0.0
(read/write) 132048 132048 0 0.0
.bss 130196 130196 0 0.0
.data 1852 1852 0 0.0
.text 724500 724500 0 0.0
lock-app BRD4161A (read only) 716344 716344 0 0.0
(read/write) 113260 113260 0 0.0
.bss 111548 111548 0 0.0
.data 1712 1712 0 0.0
.text 716336 716336 0 0.0
window-app BRD4161A (read only) 717264 717264 0 0.0
(read/write) 113588 113588 0 0.0
.bss 111868 111868 0 0.0
.data 1716 1716 0 0.0
.text 717256 717256 0 0.0
esp32 all-clusters-app c3devkit (read only) 875950 876446 496 0.1
(read/write) 1306520 1308648 2128 0.2
.dram0.bss 58248 59272 1024 1.8
.dram0.data 16464 16464 0 0.0
.flash.rodata 198568 199672 1104 0.6
.flash.text 875950 876446 496 0.1
.iram0.text 57564 57564 0 0.0
m5stack (read only) 907123 907519 396 0.0
(read/write) 426312 428456 2144 0.5
.dram0.bss 60752 61784 1032 1.7
.dram0.data 32084 32084 0 0.0
.flash.rodata 207312 208424 1112 0.5
.flash.text 907123 907519 396 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 701048 701048 0 0.0
.bss 78720 78720 0 0.0
.data 1900 1900 0 0.0
.text 614628 614628 0 0.0
lock-app k32w061+debug (read/write) 592964 592964 0 0.0
.bss 69196 69196 0 0.0
.data 1864 1864 0 0.0
.text 516104 516104 0 0.0
shell k32w061+debug (read/write) 425252 425252 0 0.0
.bss 63256 63256 0 0.0
.data 672 672 0 0.0
.text 359620 359620 0 0.0
linux all-clusters-app debug (read only) 1635553 1638497 2944 0.2
(read/write) 117472 118624 1152 1.0
.bss 50320 51344 1024 2.0
.data 978 978 0 0.0
.data.rel.ro 60928 61056 128 0.2
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 135477 136501 1024 0.8
.text 1368338 1370162 1824 0.1
bridge-app debug+rpc (read only) 1276829 1276829 0 0.0
(read/write) 85096 85096 0 0.0
.bss 51856 51856 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27272 27272 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 110620 110620 0 0.0
.text 1070869 1070869 0 0.0
chip-tool debug (read only) 4178413 4266805 88392 2.1
(read/write) 120896 122112 1216 1.0
.bss 17680 17680 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 96208 97424 1216 1.3
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 212496 213968 1472 0.7
.text 3706021 3790181 84160 2.3
lighting-app debug+rpc (read only) 1528521 1528521 0 0.0
(read/write) 101520 101520 0 0.0
.bss 41176 41176 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 53968 53968 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 127793 127793 0 0.0
.text 1268706 1268706 0 0.0
ota-provider-app debug (read only) 1236097 1236097 0 0.0
(read/write) 67776 67776 0 0.0
.bss 37440 37440 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24488 24488 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110920 110920 0 0.0
.text 1029218 1029218 0 0.0
ota-requestor-app debug (read only) 1298449 1298449 0 0.0
(read/write) 76520 76520 0 0.0
.bss 45216 45216 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25352 25352 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 127744 127744 0 0.0
.text 1073106 1073106 0 0.0
shell debug (read only) 779929 779929 0 0.0
(read/write) 57376 57376 0 0.0
.bss 16136 16136 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36496 36496 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 76463 76463 0 0.0
.text 602338 602338 0 0.0
tv-app debug (read only) 1756009 1756009 0 0.0
(read/write) 289112 289112 0 0.0
.bss 223248 223248 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58192 58192 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 152888 152888 0 0.0
.text 1461410 1461410 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2288776 2290328 1552 0.1
.bss 179612 180644 1032 0.6
.data 5192 5192 0 0.0
.heap 851640 850608 -1032 -0.1
.text 1251376 1252928 1552 0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2255960 2255960 0 0.0
.bss 171060 171060 0 0.0
.data 5464 5464 0 0.0
.heap 859920 859920 0 0.0
.text 1218560 1218560 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2233992 2233992 0 0.0
.bss 169988 169988 0 0.0
.data 5432 5432 0 0.0
.heap 861024 861024 0 0.0
.text 1196592 1196592 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139680 1139680 0 0.0
.bss 11760 11760 0 0.0
.data 4360 4360 0 0.0
.heap 1020328 1020328 0 0.0
.text 103064 103064 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 862903 862903 0 0.0
bss 112136 112136 0 0.0
rodata 97504 97504 0 0.0
text 577632 577632 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 823743 823743 0 0.0
bss 108380 108380 0 0.0
rodata 88280 88280 0 0.0
text 550824 550824 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 787926 787926 0 0.0
bss 113512 113512 0 0.0
rodata 92744 92744 0 0.0
text 507104 507104 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 839847 839847 0 0.0
bss 111208 111208 0 0.0
rodata 93904 93904 0 0.0
text 559192 559192 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764874 764874 0 0.0
bss 112584 112584 0 0.0
rodata 89164 89164 0 0.0
text 488656 488656 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497339 497339 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339456 339456 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844247 844247 0 0.0
bss 111308 111308 0 0.0
rodata 95104 95104 0 0.0
text 562296 562296 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 839567 839567 0 0.0
bss 111208 111208 0 0.0
rodata 93880 93880 0 0.0
text 558936 558936 0 0.0
shell nrf52840dk_nrf52840 (read/write) 776435 776435 0 0.0
bss 109072 109072 0 0.0
rodata 72536 72536 0 0.0
text 520232 520232 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691490 691490 0 0.0
bss 110056 110056 0 0.0
rodata 67180 67180 0 0.0
text 440844 440844 0 0.0
p6 lock-app default (read/write) 2169160 2169160 0 0.0
.bss 67184 67184 0 0.0
.data 2416 2416 0 0.0
.heap 963744 963744 0 0.0
.text 1127424 1127424 0 0.0
qpg lighting-app qpg6100+debug (read only) 491224 491224 0 0.0
(read/write) 114144 114144 0 0.0
.bss 52416 52416 0 0.0
.data 1000 1000 0 0.0
.text 485904 485904 0 0.0
lock-app qpg6100+debug (read only) 467548 467548 0 0.0
(read/write) 114140 114140 0 0.0
.bss 51368 51368 0 0.0
.data 956 956 0 0.0
.text 462228 462228 0 0.0
persistent-storage-app qpg6100+debug (read only) 155244 155244 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 149924 149924 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 664606 664606 0 0.0
bss 69944 69944 0 0.0
noinit 33216 33216 0 0.0
text 458202 458202 0 0.0

@woody-apple woody-apple added this to the Test Event 7 milestone Oct 27, 2021
@woody-apple
Copy link
Contributor

@saurabhst @Damian-Nordic @andy31415 @mspang ?

@woody-apple
Copy link
Contributor

Device vendor changing device code, fast tracking.

@woody-apple woody-apple merged commit 321f93c into project-chip:master Oct 27, 2021
@bzbarsky-apple
Copy link
Contributor

@pjzander-signify Why did this land with the .bss increases? What was the motivation for c21d6ed and why was the review comment left resolved when the resolution was reverted?

@pjzander-signify pjzander-signify deleted the issue_10694_2 branch October 28, 2021 08:37
JasonLiuZhuoCheng pushed a commit to JasonLiuZhuoCheng/connectedhomeip that referenced this pull request Oct 28, 2021
@pjzander-signify @JasonLiuZhuoCheng
Add Bridged Actions cluster (project-chip#10694) (project-chip#10989)
77241cc 
* Add Bridged Actions Cluster

* Replace OCTET_STRING with now supported CHAR_STRING

* Remove the Bridged Actions cluster commands from the all-clusters-app

* Make some Bridge Actions cluster attributes external

* Revert setting some Bridge Actions attributes to external
carol-apple pushed a commit to carol-apple/connectedhomeip that referenced this pull request Oct 28, 2021
@pjzander-signify @carol-apple
Add Bridged Actions cluster (project-chip#10694) (project-chip#10989)
6d02270 
* Add Bridged Actions Cluster

* Replace OCTET_STRING with now supported CHAR_STRING

* Remove the Bridged Actions cluster commands from the all-clusters-app

* Make some Bridge Actions cluster attributes external

* Revert setting some Bridge Actions attributes to external
@pjzander-signify pjzander-signify linked an issue Nov 3, 2021 that may be closed by this pull request
Add a bridged switched device to the bridge app #10302
Closed
@pjzander-signify pjzander-signify removed a link to an issue Nov 3, 2021
Add a bridged switched device to the bridge app #10302
Closed
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@pjzander-signify
Add Bridged Actions cluster (project-chip#10694) (project-chip#10989)
67079ac 
* Add Bridged Actions Cluster

* Replace OCTET_STRING with now supported CHAR_STRING

* Remove the Bridged Actions cluster commands from the all-clusters-app

* Make some Bridge Actions cluster attributes external

* Revert setting some Bridge Actions attributes to external
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple left review comments

@woody-apple woody-apple woody-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@andy31415 andy31415 Awaiting requested review from andy31415

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

Assignees
No one assigned
Labels
app controller darwin examples fast track review - pending
Projects
None yet
Milestone
Test Event 7
Development

Successfully merging this pull request may close these issues.
3 participants
@pjzander-signify @woody-apple @bzbarsky-apple