-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ChipDnssdPublishService and ChipDnssdRemoveServices imp on android platform #10971
Conversation
PR #10971: Size comparison from 4ab05ae to 1f4f4c4 8 builds (for k32w, p6, qpg, telink)
16 builds (for efr32, linux, mbed)
10 builds (for nrfconnect)
2 builds (for esp32)
|
src/platform/android/java/chip/platform/NsdManagerServiceResolver.java
Outdated
Show resolved
Hide resolved
Fast tracking, platform maintainer changing platform code |
Holding pending feedback from @Damian-Nordic |
src/platform/android/java/chip/platform/NsdManagerServiceResolver.java
Outdated
Show resolved
Hide resolved
src/platform/android/java/chip/platform/NsdManagerServiceResolver.java
Outdated
Show resolved
Hide resolved
src/platform/android/java/chip/platform/NsdManagerServiceResolver.java
Outdated
Show resolved
Hide resolved
953a9bf
to
5ec45de
Compare
PR #10971: Size comparison from 9b8410f to 5ec45de Full report (20 builds for efr32, k32w, linux, p6, qpg, telink)
|
5ec45de
to
200152c
Compare
Anyone know this issue? I did not change these 2 files at all. git add . |
/rebase |
Rebasing these. |
200152c
to
7f2bc85
Compare
1. publish and remove return void 2. remove -> removeServices 3. import for detail packages 4. naming consistent 5. remove DeleteLocalRef
7f2bc85
to
c830217
Compare
PR #10971: Size comparison from 3249310 to c830217 Full report (36 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
…oid platform (project-chip#10971) * added publish and remove for dnssd in android platform * fix CHIPTest AS build error * fix crash issue in dnssdimpl, DeleteRef error * added java imp for dnssd * fix restyled errors * fix review issues: 1. publish and remove return void 2. remove -> removeServices 3. import for detail packages 4. naming consistent 5. remove DeleteLocalRef
…oid platform (project-chip#10971) * added publish and remove for dnssd in android platform * fix CHIPTest AS build error * fix crash issue in dnssdimpl, DeleteRef error * added java imp for dnssd * fix restyled errors * fix review issues: 1. publish and remove return void 2. remove -> removeServices 3. import for detail packages 4. naming consistent 5. remove DeleteLocalRef
…oid platform (project-chip#10971) * added publish and remove for dnssd in android platform * fix CHIPTest AS build error * fix crash issue in dnssdimpl, DeleteRef error * added java imp for dnssd * fix restyled errors * fix review issues: 1. publish and remove return void 2. remove -> removeServices 3. import for detail packages 4. naming consistent 5. remove DeleteLocalRef
Problem
Change overview
Testing