[Mbed] Add RPC support for locking and lighting examples #10960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create common RPC service run function Add RPC support for lock and lighting apps Add button event handler to lock app task
Changes restyle
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
emargolis,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
pan-apple,
robszewczyk and
sagar-apple
pullapprove
bot
requested review from
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vivien-apple,
wbschiller,
woody-apple,
yufengwangca and
yunhanw-google
|
Any chance you could add build support using |
|
@andy31415 Do you mean build Mbed examples using |
woody-apple
approved these changes
Oct 27, 2021
|
Fast tracking, platform maintainer updating platform code |
woody-apple
added a commit
that referenced
this pull request
Oct 27, 2021
)" This reverts commit 2149dae.
JasonLiuZhuoCheng
pushed a commit
to JasonLiuZhuoCheng/connectedhomeip
that referenced
this pull request
Oct 28, 2021
…p#10960) * Add CONFIG_CHIP_PW_RPC flag to lock and lighting apps * Add more RPC services to Mbed build Create common RPC service run function Add RPC support for lock and lighting apps Add button event handler to lock app task * Fix Locking RPC service - changed locked variable type to boolen * Add AppTask reference in Rpc.cpp Changes restyle * Fix AppTask.h include
JasonLiuZhuoCheng
pushed a commit
to JasonLiuZhuoCheng/connectedhomeip
that referenced
this pull request
Oct 28, 2021
carol-apple
pushed a commit
to carol-apple/connectedhomeip
that referenced
this pull request
Oct 28, 2021
…p#10960) * Add CONFIG_CHIP_PW_RPC flag to lock and lighting apps * Add more RPC services to Mbed build Create common RPC service run function Add RPC support for lock and lighting apps Add button event handler to lock app task * Fix Locking RPC service - changed locked variable type to boolen * Add AppTask reference in Rpc.cpp Changes restyle * Fix AppTask.h include
carol-apple
pushed a commit
to carol-apple/connectedhomeip
that referenced
this pull request
Oct 28, 2021
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
…p#10960) * Add CONFIG_CHIP_PW_RPC flag to lock and lighting apps * Add more RPC services to Mbed build Create common RPC service run function Add RPC support for lock and lighting apps Add button event handler to lock app task * Fix Locking RPC service - changed locked variable type to boolen * Add AppTask reference in Rpc.cpp Changes restyle * Fix AppTask.h include
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Add RPC service support for lock-app and lighting-app examples.
Change overview
The changes are only Mbed platform-specific.
Add device, button, lighting, and locking RPC services to Mbed build
Create a common Mbed RPC service source (initialization and run RPC service) for each RPC supported example
Add a button event handler to lock app task
Fix Locking RPC service - changed the locked variable type to boolean
Testing
Build and run examples manually, check with RPC console.