[Python] Add write and read API with cluster object support #10949

erjiaqing · 2021-10-26T06:00:21Z

Problem

Python's attribute read and write does not use cluster objects

Change overview

Use cluster objects for read and write attributes.

Testing

Updates src/controller/python/test/test_scripts/cluster_objects.py
The encoding and decoding tests are in src/controller/python/test/unit_tests/test_cluster_objects.py

todo · 2021-10-26T06:00:23Z

Here, we translates multi attribute read into many individual attribute reads, this should be fixed by implementing Python's attribute read API.

connectedhomeip/src/controller/python/chip/ChipDeviceCtrl.py

Lines 380 to 390 in 3b63919

    
           # TODO: Here, we translates multi attribute read into many individual attribute reads, this should be fixed by implementing Python's attribute read API. 
        
           res = [] 
        
           for attr in attributes: 
        
               clusterInfo = self._Cluster.GetClusterInfoById( 
        
                   attr.Attribute.cluster_id) 
        
               if not clusterInfo: 
        
                   raise UnknownCluster(attr.Attribute.cluster_id) 
        
               attributeInfo = clusterInfo.get("attributes", {}).get( 
        
                   attr.Attribute.attribute_id, None) 
        
               if not attributeInfo: 
        
                   raise UnknownAttribute(

This comment was generated by todo based on a `TODO` comment in `3b63919` in #10949. cc @erjiaqing.

todo · 2021-10-26T06:01:42Z

Here, we translates multi attribute read into many individual attribute reads, this should be fixed by implementing Python's attribute read API.

connectedhomeip/src/controller/python/chip/ChipDeviceCtrl.py

Lines 380 to 390 in 5fedc38

    
           # TODO: Here, we translates multi attribute read into many individual attribute reads, this should be fixed by implementing Python's attribute read API. 
        
           res = [] 
        
           for attr in attributes: 
        
               clusterInfo = self._Cluster.GetClusterInfoById( 
        
                   attr.Attribute.cluster_id) 
        
               if not clusterInfo: 
        
                   raise UnknownCluster(attr.Attribute.cluster_id) 
        
               attributeInfo = clusterInfo.get("attributes", {}).get( 
        
                   attr.Attribute.attribute_id, None) 
        
               if not attributeInfo: 
        
                   raise UnknownAttribute(

This comment was generated by todo based on a `TODO` comment in `5fedc38` in #10949. cc @erjiaqing.

github-actions · 2021-10-26T06:26:03Z

PR #10949: Size comparison from 341c00d to 5fedc38

8 builds (for k32w, p6, qpg, telink)

platform	target	config	section	`341c00d`	`5fedc38`
k32w	lock-app	k32w061+debug	.bss	69196	69196
			.data	1864	1864
			.text	515140	515140
	shell	k32w061+debug	.bss	63256	63256
			.data	672	672
			.text	359572	359572
	lighting-app	k32w061+se05x+release	.bss	78712	78712
			.data	1900	1900
			.text	613776	613776
p6	lock-app	default	.bss	67176	67176
			.data	2416	2416
			.heap	963752	963752
			.text	1126088	1126088
qpg	lighting-app	qpg6100+debug	.bss	52416	52416
			.data	1000	1000
			.text	485044	485044
	lock-app	qpg6100+debug	.bss	51360	51360
			.data	956	956
			.text	461264	461264
	persistent-storage-app	qpg6100+debug	.bss	27752	27752
			.data	372	372
			.text	149900	149900
telink	lighting-app	tlsr9518adk80d	bss	69940	69940
			noinit	33216	33216
			text	457672	457672

4 builds (for efr32)

platform	target	config	section	`341c00d`	`5fedc38`
efr32	lighting-app	BRD4161A	.bss	113684	113684
			.data	1752	1752
			.text	735816	735816
	lock-app	BRD4161A	.bss	111540	111540
			.data	1712	1712
			.text	715080	715080
	window-app	BRD4161A	.bss	111852	111852
			.data	1716	1716
			.text	715876	715876
	lighting-app	BRD4161A+rpc	.bss	130188	130188
			.data	1852	1852
			.text	723232	723232

4 builds (for mbed)

platform	target	config	section	`341c00d`	`5fedc38`
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	.bss	179604	179604
			.data	5192	5192
			.heap	851648	851648
			.text	1251552	1251552
	lighting-app	CY8CPROTO_062_4343W+release	.bss	171060	171060
			.data	5464	5464
			.heap	859920	859920
			.text	1219256	1219256
	lock-app	CY8CPROTO_062_4343W+release	.bss	169980	169980
			.data	5432	5432
			.heap	861032	861032
			.text	1197280	1197280
	pigweed-app	CY8CPROTO_062_4343W+release	.bss	11760	11760
			.data	4360	4360
			.heap	1020328	1020328
			.text	103064	103064

2 builds (for esp32)

platform	target	config	section	`341c00d`	`5fedc38`
esp32	all-clusters-app	c3devkit	.dram0.bss	58232	58232
			.dram0.data	16464	16464
			.flash.rodata	198072	198072
			.flash.text	874742	874742
			.iram0.text	57564	57564
		m5stack	.dram0.bss	60744	60744
			.dram0.data	32084	32084
			.flash.rodata	206832	206832
			.flash.text	905895	905895
			.iram0.text	125115	125115

10 builds (for nrfconnect)

platform	target	config	section	`341c00d`	`5fedc38`
nrfconnect	lighting-app	nrf52840dk_nrf52840	bss	112136	112136
			rodata	97100	97100
			text	577204	577204
	lock-app	nrf52840dk_nrf52840	bss	111208	111208
			rodata	93500	93500
			text	558764	558764
	pigweed-app	nrf52840dk_nrf52840	bss	51824	51824
			rodata	45776	45776
			text	339456	339456
	pump-app	nrf52840dk_nrf52840	bss	111308	111308
			rodata	94700	94700
			text	561868	561868
	pump-controller-app	nrf52840dk_nrf52840	bss	111204	111204
			rodata	93476	93476
			text	558508	558508
	shell	nrf52840dk_nrf52840	bss	109072	109072
			rodata	72536	72536
			text	520324	520324
	lighting-app	nrf52840dk_nrf52840+rpc	bss	108376	108376
			rodata	87876	87876
			text	550396	550396
		nrf5340dk_nrf5340_cpuapp	bss	113508	113508
			rodata	92340	92340
			text	506676	506676
	lock-app	nrf5340dk_nrf5340_cpuapp	bss	112580	112580
			rodata	88760	88760
			text	488228	488228
	shell	nrf5340dk_nrf5340_cpuapp	bss	110056	110056
			rodata	67180	67180
			text	440936	440936

erjiaqing · 2021-10-26T13:54:03Z

/rebase

src/controller/python/chip/clusters/Attribute.py

todo · 2021-10-28T08:06:57Z

Here, we translates multi attribute read into many individual attribute reads, this should be fixed by implementing Python's attribute read API.

connectedhomeip/src/controller/python/chip/ChipDeviceCtrl.py

Lines 386 to 396 in 149b8ae

    
           # TODO: Here, we translates multi attribute read into many individual attribute reads, this should be fixed by implementing Python's attribute read API. 
        
           res = [] 
        
           for attr in attributes: 
        
               attr.EndpointId = attr[0] 
        
               attr.Attribute = attr[1] 
        
               clusterInfo = self._Cluster.GetClusterInfoById( 
        
                   attr.Attribute.cluster_id) 
        
               if not clusterInfo: 
        
                   raise UnknownCluster(attr.Attribute.cluster_id) 
        
               attributeInfo = clusterInfo.get("attributes", {}).get( 
        
                   attr.Attribute.attribute_id, None)

This comment was generated by todo based on a `TODO` comment in `149b8ae` in #10949. cc @erjiaqing.

todo · 2021-10-28T08:14:17Z

Here, we translates multi attribute read into many individual attribute reads, this should be fixed by implementing Python's attribute read API.

connectedhomeip/src/controller/python/chip/ChipDeviceCtrl.py

Lines 386 to 396 in 37e508f

    
           # TODO: Here, we translates multi attribute read into many individual attribute reads, this should be fixed by implementing Python's attribute read API. 
        
           res = [] 
        
           for attr in attributes: 
        
               endpointId = attr[0] 
        
               attribute = attr[1] 
        
               clusterInfo = self._Cluster.GetClusterInfoById( 
        
                   attribute.cluster_id) 
        
               if not clusterInfo: 
        
                   raise UnknownCluster(attribute.cluster_id) 
        
               attributeInfo = clusterInfo.get("attributes", {}).get( 
        
                   attribute.attribute_id, None)

This comment was generated by todo based on a `TODO` comment in `37e508f` in #10949. cc @erjiaqing.

github-actions · 2021-10-28T08:38:42Z

PR #10949: Size comparison from 36329e1 to 37e508f

Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	`36329e1`	`37e508f`
efr32	lighting-app	BRD4161A	(read only)	737476	737476
			(read/write)	115428	115428
			.bss	113676	113676
			.data	1752	1752
			.text	737468	737468
		BRD4161A+rpc	(read only)	724916	724916
			(read/write)	132032	132032
			.bss	130180	130180
			.data	1852	1852
			.text	724908	724908
	lock-app	BRD4161A	(read only)	716756	716756
			(read/write)	113244	113244
			.bss	111532	111532
			.data	1712	1712
			.text	716748	716748
	window-app	BRD4161A	(read only)	717660	717660
			(read/write)	113568	113568
			.bss	111852	111852
			.data	1716	1716
			.text	717652	717652
esp32	all-clusters-app	c3devkit	(read only)	875926	875926
			(read/write)	1308672	1308672
			.dram0.bss	59248	59248
			.dram0.data	16448	16448
			.flash.rodata	199744	199744
			.flash.text	875926	875926
			.iram0.text	57554	57554
		m5stack	(read only)	907187	907187
			(read/write)	428460	428460
			.dram0.bss	61744	61744
			.dram0.data	32084	32084
			.flash.rodata	208468	208468
			.flash.text	907187	907187
			.iram0.text	125115	125115
k32w	lighting-app	k32w061+se05x+release	(read/write)	701024	701024
			.bss	78688	78688
			.data	1900	1900
			.text	614636	614636
	lock-app	k32w061+debug	(read/write)	592980	592980
			.bss	69172	69172
			.data	1864	1864
			.text	516144	516144
	shell	k32w061+debug	(read/write)	425252	425252
			.bss	63256	63256
			.data	672	672
			.text	359620	359620
linux	all-clusters-app	debug	(read only)	`1653505`	`1653505`
			(read/write)	119136	119136
			.bss	51376	51376
			.data	978	978
			.data.rel.ro	61536	61536
			.dynamic	592	592
			.got	4088	4088
			.init	27	27
			.init_array	520	520
			.rodata	137845	137845
			.text	1383346	1383346
	bridge-app	debug+rpc	(read only)	1282421	1282421
			(read/write)	85192	85192
			.bss	51856	51856
			.data	976	976
			.data.rel.ro	27368	27368
			.dynamic	592	592
			.got	3952	3952
			.init	27	27
			.init_array	400	400
			.rodata	110812	110812
			.text	1076245	1076245
	chip-tool	debug	(read only)	4262469	4262469
			(read/write)	122208	122208
			.bss	17680	17680
			.data	1584	1584
			.data.rel.ro	97536	97536
			.dynamic	592	592
			.got	4368	4368
			.init	27	27
			.init_array	424	424
			.rodata	214032	214032
			.text	3785589	3785589
	lighting-app	debug+rpc	(read only)	`1541401`	`1541401`
			(read/write)	102032	102032
			.bss	41208	41208
			.data	1106	1106
			.data.rel.ro	54448	54448
			.dynamic	608	608
			.got	4112	4112
			.init	27	27
			.init_array	528	528
			.rodata	128977	128977
			.text	`1279922`	`1279922`
	ota-provider-app	debug	(read only)	1238937	1238937
			(read/write)	67904	67904
			.bss	37440	37440
			.data	752	752
			.data.rel.ro	24616	24616
			.dynamic	592	592
			.got	4016	4016
			.init	27	27
			.init_array	440	440
			.rodata	110984	110984
			.text	1031730	1031730
	ota-requestor-app	debug	(read only)	1301033	1301033
			(read/write)	76648	76648
			.bss	45216	45216
			.data	816	816
			.data.rel.ro	25496	25496
			.dynamic	592	592
			.got	3984	3984
			.init	27	27
			.init_array	512	512
			.rodata	127680	127680
			.text	`1075490`	`1075490`
	shell	debug	(read only)	787361	787361
			(read/write)	57792	57792
			.bss	16168	16168
			.data	242	242
			.data.rel.ro	36880	36880
			.dynamic	592	592
			.got	3528	3528
			.init	27	27
			.init_array	336	336
			.rodata	77519	77519
			.text	608258	608258
	tv-app	debug	(read only)	`1774529`	`1774529`
			(read/write)	289656	289656
			.bss	223280	223280
			.data	2032	2032
			.data.rel.ro	58704	58704
			.dynamic	592	592
			.got	4408	4408
			.init	27	27
			.init_array	608	608
			.rodata	154776	154776
			.text	1477442	1477442
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2290664	2290664
			.bss	180620	180620
			.data	5192	5192
			.heap	850632	850632
			.text	1253264	1253264
	lighting-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2274992	2274992
			.bss	172820	172820
			.data	5568	5568
			.heap	858056	858056
			.text	`1237592`	`1237592`
	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	`2252712`	`2252712`
			.bss	171724	171724
			.data	5552	5552
			.heap	859168	859168
			.text	1215312	1215312
	pigweed-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	1139744	1139744
			.bss	11752	11752
			.data	4368	4368
			.heap	1020328	1020328
			.text	103128	103128
	shell	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	`2048984`	`2048984`
			.bss	156208	156208
			.data	4968	4968
			.heap	875272	875272
			.text	1011584	1011584
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	862911	862911
			bss	112132	112132
			rodata	97528	97528
			text	577624	577624
		nrf52840dk_nrf52840+rpc	(read/write)	823735	823735
			bss	108372	108372
			rodata	88304	88304
			text	550800	550800
		nrf5340dk_nrf5340_cpuapp	(read/write)	787902	787902
			bss	113504	113504
			rodata	92768	92768
			text	507092	507092
	lock-app	nrf52840dk_nrf52840	(read/write)	839583	839583
			bss	111168	111168
			rodata	93880	93880
			text	559108	559108
		nrf5340dk_nrf5340_cpuapp	(read/write)	764882	764882
			bss	112576	112576
			rodata	89188	89188
			text	488668	488668
	pigweed-app	nrf52840dk_nrf52840	(read/write)	497323	497323
			bss	51824	51824
			rodata	45776	45776
			text	339436	339436
	pump-app	nrf52840dk_nrf52840	(read/write)	844287	844287
			bss	111304	111304
			rodata	95128	95128
			text	562320	562320
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	839575	839575
			bss	111200	111200
			rodata	93904	93904
			text	558952	558952
	shell	nrf52840dk_nrf52840	(read/write)	776435	776435
			bss	109072	109072
			rodata	72536	72536
			text	520236	520236
		nrf5340dk_nrf5340_cpuapp	(read/write)	691490	691490
			bss	110056	110056
			rodata	67180	67180
			text	440848	440848
p6	lock-app	default	(read/write)	2169096	2169096
			.bss	67168	67168
			.data	2416	2416
			.heap	963760	963760
			.text	1127360	1127360
qpg	lighting-app	qpg6100+debug	(read only)	491240	491240
			(read/write)	114144	114144
			.bss	52400	52400
			.data	1000	1000
			.text	485920	485920
	lock-app	qpg6100+debug	(read only)	467580	467580
			(read/write)	114140	114140
			.bss	51352	51352
			.data	956	956
			.text	462260	462260
	persistent-storage-app	qpg6100+debug	(read only)	155244	155244
			(read/write)	114140	114140
			.bss	27752	27752
			.data	372	372
			.text	149924	149924
telink	lighting-app	tlsr9518adk80d	(read/write)	664518	664518
			bss	69944	69944
			noinit	33216	33216
			text	458068	458068

todo · 2021-10-28T16:07:09Z

Here, we translates multi attribute read into many individual attribute reads, this should be fixed by implementing Python's attribute read API.

connectedhomeip/src/controller/python/chip/ChipDeviceCtrl.py

Lines 386 to 396 in 3ba9f08

    
           # TODO: Here, we translates multi attribute read into many individual attribute reads, this should be fixed by implementing Python's attribute read API. 
        
           res = [] 
        
           for attr in attributes: 
        
               endpointId = attr[0] 
        
               attribute = attr[1] 
        
               clusterInfo = self._Cluster.GetClusterInfoById( 
        
                   attribute.cluster_id) 
        
               if not clusterInfo: 
        
                   raise UnknownCluster(attribute.cluster_id) 
        
               attributeInfo = clusterInfo.get("attributes", {}).get( 
        
                   attribute.attribute_id, None)

This comment was generated by todo based on a `TODO` comment in `3ba9f08` in #10949. cc @erjiaqing.

github-actions · 2021-10-28T16:40:45Z

PR #10949: Size comparison from 36329e1 to 3ba9f08

Decreases (3 builds for esp32, qpg)

platform	target	config	section	`36329e1`	`3ba9f08`	change	% change
esp32	all-clusters-app	m5stack	(read only)	907275	907187	-88	-0.0
			.flash.text	907275	907187	-88	-0.0
qpg	lighting-app	qpg6100+debug	(read only)	491240	491224	-16	-0.0
			.bss	52400	51288	-1112	-2.1
			.text	485920	485904	-16	-0.0
	lock-app	qpg6100+debug	(read only)	467580	467556	-24	-0.0
			.bss	51352	50240	-1112	-2.2
			.text	462260	462236	-24	-0.0

Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	`36329e1`	`3ba9f08`	change	% change
efr32	lighting-app	BRD4161A	(read only)	737476	737476	0	0.0
			(read/write)	115428	115428	0	0.0
			.bss	113676	113676	0	0.0
			.data	1752	1752	0	0.0
			.text	737468	737468	0	0.0
		BRD4161A+rpc	(read only)	724916	724916	0	0.0
			(read/write)	132032	132032	0	0.0
			.bss	130180	130180	0	0.0
			.data	1852	1852	0	0.0
			.text	724908	724908	0	0.0
	lock-app	BRD4161A	(read only)	716756	716756	0	0.0
			(read/write)	113244	113244	0	0.0
			.bss	111532	111532	0	0.0
			.data	1712	1712	0	0.0
			.text	716748	716748	0	0.0
	window-app	BRD4161A	(read only)	717660	717660	0	0.0
			(read/write)	113568	113568	0	0.0
			.bss	111852	111852	0	0.0
			.data	1716	1716	0	0.0
			.text	717652	717652	0	0.0
esp32	all-clusters-app	c3devkit	(read only)	875926	875926	0	0.0
			(read/write)	1308672	1308672	0	0.0
			.dram0.bss	59248	59248	0	0.0
			.dram0.data	16448	16448	0	0.0
			.flash.rodata	199744	199744	0	0.0
			.flash.text	875926	875926	0	0.0
			.iram0.text	57554	57554	0	0.0
		m5stack	(read only)	907275	907187	-88	-0.0
			(read/write)	428460	428460	0	0.0
			.dram0.bss	61744	61744	0	0.0
			.dram0.data	32084	32084	0	0.0
			.flash.rodata	208468	208468	0	0.0
			.flash.text	907275	907187	-88	-0.0
			.iram0.text	125115	125115	0	0.0
k32w	lighting-app	k32w061+se05x+release	(read/write)	701024	701024	0	0.0
			.bss	78688	78688	0	0.0
			.data	1900	1900	0	0.0
			.text	614636	614636	0	0.0
	lock-app	k32w061+debug	(read/write)	592980	592980	0	0.0
			.bss	69172	69172	0	0.0
			.data	1864	1864	0	0.0
			.text	516144	516144	0	0.0
	shell	k32w061+debug	(read/write)	425252	425252	0	0.0
			.bss	63256	63256	0	0.0
			.data	672	672	0	0.0
			.text	359620	359620	0	0.0
linux	all-clusters-app	debug	(read only)	`1653505`	`1653505`	0	0.0
			(read/write)	119136	119136	0	0.0
			.bss	51376	51376	0	0.0
			.data	978	978	0	0.0
			.data.rel.ro	61536	61536	0	0.0
			.dynamic	592	592	0	0.0
			.got	4088	4088	0	0.0
			.init	27	27	0	0.0
			.init_array	520	520	0	0.0
			.rodata	137845	137845	0	0.0
			.text	1383346	1383346	0	0.0
	bridge-app	debug+rpc	(read only)	1282421	1282421	0	0.0
			(read/write)	85192	85192	0	0.0
			.bss	51856	51856	0	0.0
			.data	976	976	0	0.0
			.data.rel.ro	27368	27368	0	0.0
			.dynamic	592	592	0	0.0
			.got	3952	3952	0	0.0
			.init	27	27	0	0.0
			.init_array	400	400	0	0.0
			.rodata	110812	110812	0	0.0
			.text	1076245	1076245	0	0.0
	chip-tool	debug	(read only)	4262469	4262469	0	0.0
			(read/write)	122208	122208	0	0.0
			.bss	17680	17680	0	0.0
			.data	1584	1584	0	0.0
			.data.rel.ro	97536	97536	0	0.0
			.dynamic	592	592	0	0.0
			.got	4368	4368	0	0.0
			.init	27	27	0	0.0
			.init_array	424	424	0	0.0
			.rodata	214032	214032	0	0.0
			.text	3785589	3785589	0	0.0
	lighting-app	debug+rpc	(read only)	`1541401`	`1541401`	0	0.0
			(read/write)	102032	102032	0	0.0
			.bss	41208	41208	0	0.0
			.data	1106	1106	0	0.0
			.data.rel.ro	54448	54448	0	0.0
			.dynamic	608	608	0	0.0
			.got	4112	4112	0	0.0
			.init	27	27	0	0.0
			.init_array	528	528	0	0.0
			.rodata	128977	128977	0	0.0
			.text	`1279922`	`1279922`	0	0.0
	ota-provider-app	debug	(read only)	1238937	1238937	0	0.0
			(read/write)	67904	67904	0	0.0
			.bss	37440	37440	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	24616	24616	0	0.0
			.dynamic	592	592	0	0.0
			.got	4016	4016	0	0.0
			.init	27	27	0	0.0
			.init_array	440	440	0	0.0
			.rodata	110984	110984	0	0.0
			.text	1031730	1031730	0	0.0
	ota-requestor-app	debug	(read only)	1301033	1301033	0	0.0
			(read/write)	76648	76648	0	0.0
			.bss	45216	45216	0	0.0
			.data	816	816	0	0.0
			.data.rel.ro	25496	25496	0	0.0
			.dynamic	592	592	0	0.0
			.got	3984	3984	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	127680	127680	0	0.0
			.text	`1075490`	`1075490`	0	0.0
	shell	debug	(read only)	787361	787361	0	0.0
			(read/write)	57792	57792	0	0.0
			.bss	16168	16168	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	36880	36880	0	0.0
			.dynamic	592	592	0	0.0
			.got	3528	3528	0	0.0
			.init	27	27	0	0.0
			.init_array	336	336	0	0.0
			.rodata	77519	77519	0	0.0
			.text	608258	608258	0	0.0
	tv-app	debug	(read only)	`1774529`	`1774529`	0	0.0
			(read/write)	289656	289656	0	0.0
			.bss	223280	223280	0	0.0
			.data	2032	2032	0	0.0
			.data.rel.ro	58704	58704	0	0.0
			.dynamic	592	592	0	0.0
			.got	4408	4408	0	0.0
			.init	27	27	0	0.0
			.init_array	608	608	0	0.0
			.rodata	154776	154776	0	0.0
			.text	1477442	1477442	0	0.0
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2290664	2290664	0	0.0
			.bss	180620	180620	0	0.0
			.data	5192	5192	0	0.0
			.heap	850632	850632	0	0.0
			.text	1253264	1253264	0	0.0
	lighting-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2274992	2274992	0	0.0
			.bss	172820	172820	0	0.0
			.data	5568	5568	0	0.0
			.heap	858056	858056	0	0.0
			.text	`1237592`	`1237592`	0	0.0
	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	`2252712`	`2252712`	0	0.0
			.bss	171724	171724	0	0.0
			.data	5552	5552	0	0.0
			.heap	859168	859168	0	0.0
			.text	1215312	1215312	0	0.0
	pigweed-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	1139744	1139744	0	0.0
			.bss	11752	11752	0	0.0
			.data	4368	4368	0	0.0
			.heap	1020328	1020328	0	0.0
			.text	103128	103128	0	0.0
	shell	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	`2048984`	`2048984`	0	0.0
			.bss	156208	156208	0	0.0
			.data	4968	4968	0	0.0
			.heap	875272	875272	0	0.0
			.text	1011584	1011584	0	0.0
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	862911	862911	0	0.0
			bss	112132	112132	0	0.0
			rodata	97528	97528	0	0.0
			text	577624	577624	0	0.0
		nrf52840dk_nrf52840+rpc	(read/write)	823735	823735	0	0.0
			bss	108372	108372	0	0.0
			rodata	88304	88304	0	0.0
			text	550800	550800	0	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	787902	787902	0	0.0
			bss	113504	113504	0	0.0
			rodata	92768	92768	0	0.0
			text	507092	507092	0	0.0
	lock-app	nrf52840dk_nrf52840	(read/write)	839583	839583	0	0.0
			bss	111168	111168	0	0.0
			rodata	93880	93880	0	0.0
			text	559108	559108	0	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	764882	764882	0	0.0
			bss	112576	112576	0	0.0
			rodata	89188	89188	0	0.0
			text	488668	488668	0	0.0
	pigweed-app	nrf52840dk_nrf52840	(read/write)	497323	497323	0	0.0
			bss	51824	51824	0	0.0
			rodata	45776	45776	0	0.0
			text	339436	339436	0	0.0
	pump-app	nrf52840dk_nrf52840	(read/write)	844287	844287	0	0.0
			bss	111304	111304	0	0.0
			rodata	95128	95128	0	0.0
			text	562320	562320	0	0.0
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	839575	839575	0	0.0
			bss	111200	111200	0	0.0
			rodata	93904	93904	0	0.0
			text	558952	558952	0	0.0
	shell	nrf52840dk_nrf52840	(read/write)	776435	776435	0	0.0
			bss	109072	109072	0	0.0
			rodata	72536	72536	0	0.0
			text	520236	520236	0	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	691490	691490	0	0.0
			bss	110056	110056	0	0.0
			rodata	67180	67180	0	0.0
			text	440848	440848	0	0.0
p6	lock-app	default	(read/write)	2169096	2169096	0	0.0
			.bss	67168	67168	0	0.0
			.data	2416	2416	0	0.0
			.heap	963760	963760	0	0.0
			.text	1127360	1127360	0	0.0
qpg	lighting-app	qpg6100+debug	(read only)	491240	491224	-16	-0.0
			(read/write)	114144	114144	0	0.0
			.bss	52400	51288	-1112	-2.1
			.data	1000	1000	0	0.0
			.text	485920	485904	-16	-0.0
	lock-app	qpg6100+debug	(read only)	467580	467556	-24	-0.0
			(read/write)	114140	114140	0	0.0
			.bss	51352	50240	-1112	-2.2
			.data	956	956	0	0.0
			.text	462260	462236	-24	-0.0
	persistent-storage-app	qpg6100+debug	(read only)	155244	155244	0	0.0
			(read/write)	114140	114140	0	0.0
			.bss	27752	27752	0	0.0
			.data	372	372	0	0.0
			.text	149924	149924	0	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	664518	664518	0	0.0
			bss	69944	69944	0	0.0
			noinit	33216	33216	0	0.0
			text	458068	458068	0	0.0

todo · 2021-10-29T07:43:13Z

Here, we translates multi attribute read into many individual attribute reads, this should be fixed by implementing Python's attribute read API.

connectedhomeip/src/controller/python/chip/ChipDeviceCtrl.py

Lines 386 to 396 in 2d58cb9

    
           # TODO: Here, we translates multi attribute read into many individual attribute reads, this should be fixed by implementing Python's attribute read API. 
        
           res = [] 
        
           for attr in attributes: 
        
               endpointId = attr[0] 
        
               attribute = attr[1] 
        
               clusterInfo = self._Cluster.GetClusterInfoById( 
        
                   attribute.cluster_id) 
        
               if not clusterInfo: 
        
                   raise UnknownCluster(attribute.cluster_id) 
        
               attributeInfo = clusterInfo.get("attributes", {}).get( 
        
                   attribute.attribute_id, None)

This comment was generated by todo based on a `TODO` comment in `2d58cb9` in #10949. cc @erjiaqing.

github-actions · 2021-10-29T08:03:15Z

PR #10949: Size comparison from 1e27d92 to 2d58cb9

Decreases (1 build for esp32)

platform	target	config	section	`1e27d92`	`2d58cb9`	change	% change
esp32	all-clusters-app	m5stack	(read only)	907747	907659	-88	-0.0
			.flash.text	907747	907659	-88	-0.0

Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	`1e27d92`	`2d58cb9`	change	% change
efr32	lighting-app	BRD4161A	(read only)	738120	738120	0	0.0
			(read/write)	115428	115428	0	0.0
			.bss	113676	113676	0	0.0
			.data	1752	1752	0	0.0
			.text	738112	738112	0	0.0
		BRD4161A+rpc	(read only)	725560	725560	0	0.0
			(read/write)	132036	132036	0	0.0
			.bss	130180	130180	0	0.0
			.data	1852	1852	0	0.0
			.text	725552	725552	0	0.0
	lock-app	BRD4161A	(read only)	717400	717400	0	0.0
			(read/write)	113244	113244	0	0.0
			.bss	111532	111532	0	0.0
			.data	1712	1712	0	0.0
			.text	717392	717392	0	0.0
	window-app	BRD4161A	(read only)	718304	718304	0	0.0
			(read/write)	113572	113572	0	0.0
			.bss	111852	111852	0	0.0
			.data	1716	1716	0	0.0
			.text	718296	718296	0	0.0
esp32	all-clusters-app	c3devkit	(read only)	876382	876382	0	0.0
			(read/write)	1308944	1308944	0	0.0
			.dram0.bss	59248	59248	0	0.0
			.dram0.data	16448	16448	0	0.0
			.flash.rodata	200016	200016	0	0.0
			.flash.text	876382	876382	0	0.0
			.iram0.text	57554	57554	0	0.0
		m5stack	(read only)	907747	907659	-88	-0.0
			(read/write)	428724	428724	0	0.0
			.dram0.bss	61744	61744	0	0.0
			.dram0.data	32084	32084	0	0.0
			.flash.rodata	208732	208732	0	0.0
			.flash.text	907747	907659	-88	-0.0
			.iram0.text	125115	125115	0	0.0
k32w	lighting-app	k32w061+se05x+release	(read/write)	701656	701656	0	0.0
			.bss	78688	78688	0	0.0
			.data	1900	1900	0	0.0
			.text	615268	615268	0	0.0
	lock-app	k32w061+debug	(read/write)	593612	593612	0	0.0
			.bss	69172	69172	0	0.0
			.data	1864	1864	0	0.0
			.text	516776	516776	0	0.0
	shell	k32w061+debug	(read/write)	425252	425252	0	0.0
			.bss	63256	63256	0	0.0
			.data	672	672	0	0.0
			.text	359620	359620	0	0.0
linux	all-clusters-app	debug	(read only)	`1655073`	`1655073`	0	0.0
			(read/write)	119104	119104	0	0.0
			.bss	51376	51376	0	0.0
			.data	978	978	0	0.0
			.data.rel.ro	61504	61504	0	0.0
			.dynamic	592	592	0	0.0
			.got	4088	4088	0	0.0
			.init	27	27	0	0.0
			.init_array	520	520	0	0.0
			.rodata	138069	138069	0	0.0
			.text	`1384738`	`1384738`	0	0.0
	bridge-app	debug+rpc	(read only)	1283341	1283341	0	0.0
			(read/write)	85160	85160	0	0.0
			.bss	51856	51856	0	0.0
			.data	976	976	0	0.0
			.data.rel.ro	27336	27336	0	0.0
			.dynamic	592	592	0	0.0
			.got	3952	3952	0	0.0
			.init	27	27	0	0.0
			.init_array	400	400	0	0.0
			.rodata	111044	111044	0	0.0
			.text	1076981	1076981	0	0.0
	chip-tool	debug	(read only)	4266229	4266229	0	0.0
			(read/write)	122176	122176	0	0.0
			.bss	17680	17680	0	0.0
			.data	1584	1584	0	0.0
			.data.rel.ro	97504	97504	0	0.0
			.dynamic	592	592	0	0.0
			.got	4368	4368	0	0.0
			.init	27	27	0	0.0
			.init_array	424	424	0	0.0
			.rodata	214704	214704	0	0.0
			.text	3788725	3788725	0	0.0
	lighting-app	debug+rpc	(read only)	1542281	1542281	0	0.0
			(read/write)	102000	102000	0	0.0
			.bss	41208	41208	0	0.0
			.data	1106	1106	0	0.0
			.data.rel.ro	54416	54416	0	0.0
			.dynamic	608	608	0	0.0
			.got	4112	4112	0	0.0
			.init	27	27	0	0.0
			.init_array	528	528	0	0.0
			.rodata	129169	129169	0	0.0
			.text	1280658	1280658	0	0.0
	ota-provider-app	debug	(read only)	1239849	1239849	0	0.0
			(read/write)	67872	67872	0	0.0
			.bss	37440	37440	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	24584	24584	0	0.0
			.dynamic	592	592	0	0.0
			.got	4016	4016	0	0.0
			.init	27	27	0	0.0
			.init_array	440	440	0	0.0
			.rodata	111208	111208	0	0.0
			.text	`1032466`	`1032466`	0	0.0
	ota-requestor-app	debug	(read only)	1301465	1301465	0	0.0
			(read/write)	76616	76616	0	0.0
			.bss	45216	45216	0	0.0
			.data	816	816	0	0.0
			.data.rel.ro	25464	25464	0	0.0
			.dynamic	592	592	0	0.0
			.got	3984	3984	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	127424	127424	0	0.0
			.text	1076226	1076226	0	0.0
	shell	debug	(read only)	787153	787153	0	0.0
			(read/write)	57760	57760	0	0.0
			.bss	16168	16168	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	36848	36848	0	0.0
			.dynamic	592	592	0	0.0
			.got	3528	3528	0	0.0
			.init	27	27	0	0.0
			.init_array	336	336	0	0.0
			.rodata	77519	77519	0	0.0
			.text	608098	608098	0	0.0
	tv-app	debug	(read only)	1774929	1774929	0	0.0
			(read/write)	289624	289624	0	0.0
			.bss	223280	223280	0	0.0
			.data	2032	2032	0	0.0
			.data.rel.ro	58672	58672	0	0.0
			.dynamic	592	592	0	0.0
			.got	4408	4408	0	0.0
			.init	27	27	0	0.0
			.init_array	608	608	0	0.0
			.rodata	154488	154488	0	0.0
			.text	`1478178`	`1478178`	0	0.0
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2291400	2291400	0	0.0
			.bss	180620	180620	0	0.0
			.data	5192	5192	0	0.0
			.heap	850632	850632	0	0.0
			.text	1254000	1254000	0	0.0
	lighting-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2275608	2275608	0	0.0
			.bss	172820	172820	0	0.0
			.data	5568	5568	0	0.0
			.heap	858056	858056	0	0.0
			.text	1238208	1238208	0	0.0
	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2253328	2253328	0	0.0
			.bss	171724	171724	0	0.0
			.data	5552	5552	0	0.0
			.heap	859168	859168	0	0.0
			.text	1215928	1215928	0	0.0
	pigweed-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	1139744	1139744	0	0.0
			.bss	11752	11752	0	0.0
			.data	4368	4368	0	0.0
			.heap	1020328	1020328	0	0.0
			.text	103128	103128	0	0.0
	shell	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2048976	2048976	0	0.0
			.bss	156208	156208	0	0.0
			.data	4968	4968	0	0.0
			.heap	875272	875272	0	0.0
			.text	`1011576`	`1011576`	0	0.0
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	863535	863535	0	0.0
			bss	112132	112132	0	0.0
			rodata	97816	97816	0	0.0
			text	577960	577960	0	0.0
		nrf52840dk_nrf52840+rpc	(read/write)	824363	824363	0	0.0
			bss	108372	108372	0	0.0
			rodata	88596	88596	0	0.0
			text	551136	551136	0	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	788526	788526	0	0.0
			bss	113504	113504	0	0.0
			rodata	93056	93056	0	0.0
			text	507428	507428	0	0.0
	lock-app	nrf52840dk_nrf52840	(read/write)	840211	840211	0	0.0
			bss	111168	111168	0	0.0
			rodata	94172	94172	0	0.0
			text	559444	559444	0	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	765506	765506	0	0.0
			bss	112576	112576	0	0.0
			rodata	89476	89476	0	0.0
			text	489004	489004	0	0.0
	pigweed-app	nrf52840dk_nrf52840	(read/write)	497323	497323	0	0.0
			bss	51824	51824	0	0.0
			rodata	45776	45776	0	0.0
			text	339436	339436	0	0.0
	pump-app	nrf52840dk_nrf52840	(read/write)	844911	844911	0	0.0
			bss	111304	111304	0	0.0
			rodata	95416	95416	0	0.0
			text	562656	562656	0	0.0
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	840199	840199	0	0.0
			bss	111200	111200	0	0.0
			rodata	94192	94192	0	0.0
			text	559288	559288	0	0.0
	shell	nrf52840dk_nrf52840	(read/write)	776435	776435	0	0.0
			bss	109072	109072	0	0.0
			rodata	72536	72536	0	0.0
			text	520236	520236	0	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	691490	691490	0	0.0
			bss	110056	110056	0	0.0
			rodata	67180	67180	0	0.0
			text	440848	440848	0	0.0
p6	lock-app	default	(read/write)	2169744	2169744	0	0.0
			.bss	67168	67168	0	0.0
			.data	2416	2416	0	0.0
			.heap	963760	963760	0	0.0
			.text	1128008	1128008	0	0.0
qpg	lighting-app	qpg6100+debug	(read only)	491224	491224	0	0.0
			(read/write)	114144	114144	0	0.0
			.bss	51288	51288	0	0.0
			.data	1000	1000	0	0.0
			.text	485904	485904	0	0.0
	lock-app	qpg6100+debug	(read only)	467556	467556	0	0.0
			(read/write)	114140	114140	0	0.0
			.bss	50240	50240	0	0.0
			.data	956	956	0	0.0
			.text	462236	462236	0	0.0
	persistent-storage-app	qpg6100+debug	(read only)	155236	155236	0	0.0
			(read/write)	114140	114140	0	0.0
			.bss	27752	27752	0	0.0
			.data	372	372	0	0.0
			.text	149916	149916	0	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	665202	665202	0	0.0
			bss	69944	69944	0	0.0
			noinit	33216	33216	0	0.0
			text	458454	458454	0	0.0

todo · 2021-11-01T01:56:10Z

Here, we translates multi attribute read into many individual attribute reads, this should be fixed by implementing Python's attribute read API.

connectedhomeip/src/controller/python/chip/ChipDeviceCtrl.py

Lines 386 to 396 in 444f2fa

    
           # TODO: Here, we translates multi attribute read into many individual attribute reads, this should be fixed by implementing Python's attribute read API. 
        
           res = [] 
        
           for attr in attributes: 
        
               endpointId = attr[0] 
        
               attribute = attr[1] 
        
               clusterInfo = self._Cluster.GetClusterInfoById( 
        
                   attribute.cluster_id) 
        
               if not clusterInfo: 
        
                   raise UnknownCluster(attribute.cluster_id) 
        
               attributeInfo = clusterInfo.get("attributes", {}).get( 
        
                   attribute.attribute_id, None)

This comment was generated by todo based on a `TODO` comment in `444f2fa` in #10949. cc @erjiaqing.

erjiaqing · 2021-11-01T01:57:22Z

@saurabhst @Damian-Nordic @andy31415 @msandstedt PTAL thanks.

github-actions · 2021-11-01T02:13:54Z

PR #10949: Size comparison from 8dcf5d7 to 444f2fa

Decreases (1 build for esp32)

platform	target	config	section	`8dcf5d7`	`444f2fa`	change	% change
esp32	all-clusters-app	m5stack	(read only)	911451	911375	-76	-0.0
			.flash.text	911451	911375	-76	-0.0

Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	`8dcf5d7`	`444f2fa`	change	% change
efr32	lighting-app	BRD4161A	(read only)	736636	736636	0	0.0
			(read/write)	114476	114476	0	0.0
			.bss	112724	112724	0	0.0
			.data	1752	1752	0	0.0
			.text	736628	736628	0	0.0
		BRD4161A+rpc	(read only)	724076	724076	0	0.0
			(read/write)	131080	131080	0	0.0
			.bss	129228	129228	0	0.0
			.data	1852	1852	0	0.0
			.text	724068	724068	0	0.0
	lock-app	BRD4161A	(read only)	715932	715932	0	0.0
			(read/write)	112292	112292	0	0.0
			.bss	110580	110580	0	0.0
			.data	1712	1712	0	0.0
			.text	715924	715924	0	0.0
	window-app	BRD4161A	(read only)	716836	716836	0	0.0
			(read/write)	112616	112616	0	0.0
			.bss	110900	110900	0	0.0
			.data	1716	1716	0	0.0
			.text	716828	716828	0	0.0
esp32	all-clusters-app	c3devkit	(read only)	880562	880562	0	0.0
			(read/write)	1307800	1307800	0	0.0
			.dram0.bss	58456	58456	0	0.0
			.dram0.data	16464	16464	0	0.0
			.flash.rodata	199640	199640	0	0.0
			.flash.text	880562	880562	0	0.0
			.iram0.text	57554	57554	0	0.0
		m5stack	(read only)	911451	911375	-76	-0.0
			(read/write)	427560	427560	0	0.0
			.dram0.bss	60952	60952	0	0.0
			.dram0.data	32100	32100	0	0.0
			.flash.rodata	208344	208344	0	0.0
			.flash.text	911451	911375	-76	-0.0
			.iram0.text	125115	125115	0	0.0
k32w	lighting-app	k32w061+se05x+release	(read/write)	699128	699128	0	0.0
			.bss	77720	77720	0	0.0
			.data	1900	1900	0	0.0
			.text	613708	613708	0	0.0
	lock-app	k32w061+debug	(read/write)	591432	591432	0	0.0
			.bss	68220	68220	0	0.0
			.data	1864	1864	0	0.0
			.text	515548	515548	0	0.0
	shell	k32w061+debug	(read/write)	424988	424988	0	0.0
			.bss	63280	63280	0	0.0
			.data	672	672	0	0.0
			.text	359332	359332	0	0.0
linux	all-clusters-app	debug	(read only)	`1687001`	`1687001`	0	0.0
			(read/write)	119024	119024	0	0.0
			.bss	50640	50640	0	0.0
			.data	1010	1010	0	0.0
			.data.rel.ro	62112	62112	0	0.0
			.dynamic	592	592	0	0.0
			.got	4088	4088	0	0.0
			.init	27	27	0	0.0
			.init_array	536	536	0	0.0
			.rodata	138069	138069	0	0.0
			.text	1415874	1415874	0	0.0
	bridge-app	debug+rpc	(read only)	`1281957`	`1281957`	0	0.0
			(read/write)	84136	84136	0	0.0
			.bss	50800	50800	0	0.0
			.data	976	976	0	0.0
			.data.rel.ro	27368	27368	0	0.0
			.dynamic	592	592	0	0.0
			.got	3952	3952	0	0.0
			.init	27	27	0	0.0
			.init_array	400	400	0	0.0
			.rodata	110020	110020	0	0.0
			.text	1076693	1076693	0	0.0
	chip-tool	debug	(read only)	4314925	4314925	0	0.0
			(read/write)	123648	123648	0	0.0
			.bss	17712	17712	0	0.0
			.data	1584	1584	0	0.0
			.data.rel.ro	98928	98928	0	0.0
			.dynamic	592	592	0	0.0
			.got	4368	4368	0	0.0
			.init	27	27	0	0.0
			.init_array	424	424	0	0.0
			.rodata	217360	217360	0	0.0
			.text	`3831621`	`3831621`	0	0.0
	lighting-app	debug+rpc	(read only)	1540865	1540865	0	0.0
			(read/write)	101008	101008	0	0.0
			.bss	40184	40184	0	0.0
			.data	1106	1106	0	0.0
			.data.rel.ro	54448	54448	0	0.0
			.dynamic	608	608	0	0.0
			.got	4112	4112	0	0.0
			.init	27	27	0	0.0
			.init_array	528	528	0	0.0
			.rodata	128113	128113	0	0.0
			.text	1280370	1280370	0	0.0
	ota-provider-app	debug	(read only)	`1239033`	`1239033`	0	0.0
			(read/write)	67104	67104	0	0.0
			.bss	36640	36640	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	24616	24616	0	0.0
			.dynamic	592	592	0	0.0
			.got	4016	4016	0	0.0
			.init	27	27	0	0.0
			.init_array	440	440	0	0.0
			.rodata	110408	110408	0	0.0
			.text	1032498	1032498	0	0.0
	ota-requestor-app	debug	(read only)	1302033	1302033	0	0.0
			(read/write)	76360	76360	0	0.0
			.bss	44896	44896	0	0.0
			.data	816	816	0	0.0
			.data.rel.ro	25528	25528	0	0.0
			.dynamic	592	592	0	0.0
			.got	3984	3984	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	127072	127072	0	0.0
			.text	`1077170`	`1077170`	0	0.0
	shell	debug	(read only)	786145	786145	0	0.0
			(read/write)	57664	57664	0	0.0
			.bss	16072	16072	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	36848	36848	0	0.0
			.dynamic	592	592	0	0.0
			.got	3528	3528	0	0.0
			.init	27	27	0	0.0
			.init_array	336	336	0	0.0
			.rodata	77423	77423	0	0.0
			.text	607186	607186	0	0.0
	tv-app	debug	(read only)	1773337	1773337	0	0.0
			(read/write)	288600	288600	0	0.0
			.bss	222224	222224	0	0.0
			.data	2032	2032	0	0.0
			.data.rel.ro	58704	58704	0	0.0
			.dynamic	592	592	0	0.0
			.got	4408	4408	0	0.0
			.init	27	27	0	0.0
			.init_array	608	608	0	0.0
			.rodata	153464	153464	0	0.0
			.text	`1477682`	`1477682`	0	0.0
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2294952	2294952	0	0.0
			.bss	179828	179828	0	0.0
			.data	5216	5216	0	0.0
			.heap	851400	851400	0	0.0
			.text	1257552	1257552	0	0.0
	lighting-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	`2274336`	`2274336`	0	0.0
			.bss	171868	171868	0	0.0
			.data	5568	5568	0	0.0
			.heap	859008	859008	0	0.0
			.text	1236936	1236936	0	0.0
	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2252056	2252056	0	0.0
			.bss	170772	170772	0	0.0
			.data	5552	5552	0	0.0
			.heap	860120	860120	0	0.0
			.text	1214656	1214656	0	0.0
	pigweed-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	1139744	1139744	0	0.0
			.bss	11752	11752	0	0.0
			.data	4368	4368	0	0.0
			.heap	1020328	1020328	0	0.0
			.text	103128	103128	0	0.0
	shell	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2048656	2048656	0	0.0
			.bss	156232	156232	0	0.0
			.data	4968	4968	0	0.0
			.heap	875248	875248	0	0.0
			.text	1011256	1011256	0	0.0
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	861267	861267	0	0.0
			bss	111180	111180	0	0.0
			rodata	96860	96860	0	0.0
			text	577612	577612	0	0.0
		nrf52840dk_nrf52840+rpc	(read/write)	822095	822095	0	0.0
			bss	107424	107424	0	0.0
			rodata	87640	87640	0	0.0
			text	550784	550784	0	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	786306	786306	0	0.0
			bss	112556	112556	0	0.0
			rodata	92100	92100	0	0.0
			text	507080	507080	0	0.0
	lock-app	nrf52840dk_nrf52840	(read/write)	837975	837975	0	0.0
			bss	110216	110216	0	0.0
			rodata	93216	93216	0	0.0
			text	559092	559092	0	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	763270	763270	0	0.0
			bss	111628	111628	0	0.0
			rodata	88520	88520	0	0.0
			text	488652	488652	0	0.0
	pigweed-app	nrf52840dk_nrf52840	(read/write)	497323	497323	0	0.0
			bss	51824	51824	0	0.0
			rodata	45776	45776	0	0.0
			text	339436	339436	0	0.0
	pump-app	nrf52840dk_nrf52840	(read/write)	842643	842643	0	0.0
			bss	110352	110352	0	0.0
			rodata	94460	94460	0	0.0
			text	562300	562300	0	0.0
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	837947	837947	0	0.0
			bss	110252	110252	0	0.0
			rodata	93236	93236	0	0.0
			text	558932	558932	0	0.0
	shell	nrf52840dk_nrf52840	(read/write)	776179	776179	0	0.0
			bss	109096	109096	0	0.0
			rodata	72536	72536	0	0.0
			text	519936	519936	0	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	691202	691202	0	0.0
			bss	110080	110080	0	0.0
			rodata	67180	67180	0	0.0
			text	440548	440548	0	0.0
p6	lock-app	default	(read/write)	`2167872`	`2167872`	0	0.0
			.bss	66216	66216	0	0.0
			.data	2416	2416	0	0.0
			.heap	964712	964712	0	0.0
			.text	1126136	1126136	0	0.0
qpg	lighting-app	qpg6100+debug	(read only)	490500	490500	0	0.0
			(read/write)	114144	114144	0	0.0
			.bss	50336	50336	0	0.0
			.data	1000	1000	0	0.0
			.text	485180	485180	0	0.0
	lock-app	qpg6100+debug	(read only)	466844	466844	0	0.0
			(read/write)	114140	114140	0	0.0
			.bss	49288	49288	0	0.0
			.data	956	956	0	0.0
			.text	461524	461524	0	0.0
	persistent-storage-app	qpg6100+debug	(read only)	155820	155820	0	0.0
			(read/write)	114140	114140	0	0.0
			.bss	27752	27752	0	0.0
			.data	372	372	0	0.0
			.text	150500	150500	0	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	662890	662890	0	0.0
			bss	68992	68992	0	0.0
			noinit	33216	33216	0	0.0
			text	458036	458036	0	0.0

andy31415 · 2021-11-01T15:27:30Z

fast track: 6-day old PR (3 business days) created by domain owner and that does not affect main C++ library (python is used for testing)

…chip#10949)

boring-cyborg bot added app controller labels Oct 26, 2021

restyled-io bot mentioned this pull request Oct 26, 2021

Restyle [Python] Add write and read API with cluster object support #10950

Closed

erjiaqing force-pushed the python/read-write-cluster-object branch from 3b63919 to 5fedc38 Compare October 26, 2021 06:01

pullapprove bot requested review from woody-apple, yufengwangca and yunhanw-google October 26, 2021 06:01

pullapprove bot added the review - pending label Oct 26, 2021

woody-apple approved these changes Oct 27, 2021

View reviewed changes

pullapprove bot requested a review from electrocucaracha October 27, 2021 19:28

electrocucaracha reviewed Oct 27, 2021

View reviewed changes

src/controller/python/chip/clusters/Attribute.py Outdated Show resolved Hide resolved

erjiaqing force-pushed the python/read-write-cluster-object branch from 5fedc38 to 149b8ae Compare October 28, 2021 08:06

erjiaqing force-pushed the python/read-write-cluster-object branch from 149b8ae to 37e508f Compare October 28, 2021 08:14

erjiaqing force-pushed the python/read-write-cluster-object branch from 3ba9f08 to 2d58cb9 Compare October 29, 2021 07:43

[Python] Add write and read API with cluster object support

444f2fa

erjiaqing force-pushed the python/read-write-cluster-object branch from 2d58cb9 to 444f2fa Compare November 1, 2021 01:56

andy31415 approved these changes Nov 1, 2021

View reviewed changes

andy31415 added the fast track label Nov 1, 2021

andy31415 merged commit 5da5e79 into project-chip:master Nov 1, 2021

todo bot mentioned this pull request Nov 1, 2021

Here, we translates multi attribute read into many individual attribute reads, t... #11269

Closed

PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021

[Python] Add write and read API with cluster object support (project-…

76d949c

…chip#10949)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Python] Add write and read API with cluster object support #10949

[Python] Add write and read API with cluster object support #10949

erjiaqing commented Oct 26, 2021

todo bot commented Oct 26, 2021

todo bot commented Oct 26, 2021

github-actions bot commented Oct 26, 2021 •

edited

Loading

erjiaqing commented Oct 26, 2021

todo bot commented Oct 28, 2021

todo bot commented Oct 28, 2021

github-actions bot commented Oct 28, 2021 •

edited

Loading

todo bot commented Oct 28, 2021

github-actions bot commented Oct 28, 2021 •

edited

Loading

todo bot commented Oct 29, 2021

github-actions bot commented Oct 29, 2021 •

edited

Loading

todo bot commented Nov 1, 2021

erjiaqing commented Nov 1, 2021

github-actions bot commented Nov 1, 2021 •

edited

Loading

andy31415 commented Nov 1, 2021

[Python] Add write and read API with cluster object support #10949

[Python] Add write and read API with cluster object support #10949

Conversation

erjiaqing commented Oct 26, 2021

Problem

Change overview

Testing

todo bot commented Oct 26, 2021

Here, we translates multi attribute read into many individual attribute reads, this should be fixed by implementing Python's attribute read API.

This comment was generated by todo based on a TODO comment in 3b63919 in #10949. cc @erjiaqing.

todo bot commented Oct 26, 2021

Here, we translates multi attribute read into many individual attribute reads, this should be fixed by implementing Python's attribute read API.

This comment was generated by todo based on a TODO comment in 5fedc38 in #10949. cc @erjiaqing.

github-actions bot commented Oct 26, 2021 • edited Loading

erjiaqing commented Oct 26, 2021

todo bot commented Oct 28, 2021

Here, we translates multi attribute read into many individual attribute reads, this should be fixed by implementing Python's attribute read API.

This comment was generated by todo based on a TODO comment in 149b8ae in #10949. cc @erjiaqing.

todo bot commented Oct 28, 2021

Here, we translates multi attribute read into many individual attribute reads, this should be fixed by implementing Python's attribute read API.

This comment was generated by todo based on a TODO comment in 37e508f in #10949. cc @erjiaqing.

github-actions bot commented Oct 28, 2021 • edited Loading

todo bot commented Oct 28, 2021

Here, we translates multi attribute read into many individual attribute reads, this should be fixed by implementing Python's attribute read API.

This comment was generated by todo based on a TODO comment in 3ba9f08 in #10949. cc @erjiaqing.

github-actions bot commented Oct 28, 2021 • edited Loading

todo bot commented Oct 29, 2021

Here, we translates multi attribute read into many individual attribute reads, this should be fixed by implementing Python's attribute read API.

This comment was generated by todo based on a TODO comment in 2d58cb9 in #10949. cc @erjiaqing.

github-actions bot commented Oct 29, 2021 • edited Loading

todo bot commented Nov 1, 2021

Here, we translates multi attribute read into many individual attribute reads, this should be fixed by implementing Python's attribute read API.

This comment was generated by todo based on a TODO comment in 444f2fa in #10949. cc @erjiaqing.

erjiaqing commented Nov 1, 2021

github-actions bot commented Nov 1, 2021 • edited Loading

andy31415 commented Nov 1, 2021

This comment was generated by todo based on a `TODO` comment in `3b63919` in #10949. cc @erjiaqing.

This comment was generated by todo based on a `TODO` comment in `5fedc38` in #10949. cc @erjiaqing.

github-actions bot commented Oct 26, 2021 •

edited

Loading

This comment was generated by todo based on a `TODO` comment in `149b8ae` in #10949. cc @erjiaqing.

This comment was generated by todo based on a `TODO` comment in `37e508f` in #10949. cc @erjiaqing.

github-actions bot commented Oct 28, 2021 •

edited

Loading

This comment was generated by todo based on a `TODO` comment in `3ba9f08` in #10949. cc @erjiaqing.

github-actions bot commented Oct 28, 2021 •

edited

Loading

This comment was generated by todo based on a `TODO` comment in `2d58cb9` in #10949. cc @erjiaqing.

github-actions bot commented Oct 29, 2021 •

edited

Loading

This comment was generated by todo based on a `TODO` comment in `444f2fa` in #10949. cc @erjiaqing.

github-actions bot commented Nov 1, 2021 •

edited

Loading