-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various small revisions to TCPEndPoint #10864
Merged
kpschoedel
merged 2 commits into
project-chip:master
from
kpschoedel:x7715-inet-3g-tcpendpoint
Oct 25, 2021
Merged
Various small revisions to TCPEndPoint #10864
kpschoedel
merged 2 commits into
project-chip:master
from
kpschoedel:x7715-inet-3g-tcpendpoint
Oct 25, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem Working toward project-chip#7715 Virtualize System and Inet interfaces #### Change overview Miscellaneous revisions with no change to functionality. - Add `TCPTest` class for test access to internal `TCPEndPoint` state. - Make `State` private. - Favor `ReturnErrorOnFailure()` etc. - Factor `GetSocketInfo()` out of `Get(Local|Peer)Info()` #### Testing CI; no changes to functionality intended.
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
erjiaqing,
franck-apple,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
mlepage-google,
msandstedt,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
tcarmelveilleux,
turon,
vivien-apple,
wbschiller and
woody-apple
October 22, 2021 18:19
woody-apple
approved these changes
Oct 22, 2021
PR #10864: Size comparison from e282eec to 516d176 35 builds (for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
LuDuda
approved these changes
Oct 22, 2021
msandstedt
reviewed
Oct 25, 2021
andy31415
approved these changes
Oct 25, 2021
msandstedt
approved these changes
Oct 25, 2021
JasonLiuZhuoCheng
pushed a commit
to JasonLiuZhuoCheng/connectedhomeip
that referenced
this pull request
Oct 28, 2021
#### Problem Working toward project-chip#7715 Virtualize System and Inet interfaces #### Change overview Miscellaneous revisions with no change to functionality. - Add `TCPTest` class for test access to internal `TCPEndPoint` state. - Make `State` private. - Favor `ReturnErrorOnFailure()` etc. - Factor `GetSocketInfo()` out of `Get(Local|Peer)Info()` #### Testing CI; no changes to functionality intended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Working toward #7715 Virtualize System and Inet interfaces
Change overview
Miscellaneous revisions with no change to functionality.
TCPTest
class for test access to internalTCPEndPoint
state.State
private.ReturnErrorOnFailure()
etc.GetSocketInfo()
out ofGet(Local|Peer)Info()
Testing
CI; no changes to functionality intended.