Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle Add Mode Select Cluster #10785

Closed
wants to merge 4 commits into from
Closed

Conversation

restyled-io[bot]
Copy link
Contributor

@restyled-io restyled-io bot commented Oct 21, 2021

A duplicate of #10752 with additional commits that automatically address
incorrect style, created by Restyled.

⚠️ Even though this PR is not a Fork, it contains outside contributions.
Please review accordingly.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions
    ```console
    git remote add upstream https://github.com/project-chip/connectedhomeip.git
    git fetch upstream pull/<this PR number>/head
    git merge --ff-only FETCH_HEAD
    git push
    ```
    

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

Problem
Add the implementation for Mode Select Cluster. The specification for
Mode Select Cluster can be found at https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/master/src/app_clusters/ModeSelect.adoc

Change overview
* Add src/app/zap-templates/zcl/data-model/chip/mode-select-cluster.xml
* Add the ModeSelectCluster to the all-cluster-app
* Add the ModeSelectCluster to the chip-tool
* Add src/app/clusters/mode-select-server/mode-select-server.cpp, the
main logic for the server of the ModeSelectCluster
* Add src/app/clusters/mode-select-server/supported-modes-manager.h,
which contains helper method for managing the supported options.
* Generate code for Mode Select Cluster
* Also fixed the src/app/clusters/operational-credentials-server/operational-credentials-server.cpp

Testing
How was this tested? (at least one bullet point required)

If manually tested, what platforms controller and device platforms were manually tested, and how?
Manually tested with chip-tool built on MacOs. Tested by issuing the read command and the "change-to-mode" command, and verified that all the attributes can be read, and "change-to-mode" correctly changes the "current-mode" attribute.
@CLAassistant
Copy link

CLAassistant commented Oct 21, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ du48s03
❌ dinglamazon
You have signed the CLA already but the status is still pending? Let us recheck it.

@restyled-io restyled-io bot force-pushed the restyled/pull-10752 branch from 106c379 to a839c1d Compare October 21, 2021 18:08
@restyled-io restyled-io bot closed this Oct 21, 2021
@restyled-io restyled-io bot deleted the restyled/pull-10752 branch October 21, 2021 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants