Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[examples] Enable Descriptor cluster on all endpoints #10761

Merged
merged 1 commit into from
Oct 26, 2021
Merged

[examples] Enable Descriptor cluster on all endpoints #10761

merged 1 commit into from
Oct 26, 2021

Conversation

Damian-Nordic
Copy link
Contributor

@Damian-Nordic Damian-Nordic commented Oct 21, 2021 •
edited
Loading

Problem

Currently, the Descriptor cluster is enabled only on endpoint 0 while it should be enabled on all endpoints to expose all clusters available on a given node.

Change overview

Enable Descriptor cluster on all endpoints in all examples to make sure that a controller can find out all clusters supported by a given device.

Testing

Tested manually all examples available for the nRF52840 DK, using Python CHIP Controller.

@Damian-Nordic Damian-Nordic changed the title [examples] Enable Descriptor cluster on all endpoints [examples/nrfconnect] Enable Descriptor cluster on all endpoints Oct 21, 2021
@tima-q tima-q reopened this Oct 21, 2021
@bzbarsky-apple
Copy link
Contributor

bzbarsky-apple commented Oct 21, 2021 •
edited
Loading

@Damian-Nordic I would have expected setting things external to in fact reduce the .bss use, and that is the plan of record for what to do with descriptor, once we make reporting work without the actual attribute write there. Sounds like that's a pretty high priority, as is figuring out why setting things external is not helping. I'm looking into the latter right now.

@Damian-Nordic
Copy link
Contributor Author

@bzbarsky-apple Thanks, I'll take a look into that tomorrow. It seems that ATTRIBUTE_MASK_EXTERNAL_STORAGE is taken into account when calculating the position of an attribute in the table, so maybe it's just the size that needs to be fixed.

@bzbarsky-apple
Copy link
Contributor

@Damian-Nordic Once #10826 merges, setting things external should work right.

@woody-apple
Copy link
Contributor

@Damian-Nordic can you take a peek at conflicts? Thanks!

@bzbarsky-apple
Copy link
Contributor

Probably needs a regen now that #10826 merged....

@Damian-Nordic Damian-Nordic changed the title [examples/nrfconnect] Enable Descriptor cluster on all endpoints [examples] Enable Descriptor cluster on all endpoints Oct 22, 2021
@Damian-Nordic
Copy link
Contributor Author

Damian-Nordic commented Oct 22, 2021 •
edited
Loading

@bzbarsky-apple Thanks a lot for this work. I rebased my change now and switched Descriptor attributes on all endpoints to the external storage.

@pullapprove pullapprove bot requested a review from tecimovic October 22, 2021 21:56
@github-actions
Copy link

PR #10761: Size comparison from d88736a to 483e35c

Increases above 1.0% from d88736a to 483e35c:

platform target config section d88736a 483e35c change % change
linux tv-app debug .data.rel.ro 57408 58176 768 1.3
35 builds (for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section d88736a 483e35c change % change
efr32 lighting-app BRD4161A .bss 113716 113724 8 0.0
.data 1752 1752 0 0.0
.text 735748 735852 104 0.0
lock-app BRD4161A .bss 111572 111580 8 0.0
.data 1712 1712 0 0.0
.text 714948 715052 104 0.0
window-app BRD4161A .bss 111884 111892 8 0.0
.data 1716 1716 0 0.0
.text 715792 715992 200 0.0
lighting-app BRD4161A+rpc .bss 130220 130228 8 0.0
.data 1852 1852 0 0.0
.text 723172 723268 96 0.0
esp32 all-clusters-app c3devkit .dram0.bss 58272 58272 0 0.0
.dram0.data 16440 16440 0 0.0
.flash.rodata 197936 198032 96 0.0
.flash.text 874294 874294 0 0.0
.iram0.text 57564 57564 0 0.0
m5stack .dram0.bss 60776 60776 0 0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 206672 206768 96 0.0
.flash.text 905323 905323 0 0.0
.iram0.text 125115 125115 0 0.0
k32w lock-app k32w061+debug .bss 69228 69228 0 0.0
.data 1864 1864 0 0.0
.text 515060 515160 100 0.0
shell k32w061+debug .bss 63256 63256 0 0.0
.data 672 672 0 0.0
.text 359528 359528 0 0.0
lighting-app k32w061+se05x+release .bss 78744 78752 8 0.0
.data 1900 1900 0 0.0
.text 613760 613860 100 0.0
linux all-clusters-app debug .bss 50192 50192 0 0.0
.data 978 978 0 0.0
.data.rel.ro 60448 60608 160 0.3
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 134453 134453 0 0.0
.text 1353122 1353122 0 0.0
chip-tool debug .bss 17712 17712 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 93888 93888 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 416 416 0 0.0
.rodata 194308 194308 0 0.0
.text 3510757 3510757 0 0.0
ota-provider-app debug .bss 37472 37472 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24488 24488 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110312 110312 0 0.0
.text 1023042 1023042 0 0.0
ota-requestor-app debug .bss 205728 205728 0 0.0
.data 752 752 0 0.0
.data.rel.ro 25800 25800 0 0.0
.dynamic 592 592 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 128360 128360 0 0.0
.text 1141650 1141650 0 0.0
shell debug .bss 16136 16136 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36496 36496 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 76463 76463 0 0.0
.text 598722 598722 0 0.0
tv-app debug .bss 215568 215600 32 0.0
.data 2032 2032 0 0.0
.data.rel.ro 57408 58176 768 1.3
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 151944 151944 0 0.0
.text 1453538 1453538 0 0.0
bridge-app debug+rpc .bss 51888 51888 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27112 27272 160 0.6
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 109724 109724 0 0.0
.text 1063925 1063925 0 0.0
lighting-app debug+rpc .bss 41208 41208 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 53808 53968 160 0.3
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 126897 126897 0 0.0
.text 1261874 1261874 0 0.0
mbed lighting-app CY8CPROTO_062_4343W+release .bss 171092 171092 0 0.0
.data 5464 5464 0 0.0
.heap 859888 859888 0 0.0
.text 1219096 1219192 96 0.0
lock-app CY8CPROTO_062_4343W+release .bss 170012 170020 8 0.0
.data 5432 5432 0 0.0
.heap 861000 860992 -8 -0.0
.text 1196992 1197096 104 0.0
pigweed-app CY8CPROTO_062_4343W+release .bss 11760 11760 0 0.0
.data 4360 4360 0 0.0
.heap 1020328 1020328 0 0.0
.text 103064 103064 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 bss 112168 112168 0 0.0
rodata 97084 97184 100 0.1
text 577196 577196 0 0.0
lock-app nrf52840dk_nrf52840 bss 111240 111240 0 0.0
rodata 93484 93584 100 0.1
text 558684 558684 0 0.0
pigweed-app nrf52840dk_nrf52840 bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339456 339456 0 0.0
pump-app nrf52840dk_nrf52840 bss 111300 111300 0 0.0
rodata 94380 94480 100 0.1
text 561836 561836 0 0.0
pump-controller-app nrf52840dk_nrf52840 bss 111236 111240 4 0.0
rodata 93460 93560 100 0.1
text 558476 558476 0 0.0
shell nrf52840dk_nrf52840 bss 109072 109072 0 0.0
rodata 72524 72524 0 0.0
text 520300 520300 0 0.0
lighting-app nrf52840dk_nrf52840+rpc bss 108408 108412 4 0.0
rodata 87860 87960 100 0.1
text 550388 550388 0 0.0
nrf5340dk_nrf5340_cpuapp bss 113540 113544 4 0.0
rodata 92324 92424 100 0.1
text 506664 506664 0 0.0
lock-app nrf5340dk_nrf5340_cpuapp bss 112612 112616 4 0.0
rodata 88744 88844 100 0.1
text 488148 488148 0 0.0
shell nrf5340dk_nrf5340_cpuapp bss 110056 110056 0 0.0
rodata 67168 67168 0 0.0
text 440908 440908 0 0.0
p6 lock-app default .bss 67208 67216 8 0.0
.data 2416 2416 0 0.0
.heap 963720 963712 -8 -0.0
.text 1125984 1126080 96 0.0
qpg lighting-app qpg6100+debug .bss 52456 52456 0 0.0
.data 1004 1004 0 0.0
.text 485008 485108 100 0.0
lock-app qpg6100+debug .bss 51400 51408 8 0.0
.data 960 960 0 0.0
.text 461164 461264 100 0.0
persistent-storage-app qpg6100+debug .bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 149896 149896 0 0.0
telink lighting-app tlsr9518adk80d bss 69988 69992 4 0.0
noinit 33216 33216 0 0.0
text 457664 457664 0 0.0

LuDuda
LuDuda approved these changes Oct 24, 2021
View reviewed changes
Copy link
Contributor

@LuDuda LuDuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@andy31415
Copy link
Contributor

@Damian-Nordic - merge conflicts

@pullapprove pullapprove bot requested a review from selissia October 26, 2021 07:17
@github-actions
Copy link

PR #10761: Size comparison from 341c00d to 345b76b

8 builds (for k32w, p6, qpg, telink)
platform target config section 341c00d 345b76b change % change
k32w lock-app k32w061+debug .bss 69196 69196 0 0.0
.data 1864 1864 0 0.0
.text 515140 515240 100 0.0
shell k32w061+debug .bss 63256 63256 0 0.0
.data 672 672 0 0.0
.text 359572 359572 0 0.0
lighting-app k32w061+se05x+release .bss 78712 78720 8 0.0
.data 1900 1900 0 0.0
.text 613776 613876 100 0.0
p6 lock-app default .bss 67176 67184 8 0.0
.data 2416 2416 0 0.0
.heap 963752 963744 -8 -0.0
.text 1126088 1126192 104 0.0
qpg lighting-app qpg6100+debug .bss 52416 52416 0 0.0
.data 1000 1000 0 0.0
.text 485044 485144 100 0.0
lock-app qpg6100+debug .bss 51360 51368 8 0.0
.data 956 956 0 0.0
.text 461264 461364 100 0.0
persistent-storage-app qpg6100+debug .bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 149900 149900 0 0.0
telink lighting-app tlsr9518adk80d bss 69940 69944 4 0.0
noinit 33216 33216 0 0.0
text 457672 457672 0 0.0

@github-actions
Copy link

github-actions bot commented Oct 26, 2021 •
edited
Loading

PR #10761: Size comparison from 341c00d to 5c6165d

8 builds (for k32w, p6, qpg, telink)
platform target config section 341c00d 5c6165d change % change
k32w lock-app k32w061+debug .bss 69196 69196 0 0.0
.data 1864 1864 0 0.0
.text 515140 515240 100 0.0
shell k32w061+debug .bss 63256 63256 0 0.0
.data 672 672 0 0.0
.text 359572 359572 0 0.0
lighting-app k32w061+se05x+release .bss 78712 78720 8 0.0
.data 1900 1900 0 0.0
.text 613776 613876 100 0.0
p6 lock-app default .bss 67176 67184 8 0.0
.data 2416 2416 0 0.0
.heap 963752 963744 -8 -0.0
.text 1126088 1126192 104 0.0
qpg lighting-app qpg6100+debug .bss 52416 52416 0 0.0
.data 1000 1000 0 0.0
.text 485044 485144 100 0.0
lock-app qpg6100+debug .bss 51360 51368 8 0.0
.data 956 956 0 0.0
.text 461264 461364 100 0.0
persistent-storage-app qpg6100+debug .bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 149900 149900 0 0.0
telink lighting-app tlsr9518adk80d bss 69940 69944 4 0.0
noinit 33216 33216 0 0.0
text 457672 457672 0 0.0
4 builds (for efr32)
platform target config section 341c00d 5c6165d change % change
efr32 lighting-app BRD4161A .bss 113684 113692 8 0.0
.data 1752 1752 0 0.0
.text 735816 735912 96 0.0
lock-app BRD4161A .bss 111540 111548 8 0.0
.data 1712 1712 0 0.0
.text 715080 715176 96 0.0
window-app BRD4161A .bss 111852 111860 8 0.0
.data 1716 1716 0 0.0
.text 715876 716076 200 0.0
lighting-app BRD4161A+rpc .bss 130188 130196 8 0.0
.data 1852 1852 0 0.0
.text 723232 723336 104 0.0
4 builds (for mbed)
platform target config section 341c00d 5c6165d change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 179604 179604 0 0.0
.data 5192 5192 0 0.0
.heap 851648 851648 0 0.0
.text 1251552 1251648 96 0.0
lighting-app CY8CPROTO_062_4343W+release .bss 171060 171060 0 0.0
.data 5464 5464 0 0.0
.heap 859920 859920 0 0.0
.text 1219256 1219352 96 0.0
lock-app CY8CPROTO_062_4343W+release .bss 169980 169988 8 0.0
.data 5432 5432 0 0.0
.heap 861032 861024 -8 -0.0
.text 1197280 1197384 104 0.0
pigweed-app CY8CPROTO_062_4343W+release .bss 11760 11760 0 0.0
.data 4360 4360 0 0.0
.heap 1020328 1020328 0 0.0
.text 103064 103064 0 0.0
12 builds (for esp32, nrfconnect)
platform target config section 341c00d 5c6165d change % change
esp32 all-clusters-app c3devkit .dram0.bss 58232 58232 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 198072 198176 104 0.1
.flash.text 874742 874742 0 0.0
.iram0.text 57564 57564 0 0.0
m5stack .dram0.bss 60744 60744 0 0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 206832 206928 96 0.0
.flash.text 905895 905807 -88 -0.0
.iram0.text 125115 125115 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 bss 112136 112136 0 0.0
rodata 97100 97200 100 0.1
text 577204 577204 0 0.0
lock-app nrf52840dk_nrf52840 bss 111208 111208 0 0.0
rodata 93500 93600 100 0.1
text 558764 558764 0 0.0
pigweed-app nrf52840dk_nrf52840 bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339456 339456 0 0.0
pump-app nrf52840dk_nrf52840 bss 111308 111308 0 0.0
rodata 94700 94800 100 0.1
text 561868 561868 0 0.0
pump-controller-app nrf52840dk_nrf52840 bss 111204 111208 4 0.0
rodata 93476 93576 100 0.1
text 558508 558508 0 0.0
shell nrf52840dk_nrf52840 bss 109072 109072 0 0.0
rodata 72536 72536 0 0.0
text 520324 520324 0 0.0
lighting-app nrf52840dk_nrf52840+rpc bss 108376 108380 4 0.0
rodata 87876 87976 100 0.1
text 550396 550396 0 0.0
nrf5340dk_nrf5340_cpuapp bss 113508 113512 4 0.0
rodata 92340 92440 100 0.1
text 506676 506676 0 0.0
lock-app nrf5340dk_nrf5340_cpuapp bss 112580 112584 4 0.0
rodata 88760 88860 100 0.1
text 488228 488228 0 0.0
shell nrf5340dk_nrf5340_cpuapp bss 110056 110056 0 0.0
rodata 67180 67180 0 0.0
text 440936 440936 0 0.0

@Damian-Nordic
[examples] Enable Descriptor cluster on all endpoints
f9603b1 
Enable Descriptor cluster on all endpoints in all examples
to make sure that a controller can find out all clusters
supported by a given device.
@github-actions
Copy link

github-actions bot commented Oct 26, 2021 •
edited
Loading

PR #10761: Size comparison from 62a6f85 to f9603b1

8 builds (for k32w, p6, qpg, telink)
platform target config section 62a6f85 f9603b1 change % change
k32w lock-app k32w061+debug .bss 69196 69196 0 0.0
.data 1864 1864 0 0.0
.text 515140 515240 100 0.0
shell k32w061+debug .bss 63256 63256 0 0.0
.data 672 672 0 0.0
.text 359572 359572 0 0.0
lighting-app k32w061+se05x+release .bss 78712 78720 8 0.0
.data 1900 1900 0 0.0
.text 613776 613876 100 0.0
p6 lock-app default .bss 67176 67184 8 0.0
.data 2416 2416 0 0.0
.heap 963752 963744 -8 -0.0
.text 1126088 1126192 104 0.0
qpg lighting-app qpg6100+debug .bss 52416 52416 0 0.0
.data 1000 1000 0 0.0
.text 485044 485144 100 0.0
lock-app qpg6100+debug .bss 51360 51368 8 0.0
.data 956 956 0 0.0
.text 461264 461364 100 0.0
persistent-storage-app qpg6100+debug .bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 149900 149900 0 0.0
telink lighting-app tlsr9518adk80d bss 69940 69944 4 0.0
noinit 33216 33216 0 0.0
text 457672 457672 0 0.0

Increases above 1.0% from 62a6f85 to f9603b1:

platform target config section 62a6f85 f9603b1 change % change
linux tv-app debug .data.rel.ro 57424 58192 768 1.3
12 builds (for efr32, linux)
platform target config section 62a6f85 f9603b1 change % change
efr32 lighting-app BRD4161A .bss 113684 113692 8 0.0
.data 1752 1752 0 0.0
.text 735816 735912 96 0.0
lock-app BRD4161A .bss 111540 111548 8 0.0
.data 1712 1712 0 0.0
.text 715080 715176 96 0.0
window-app BRD4161A .bss 111852 111860 8 0.0
.data 1716 1716 0 0.0
.text 715876 716076 200 0.0
lighting-app BRD4161A+rpc .bss 130188 130196 8 0.0
.data 1852 1852 0 0.0
.text 723232 723336 104 0.0
linux all-clusters-app debug .bss 50160 50160 0 0.0
.data 978 978 0 0.0
.data.rel.ro 60640 60800 160 0.3
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 134517 134517 0 0.0
.text 1356946 1356946 0 0.0
chip-tool debug .bss 17680 17680 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 94896 94896 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 416 416 0 0.0
.rodata 208068 208068 0 0.0
.text 3642741 3642741 0 0.0
ota-provider-app debug .bss 37440 37440 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24488 24488 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110344 110344 0 0.0
.text 1023714 1023714 0 0.0
ota-requestor-app debug .bss 208320 208320 0 0.0
.data 752 752 0 0.0
.data.rel.ro 25928 25928 0 0.0
.dynamic 592 592 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 129000 129000 0 0.0
.text 1145602 1145602 0 0.0
shell debug .bss 16136 16136 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36496 36496 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 76495 76495 0 0.0
.text 599458 599458 0 0.0
tv-app debug .bss 215536 215568 32 0.0
.data 2032 2032 0 0.0
.data.rel.ro 57424 58192 768 1.3
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 152072 152072 0 0.0
.text 1454338 1454338 0 0.0
bridge-app debug+rpc .bss 51856 51856 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27112 27272 160 0.6
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 109740 109740 0 0.0
.text 1064293 1064293 0 0.0
lighting-app debug+rpc .bss 41176 41176 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 53808 53968 160 0.3
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 126897 126897 0 0.0
.text 1262178 1262178 0 0.0
4 builds (for mbed)
platform target config section 62a6f85 f9603b1 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 179604 179604 0 0.0
.data 5192 5192 0 0.0
.heap 851648 851648 0 0.0
.text 1251552 1251648 96 0.0
lighting-app CY8CPROTO_062_4343W+release .bss 171060 171060 0 0.0
.data 5464 5464 0 0.0
.heap 859920 859920 0 0.0
.text 1219256 1219352 96 0.0
lock-app CY8CPROTO_062_4343W+release .bss 169980 169988 8 0.0
.data 5432 5432 0 0.0
.heap 861032 861024 -8 -0.0
.text 1197280 1197384 104 0.0
pigweed-app CY8CPROTO_062_4343W+release .bss 11760 11760 0 0.0
.data 4360 4360 0 0.0
.heap 1020328 1020328 0 0.0
.text 103064 103064 0 0.0
12 builds (for esp32, nrfconnect)
platform target config section 62a6f85 f9603b1 change % change
esp32 all-clusters-app c3devkit .dram0.bss 58232 58232 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 198072 198176 104 0.1
.flash.text 874742 874742 0 0.0
.iram0.text 57564 57564 0 0.0
m5stack .dram0.bss 60744 60744 0 0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 206832 206928 96 0.0
.flash.text 905807 905807 0 0.0
.iram0.text 125115 125115 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 bss 112136 112136 0 0.0
rodata 97100 97200 100 0.1
text 577204 577204 0 0.0
lock-app nrf52840dk_nrf52840 bss 111208 111208 0 0.0
rodata 93500 93600 100 0.1
text 558764 558764 0 0.0
pigweed-app nrf52840dk_nrf52840 bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339456 339456 0 0.0
pump-app nrf52840dk_nrf52840 bss 111308 111308 0 0.0
rodata 94700 94800 100 0.1
text 561868 561868 0 0.0
pump-controller-app nrf52840dk_nrf52840 bss 111204 111208 4 0.0
rodata 93476 93576 100 0.1
text 558508 558508 0 0.0
shell nrf52840dk_nrf52840 bss 109072 109072 0 0.0
rodata 72536 72536 0 0.0
text 520324 520324 0 0.0
lighting-app nrf52840dk_nrf52840+rpc bss 108376 108380 4 0.0
rodata 87876 87976 100 0.1
text 550396 550396 0 0.0
nrf5340dk_nrf5340_cpuapp bss 113508 113512 4 0.0
rodata 92340 92440 100 0.1
text 506676 506676 0 0.0
lock-app nrf5340dk_nrf5340_cpuapp bss 112580 112584 4 0.0
rodata 88760 88860 100 0.1
text 488228 488228 0 0.0
shell nrf5340dk_nrf5340_cpuapp bss 110056 110056 0 0.0
rodata 67180 67180 0 0.0
text 440936 440936 0 0.0

@github-actions
Copy link

Size increase report for "gn_qpg-example-build" from 62a6f85

File Section File VM
chip-qpg6100-lighting-example.out .text 100 100
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-qpg6100-lighting-example.out.map and ./pull_artifact/chip-qpg6100-lighting-example.out.map:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: unknown file type for file './pull_artifact/chip-qpg6100-lighting-example.out.map'

Comparing ./master_artifact/chip-qpg6100-lighting-example.out and ./pull_artifact/chip-qpg6100-lighting-example.out:

sections,vmsize,filesize
.text,100,100
[Unmapped],0,-100

@Damian-Nordic Damian-Nordic merged commit 4ab05ae into project-chip:master Oct 26, 2021
@github-actions
Copy link

Size increase report for "esp32-example-build" from 62a6f85

File Section File VM
chip-all-clusters-app.elf .flash.rodata 104 104
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.flash.rodata,104,104
[Unmapped],0,-104

@github-actions
Copy link

Size increase report for "nrfconnect-example-build" from 62a6f85

File Section File VM
chip-lock.elf rodata 96 100
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
rodata,100,96

JasonLiuZhuoCheng pushed a commit to JasonLiuZhuoCheng/connectedhomeip that referenced this pull request Oct 28, 2021
@Damian-Nordic @JasonLiuZhuoCheng
[examples] Enable Descriptor cluster on all endpoints (project-chip#1…
14e4c32 
…0761)

Enable Descriptor cluster on all endpoints in all examples
to make sure that a controller can find out all clusters
supported by a given device.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@LuDuda LuDuda LuDuda approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@tecimovic tecimovic Awaiting requested review from tecimovic

@selissia selissia Awaiting requested review from selissia

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Damian-Nordic @tima-q @bzbarsky-apple @woody-apple @andy31415 @LuDuda