Remove const for Concrete*Path.h members

[vivien-apple]

Problem

The following code does not work because of Concrete*Path members beeing const.

void SomeMethod()
{
    CHIP_ERROR err = CHIP_NO_ERROR;
    chip::app::ConcreteCommandPath commandPath;

    ... some code...
    err = RetrieveEndpointClusterAndCommandIdsInSomeWays();
    SuccessOrExit(err);
    commandPath = chip:app::ConcreteCommandPath(endpointId, clusterId, commandId);

exit:
   ... some code...
}

Change overview

• Remove const for members

Testing

There is no behaviour changed afaict and I have some local changes where I need this so that's how I have checked that it works.

[github-actions]

PR #10756: Size comparison from c4a4361 to 4628004

5 builds (for k32w, p6, telink)

platform	target	config	section	c4a4361	4628004	change	% change
k32w	lock-app	k32w061+debug	.bss	69060	69060	0	0.0
			.data	1864	1864	0	0.0
			.text	515688	515688	0	0.0
	shell	k32w061+debug	.bss	55080	55080	0	0.0
			.data	672	672	0	0.0
			.text	357336	357336	0	0.0
	lighting-app	k32w061+se05x+release	.bss	78584	78584	0	0.0
			.data	1900	1900	0	0.0
			.text	614456	614456	0	0.0
p6	lock-app	default	.bss	68208	68208	0	0.0
			.data	2416	2416	0	0.0
			.heap	962720	962720	0	0.0
			.text	1126536	1126536	0	0.0
telink	lighting-app	tlsr9518adk80d	bss	70992	70992	0	0.0
			noinit	33216	33216	0	0.0
			text	458348	458348	0	0.0

17 builds (for efr32, linux, mbed, qpg)

platform	target	config	section	c4a4361	4628004	change	% change
efr32	lighting-app	BRD4161A	.bss	118028	118028	0	0.0
			.data	1800	1800	0	0.0
			.text	782888	782888	0	0.0
	lock-app	BRD4161A	.bss	115884	115884	0	0.0
			.data	1760	1760	0	0.0
			.text	762024	762024	0	0.0
	window-app	BRD4161A	.bss	116204	116204	0	0.0
			.data	1764	1764	0	0.0
			.text	762940	762940	0	0.0
	lighting-app	BRD4161A+rpc	.bss	131356	131356	0	0.0
			.data	1852	1852	0	0.0
			.text	762604	762604	0	0.0
linux	all-clusters-app	debug	.bss	52176	52176	0	0.0
			.data	978	978	0	0.0
			.data.rel.ro	59072	59072	0	0.0
			.dynamic	592	592	0	0.0
			.got	4080	4080	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	136245	136245	0	0.0
			.text	1341586	1341586	0	0.0
	chip-tool	debug	.bss	17520	17520	0	0.0
			.data	1584	1584	0	0.0
			.data.rel.ro	91920	91920	0	0.0
			.dynamic	592	592	0	0.0
			.got	4344	4344	0	0.0
			.init	27	27	0	0.0
			.init_array	416	416	0	0.0
			.rodata	184004	184004	0	0.0
			.text	3456805	3456805	0	0.0
	ota-provider-app	debug	.bss	37440	37440	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	23176	23176	0	0.0
			.dynamic	592	592	0	0.0
			.got	4008	4008	0	0.0
			.init	27	27	0	0.0
			.init_array	440	440	0	0.0
			.rodata	110024	110024	0	0.0
			.text	1009586	1009586	0	0.0
	ota-requestor-app	debug	.bss	205696	205696	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	24488	24488	0	0.0
			.dynamic	592	592	0	0.0
			.got	4136	4136	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	128776	128776	0	0.0
			.text	1129490	1129490	0	0.0
	shell	debug	.bss	16072	16072	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	35120	35120	0	0.0
			.dynamic	592	592	0	0.0
			.got	3496	3496	0	0.0
			.init	27	27	0	0.0
			.init_array	336	336	0	0.0
			.rodata	71823	71823	0	0.0
			.text	569906	569906	0	0.0
	tv-app	debug	.bss	216560	216560	0	0.0
			.data	2032	2032	0	0.0
			.data.rel.ro	56096	56096	0	0.0
			.dynamic	592	592	0	0.0
			.got	4400	4400	0	0.0
			.init	27	27	0	0.0
			.init_array	608	608	0	0.0
			.rodata	153384	153384	0	0.0
			.text	1444114	1444114	0	0.0
	bridge-app	debug+rpc	.bss	52880	52880	0	0.0
			.data	976	976	0	0.0
			.data.rel.ro	25784	25784	0	0.0
			.dynamic	592	592	0	0.0
			.got	3944	3944	0	0.0
			.init	27	27	0	0.0
			.init_array	400	400	0	0.0
			.rodata	110620	110620	0	0.0
			.text	1050661	1050661	0	0.0
	lighting-app	debug+rpc	.bss	42200	42200	0	0.0
			.data	1106	1106	0	0.0
			.data.rel.ro	52496	52496	0	0.0
			.dynamic	608	608	0	0.0
			.got	4104	4104	0	0.0
			.init	27	27	0	0.0
			.init_array	528	528	0	0.0
			.rodata	127793	127793	0	0.0
			.text	1250898	1250898	0	0.0
mbed	lighting-app	CY8CPROTO_062_4343W+release	.bss	172092	172092	0	0.0
			.data	5464	5464	0	0.0
			.heap	858888	858888	0	0.0
			.text	1220152	1220152	0	0.0
	lock-app	CY8CPROTO_062_4343W+release	.bss	171012	171012	0	0.0
			.data	5432	5432	0	0.0
			.heap	860000	860000	0	0.0
			.text	1198048	1198048	0	0.0
qpg	lighting-app	qpg6100+debug	.bss	53552	53552	0	0.0
			.data	996	996	0	0.0
			.text	486644	486644	0	0.0
	lock-app	qpg6100+debug	.bss	52496	52496	0	0.0
			.data	952	952	0	0.0
			.text	462712	462712	0	0.0
	persistent-storage-app	qpg6100+debug	.bss	17778	17778	0	0.0
			.data	280	280	0	0.0
			.text	102708	102708	0	0.0

12 builds (for esp32, nrfconnect)

platform	target	config	section	c4a4361	4628004	change	% change
esp32	all-clusters-app	c3devkit	.dram0.bss	60320	60320	0	0.0
			.dram0.data	16200	16200	0	0.0
			.flash.rodata	199128	199128	0	0.0
			.flash.text	872850	872850	0	0.0
			.iram0.text	57330	57330	0	0.0
		m5stack	.dram0.bss	62824	62824	0	0.0
			.dram0.data	32084	32084	0	0.0
			.flash.rodata	207872	207872	0	0.0
			.flash.text	903827	903915	88	0.0
			.iram0.text	125115	125115	0	0.0
nrfconnect	lighting-app	nrf52840dk_nrf52840	bss	112476	112476	0	0.0
			rodata	97780	97780	0	0.0
			text	577800	577800	0	0.0
	lock-app	nrf52840dk_nrf52840	bss	111544	111544	0	0.0
			rodata	94116	94116	0	0.0
			text	559288	559288	0	0.0
	pigweed-app	nrf52840dk_nrf52840	bss	51824	51824	0	0.0
			rodata	45776	45776	0	0.0
			text	339456	339456	0	0.0
	pump-app	nrf52840dk_nrf52840	bss	111612	111612	0	0.0
			rodata	95096	95096	0	0.0
			text	562440	562440	0	0.0
	pump-controller-app	nrf52840dk_nrf52840	bss	111552	111552	0	0.0
			rodata	94176	94176	0	0.0
			text	559080	559080	0	0.0
	shell	nrf52840dk_nrf52840	bss	107316	107316	0	0.0
			rodata	71644	71644	0	0.0
			text	519032	519032	0	0.0
	lighting-app	nrf52840dk_nrf52840+rpc	bss	108720	108720	0	0.0
			rodata	88564	88564	0	0.0
			text	551000	551000	0	0.0
		nrf5340dk_nrf5340_cpuapp	bss	113852	113852	0	0.0
			rodata	93020	93020	0	0.0
			text	507264	507264	0	0.0
	lock-app	nrf5340dk_nrf5340_cpuapp	bss	112916	112916	0	0.0
			rodata	89376	89376	0	0.0
			text	488744	488744	0	0.0
	shell	nrf5340dk_nrf5340_cpuapp	bss	108300	108300	0	0.0
			rodata	66288	66288	0	0.0
			text	439632	439632	0	0.0

[andy31415]

This is a failure of the goto pattern no?

Const correctes is generally useful. Do we have instances in the code where these paths are used but we cannot get rid of the goto pattern?

[andy31415]

Re-marking as approved - the "changes requested" seems a bit harsh. It seems to be we already pass things as const & for these paths so const correctness is preserved.

I would however like an aswer thogh: goto pattern forcing us to have c-style declarations and concessions in the code seems not right. I would much rather not use the goto exit.

No review at all from myself yet.

[vivien-apple]

Re-marking as approved - the "changes requested" seems a bit harsh. It seems to be we already pass things as const & for these paths so const correctness is preserved.

I would however like an aswer thogh: goto pattern forcing us to have c-style declarations and concessions in the code seems not right. I would much rather not use the goto exit.

Right. I have some other use case where I have Concrete*Path as class members and I would like to update them later instead of having to store a chip::EndpointId, chip::ClusterId and a chip::SomethingId.
I can declare a pointer to a Concrete*Path object but that forces me to manage memory which I do not really want to.

So this is not only about the goto pattern thing... but I used that as an example because this particular instance of the issue already exists into the codebase while the other use case I'm speaking of only exist onto my local fork at the moment.

[andy31415]

Approving for other usages (i.e. not goto exit, but things like "current path" in a class).

[andy31415]

Fast track reasoning: trivial change/refactor.

[vivien-apple]

As discussed on slack, I also needs it here : https://github.com/vivien-apple/connectedhomeip-1/blob/Tests_Node/examples/chip-tool/templates/partials/test_cluster.zapt#L112

I can workaround that by manually storing all those elements and making comparison against each but that sounds painful...