-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix codegen to handle the int sizes between int32 and int64 correctly. #10750
Merged
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:handle-weird-int-sizes
Oct 21, 2021
Merged
Fix codegen to handle the int sizes between int32 and int64 correctly. #10750
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:handle-weird-int-sizes
Oct 21, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes handling of eui64, not that we should be using that to start with. Does not enable Accessors bits for these, though, because it's not clear how they would be stored in the attribute store.
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
emargolis,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
mlepage-google,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
tcarmelveilleux,
turon,
wbschiller and
woody-apple
October 21, 2021 03:50
PR #10750: Size comparison from 6e22d13 to 2d6c7d5 8 builds (for k32w, p6, qpg, telink)
14 builds (for efr32, linux, mbed)
2 builds (for esp32)
10 builds (for nrfconnect)
|
erjiaqing
approved these changes
Oct 21, 2021
yunhanw-google
approved these changes
Oct 21, 2021
andy31415
approved these changes
Oct 21, 2021
Fast track rationale: small change with an obvious fix, non-trivial to unit test and can only examine result output. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes handling of eui64, not that we should be using that to
start with.
Does not enable Accessors bits for these, though, because it's not
clear how they would be stored in the attribute store.
Problem
Generating these types as
uint8_t *
, which is clearly wrong.Change overview
Generate them as
uint64_t
.Testing
The only actual change in the codegen is code we don't actually use yet.