-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Inet DNSResolver #10725
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
kpschoedel:x7715-inet-dns-2
Oct 20, 2021
Merged
Remove Inet DNSResolver #10725
bzbarsky-apple
merged 2 commits into
project-chip:master
from
kpschoedel:x7715-inet-dns-2
Oct 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem `DNSResolver` is unused. #### Change overview Remove it. #### Testing CI.
andy31415
approved these changes
Oct 20, 2021
PR #10725: Size comparison from 447cdd7 to 347b590 16 builds (for k32w, linux, p6, qpg, telink)
6 builds (for efr32, mbed)
12 builds (for esp32, nrfconnect)
|
bzbarsky-apple
approved these changes
Oct 20, 2021
LuDuda
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
DNSResolver
is unused.Change overview
Remove it.
Testing
CI.