-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add equality comparison to ConcreteAttributePath and ConcreteCommandPath #10707
Merged
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:App_ConcretePathEquality
Oct 20, 2021
Merged
Add equality comparison to ConcreteAttributePath and ConcreteCommandPath #10707
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:App_ConcretePathEquality
Oct 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
emargolis,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
msandstedt,
pan-apple,
sagar-apple,
saurabhst,
shana-apple,
tcarmelveilleux,
turon and
wbschiller
October 20, 2021 13:35
pullapprove
bot
requested review from
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
msandstedt,
pan-apple,
sagar-apple,
saurabhst,
shana-apple,
tcarmelveilleux,
turon,
wbschiller,
woody-apple and
yufengwangca
October 20, 2021 13:35
Damian-Nordic
approved these changes
Oct 20, 2021
vivien-apple
force-pushed
the
App_ConcretePathEquality
branch
from
October 20, 2021 13:47
111acad
to
fc0a8b0
Compare
PR #10707: Size comparison from 1c0ded5 to fc0a8b0 5 builds (for k32w, p6, telink)
12 builds (for efr32, linux)
2 builds (for mbed)
12 builds (for esp32, nrfconnect)
3 builds (for qpg)
|
msandstedt
approved these changes
Oct 20, 2021
bzbarsky-apple
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I have some code where I need to compare concrete paths, instead of manually comparing every elements it would be great if
ConcreteCommandPath
andConcreteAttributePath
knows how to do that.Change overview
ConcreteAttributePath
andConcreteCommandPath
Testing
It was tested locally by replacing some code I have.