Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a bridged switched device to the bridge app (#10302) #10703

Merged
merged 1 commit into from
Nov 3, 2021
Merged

Add a bridged switched device to the bridge app (#10302) #10703

merged 1 commit into from
Nov 3, 2021

Conversation

pjzander-signify
Copy link
Contributor

Problem

For testing the switch cluster on a Bridge device we want to add a (virtual) switch to the bridge app.

Change overview

  • Extended the switch cluster with the FeatureMap definitions
  • Enable the switch cluster in controller-clusters.zap
  • Add the FeatureMap attribute in controller-clusters.zap
  • Enable the MultiPressMax attribute in all-clusters-app.zap
  • Add the feature map attribute in all-clusters-app.zap
  • Add the switch cluster in bridge-app.zap
  • Add support for the switch cluster in the bridge-app

Testing

  • Manual tested with the chip-tool and the bridge-app
  • Passed all Github workflows.

@github-actions
Copy link

github-actions bot commented Oct 26, 2021 •
edited
Loading

PR #10703: Size comparison from 4ab05ae to df1619d

Increases above 1.0% from 4ab05ae to df1619d:

platform target config section 4ab05ae df1619d change % change
linux bridge-app debug+rpc .data 976 1552 576 59.0
20 builds (for efr32, k32w, linux, p6, qpg, telink)
platform target config section 4ab05ae df1619d change % change
efr32 lighting-app BRD4161A .bss 113692 113692 0 0.0
.data 1752 1752 0 0.0
.text 735912 735912 0 0.0
lock-app BRD4161A .bss 111548 111548 0 0.0
.data 1712 1712 0 0.0
.text 715176 715176 0 0.0
window-app BRD4161A .bss 111860 111860 0 0.0
.data 1716 1716 0 0.0
.text 716076 716076 0 0.0
lighting-app BRD4161A+rpc .bss 130196 130196 0 0.0
.data 1852 1852 0 0.0
.text 723336 723336 0 0.0
k32w lock-app k32w061+debug .bss 69196 69196 0 0.0
.data 1864 1864 0 0.0
.text 515240 515240 0 0.0
shell k32w061+debug .bss 63256 63256 0 0.0
.data 672 672 0 0.0
.text 359572 359572 0 0.0
lighting-app k32w061+se05x+release .bss 78720 78720 0 0.0
.data 1900 1900 0 0.0
.text 613876 613876 0 0.0
linux all-clusters-app debug .bss 50160 50192 32 0.1
.data 978 978 0 0.0
.data.rel.ro 60800 60864 64 0.1
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 134517 134517 0 0.0
.text 1356946 1356946 0 0.0
chip-tool debug .bss 17680 17680 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 94896 95040 144 0.2
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 416 416 0 0.0
.rodata 208068 208068 0 0.0
.text 3642741 3644501 1760 0.0
ota-provider-app debug .bss 37440 37440 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24488 24488 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110344 110344 0 0.0
.text 1023714 1023714 0 0.0
ota-requestor-app debug .bss 208320 208320 0 0.0
.data 752 752 0 0.0
.data.rel.ro 25928 25928 0 0.0
.dynamic 592 592 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 129000 129000 0 0.0
.text 1145602 1145602 0 0.0
shell debug .bss 16136 16136 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36496 36496 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 76495 76495 0 0.0
.text 599458 599458 0 0.0
tv-app debug .bss 215568 215568 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58192 58192 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 152072 152072 0 0.0
.text 1454338 1454338 0 0.0
bridge-app debug+rpc .bss 51856 51856 0 0.0
.data 976 1552 576 59.0
.data.rel.ro 27272 27544 272 1.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 109740 109772 32 0.0
.text 1064293 1067413 3120 0.3
lighting-app debug+rpc .bss 41176 41176 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 53968 53968 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 126897 126897 0 0.0
.text 1262178 1262178 0 0.0
p6 lock-app default .bss 67184 67184 0 0.0
.data 2416 2416 0 0.0
.heap 963744 963744 0 0.0
.text 1126192 1126192 0 0.0
qpg lighting-app qpg6100+debug .bss 52416 52416 0 0.0
.data 1000 1000 0 0.0
.text 485144 485144 0 0.0
lock-app qpg6100+debug .bss 51368 51368 0 0.0
.data 956 956 0 0.0
.text 461364 461364 0 0.0
persistent-storage-app qpg6100+debug .bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 149900 149900 0 0.0
telink lighting-app tlsr9518adk80d bss 69944 69944 0 0.0
noinit 33216 33216 0 0.0
text 457672 457672 0 0.0
14 builds (for mbed, nrfconnect)
platform target config section 4ab05ae df1619d change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 179604 179612 8 0.0
.data 5192 5192 0 0.0
.heap 851648 851640 -8 -0.0
.text 1251648 1251688 40 0.0
lighting-app CY8CPROTO_062_4343W+release .bss 171060 171060 0 0.0
.data 5464 5464 0 0.0
.heap 859920 859920 0 0.0
.text 1219352 1219352 0 0.0
lock-app CY8CPROTO_062_4343W+release .bss 169988 169988 0 0.0
.data 5432 5432 0 0.0
.heap 861024 861024 0 0.0
.text 1197384 1197384 0 0.0
pigweed-app CY8CPROTO_062_4343W+release .bss 11760 11760 0 0.0
.data 4360 4360 0 0.0
.heap 1020328 1020328 0 0.0
.text 103064 103064 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 bss 112136 112136 0 0.0
rodata 97200 97200 0 0.0
text 577204 577204 0 0.0
lock-app nrf52840dk_nrf52840 bss 111208 111208 0 0.0
rodata 93600 93600 0 0.0
text 558764 558764 0 0.0
pigweed-app nrf52840dk_nrf52840 bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339456 339456 0 0.0
pump-app nrf52840dk_nrf52840 bss 111308 111308 0 0.0
rodata 94800 94800 0 0.0
text 561868 561868 0 0.0
pump-controller-app nrf52840dk_nrf52840 bss 111208 111208 0 0.0
rodata 93576 93576 0 0.0
text 558508 558508 0 0.0
shell nrf52840dk_nrf52840 bss 109072 109072 0 0.0
rodata 72536 72536 0 0.0
text 520324 520324 0 0.0
lighting-app nrf52840dk_nrf52840+rpc bss 108380 108380 0 0.0
rodata 87976 87976 0 0.0
text 550396 550396 0 0.0
nrf5340dk_nrf5340_cpuapp bss 113512 113512 0 0.0
rodata 92440 92440 0 0.0
text 506676 506676 0 0.0
lock-app nrf5340dk_nrf5340_cpuapp bss 112584 112584 0 0.0
rodata 88860 88860 0 0.0
text 488228 488228 0 0.0
shell nrf5340dk_nrf5340_cpuapp bss 110056 110056 0 0.0
rodata 67180 67180 0 0.0
text 440936 440936 0 0.0
2 builds (for esp32)
platform target config section 4ab05ae df1619d change % change
esp32 all-clusters-app c3devkit .dram0.bss 58232 58240 8 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 198176 198208 32 0.0
.flash.text 874742 874742 0 0.0
.iram0.text 57564 57564 0 0.0
m5stack .dram0.bss 60744 60752 8 0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 206928 206968 40 0.0
.flash.text 905807 905895 88 0.0
.iram0.text 125115 125115 0 0.0

@github-actions
Copy link

Size increase report for "esp32-example-build" from 4ab05ae

File Section File VM
chip-all-clusters-app.elf .flash.rodata 32 32
chip-all-clusters-app.elf .dram0.bss 0 8
chip-all-clusters-app.elf .dram0.heap_start 0 -8
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.flash.rodata,32,32
.dram0.bss,8,0
.dram0.heap_start,-8,0
[Unmapped],0,-32

@andy31415
Copy link
Contributor

I think we should wait till #10681 goes in, at which point, the various list attributes being implemented in this file would need to be replaced with the AttributeAccessInterface, as well as removing the descriptor cluster bits in this file.

@mrjerryjohns - that PR is in now

@pullapprove pullapprove bot requested a review from selissia October 26, 2021 19:53
@andy31415
Copy link
Contributor

fast track: example app update

@andy31415
Copy link
Contributor

@pjzander-signify - could you fix the merge conflicts? Then we can merge as fast-track

@github-actions
Copy link

github-actions bot commented Nov 2, 2021 •
edited
Loading

PR #10703: Size comparison from 8ae5b65 to 05240f4

Increases above 0.2%:

platform target config section 8ae5b65 05240f4 change % change
linux bridge-app debug+rpc (read only) 1282077 1285549 3472 0.3
(read/write) 68488 69352 864 1.3
.data 992 1568 576 58.1
.data.rel.ro 27496 27768 272 1.0
.text 1075669 1078805 3136 0.3
lighting-app debug+rpc .rodata 128977 129457 480 0.4
Increases (7 builds for esp32, linux, mbed)
platform target config section 8ae5b65 05240f4 change % change
esp32 all-clusters-app c3devkit (read/write) 1307776 1307832 56 0.0
.dram0.bss 58592 58600 8 0.0
.flash.rodata 199488 199528 40 0.0
m5stack (read/write) 427544 427592 48 0.0
.dram0.bss 61088 61096 8 0.0
.flash.rodata 208192 208232 40 0.0
linux all-clusters-app debug (read only) 1689169 1689193 24 0.0
(read/write) 119664 119728 64 0.1
.bss 51120 51152 32 0.1
.data.rel.ro 62240 62272 32 0.1
bridge-app debug+rpc (read only) 1282077 1285549 3472 0.3
(read/write) 68488 69352 864 1.3
.bss 35024 35056 32 0.1
.data 992 1568 576 58.1
.data.rel.ro 27496 27768 272 1.0
.text 1075669 1078805 3136 0.3
chip-tool debug (read only) 4324637 4326765 2128 0.0
(read/write) 123936 124096 160 0.1
.data.rel.ro 98744 98888 144 0.1
.rodata 218512 218544 32 0.0
.text 3840709 3842469 1760 0.0
lighting-app debug+rpc .rodata 128977 129457 480 0.4
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2292664 2292696 32 0.0
.bss 179956 179964 8 0.0
.text 1255264 1255296 32 0.0
Decreases (11 builds for efr32, k32w, linux, mbed, nrfconnect, qpg, telink)
platform target config section 8ae5b65 05240f4 change % change
efr32 lighting-app BRD4161A (read only) 736548 736020 -528 -0.1
.text 736540 736012 -528 -0.1
BRD4161A+rpc (read only) 723988 723444 -544 -0.1
.text 723980 723436 -544 -0.1
k32w lighting-app k32w061+se05x+release (read/write) 699048 698780 -268 -0.0
.text 613492 613224 -268 -0.0
linux lighting-app debug+rpc (read only) 1541433 1538857 -2576 -0.2
.text 1279762 1276706 -3056 -0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 851264 851256 -8 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2271608 2271352 -256 -0.0
.text 1234208 1233952 -256 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860983 860727 -256 -0.0
text 577512 577252 -260 -0.0
nrf52840dk_nrf52840+rpc (read/write) 821807 821551 -256 -0.0
text 550688 550424 -264 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786010 785754 -256 -0.0
text 506980 506716 -264 -0.1
qpg lighting-app qpg6100+debug (read only) 490328 490064 -264 -0.1
.text 485008 484744 -264 -0.1
telink lighting-app tlsr9518adk80d (read/write) 662382 662078 -304 -0.0
text 457774 457470 -304 -0.1
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 8ae5b65 05240f4 change % change
efr32 lighting-app BRD4161A (read only) 736548 736020 -528 -0.1
(read/write) 114612 114612 0 0.0
.bss 112852 112852 0 0.0
.data 1760 1760 0 0.0
.text 736540 736012 -528 -0.1
BRD4161A+rpc (read only) 723988 723444 -544 -0.1
(read/write) 131216 131216 0 0.0
.bss 129356 129356 0 0.0
.data 1860 1860 0 0.0
.text 723980 723436 -544 -0.1
lock-app BRD4161A (read only) 715828 715828 0 0.0
(read/write) 112428 112428 0 0.0
.bss 110708 110708 0 0.0
.data 1720 1720 0 0.0
.text 715820 715820 0 0.0
window-app BRD4161A (read only) 716728 716728 0 0.0
(read/write) 112756 112756 0 0.0
.bss 111028 111028 0 0.0
.data 1724 1724 0 0.0
.text 716720 716720 0 0.0
esp32 all-clusters-app c3devkit (read only) 880486 880486 0 0.0
(read/write) 1307776 1307832 56 0.0
.dram0.bss 58592 58600 8 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 199488 199528 40 0.0
.flash.text 880486 880486 0 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 911507 911507 0 0.0
(read/write) 427544 427592 48 0.0
.dram0.bss 61088 61096 8 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 208192 208232 40 0.0
.flash.text 911507 911507 0 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699048 698780 -268 -0.0
.bss 77848 77848 0 0.0
.data 1908 1908 0 0.0
.text 613492 613224 -268 -0.0
lock-app k32w061+debug (read/write) 591356 591356 0 0.0
.bss 68364 68364 0 0.0
.data 1872 1872 0 0.0
.text 515320 515320 0 0.0
shell k32w061+debug (read/write) 424748 424748 0 0.0
.bss 63288 63288 0 0.0
.data 672 672 0 0.0
.text 359084 359084 0 0.0
linux all-clusters-app debug (read only) 1689169 1689193 24 0.0
(read/write) 119664 119728 64 0.1
.bss 51120 51152 32 0.1
.data 1042 1042 0 0.0
.data.rel.ro 62240 62272 32 0.1
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 139285 139285 0 0.0
.text 1416514 1416514 0 0.0
bridge-app debug+rpc (read only) 1282077 1285549 3472 0.3
(read/write) 68488 69352 864 1.3
.bss 35024 35056 32 0.1
.data 992 1568 576 58.1
.data.rel.ro 27496 27768 272 1.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 110852 110852 0 0.0
.text 1075669 1078805 3136 0.3
chip-tool debug (read only) 4324637 4326765 2128 0.0
(read/write) 123936 124096 160 0.1
.bss 18192 18192 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 98744 98888 144 0.1
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 218512 218544 32 0.0
.text 3840709 3842469 1760 0.0
lighting-app debug+rpc (read only) 1541433 1538857 -2576 -0.2
(read/write) 101680 101680 0 0.0
.bss 40696 40696 0 0.0
.data 1138 1138 0 0.0
.data.rel.ro 54560 54560 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128977 129457 480 0.4
.text 1279762 1276706 -3056 -0.2
ota-provider-app debug (read only) 1241929 1241929 0 0.0
(read/write) 67520 67520 0 0.0
.bss 37120 37120 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24568 24568 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 111784 111784 0 0.0
.text 1034066 1034066 0 0.0
ota-requestor-app debug (read only) 1309225 1309225 0 0.0
(read/write) 76840 76840 0 0.0
.bss 45376 45376 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25512 25512 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 122752 122752 0 0.0
.text 1088754 1088754 0 0.0
shell debug (read only) 785809 785809 0 0.0
(read/write) 57664 57664 0 0.0
.bss 16104 16104 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77551 77551 0 0.0
.text 606770 606770 0 0.0
tv-app debug (read only) 1789321 1789321 0 0.0
(read/write) 289240 289240 0 0.0
.bss 222736 222736 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 58784 58784 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 154584 154584 0 0.0
.text 1492546 1492546 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2292664 2292696 32 0.0
.bss 179956 179964 8 0.0
.data 5224 5224 0 0.0
.heap 851264 851256 -8 -0.0
.text 1255264 1255296 32 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2271608 2271352 -256 -0.0
.bss 172004 172004 0 0.0
.data 5576 5576 0 0.0
.heap 858864 858864 0 0.0
.text 1234208 1233952 -256 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2249328 2249328 0 0.0
.bss 170900 170900 0 0.0
.data 5560 5560 0 0.0
.heap 859984 859984 0 0.0
.text 1211928 1211928 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048392 2048392 0 0.0
.bss 156248 156248 0 0.0
.data 4968 4968 0 0.0
.heap 875232 875232 0 0.0
.text 1010992 1010992 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860983 860727 -256 -0.0
bss 111312 111312 0 0.0
rodata 96536 96536 0 0.0
text 577512 577252 -260 -0.0
nrf52840dk_nrf52840+rpc (read/write) 821807 821551 -256 -0.0
bss 107552 107552 0 0.0
rodata 87312 87312 0 0.0
text 550688 550424 -264 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786010 785754 -256 -0.0
bss 112688 112688 0 0.0
rodata 91780 91780 0 0.0
text 506980 506716 -264 -0.1
lock-app nrf52840dk_nrf52840 (read/write) 837675 837675 0 0.0
bss 110348 110348 0 0.0
rodata 92892 92892 0 0.0
text 558992 558992 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 762986 762986 0 0.0
bss 111756 111756 0 0.0
rodata 88196 88196 0 0.0
text 488552 488552 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 843783 843783 0 0.0
bss 110484 110484 0 0.0
rodata 94600 94600 0 0.0
text 563172 563172 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837547 837547 0 0.0
bss 110384 110384 0 0.0
rodata 92892 92892 0 0.0
text 558728 558728 0 0.0
shell nrf52840dk_nrf52840 (read/write) 775867 775867 0 0.0
bss 109104 109104 0 0.0
rodata 72400 72400 0 0.0
text 519772 519772 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690922 690922 0 0.0
bss 110084 110084 0 0.0
rodata 67044 67044 0 0.0
text 440372 440372 0 0.0
p6 lock-app default (read/write) 2167688 2167688 0 0.0
.bss 66352 66352 0 0.0
.data 2424 2424 0 0.0
.heap 964568 964568 0 0.0
.text 1125952 1125952 0 0.0
qpg lighting-app qpg6100+debug (read only) 490328 490064 -264 -0.1
(read/write) 114144 114144 0 0.0
.bss 50408 50408 0 0.0
.data 1008 1008 0 0.0
.text 485008 484744 -264 -0.1
lock-app qpg6100+debug (read only) 466668 466668 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49352 49352 0 0.0
.data 964 964 0 0.0
.text 461348 461348 0 0.0
persistent-storage-app qpg6100+debug (read only) 155796 155796 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27760 27760 0 0.0
.data 372 372 0 0.0
.text 150476 150476 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662382 662078 -304 -0.0
bss 69116 69116 0 0.0
noinit 33216 33216 0 0.0
text 457774 457470 -304 -0.1

@github-actions
Copy link

github-actions bot commented Nov 2, 2021 •
edited
Loading

PR #10703: Size comparison from eddd4f7 to e0ab41c

Increases (1 build for mbed)
platform target config section eddd4f7 e0ab41c change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2292704 2292736 32 0.0
.bss 179956 179964 8 0.0
.text 1255304 1255336 32 0.0
Decreases (1 build for mbed)
platform target config section eddd4f7 e0ab41c change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 851264 851256 -8 -0.0
Full report (15 builds for mbed, nrfconnect)
platform target config section eddd4f7 e0ab41c change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2292704 2292736 32 0.0
.bss 179956 179964 8 0.0
.data 5224 5224 0 0.0
.heap 851264 851256 -8 -0.0
.text 1255304 1255336 32 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2271648 2271648 0 0.0
.bss 172004 172004 0 0.0
.data 5576 5576 0 0.0
.heap 858864 858864 0 0.0
.text 1234248 1234248 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2249368 2249368 0 0.0
.bss 170900 170900 0 0.0
.data 5560 5560 0 0.0
.heap 859984 859984 0 0.0
.text 1211968 1211968 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048432 2048432 0 0.0
.bss 156248 156248 0 0.0
.data 4968 4968 0 0.0
.heap 875232 875232 0 0.0
.text 1011032 1011032 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861027 861027 0 0.0
bss 111312 111312 0 0.0
rodata 96548 96548 0 0.0
text 577548 577548 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 821851 821851 0 0.0
bss 107552 107552 0 0.0
rodata 87324 87324 0 0.0
text 550720 550720 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786050 786050 0 0.0
bss 112688 112688 0 0.0
rodata 91788 91788 0 0.0
text 507012 507012 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 837731 837731 0 0.0
bss 110348 110348 0 0.0
rodata 92900 92900 0 0.0
text 559028 559028 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763030 763030 0 0.0
bss 111756 111756 0 0.0
rodata 88208 88208 0 0.0
text 488584 488584 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 843843 843843 0 0.0
bss 110484 110484 0 0.0
rodata 94612 94612 0 0.0
text 563208 563208 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837587 837587 0 0.0
bss 110384 110384 0 0.0
rodata 92900 92900 0 0.0
text 558764 558764 0 0.0
shell nrf52840dk_nrf52840 (read/write) 775911 775911 0 0.0
bss 109104 109104 0 0.0
rodata 72412 72412 0 0.0
text 519804 519804 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690962 690962 0 0.0
bss 110084 110084 0 0.0
rodata 67052 67052 0 0.0
text 440404 440404 0 0.0

@bzbarsky-apple
Copy link
Contributor

@msandstedt @saurabhst @jepenven-silabs @jmartinez-silabs @LuDuda @Damian-Nordic Please take a look?

@bzbarsky-apple bzbarsky-apple merged commit d920345 into project-chip:master Nov 3, 2021
@pjzander-signify pjzander-signify deleted the issue_10302 branch November 3, 2021 08:25
@pjzander-signify pjzander-signify linked an issue Nov 3, 2021 that may be closed by this pull request
Add a bridged switched device to the bridge app #10302
Closed
andy31415 pushed a commit that referenced this pull request Nov 3, 2021
@pjzander-signify @andreilitvin
Add a bridged switched device to the bridge app (#10703)
d9e8c75
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@pjzander-signify
Add a bridged switched device to the bridge app (project-chip#10703)
e0dbb22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@woody-apple woody-apple woody-apple approved these changes

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@tecimovic tecimovic Awaiting requested review from tecimovic

@selissia selissia Awaiting requested review from selissia

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

Assignees
No one assigned
Labels
app controller darwin examples fast track review - pending
Projects
None yet
Milestone
Test Event 7
Development

Successfully merging this pull request may close these issues.

Add a bridged switched device to the bridge app
7 participants
@pjzander-signify @andy31415 @bzbarsky-apple @mrjerryjohns @woody-apple @jmartinez-silabs @franck-apple