-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Fix build by changing computePaseVerifier to take device pointer #10672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
mlepage-google,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple and
saurabhst
October 19, 2021 21:52
pullapprove
bot
requested review from
shana-apple,
vivien-apple,
wbschiller,
woody-apple and
yunhanw-google
October 19, 2021 21:52
PR #10672: Size comparison from 4efc582 to ec3bcdd 2 builds (for p6, telink)
6 builds (for k32w, qpg)
14 builds (for efr32, linux, mbed)
12 builds (for esp32, nrfconnect)
|
bzbarsky-apple
approved these changes
Oct 19, 2021
andy31415
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
computePaseVerifier
to take in a device pointer, which is expected to be the connected device pointer when called from an app.Testing
computePaseVerifier
manually from CHIPTool app.