-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't double-send certs #10666
Merged
Merged
Don't double-send certs #10666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When device attestation was added, it added a call to send the operational certs right after device attestatation. This was previously done as a separate stage in the state machine and it was also added as a separate stage after device attestation. This causes the certs to be sent twice.
(cecille): device attestation casues operational cert provisioinging to happen, This should be a separate stage.connectedhomeip/src/controller/CHIPDeviceController.cpp Lines 1846 to 1849 in c9c677a
This comment was generated by todo based on a
|
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
franck-apple,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
shana-apple,
tcarmelveilleux and
turon
October 19, 2021 19:29
pullapprove
bot
requested review from
vivien-apple,
wbschiller,
woody-apple and
yunhanw-google
October 19, 2021 19:29
PR #10666: Size comparison from 87c3a1a to c9c677a 5 builds (for p6, qpg, telink)
17 builds (for efr32, k32w, linux, mbed)
2 builds (for esp32)
10 builds (for nrfconnect)
|
yunhanw-google
approved these changes
Oct 19, 2021
jmartinez-silabs
approved these changes
Oct 20, 2021
msandstedt
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When device attestation was added, it added a call to send the
operational certs right after device attestatation. This was
previously done as a separate stage in the state machine and it was
also added as a separate stage after device attestation. This causes
the certs to be sent twice.
Change overview
Removes the second explicit stage to add certs.
Testing
Checked fabric table logs on the linux lighting app and saw only a single fabric added on the first commissioning when using on network commissioning.