-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove AsyncDNSResolver #10660
Merged
Damian-Nordic
merged 1 commit into
project-chip:master
from
kpschoedel:x7715-inet-dns-1
Oct 20, 2021
Merged
Remove AsyncDNSResolver #10660
Damian-Nordic
merged 1 commit into
project-chip:master
from
kpschoedel:x7715-inet-dns-1
Oct 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem `AsyncDNSResolver` is unused, and also uses threading internally, which interferes with threading cleanup (issue project-chip#7725). #### Change overview Remove it. #### Testing CI. (This code had no unit tests.)
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
emargolis,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
shana-apple and
vivien-apple
October 19, 2021 18:30
pullapprove
bot
requested review from
wbschiller,
woody-apple,
yufengwangca and
yunhanw-google
October 19, 2021 18:30
msandstedt
approved these changes
Oct 19, 2021
PR #10660: Size comparison from 87c3a1a to d1dad71 10 builds (for k32w, mbed, p6, qpg, telink)
12 builds (for efr32, linux)
12 builds (for esp32, nrfconnect)
|
mspang
approved these changes
Oct 19, 2021
Damian-Nordic
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
AsyncDNSResolver
is unused, and also uses threading internally,which interferes with threading cleanup (issue #7725).
Change overview
Remove it.
Testing
CI. (This code had no unit tests.)