-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ameba] Remove python2 from dockerfile #10654
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
emargolis,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
msandstedt,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
shana-apple,
vivien-apple and
wbschiller
October 19, 2021 11:53
pullapprove
bot
requested review from
woody-apple,
yufengwangca and
yunhanw-google
October 19, 2021 11:53
PR #10654: Size comparison from 4c7f664 to 8ffa9ab 5 builds (for k32w, p6, telink)
15 builds (for efr32, linux, qpg)
2 builds (for mbed)
|
andy31415
requested changes
Oct 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two changes please:
- this changes docker images, so please update the docker version
- the
git clone
has to be from a fixed SHA so that docker builds are reproducible (builds today should be the same as builds 1 month from now)
andy31415
approved these changes
Oct 19, 2021
PR #10654: Size comparison from 83dfc06 to 11285c0 2 builds (for p6, telink)
18 builds (for efr32, k32w, linux, qpg)
2 builds (for mbed)
12 builds (for esp32, nrfconnect)
|
bzbarsky-apple
approved these changes
Oct 19, 2021
PR #10654: Size comparison from 83dfc06 to f60e719 1 build (for telink)
15 builds (for k32w, linux, p6, qpg)
6 builds (for efr32, mbed)
12 builds (for esp32, nrfconnect)
|
LuDuda
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
To be aligned with the change applied in ameba sdk for fixing the 'python2: not found' issue in vscode instance build.
Change overview
Modification on dockerfile.
Testing
Tested with build_examples build without python2 installed.