Update chip-tool to use the InvokeCommand API #10611

vivien-apple · 2021-10-18T14:42:27Z

Problem

chip-tool command line does not use the InvokeCommand API for most commands

Change overview

Update chip-tool to use the new InvokeCommand API for most commands

Testing

I have manually tested it.

vivien-apple · 2021-10-18T14:45:46Z

Answering #10498 (comment) here.

I disagree with this and I would be happy to hear the rationale behind it, especially given the fact that #10498 contains a template to fill in nested arguments such as list of struct that contains list from json.
An easy thing to do for chip-tool for example is to let it absorb json string for such arguments and use the same code than the one used for generating tests from YAML.

vivien-apple · 2021-10-18T14:50:57Z

CI will likely be red since BitFlags have landed and this PR does not support them properly...

github-actions · 2021-10-18T15:26:37Z

PR #10611: Size comparison from 1cb7d96 to 6cd4b2e

14 builds

platform	target	config	section	`1cb7d96`	`6cd4b2e`
efr32	lighting-app	BRD4161A	.bss	118020	118020
			.data	1800	1800
			.text	782564	782564
	lock-app	BRD4161A	.bss	115892	115892
			.data	1760	1760
			.text	761868	761868
	window-app	BRD4161A	.bss	116212	116212
			.data	1764	1764
			.text	762792	762792
	lighting-app	BRD4161A+rpc	.bss	131348	131348
			.data	1852	1852
			.text	762308	762308
k32w	lock-app	k32w061+debug	.bss	69052	69052
			.data	1864	1864
			.text	515320	515320
	shell	k32w061+debug	.bss	55080	55080
			.data	672	672
			.text	357300	357300
	lighting-app	k32w061+se05x+release	.bss	78560	78560
			.data	1900	1900
			.text	613928	613928
mbed	lighting-app	CY8CPROTO_062_4343W+release	.bss	172148	172148
			.data	5464	5464
			.heap	858832	858832
			.text	1219576	1219576
	lock-app	CY8CPROTO_062_4343W+release	.bss	171084	171084
			.data	5432	5432
			.heap	859928	859928
			.text	1197632	1197632
p6	lock-app	default	.bss	68216	68216
			.data	2416	2416
			.heap	962712	962712
			.text	1126424	1126424
qpg	lighting-app	qpg6100+debug	.bss	53536	53536
			.data	996	996
			.text	486240	486240
	lock-app	qpg6100+debug	.bss	52488	52488
			.data	952	952
			.text	462496	462496
	persistent-storage-app	qpg6100+debug	.bss	17778	17778
			.data	280	280
			.text	102704	102704
telink	lighting-app	tlsr9518adk80d	bss	70984	70984
			noinit	33216	33216
			text	458218	458218

12 builds

platform	target	config	section	`1cb7d96`	`6cd4b2e`
esp32	all-clusters-app	c3devkit	.dram0.bss	60280	60280
			.dram0.data	16192	16192
			.flash.rodata	198624	198624
			.flash.text	870186	870186
			.iram0.text	57330	57330
		m5stack	.dram0.bss	62776	62776
			.dram0.data	32084	32084
			.flash.rodata	207056	207056
			.flash.text	900547	900547
			.iram0.text	125115	125115
nrfconnect	lighting-app	nrf52840dk_nrf52840	bss	112316	112316
			rodata	97528	97528
			text	577560	577560
	lock-app	nrf52840dk_nrf52840	bss	111348	111348
			rodata	94028	94028
			text	559060	559060
	pigweed-app	nrf52840dk_nrf52840	bss	51772	51772
			rodata	45772	45772
			text	339392	339392
	pump-app	nrf52840dk_nrf52840	bss	111416	111416
			rodata	95008	95008
			text	562216	562216
	pump-controller-app	nrf52840dk_nrf52840	bss	111356	111356
			rodata	94088	94088
			text	558852	558852
	shell	nrf52840dk_nrf52840	bss	107316	107316
			rodata	71640	71640
			text	519032	519032
	lighting-app	nrf52840dk_nrf52840+rpc	bss	108556	108556
			rodata	88320	88320
			text	550764	550764
		nrf5340dk_nrf5340_cpuapp	bss	113688	113688
			rodata	92772	92772
			text	507020	507020
	lock-app	nrf5340dk_nrf5340_cpuapp	bss	112720	112720
			rodata	89284	89284
			text	488516	488516
	shell	nrf5340dk_nrf5340_cpuapp	bss	108300	108300
			rodata	66284	66284
			text	439632	439632

mrjerryjohns · 2021-10-18T17:10:12Z

An easy thing to do for chip-tool for example is to let it absorb json string for such arguments and use the same code than the one used for generating tests from YAML.

Passing JSON string at the command-line as an argument feels quite un-wieldy to me from a developer-friendliness standpoint:

chip-tool test-cluster TestStructArrayArgumentRequest 1 "{ arg1: [ { a: 8, b: false, c: { a: 20, b: false } }, { a: 8, b: false, c: { a: 20, b: false } } ], arg3: 3 }"

If the user enters the wrong JSON string, or the wrong type/field-name above, would there be schema validation provided that would inform them of what they did wrong?

A potential alternative based on Python:

req = TestStructArrayArgumentRequest()
req.arg1.append(NestedStructList(a: 8, b: false, c: SimpleStruct(a: 20, b: false)))
resp = await session.SendCommand(req)

There is type-safety built in above, as well as rich help text we can provide for each generated type to guide the user to filling in the arguments.

This is in addition to the fact that we have an interactive shell with history that can be used to send previous commands, print out responses/errors, parse out the response and access individual fields in it, etc.

vivien-apple · 2021-10-18T20:30:01Z

An easy thing to do for chip-tool for example is to let it absorb json string for such arguments and use the same code than the one used for generating tests from YAML.

Passing JSON string at the command-line as an argument feels quite un-wieldy to me from a developer-friendliness standpoint:
chip-tool test-cluster TestStructArrayArgumentRequest 1 "{ arg1: [ { a: 8, b: false, c: { a: 20, b: false } }, { a: 8, b: false, c: { a: 20, b: false } } ], arg3: 3 }"
If the user enters the wrong JSON string, or the wrong type/field-name above, would there be schema validation provided that would inform them of what they did wrong?

A potential alternative based on Python:
req = TestStructArrayArgumentRequest()
req.arg1.append(NestedStructList(a: 8, b: false, c: SimpleStruct(a: 20, b: false)))
resp = await session.SendCommand(req)
There is type-safety built in above, as well as rich help text we can provide for each generated type to guide the user to filling in the arguments.

This is in addition to the fact that we have an interactive shell with history that can be used to send previous commands, print out responses/errors, parse out the response and access individual fields in it, etc.

I am not arguing about the fact that passing JSON string is better than using python with interactive shell.

The only thing I'm saying is that there are some developers using chip-tool, and it may be convenient to issues commands with complex types from time to time.
Now the fact that there are 2 developer tools, and the fact they have a lot of use cases in common is a subject in itself.

github-actions · 2021-10-18T21:40:53Z

PR #10611: Size comparison from c12fdbe to 00d3f64

8 builds

platform	target	config	section	`c12fdbe`	`00d3f64`
k32w	lock-app	k32w061+debug	.bss	69052	69052
			.data	1864	1864
			.text	515352	515352
	shell	k32w061+debug	.bss	55080	55080
			.data	672	672
			.text	357332	357332
	lighting-app	k32w061+se05x+release	.bss	78576	78576
			.data	1900	1900
			.text	614136	614136
p6	lock-app	default	.bss	68216	68216
			.data	2416	2416
			.heap	962712	962712
			.text	1126472	1126472
qpg	lighting-app	qpg6100+debug	.bss	53552	53552
			.data	996	996
			.text	486448	486448
	lock-app	qpg6100+debug	.bss	52488	52488
			.data	952	952
			.text	462520	462520
	persistent-storage-app	qpg6100+debug	.bss	17778	17778
			.data	280	280
			.text	102704	102704
telink	lighting-app	tlsr9518adk80d	bss	71000	71000
			noinit	33216	33216
			text	458220	458220

Increases above 1.0% from c12fdbe to 00d3f64:

platform	target	config	section	`c12fdbe`	`00d3f64`	change	% change
linux	chip-tool	debug	.data.rel.ro	86192	89216	3024	3.5
			.rodata	178476	183228	4752	2.7
			.text	`2859461`	3407301	547840	19.2

14 builds

platform	target	config	section	`c12fdbe`	`00d3f64`	change	% change
efr32	lighting-app	BRD4161A	.bss	118036	118036	0	0.0
			.data	1800	1800	0	0.0
			.text	782788	782788	0	0.0
	lock-app	BRD4161A	.bss	115892	115892	0	0.0
			.data	1760	1760	0	0.0
			.text	761932	761932	0	0.0
	window-app	BRD4161A	.bss	116212	116212	0	0.0
			.data	1764	1764	0	0.0
			.text	762840	762840	0	0.0
	lighting-app	BRD4161A+rpc	.bss	131364	131364	0	0.0
			.data	1852	1852	0	0.0
			.text	762532	762532	0	0.0
linux	all-clusters-app	debug	.bss	52176	52176	0	0.0
			.data	978	978	0	0.0
			.data.rel.ro	58688	58688	0	0.0
			.dynamic	592	592	0	0.0
			.got	4072	4072	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	136149	136149	0	0.0
			.text	1344930	1344930	0	0.0
	chip-tool	debug	.bss	17552	17552	0	0.0
			.data	1584	1584	0	0.0
			.data.rel.ro	86192	89216	3024	3.5
			.dynamic	592	592	0	0.0
			.got	4344	4344	0	0.0
			.init	27	27	0	0.0
			.init_array	416	416	0	0.0
			.rodata	178476	183228	4752	2.7
			.text	`2859461`	3407301	547840	19.2
	ota-provider-app	debug	.bss	37472	37472	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	23176	23176	0	0.0
			.dynamic	592	592	0	0.0
			.got	4008	4008	0	0.0
			.init	27	27	0	0.0
			.init_array	440	440	0	0.0
			.rodata	109832	109832	0	0.0
			.text	1010354	1010354	0	0.0
	ota-requestor-app	debug	.bss	205728	205728	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	24488	24488	0	0.0
			.dynamic	592	592	0	0.0
			.got	4136	4136	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	128328	128328	0	0.0
			.text	1129666	1129666	0	0.0
	shell	debug	.bss	16072	16072	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	35120	35120	0	0.0
			.dynamic	592	592	0	0.0
			.got	3496	3496	0	0.0
			.init	27	27	0	0.0
			.init_array	336	336	0	0.0
			.rodata	71855	71855	0	0.0
			.text	569858	569858	0	0.0
	tv-app	debug	.bss	216400	216400	0	0.0
			.data	2032	2032	0	0.0
			.data.rel.ro	55872	55872	0	0.0
			.dynamic	592	592	0	0.0
			.got	4400	4400	0	0.0
			.init	27	27	0	0.0
			.init_array	608	608	0	0.0
			.rodata	151848	151848	0	0.0
			.text	1464242	1464242	0	0.0
	bridge-app	debug+rpc	.bss	52912	52912	0	0.0
			.data	976	976	0	0.0
			.data.rel.ro	25784	25784	0	0.0
			.dynamic	592	592	0	0.0
			.got	3944	3944	0	0.0
			.init	27	27	0	0.0
			.init_array	400	400	0	0.0
			.rodata	110452	110452	0	0.0
			.text	1052389	1052389	0	0.0
	lighting-app	debug+rpc	.bss	42232	42232	0	0.0
			.data	1106	1106	0	0.0
			.data.rel.ro	52496	52496	0	0.0
			.dynamic	608	608	0	0.0
			.got	4104	4104	0	0.0
			.init	27	27	0	0.0
			.init_array	528	528	0	0.0
			.rodata	127665	127665	0	0.0
			.text	`1253666`	`1253666`	0	0.0
mbed	lighting-app	CY8CPROTO_062_4343W+release	.bss	172164	172164	0	0.0
			.data	5464	5464	0	0.0
			.heap	858816	858816	0	0.0
			.text	1219800	1219800	0	0.0
	lock-app	CY8CPROTO_062_4343W+release	.bss	171084	171084	0	0.0
			.data	5432	5432	0	0.0
			.heap	859928	859928	0	0.0
			.text	1197632	1197632	0	0.0

github-actions · 2021-10-18T22:19:48Z

PR #10611: Size comparison from ca22841 to e3cb094

5 builds

platform	target	config	section	`ca22841`	`e3cb094`
p6	lock-app	default	.bss	68216	68216
			.data	2416	2416
			.heap	962712	962712
			.text	1126464	1126464
qpg	lighting-app	qpg6100+debug	.bss	53552	53552
			.data	996	996
			.text	486440	486440
	lock-app	qpg6100+debug	.bss	52488	52488
			.data	952	952
			.text	462512	462512
	persistent-storage-app	qpg6100+debug	.bss	17778	17778
			.data	280	280
			.text	102704	102704
telink	lighting-app	tlsr9518adk80d	bss	71000	71000
			noinit	33216	33216
			text	458216	458216

Increases above 1.0% from ca22841 to e3cb094:

platform	target	config	section	`ca22841`	`e3cb094`	change	% change
linux	chip-tool	debug	.data.rel.ro	86192	89216	3024	3.5
			.rodata	178700	183484	4784	2.7
			.text	2859717	`3401845`	542128	19.0

15 builds

platform	target	config	section	`ca22841`	`e3cb094`	change	% change
efr32	lighting-app	BRD4161A	.bss	118036	118036	0	0.0
			.data	1800	1800	0	0.0
			.text	782788	782788	0	0.0
	lock-app	BRD4161A	.bss	115892	115892	0	0.0
			.data	1760	1760	0	0.0
			.text	761924	761924	0	0.0
	window-app	BRD4161A	.bss	116212	116212	0	0.0
			.data	1764	1764	0	0.0
			.text	762840	762840	0	0.0
	lighting-app	BRD4161A+rpc	.bss	131364	131364	0	0.0
			.data	1852	1852	0	0.0
			.text	762540	762540	0	0.0
k32w	lock-app	k32w061+debug	.bss	69052	69052	0	0.0
			.data	1864	1864	0	0.0
			.text	515344	515344	0	0.0
	shell	k32w061+debug	.bss	55080	55080	0	0.0
			.data	672	672	0	0.0
			.text	357332	357332	0	0.0
	lighting-app	k32w061+se05x+release	.bss	78576	78576	0	0.0
			.data	1900	1900	0	0.0
			.text	614128	614128	0	0.0
linux	all-clusters-app	debug	.bss	52176	52176	0	0.0
			.data	978	978	0	0.0
			.data.rel.ro	58688	58688	0	0.0
			.dynamic	592	592	0	0.0
			.got	4072	4072	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	136149	136149	0	0.0
			.text	1344946	1344946	0	0.0
	chip-tool	debug	.bss	17552	17552	0	0.0
			.data	1584	1584	0	0.0
			.data.rel.ro	86192	89216	3024	3.5
			.dynamic	592	592	0	0.0
			.got	4344	4344	0	0.0
			.init	27	27	0	0.0
			.init_array	416	416	0	0.0
			.rodata	178700	183484	4784	2.7
			.text	2859717	`3401845`	542128	19.0
	ota-provider-app	debug	.bss	37472	37472	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	23176	23176	0	0.0
			.dynamic	592	592	0	0.0
			.got	4008	4008	0	0.0
			.init	27	27	0	0.0
			.init_array	440	440	0	0.0
			.rodata	109832	109832	0	0.0
			.text	1010370	1010370	0	0.0
	ota-requestor-app	debug	.bss	205728	205728	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	24488	24488	0	0.0
			.dynamic	592	592	0	0.0
			.got	4136	4136	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	128552	128552	0	0.0
			.text	`1129922`	`1129922`	0	0.0
	shell	debug	.bss	16072	16072	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	35120	35120	0	0.0
			.dynamic	592	592	0	0.0
			.got	3496	3496	0	0.0
			.init	27	27	0	0.0
			.init_array	336	336	0	0.0
			.rodata	71855	71855	0	0.0
			.text	569858	569858	0	0.0
	tv-app	debug	.bss	216400	216400	0	0.0
			.data	2032	2032	0	0.0
			.data.rel.ro	55872	55872	0	0.0
			.dynamic	592	592	0	0.0
			.got	4400	4400	0	0.0
			.init	27	27	0	0.0
			.init_array	608	608	0	0.0
			.rodata	152072	152072	0	0.0
			.text	`1464498`	`1464498`	0	0.0
	bridge-app	debug+rpc	.bss	52912	52912	0	0.0
			.data	976	976	0	0.0
			.data.rel.ro	25784	25784	0	0.0
			.dynamic	592	592	0	0.0
			.got	3944	3944	0	0.0
			.init	27	27	0	0.0
			.init_array	400	400	0	0.0
			.rodata	110452	110452	0	0.0
			.text	`1052405`	`1052405`	0	0.0
	lighting-app	debug+rpc	.bss	42232	42232	0	0.0
			.data	1106	1106	0	0.0
			.data.rel.ro	52496	52496	0	0.0
			.dynamic	608	608	0	0.0
			.got	4104	4104	0	0.0
			.init	27	27	0	0.0
			.init_array	528	528	0	0.0
			.rodata	127665	127665	0	0.0
			.text	1253682	1253682	0	0.0

2 builds

platform	target	config	section	`ca22841`	`e3cb094`
mbed	lighting-app	CY8CPROTO_062_4343W+release	.bss	172164	172164
			.data	5464	5464
			.heap	858816	858816
			.text	`1219792`	`1219792`
	lock-app	CY8CPROTO_062_4343W+release	.bss	171084	171084
			.data	5432	5432
			.heap	859928	859928
			.text	1197616	1197616

2 builds

platform	target	config	section	`ca22841`	`e3cb094`	change	% change
esp32	all-clusters-app	c3devkit	.dram0.bss	60296	60296	0	0.0
			.dram0.data	16192	16192	0	0.0
			.flash.rodata	198888	198888	0	0.0
			.flash.text	872530	872530	0	0.0
			.iram0.text	57330	57330	0	0.0
		m5stack	.dram0.bss	62792	62792	0	0.0
			.dram0.data	32084	32084	0	0.0
			.flash.rodata	207312	207312	0	0.0
			.flash.text	902751	902659	-92	-0.0
			.iram0.text	125115	125115	0	0.0

10 builds

platform	target	config	section	`ca22841`	`e3cb094`
nrfconnect	lighting-app	nrf52840dk_nrf52840	bss	112332	112332
			rodata	97684	97684
			text	577572	577572
	lock-app	nrf52840dk_nrf52840	bss	111348	111348
			rodata	94020	94020
			text	559072	559072
	pigweed-app	nrf52840dk_nrf52840	bss	51772	51772
			rodata	45772	45772
			text	339392	339392
	pump-app	nrf52840dk_nrf52840	bss	111416	111416
			rodata	95000	95000
			text	562228	562228
	pump-controller-app	nrf52840dk_nrf52840	bss	111356	111356
			rodata	94080	94080
			text	558864	558864
	shell	nrf52840dk_nrf52840	bss	107316	107316
			rodata	71640	71640
			text	519032	519032
	lighting-app	nrf52840dk_nrf52840+rpc	bss	108572	108572
			rodata	88472	88472
			text	550776	550776
		nrf5340dk_nrf5340_cpuapp	bss	113704	113704
			rodata	92924	92924
			text	507036	507036
	lock-app	nrf5340dk_nrf5340_cpuapp	bss	112720	112720
			rodata	89280	89280
			text	488532	488532
	shell	nrf5340dk_nrf5340_cpuapp	bss	108300	108300
			rodata	66284	66284
			text	439632	439632

bzbarsky-apple · 2021-10-20T14:31:06Z

@jepenven-silabs @jmartinez-silabs @Damian-Nordic @LuDuda Please take a look?

github-actions · 2021-10-20T16:29:07Z

PR #10611: Size comparison from 0a3f98a to 348b7f9

1 build (for telink)

platform	target	config	section	`0a3f98a`	`348b7f9`
telink	lighting-app	tlsr9518adk80d	bss	71000	71000
			noinit	33216	33216
			text	458318	458318

Increases above 1.0% from 0a3f98a to 348b7f9:

platform	target	config	section	`0a3f98a`	`348b7f9`	change	% change
linux	chip-tool	debug	.data.rel.ro	86320	89344	3024	3.5
			.rodata	179564	184412	4848	2.7
			.text	`2887045`	`3425061`	538016	18.6

15 builds (for k32w, linux, p6, qpg)

platform	target	config	section	`0a3f98a`	`348b7f9`	change	% change
k32w	lock-app	k32w061+debug	.bss	69052	69052	0	0.0
			.data	1864	1864	0	0.0
			.text	515536	515536	0	0.0
	shell	k32w061+debug	.bss	55080	55080	0	0.0
			.data	672	672	0	0.0
			.text	357332	357332	0	0.0
	lighting-app	k32w061+se05x+release	.bss	78576	78576	0	0.0
			.data	1900	1900	0	0.0
			.text	614304	614304	0	0.0
linux	all-clusters-app	debug	.bss	52176	52176	0	0.0
			.data	978	978	0	0.0
			.data.rel.ro	58688	58688	0	0.0
			.dynamic	592	592	0	0.0
			.got	4080	4080	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	136373	136373	0	0.0
			.text	1343314	1343314	0	0.0
	chip-tool	debug	.bss	17552	17552	0	0.0
			.data	1584	1584	0	0.0
			.data.rel.ro	86320	89344	3024	3.5
			.dynamic	592	592	0	0.0
			.got	4344	4344	0	0.0
			.init	27	27	0	0.0
			.init_array	416	416	0	0.0
			.rodata	179564	184412	4848	2.7
			.text	`2887045`	`3425061`	538016	18.6
	ota-provider-app	debug	.bss	37472	37472	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	23176	23176	0	0.0
			.dynamic	592	592	0	0.0
			.got	4008	4008	0	0.0
			.init	27	27	0	0.0
			.init_array	440	440	0	0.0
			.rodata	110024	110024	0	0.0
			.text	`1009714`	`1009714`	0	0.0
	ota-requestor-app	debug	.bss	205728	205728	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	24488	24488	0	0.0
			.dynamic	592	592	0	0.0
			.got	4136	4136	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	128744	128744	0	0.0
			.text	`1129298`	`1129298`	0	0.0
	shell	debug	.bss	16072	16072	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	35120	35120	0	0.0
			.dynamic	592	592	0	0.0
			.got	3496	3496	0	0.0
			.init	27	27	0	0.0
			.init_array	336	336	0	0.0
			.rodata	71823	71823	0	0.0
			.text	569842	569842	0	0.0
	tv-app	debug	.bss	216400	216400	0	0.0
			.data	2032	2032	0	0.0
			.data.rel.ro	55872	55872	0	0.0
			.dynamic	592	592	0	0.0
			.got	4400	4400	0	0.0
			.init	27	27	0	0.0
			.init_array	608	608	0	0.0
			.rodata	152264	152264	0	0.0
			.text	1461602	1461602	0	0.0
	bridge-app	debug+rpc	.bss	52912	52912	0	0.0
			.data	976	976	0	0.0
			.data.rel.ro	25784	25784	0	0.0
			.dynamic	592	592	0	0.0
			.got	3944	3944	0	0.0
			.init	27	27	0	0.0
			.init_array	400	400	0	0.0
			.rodata	110620	110620	0	0.0
			.text	`1051093`	`1051093`	0	0.0
	lighting-app	debug+rpc	.bss	42232	42232	0	0.0
			.data	1106	1106	0	0.0
			.data.rel.ro	52496	52496	0	0.0
			.dynamic	608	608	0	0.0
			.got	4104	4104	0	0.0
			.init	27	27	0	0.0
			.init_array	528	528	0	0.0
			.rodata	127825	127825	0	0.0
			.text	1251314	1251314	0	0.0
p6	lock-app	default	.bss	68216	68216	0	0.0
			.data	2416	2416	0	0.0
			.heap	962712	962712	0	0.0
			.text	1126552	1126552	0	0.0
qpg	lighting-app	qpg6100+debug	.bss	53552	53552	0	0.0
			.data	996	996	0	0.0
			.text	486624	486624	0	0.0
	lock-app	qpg6100+debug	.bss	52488	52488	0	0.0
			.data	952	952	0	0.0
			.text	462692	462692	0	0.0
	persistent-storage-app	qpg6100+debug	.bss	17778	17778	0	0.0
			.data	280	280	0	0.0
			.text	102704	102704	0	0.0

6 builds (for efr32, mbed)

platform	target	config	section	`0a3f98a`	`348b7f9`
efr32	lighting-app	BRD4161A	.bss	118036	118036
			.data	1800	1800
			.text	782896	782896
	lock-app	BRD4161A	.bss	115892	115892
			.data	1760	1760
			.text	762040	762040
	window-app	BRD4161A	.bss	116212	116212
			.data	1764	1764
			.text	762948	762948
	lighting-app	BRD4161A+rpc	.bss	131364	131364
			.data	1852	1852
			.text	762636	762636
mbed	lighting-app	CY8CPROTO_062_4343W+release	.bss	172164	172164
			.data	5464	5464
			.heap	858816	858816
			.text	1220144	1220144
	lock-app	CY8CPROTO_062_4343W+release	.bss	171084	171084
			.data	5432	5432
			.heap	859928	859928
			.text	1198040	1198040

12 builds (for esp32, nrfconnect)

platform	target	config	section	`0a3f98a`	`348b7f9`	change
esp32	all-clusters-app	c3devkit	.dram0.bss	60296	60296	0
			.dram0.data	16192	16192	0
			.flash.rodata	198992	198992	0
			.flash.text	873186	873186	0
			.iram0.text	57330	57330	0
		m5stack	.dram0.bss	62792	62792	0
			.dram0.data	32084	32084	0
			.flash.rodata	207736	207736	0
			.flash.text	904335	904423	88
			.iram0.text	125115	125115	0
nrfconnect	lighting-app	nrf52840dk_nrf52840	bss	112332	112332	0
			rodata	97776	97776	0
			text	577660	577660	0
	lock-app	nrf52840dk_nrf52840	bss	111348	111348	0
			rodata	94112	94112	0
			text	559160	559160	0
	pigweed-app	nrf52840dk_nrf52840	bss	51772	51772	0
			rodata	45772	45772	0
			text	339392	339392	0
	pump-app	nrf52840dk_nrf52840	bss	111416	111416	0
			rodata	95092	95092	0
			text	562312	562312	0
	pump-controller-app	nrf52840dk_nrf52840	bss	111356	111356	0
			rodata	94172	94172	0
			text	558952	558952	0
	shell	nrf52840dk_nrf52840	bss	107316	107316	0
			rodata	71640	71640	0
			text	519032	519032	0
	lighting-app	nrf52840dk_nrf52840+rpc	bss	108572	108572	0
			rodata	88560	88560	0
			text	550864	550864	0
		nrf5340dk_nrf5340_cpuapp	bss	113704	113704	0
			rodata	93016	93016	0
			text	507124	507124	0
	lock-app	nrf5340dk_nrf5340_cpuapp	bss	112720	112720	0
			rodata	89372	89372	0
			text	488616	488616	0
	shell	nrf5340dk_nrf5340_cpuapp	bss	108300	108300	0
			rodata	66284	66284	0
			text	439632	439632	0

vivien-apple self-assigned this Oct 18, 2021

boring-cyborg bot added the examples label Oct 18, 2021

vivien-apple mentioned this pull request Oct 18, 2021

Convert chip-tool and the YAML test framework to InvokeCommand for command sending #10498

Merged

pullapprove bot requested review from turon, wbschiller and woody-apple October 18, 2021 14:43

pullapprove bot added the review - pending label Oct 18, 2021

mrjerryjohns approved these changes Oct 18, 2021

View reviewed changes

vivien-apple force-pushed the ChipTool_UseInvokeCommand branch from 6cd4b2e to 00d3f64 Compare October 18, 2021 21:19

boring-cyborg bot added the app label Oct 18, 2021

vivien-apple force-pushed the ChipTool_UseInvokeCommand branch from 00d3f64 to e3cb094 Compare October 18, 2021 22:00

bzbarsky-apple approved these changes Oct 19, 2021

View reviewed changes

yunhanw-google approved these changes Oct 20, 2021

View reviewed changes

Damian-Nordic approved these changes Oct 20, 2021

View reviewed changes

pullapprove bot added review - approved and removed review - pending labels Oct 20, 2021

jmartinez-silabs approved these changes Oct 20, 2021

View reviewed changes

vivien-apple added 2 commits October 20, 2021 18:03

Update chip-tool to use the InvokeCommand API

c90de34

Update generated chip-tool commands

348b7f9

vivien-apple force-pushed the ChipTool_UseInvokeCommand branch from e3cb094 to 348b7f9 Compare October 20, 2021 16:11

vivien-apple merged commit 4a9d84d into project-chip:master Oct 20, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update chip-tool to use the InvokeCommand API #10611

Update chip-tool to use the InvokeCommand API #10611

vivien-apple commented Oct 18, 2021

vivien-apple commented Oct 18, 2021

vivien-apple commented Oct 18, 2021

github-actions bot commented Oct 18, 2021 •

edited

Loading

mrjerryjohns commented Oct 18, 2021

vivien-apple commented Oct 18, 2021

github-actions bot commented Oct 18, 2021 •

edited

Loading

github-actions bot commented Oct 18, 2021 •

edited

Loading

bzbarsky-apple commented Oct 20, 2021

github-actions bot commented Oct 20, 2021 •

edited

Loading

Update chip-tool to use the InvokeCommand API #10611

Update chip-tool to use the InvokeCommand API #10611

Conversation

vivien-apple commented Oct 18, 2021

Problem

Change overview

Testing

vivien-apple commented Oct 18, 2021

vivien-apple commented Oct 18, 2021

github-actions bot commented Oct 18, 2021 • edited Loading

mrjerryjohns commented Oct 18, 2021

vivien-apple commented Oct 18, 2021

github-actions bot commented Oct 18, 2021 • edited Loading

github-actions bot commented Oct 18, 2021 • edited Loading

bzbarsky-apple commented Oct 20, 2021

github-actions bot commented Oct 20, 2021 • edited Loading

github-actions bot commented Oct 18, 2021 •

edited

Loading

github-actions bot commented Oct 18, 2021 •

edited

Loading

github-actions bot commented Oct 18, 2021 •

edited

Loading

github-actions bot commented Oct 20, 2021 •

edited

Loading