-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IM event codegen support #10599
Merged
yunhanw-google
merged 2 commits into
project-chip:master
from
yunhanw-google:feature/add_initial_event_codegen
Oct 19, 2021
Merged
IM event codegen support #10599
yunhanw-google
merged 2 commits into
project-chip:master
from
yunhanw-google:feature/add_initial_event_codegen
Oct 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
erjiaqing,
franck-apple,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
shana-apple,
turon and
vivien-apple
October 16, 2021 06:44
yunhanw-google
changed the title
Feature/add initial event codegen
IM event codegen support
Oct 16, 2021
yunhanw-google
force-pushed
the
feature/add_initial_event_codegen
branch
from
October 16, 2021 07:00
8986e4e
to
6aa3188
Compare
PR #10599: Size comparison from efc17de to 8986e4e 5 builds
|
PR #10599: Size comparison from efc17de to 6aa3188 2 builds
18 builds
2 builds
12 builds
|
yunhanw-google
force-pushed
the
feature/add_initial_event_codegen
branch
from
October 16, 2021 17:43
6aa3188
to
8daf161
Compare
PR #10599: Size comparison from efc17de to 8daf161 1 build
15 builds
6 builds
2 builds
10 builds
|
Damian-Nordic
approved these changes
Oct 18, 2021
zzz_generated/app-common/app-common/zap-generated/cluster-objects.h
Outdated
Show resolved
Hide resolved
yunhanw-google
force-pushed
the
feature/add_initial_event_codegen
branch
from
October 19, 2021 03:29
8daf161
to
4e2ac1f
Compare
PR #10599: Size comparison from f1555d1 to 4e2ac1f 5 builds
3 builds
|
yunhanw-google
force-pushed
the
feature/add_initial_event_codegen
branch
from
October 19, 2021 05:42
3f7d156
to
495fe9d
Compare
PR #10599: Size comparison from 1623b4b to 495fe9d 8 builds (for k32w, p6, qpg, telink)
14 builds (for efr32, linux, mbed)
12 builds (for esp32, nrfconnect)
|
yunhanw-google
force-pushed
the
feature/add_initial_event_codegen
branch
from
October 19, 2021 17:00
495fe9d
to
9a41e10
Compare
PR #10599: Size comparison from 09519d8 to 9a41e10 8 builds (for k32w, p6, qpg, telink)
12 builds (for efr32, linux)
2 builds (for mbed)
12 builds (for esp32, nrfconnect)
|
mrjerryjohns
approved these changes
Oct 19, 2021
jmartinez-silabs
approved these changes
Oct 19, 2021
yunhanw-google
force-pushed
the
feature/add_initial_event_codegen
branch
from
October 19, 2021 18:45
9a41e10
to
4184c33
Compare
PR #10599: Size comparison from 87c3a1a to 4184c33 2 builds (for p6, telink)
14 builds (for k32w, linux, qpg)
6 builds (for efr32, mbed)
12 builds (for esp32, nrfconnect)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Need to add IM Event codegen support in cluster object to unblock IM event management integration in application.
#10598
Change overview
Update the zapt file to generate IM event for clusters.
Add event in test cluster xml
Testing
Presubmit compilation.