Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Size reports: Don't comment on outdated builds #10565

Merged
merged 1 commit into from
Oct 21, 2021

Conversation

kpschoedel
Copy link
Contributor

Problem

gh_report.py may send comments on builds that are already outdated,
and may do so out of chronological order, which clutters PRs and may
eclipse the actually relevant report.

Change overview

Before commenting, check that the report is for the latest commit.

Testing

Offline run identified and correctly handled such a case.

scripts/tools/memory/gh_report.py --db=/tmp/test.db --log-level=debug \
    --pr --github-repo project-chip/connectedhomeip \
    --github-limit-artifacts=500 --github-limit-artifact-pages=100 \
    --github-keep --github-comment --github-dryrun-comment

#### Problem

`gh_report.py` may send comments on builds that are already outdated,
and may do so out of chronological order, which clutters PRs and may
eclipse the actually relevant report.

#### Change overview

Before commenting, check that the report is for the latest commit.

#### Testing

Offline run identified and correctly handled such a case.

    scripts/tools/memory/gh_report.py --db=/tmp/test.db --log-level=debug \
        --pr --github-repo project-chip/connectedhomeip \
        --github-limit-artifacts=500 --github-limit-artifact-pages=100 \
        --github-keep --github-comment --github-dryrun-comment
@github-actions
Copy link

github-actions bot commented Oct 15, 2021

PR #10565: Size comparison from c4660e6 to 613ff1a

8 builds
platform target config section c4660e6 613ff1a change % change
k32w lock-app k32w061+debug .bss 69052 69052 0 0.0
.data 1864 1864 0 0.0
.text 515444 515444 0 0.0
shell k32w061+debug .bss 55080 55080 0 0.0
.data 672 672 0 0.0
.text 357172 357172 0 0.0
lighting-app k32w061+se05x+release .bss 78560 78560 0 0.0
.data 1900 1900 0 0.0
.text 614116 614116 0 0.0
p6 lock-app default .bss 68216 68216 0 0.0
.data 2416 2416 0 0.0
.heap 962712 962712 0 0.0
.text 1126544 1126544 0 0.0
qpg lighting-app qpg6100+debug .bss 53536 53536 0 0.0
.data 996 996 0 0.0
.text 486352 486352 0 0.0
lock-app qpg6100+debug .bss 52488 52488 0 0.0
.data 952 952 0 0.0
.text 462544 462544 0 0.0
persistent-storage-app qpg6100+debug .bss 17778 17778 0 0.0
.data 280 280 0 0.0
.text 102704 102704 0 0.0
telink lighting-app tlsr9518adk80d bss 70984 70984 0 0.0
noinit 33216 33216 0 0.0
text 458376 458376 0 0.0
14 builds
platform target config section c4660e6 613ff1a change % change
efr32 lighting-app BRD4161A .bss 118020 118020 0 0.0
.data 1800 1800 0 0.0
.text 782732 782732 0 0.0
lock-app BRD4161A .bss 115892 115892 0 0.0
.data 1760 1760 0 0.0
.text 761988 761988 0 0.0
window-app BRD4161A .bss 116212 116212 0 0.0
.data 1764 1764 0 0.0
.text 762896 762896 0 0.0
lighting-app BRD4161A+rpc .bss 131348 131348 0 0.0
.data 1852 1852 0 0.0
.text 762476 762476 0 0.0
linux all-clusters-app debug .bss 52144 52144 0 0.0
.data 978 978 0 0.0
.data.rel.ro 58368 58368 0 0.0
.dynamic 592 592 0 0.0
.got 4072 4072 0 0.0
.init 27 27 0 0.0
.init_array 504 504 0 0.0
.rodata 135637 135637 0 0.0
.text 1322082 1322082 0 0.0
chip-tool debug .bss 17552 17552 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 83264 83264 0 0.0
.dynamic 592 592 0 0.0
.got 4328 4328 0 0.0
.init 27 27 0 0.0
.init_array 416 416 0 0.0
.rodata 174432 174432 0 0.0
.text 2422901 2422901 0 0.0
ota-provider-app debug .bss 37472 37472 0 0.0
.data 752 752 0 0.0
.data.rel.ro 23144 23144 0 0.0
.dynamic 592 592 0 0.0
.got 4008 4008 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 109720 109720 0 0.0
.text 1009730 1009730 0 0.0
ota-requestor-app debug .bss 205728 205728 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24440 24440 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 127768 127768 0 0.0
.text 1129394 1129394 0 0.0
shell debug .bss 16072 16072 0 0.0
.data 242 242 0 0.0
.data.rel.ro 35120 35120 0 0.0
.dynamic 592 592 0 0.0
.got 3496 3496 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 71855 71855 0 0.0
.text 568898 568898 0 0.0
tv-app debug .bss 216368 216368 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 55504 55504 0 0.0
.dynamic 592 592 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 151336 151336 0 0.0
.text 1464034 1464034 0 0.0
bridge-app debug+rpc .bss 52880 52880 0 0.0
.data 976 976 0 0.0
.data.rel.ro 25464 25464 0 0.0
.dynamic 592 592 0 0.0
.got 3944 3944 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 110388 110388 0 0.0
.text 1051349 1051349 0 0.0
lighting-app debug+rpc .bss 42200 42200 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 52208 52208 0 0.0
.dynamic 608 608 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 127537 127537 0 0.0
.text 1252498 1252498 0 0.0
mbed lighting-app CY8CPROTO_062_4343W+release .bss 172148 172148 0 0.0
.data 5464 5464 0 0.0
.heap 858832 858832 0 0.0
.text 1220072 1220072 0 0.0
lock-app CY8CPROTO_062_4343W+release .bss 171084 171084 0 0.0
.data 5432 5432 0 0.0
.heap 859928 859928 0 0.0
.text 1198056 1198056 0 0.0
12 builds
platform target config section c4660e6 613ff1a change % change
esp32 all-clusters-app c3devkit .dram0.bss 60264 60264 0 0.0
.dram0.data 16208 16208 0 0.0
.flash.rodata 198632 198632 0 0.0
.flash.text 869794 869794 0 0.0
.iram0.text 57330 57330 0 0.0
m5stack .dram0.bss 62760 62760 0 0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 207076 207076 0 0.0
.flash.text 900411 900503 92 0.0
.iram0.text 125115 125115 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 bss 112316 112316 0 0.0
rodata 97576 97576 0 0.0
text 577696 577696 0 0.0
lock-app nrf52840dk_nrf52840 bss 111348 111348 0 0.0
rodata 94072 94072 0 0.0
text 559136 559136 0 0.0
pigweed-app nrf52840dk_nrf52840 bss 51772 51772 0 0.0
rodata 45772 45772 0 0.0
text 339392 339392 0 0.0
pump-app nrf52840dk_nrf52840 bss 111416 111416 0 0.0
rodata 95052 95052 0 0.0
text 562308 562308 0 0.0
pump-controller-app nrf52840dk_nrf52840 bss 111356 111356 0 0.0
rodata 94132 94132 0 0.0
text 558912 558912 0 0.0
shell nrf52840dk_nrf52840 bss 107316 107316 0 0.0
rodata 71640 71640 0 0.0
text 518908 518908 0 0.0
lighting-app nrf52840dk_nrf52840+rpc bss 108556 108556 0 0.0
rodata 88360 88360 0 0.0
text 550900 550900 0 0.0
nrf5340dk_nrf5340_cpuapp bss 113688 113688 0 0.0
rodata 92816 92816 0 0.0
text 507156 507156 0 0.0
lock-app nrf5340dk_nrf5340_cpuapp bss 112720 112720 0 0.0
rodata 89332 89332 0 0.0
text 488592 488592 0 0.0
shell nrf5340dk_nrf5340_cpuapp bss 108300 108300 0 0.0
rodata 66284 66284 0 0.0
text 439504 439504 0 0.0

@andy31415 andy31415 merged commit c8cd1d8 into project-chip:master Oct 21, 2021
@kpschoedel kpschoedel deleted the nubloat-report-7 branch October 21, 2021 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants