-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Size reports: Don't comment on outdated builds #10565
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem `gh_report.py` may send comments on builds that are already outdated, and may do so out of chronological order, which clutters PRs and may eclipse the actually relevant report. #### Change overview Before commenting, check that the report is for the latest commit. #### Testing Offline run identified and correctly handled such a case. scripts/tools/memory/gh_report.py --db=/tmp/test.db --log-level=debug \ --pr --github-repo project-chip/connectedhomeip \ --github-limit-artifacts=500 --github-limit-artifact-pages=100 \ --github-keep --github-comment --github-dryrun-comment
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
emargolis,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst and
shana-apple
October 15, 2021 16:00
pullapprove
bot
requested review from
vivien-apple,
wbschiller and
woody-apple
October 15, 2021 16:00
PR #10565: Size comparison from c4660e6 to 613ff1a 8 builds
14 builds
12 builds
|
andy31415
approved these changes
Oct 15, 2021
bzbarsky-apple
approved these changes
Oct 20, 2021
msandstedt
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
gh_report.py
may send comments on builds that are already outdated,and may do so out of chronological order, which clutters PRs and may
eclipse the actually relevant report.
Change overview
Before commenting, check that the report is for the latest commit.
Testing
Offline run identified and correctly handled such a case.