Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ChipTool] Add a command to enumerate the paired devices and show ip/… #10558

Merged
merged 1 commit into from
Oct 27, 2021
Merged

[ChipTool] Add a command to enumerate the paired devices and show ip/… #10558

merged 1 commit into from
Oct 27, 2021

Conversation

vivien-apple
Copy link
Contributor

…port/interface informations for them

Problem

When pairing to multiple devices using chip-tool it is sometimes useful in order to debug to have some informations about the devices such as the IP/Port/Interface.

This PR adds ./out/debug/standalone/chip-tool pairing list, which results into:

+---------------------------------------------------------------------------------------------+
|       NodeId       |                   Address                     | Port |    Interface    |
+---------------------------------------------------------------------------------------------+
| 0x12344321         | ::1                                           | 5540 |                 |
| 0x01234567         | ::1                                           | 5541 |                 |
+---------------------------------------------------------------------------------------------+

Change overview

  • Add a command that makes human readable the pairing related informations of chip_tool_config.ini.

Testing

How was this tested? (at least one bullet point required)

  • If unit tests were added, how do they cover this issue?
  • If unit tests existed, how were they fixed/modified to prevent this in future?
  • If new unit tests are not added, why not?
  • If integration tests were added, how do they verify this change?
  • If new integration tests are not added, why not?
  • If manually tested, what platforms controller and device platforms were manually tested, and how?
  • If no testing is required, why not?

@vivien-apple vivien-apple self-assigned this Oct 15, 2021
@github-actions
Copy link

github-actions bot commented Oct 15, 2021 •
edited
Loading

PR #10558: Size comparison from a56c83e to ce96697

14 builds
platform target config section a56c83e ce96697 change % change
efr32 lighting-app BRD4161A .bss 118020 118020 0 0.0
.data 1800 1800 0 0.0
.text 782924 782924 0 0.0
lock-app BRD4161A .bss 115892 115892 0 0.0
.data 1760 1760 0 0.0
.text 762180 762180 0 0.0
window-app BRD4161A .bss 116212 116212 0 0.0
.data 1764 1764 0 0.0
.text 763088 763088 0 0.0
lighting-app BRD4161A+rpc .bss 131348 131348 0 0.0
.data 1852 1852 0 0.0
.text 762668 762668 0 0.0
k32w lock-app k32w061+debug .bss 69052 69052 0 0.0
.data 1864 1864 0 0.0
.text 515572 515572 0 0.0
shell k32w061+debug .bss 55080 55080 0 0.0
.data 672 672 0 0.0
.text 357680 357680 0 0.0
lighting-app k32w061+se05x+release .bss 78568 78568 0 0.0
.data 1900 1900 0 0.0
.text 614244 614244 0 0.0
mbed lighting-app CY8CPROTO_062_4343W+release .bss 172148 172148 0 0.0
.data 5464 5464 0 0.0
.heap 858832 858832 0 0.0
.text 1220096 1220096 0 0.0
lock-app CY8CPROTO_062_4343W+release .bss 171084 171084 0 0.0
.data 5432 5432 0 0.0
.heap 859928 859928 0 0.0
.text 1198080 1198080 0 0.0
p6 lock-app default .bss 68224 68224 0 0.0
.data 2416 2416 0 0.0
.heap 962704 962704 0 0.0
.text 1126784 1126784 0 0.0
qpg lighting-app qpg6100+debug .bss 53536 53536 0 0.0
.data 996 996 0 0.0
.text 486504 486504 0 0.0
lock-app qpg6100+debug .bss 52488 52488 0 0.0
.data 952 952 0 0.0
.text 462696 462696 0 0.0
persistent-storage-app qpg6100+debug .bss 17778 17778 0 0.0
.data 280 280 0 0.0
.text 102704 102704 0 0.0
telink lighting-app tlsr9518adk80d bss 70988 70988 0 0.0
noinit 33216 33216 0 0.0
text 458530 458530 0 0.0

Increases above 1.0% from ce96697 to a56c83e:

platform target config section a56c83e ce96697 change % change
linux chip-tool debug .init_array 424 432 8 1.9
8 builds
platform target config section a56c83e ce96697 change % change
linux all-clusters-app debug .bss 52176 52176 0 0.0
.data 978 978 0 0.0
.data.rel.ro 58416 58416 0 0.0
.dynamic 592 592 0 0.0
.got 4072 4072 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 135797 135797 0 0.0
.text 1322610 1322610 0 0.0
chip-tool debug .bss 17584 17584 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 83312 83344 32 0.0
.dynamic 592 592 0 0.0
.got 4328 4328 0 0.0
.init 27 27 0 0.0
.init_array 424 432 8 1.9
.rodata 174560 174976 416 0.2
.text 2423429 2425989 2560 0.1
ota-provider-app debug .bss 37504 37504 0 0.0
.data 752 752 0 0.0
.data.rel.ro 23192 23192 0 0.0
.dynamic 592 592 0 0.0
.got 4008 4008 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 109856 109856 0 0.0
.text 1010258 1010258 0 0.0
ota-requestor-app debug .bss 205760 205760 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24488 24488 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 127936 127936 0 0.0
.text 1129922 1129922 0 0.0
shell debug .bss 16104 16104 0 0.0
.data 242 242 0 0.0
.data.rel.ro 35184 35184 0 0.0
.dynamic 592 592 0 0.0
.got 3504 3504 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 72143 72143 0 0.0
.text 575314 575314 0 0.0
tv-app debug .bss 216400 216400 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 55568 55568 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 151560 151560 0 0.0
.text 1468146 1468146 0 0.0
bridge-app debug+rpc .bss 52912 52912 0 0.0
.data 976 976 0 0.0
.data.rel.ro 25512 25512 0 0.0
.dynamic 592 592 0 0.0
.got 3944 3944 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110548 110548 0 0.0
.text 1051877 1051877 0 0.0
lighting-app debug+rpc .bss 42232 42232 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 52256 52256 0 0.0
.dynamic 608 608 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 127665 127665 0 0.0
.text 1253026 1253026 0 0.0
12 builds
platform target config section a56c83e ce96697 change % change
esp32 all-clusters-app c3devkit .dram0.bss 60264 60264 0 0.0
.dram0.data 16232 16232 0 0.0
.flash.rodata 198632 198632 0 0.0
.flash.text 870358 870358 0 0.0
.iram0.text 57330 57330 0 0.0
m5stack .dram0.bss 62768 62768 0 0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 207212 207212 0 0.0
.flash.text 901511 901511 0 0.0
.iram0.text 125115 125115 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 bss 112320 112320 0 0.0
rodata 97632 97632 0 0.0
text 577824 577824 0 0.0
lock-app nrf52840dk_nrf52840 bss 111352 111352 0 0.0
rodata 94128 94128 0 0.0
text 559264 559264 0 0.0
pigweed-app nrf52840dk_nrf52840 bss 51772 51772 0 0.0
rodata 45772 45772 0 0.0
text 339392 339392 0 0.0
pump-app nrf52840dk_nrf52840 bss 111420 111420 0 0.0
rodata 95112 95112 0 0.0
text 562436 562436 0 0.0
pump-controller-app nrf52840dk_nrf52840 bss 111360 111360 0 0.0
rodata 94188 94188 0 0.0
text 559040 559040 0 0.0
shell nrf52840dk_nrf52840 bss 107320 107320 0 0.0
rodata 71788 71788 0 0.0
text 519308 519308 0 0.0
lighting-app nrf52840dk_nrf52840+rpc bss 108560 108560 0 0.0
rodata 88416 88416 0 0.0
text 551028 551028 0 0.0
nrf5340dk_nrf5340_cpuapp bss 113692 113692 0 0.0
rodata 92872 92872 0 0.0
text 507284 507284 0 0.0
lock-app nrf5340dk_nrf5340_cpuapp bss 112724 112724 0 0.0
rodata 89388 89388 0 0.0
text 488720 488720 0 0.0
shell nrf5340dk_nrf5340_cpuapp bss 108304 108304 0 0.0
rodata 66432 66432 0 0.0
text 439908 439908 0 0.0

@woody-apple
Copy link
Contributor

@vivien-apple Can you please resolve conflicts?

@woody-apple
Copy link
Contributor

Fast tracking this PR, given it's adding test tools

@woody-apple
Copy link
Contributor

/rebase

@vivien-apple vivien-apple force-pushed the ChipTool_CommandListPairing branch from ce96697 to f21c274 Compare October 27, 2021 08:31
@vivien-apple vivien-apple force-pushed the ChipTool_CommandListPairing branch from f21c274 to d42a40f Compare October 27, 2021 08:47
@github-actions
Copy link

github-actions bot commented Oct 27, 2021 •
edited
Loading

PR #10558: Size comparison from 3249310 to d42a40f

Increases above 1%:

platform target config section 3249310 d42a40f change % change
linux chip-tool debug .init_array 416 424 8 1.9
Increases (1 build for linux)
platform target config section 3249310 d42a40f change % change
linux chip-tool debug (read only) 4146325 4149509 3184 0.1
(read/write) 120184 120224 40 0.0
.data.rel.ro 95520 95552 32 0.0
.init_array 416 424 8 1.9
.rodata 210224 210704 480 0.2
.text 3677813 3680421 2608 0.1
Full report (36 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 3249310 d42a40f change % change
efr32 lighting-app BRD4161A (read only) 737104 737104 0 0.0
(read/write) 115444 115444 0 0.0
.bss 113692 113692 0 0.0
.data 1752 1752 0 0.0
.text 737096 737096 0 0.0
BRD4161A+rpc (read only) 724536 724536 0 0.0
(read/write) 132052 132052 0 0.0
.bss 130196 130196 0 0.0
.data 1852 1852 0 0.0
.text 724528 724528 0 0.0
lock-app BRD4161A (read only) 716368 716368 0 0.0
(read/write) 113260 113260 0 0.0
.bss 111548 111548 0 0.0
.data 1712 1712 0 0.0
.text 716360 716360 0 0.0
window-app BRD4161A (read only) 717276 717276 0 0.0
(read/write) 113584 113584 0 0.0
.bss 111868 111868 0 0.0
.data 1716 1716 0 0.0
.text 717268 717268 0 0.0
esp32 all-clusters-app c3devkit (read only) 875790 875790 0 0.0
(read/write) 1306456 1306456 0 0.0
.dram0.bss 58240 58240 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 198520 198520 0 0.0
.flash.text 875790 875790 0 0.0
.iram0.text 57564 57564 0 0.0
m5stack (read only) 906891 906891 0 0.0
(read/write) 426264 426264 0 0.0
.dram0.bss 60752 60752 0 0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 207264 207264 0 0.0
.flash.text 906891 906891 0 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 701096 701096 0 0.0
.bss 78720 78720 0 0.0
.data 1900 1900 0 0.0
.text 614676 614676 0 0.0
lock-app k32w061+debug (read/write) 592900 592900 0 0.0
.bss 69196 69196 0 0.0
.data 1864 1864 0 0.0
.text 516040 516040 0 0.0
shell k32w061+debug (read/write) 425236 425236 0 0.0
.bss 63256 63256 0 0.0
.data 672 672 0 0.0
.text 359604 359604 0 0.0
linux all-clusters-app debug (read only) 1634209 1634209 0 0.0
(read/write) 117408 117408 0 0.0
.bss 50320 50320 0 0.0
.data 978 978 0 0.0
.data.rel.ro 60864 60864 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 135541 135541 0 0.0
.text 1366930 1366930 0 0.0
bridge-app debug+rpc (read only) 1275693 1275693 0 0.0
(read/write) 85096 85096 0 0.0
.bss 51856 51856 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27272 27272 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 110684 110684 0 0.0
.text 1069669 1069669 0 0.0
chip-tool debug (read only) 4146325 4149509 3184 0.1
(read/write) 120184 120224 40 0.0
.bss 17680 17680 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 95520 95552 32 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 416 424 8 1.9
.rodata 210224 210704 480 0.2
.text 3677813 3680421 2608 0.1
lighting-app debug+rpc (read only) 1527209 1527209 0 0.0
(read/write) 101520 101520 0 0.0
.bss 41176 41176 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 53968 53968 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 127889 127889 0 0.0
.text 1267298 1267298 0 0.0
ota-provider-app debug (read only) 1234753 1234753 0 0.0
(read/write) 67776 67776 0 0.0
.bss 37440 37440 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24488 24488 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110984 110984 0 0.0
.text 1027810 1027810 0 0.0
ota-requestor-app debug (read only) 1292033 1292033 0 0.0
(read/write) 76264 76264 0 0.0
.bss 44960 44960 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25352 25352 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 127904 127904 0 0.0
.text 1066530 1066530 0 0.0
shell debug (read only) 778361 778361 0 0.0
(read/write) 57376 57376 0 0.0
.bss 16136 16136 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36496 36496 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 76527 76527 0 0.0
.text 600706 600706 0 0.0
tv-app debug (read only) 1753753 1753753 0 0.0
(read/write) 281432 281432 0 0.0
.bss 215568 215568 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58192 58192 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 152984 152984 0 0.0
.text 1459058 1459058 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2288664 2288664 0 0.0
.bss 179612 179612 0 0.0
.data 5192 5192 0 0.0
.heap 851640 851640 0 0.0
.text 1251264 1251264 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2255896 2255896 0 0.0
.bss 171060 171060 0 0.0
.data 5464 5464 0 0.0
.heap 859920 859920 0 0.0
.text 1218496 1218496 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2233928 2233928 0 0.0
.bss 169988 169988 0 0.0
.data 5432 5432 0 0.0
.heap 861024 861024 0 0.0
.text 1196528 1196528 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139680 1139680 0 0.0
.bss 11760 11760 0 0.0
.data 4360 4360 0 0.0
.heap 1020328 1020328 0 0.0
.text 103064 103064 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 862967 862967 0 0.0
bss 112136 112136 0 0.0
rodata 97504 97504 0 0.0
text 577704 577704 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 823807 823807 0 0.0
bss 108380 108380 0 0.0
rodata 88280 88280 0 0.0
text 550896 550896 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 788006 788006 0 0.0
bss 113512 113512 0 0.0
rodata 92744 92744 0 0.0
text 507176 507176 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 839911 839911 0 0.0
bss 111208 111208 0 0.0
rodata 93904 93904 0 0.0
text 559264 559264 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764954 764954 0 0.0
bss 112584 112584 0 0.0
rodata 89164 89164 0 0.0
text 488728 488728 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497339 497339 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339456 339456 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844311 844311 0 0.0
bss 111308 111308 0 0.0
rodata 95104 95104 0 0.0
text 562368 562368 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 839631 839631 0 0.0
bss 111208 111208 0 0.0
rodata 93880 93880 0 0.0
text 559008 559008 0 0.0
shell nrf52840dk_nrf52840 (read/write) 776579 776579 0 0.0
bss 109072 109072 0 0.0
rodata 72536 72536 0 0.0
text 520368 520368 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691634 691634 0 0.0
bss 110056 110056 0 0.0
rodata 67180 67180 0 0.0
text 440980 440980 0 0.0
p6 lock-app default (read/write) 2169104 2169104 0 0.0
.bss 67184 67184 0 0.0
.data 2416 2416 0 0.0
.heap 963744 963744 0 0.0
.text 1127368 1127368 0 0.0
qpg lighting-app qpg6100+debug (read only) 491272 491272 0 0.0
(read/write) 114144 114144 0 0.0
.bss 52416 52416 0 0.0
.data 1000 1000 0 0.0
.text 485952 485952 0 0.0
lock-app qpg6100+debug (read only) 467492 467492 0 0.0
(read/write) 114140 114140 0 0.0
.bss 51368 51368 0 0.0
.data 956 956 0 0.0
.text 462172 462172 0 0.0
persistent-storage-app qpg6100+debug (read only) 155220 155220 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 149900 149900 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 664678 664678 0 0.0
bss 69944 69944 0 0.0
noinit 33216 33216 0 0.0
text 458278 458278 0 0.0

@vivien-apple vivien-apple merged commit 22f8115 into project-chip:master Oct 27, 2021
JasonLiuZhuoCheng pushed a commit to JasonLiuZhuoCheng/connectedhomeip that referenced this pull request Oct 28, 2021
@vivien-apple @JasonLiuZhuoCheng
[ChipTool] Add a command to enumerate the paired devices and show ip/…
ad52857 
…port/interface informations for them (project-chip#10558)
carol-apple pushed a commit to carol-apple/connectedhomeip that referenced this pull request Oct 28, 2021
@vivien-apple @carol-apple
[ChipTool] Add a command to enumerate the paired devices and show ip/…
4c184b1 
…port/interface informations for them (project-chip#10558)
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@vivien-apple
[ChipTool] Add a command to enumerate the paired devices and show ip/…
1a6126e 
…port/interface informations for them (project-chip#10558)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msandstedt msandstedt msandstedt left review comments

@andy31415 andy31415 andy31415 left review comments

@tcarmelveilleux tcarmelveilleux tcarmelveilleux left review comments

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@woody-apple woody-apple woody-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@shana-apple shana-apple Awaiting requested review from shana-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees

@vivien-apple vivien-apple

Labels
examples fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vivien-apple @woody-apple @tcarmelveilleux @andy31415 @msandstedt @bzbarsky-apple