Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DNS-SD] Clean up common constants #10553

Merged
merged 2 commits into from
Oct 19, 2021
Merged

[DNS-SD] Clean up common constants #10553

merged 2 commits into from
Oct 19, 2021

Conversation

Damian-Nordic
Copy link
Contributor

Problem

DNS-SD constants are currently defined in many places, some constants are duplicated, and there are constants that have
similar names, but different meanings (like the service instance name for the commissionable and operational node, respectively).

Change overview

Try to clean them up by putting most of them in a single lib/dnssd/Constants.h header file. Also, remove unnecessary
kDnssd prefixes since the constants are already in the Dnssd namespace.

Testing

Tested by CI. Also tested manually using nRF Connect and Linux (minimal mDNS) lighting-app - tried to commissioned all the apps and verified operational services show up.

@Damian-Nordic
[DNS-SD] Clean up common constants
eb406b1 
DNS-SD constants are currently defined in many places, some
constants are duplicated, and there are constants that have
similar names, but mean different things (like the service
instance name for the commissionable and operational node,
respectively).

Try to clean them up by putting most of them in a single
lib/dnssd/Constants.h header file. Also, remove unnecessary
kDnssd prefixes since the constants are already in the
Dnssd namespace.
@restyled-io restyled-io bot mentioned this pull request Oct 15, 2021
Closed
@github-actions
Copy link

github-actions bot commented Oct 15, 2021 •
edited
Loading

PR #10553: Size comparison from a56c83e to c864eea

8 builds
platform target config section a56c83e c864eea change % change
k32w lock-app k32w061+debug .bss 69052 69052 0 0.0
.data 1864 1864 0 0.0
.text 515572 515572 0 0.0
shell k32w061+debug .bss 55080 55080 0 0.0
.data 672 672 0 0.0
.text 357680 357680 0 0.0
lighting-app k32w061+se05x+release .bss 78568 78568 0 0.0
.data 1900 1900 0 0.0
.text 614244 614244 0 0.0
p6 lock-app default .bss 68224 68224 0 0.0
.data 2416 2416 0 0.0
.heap 962704 962704 0 0.0
.text 1126784 1126784 0 0.0
qpg lighting-app qpg6100+debug .bss 53536 53536 0 0.0
.data 996 996 0 0.0
.text 486504 486504 0 0.0
lock-app qpg6100+debug .bss 52488 52488 0 0.0
.data 952 952 0 0.0
.text 462696 462696 0 0.0
persistent-storage-app qpg6100+debug .bss 17778 17778 0 0.0
.data 280 280 0 0.0
.text 102704 102704 0 0.0
telink lighting-app tlsr9518adk80d bss 70988 70988 0 0.0
noinit 33216 33216 0 0.0
text 458530 458530 0 0.0
14 builds
platform target config section a56c83e c864eea change % change
efr32 lighting-app BRD4161A .bss 118020 118020 0 0.0
.data 1800 1800 0 0.0
.text 782924 782924 0 0.0
lock-app BRD4161A .bss 115892 115892 0 0.0
.data 1760 1760 0 0.0
.text 762180 762180 0 0.0
window-app BRD4161A .bss 116212 116212 0 0.0
.data 1764 1764 0 0.0
.text 763088 763088 0 0.0
lighting-app BRD4161A+rpc .bss 131348 131348 0 0.0
.data 1852 1852 0 0.0
.text 762668 762668 0 0.0
linux all-clusters-app debug .bss 52176 52176 0 0.0
.data 978 978 0 0.0
.data.rel.ro 58416 58416 0 0.0
.dynamic 592 592 0 0.0
.got 4072 4072 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 135797 135797 0 0.0
.text 1322610 1322610 0 0.0
chip-tool debug .bss 17584 17584 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 83312 83312 0 0.0
.dynamic 592 592 0 0.0
.got 4328 4328 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 174560 174560 0 0.0
.text 2423429 2423429 0 0.0
ota-provider-app debug .bss 37504 37504 0 0.0
.data 752 752 0 0.0
.data.rel.ro 23192 23192 0 0.0
.dynamic 592 592 0 0.0
.got 4008 4008 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 109856 109856 0 0.0
.text 1010258 1010258 0 0.0
ota-requestor-app debug .bss 205760 205760 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24488 24488 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 127936 127936 0 0.0
.text 1129922 1129922 0 0.0
shell debug .bss 16104 16104 0 0.0
.data 242 242 0 0.0
.data.rel.ro 35184 35184 0 0.0
.dynamic 592 592 0 0.0
.got 3504 3504 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 72143 72143 0 0.0
.text 575314 575314 0 0.0
tv-app debug .bss 216400 216400 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 55568 55568 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 151560 151592 32 0.0
.text 1468146 1468146 0 0.0
bridge-app debug+rpc .bss 52912 52912 0 0.0
.data 976 976 0 0.0
.data.rel.ro 25512 25512 0 0.0
.dynamic 592 592 0 0.0
.got 3944 3944 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110548 110548 0 0.0
.text 1051877 1051877 0 0.0
lighting-app debug+rpc .bss 42232 42232 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 52256 52256 0 0.0
.dynamic 608 608 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 127665 127665 0 0.0
.text 1253026 1253026 0 0.0
mbed lighting-app CY8CPROTO_062_4343W+release .bss 172148 172148 0 0.0
.data 5464 5464 0 0.0
.heap 858832 858832 0 0.0
.text 1220096 1220096 0 0.0
lock-app CY8CPROTO_062_4343W+release .bss 171084 171084 0 0.0
.data 5432 5432 0 0.0
.heap 859928 859928 0 0.0
.text 1198080 1198080 0 0.0
2 builds
platform target config section a56c83e c864eea change % change
esp32 all-clusters-app c3devkit .dram0.bss 60264 60264 0 0.0
.dram0.data 16232 16232 0 0.0
.flash.rodata 198632 198632 0 0.0
.flash.text 870358 870358 0 0.0
.iram0.text 57330 57330 0 0.0
m5stack .dram0.bss 62768 62768 0 0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 207212 207212 0 0.0
.flash.text 901511 901511 0 0.0
.iram0.text 125115 125115 0 0.0
10 builds
platform target config section a56c83e c864eea change % change
nrfconnect lighting-app nrf52840dk_nrf52840 bss 112320 112320 0 0.0
rodata 97632 97632 0 0.0
text 577824 577824 0 0.0
lock-app nrf52840dk_nrf52840 bss 111352 111352 0 0.0
rodata 94128 94128 0 0.0
text 559264 559264 0 0.0
pigweed-app nrf52840dk_nrf52840 bss 51772 51772 0 0.0
rodata 45772 45772 0 0.0
text 339392 339392 0 0.0
pump-app nrf52840dk_nrf52840 bss 111420 111420 0 0.0
rodata 95112 95112 0 0.0
text 562436 562436 0 0.0
pump-controller-app nrf52840dk_nrf52840 bss 111360 111360 0 0.0
rodata 94188 94188 0 0.0
text 559040 559040 0 0.0
shell nrf52840dk_nrf52840 bss 107320 107320 0 0.0
rodata 71788 71788 0 0.0
text 519308 519308 0 0.0
lighting-app nrf52840dk_nrf52840+rpc bss 108560 108560 0 0.0
rodata 88416 88416 0 0.0
text 551028 551028 0 0.0
nrf5340dk_nrf5340_cpuapp bss 113692 113692 0 0.0
rodata 92872 92872 0 0.0
text 507284 507284 0 0.0
lock-app nrf5340dk_nrf5340_cpuapp bss 112724 112724 0 0.0
rodata 89388 89388 0 0.0
text 488720 488720 0 0.0
shell nrf5340dk_nrf5340_cpuapp bss 108304 108304 0 0.0
rodata 66432 66432 0 0.0
text 439908 439908 0 0.0

@github-actions
Copy link

github-actions bot commented Oct 15, 2021 •
edited
Loading

PR #10553: Size comparison from a56c83e to 325b60f

8 builds
platform target config section a56c83e 325b60f change % change
k32w lock-app k32w061+debug .bss 69052 69052 0 0.0
.data 1864 1864 0 0.0
.text 515572 515572 0 0.0
shell k32w061+debug .bss 55080 55080 0 0.0
.data 672 672 0 0.0
.text 357680 357680 0 0.0
lighting-app k32w061+se05x+release .bss 78568 78568 0 0.0
.data 1900 1900 0 0.0
.text 614244 614244 0 0.0
p6 lock-app default .bss 68224 68224 0 0.0
.data 2416 2416 0 0.0
.heap 962704 962704 0 0.0
.text 1126784 1126784 0 0.0
qpg lighting-app qpg6100+debug .bss 53536 53536 0 0.0
.data 996 996 0 0.0
.text 486504 486504 0 0.0
lock-app qpg6100+debug .bss 52488 52488 0 0.0
.data 952 952 0 0.0
.text 462696 462696 0 0.0
persistent-storage-app qpg6100+debug .bss 17778 17778 0 0.0
.data 280 280 0 0.0
.text 102704 102704 0 0.0
telink lighting-app tlsr9518adk80d bss 70988 70988 0 0.0
noinit 33216 33216 0 0.0
text 458530 458530 0 0.0
14 builds
platform target config section a56c83e 325b60f change % change
efr32 lighting-app BRD4161A .bss 118020 118020 0 0.0
.data 1800 1800 0 0.0
.text 782924 782924 0 0.0
lock-app BRD4161A .bss 115892 115892 0 0.0
.data 1760 1760 0 0.0
.text 762180 762180 0 0.0
window-app BRD4161A .bss 116212 116212 0 0.0
.data 1764 1764 0 0.0
.text 763088 763088 0 0.0
lighting-app BRD4161A+rpc .bss 131348 131348 0 0.0
.data 1852 1852 0 0.0
.text 762668 762668 0 0.0
linux all-clusters-app debug .bss 52176 52176 0 0.0
.data 978 978 0 0.0
.data.rel.ro 58416 58416 0 0.0
.dynamic 592 592 0 0.0
.got 4072 4072 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 135797 135797 0 0.0
.text 1322610 1322610 0 0.0
chip-tool debug .bss 17584 17584 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 83312 83312 0 0.0
.dynamic 592 592 0 0.0
.got 4328 4328 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 174560 174560 0 0.0
.text 2423429 2423429 0 0.0
ota-provider-app debug .bss 37504 37504 0 0.0
.data 752 752 0 0.0
.data.rel.ro 23192 23192 0 0.0
.dynamic 592 592 0 0.0
.got 4008 4008 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 109856 109856 0 0.0
.text 1010258 1010258 0 0.0
ota-requestor-app debug .bss 205760 205760 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24488 24488 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 127936 127936 0 0.0
.text 1129922 1129922 0 0.0
shell debug .bss 16104 16104 0 0.0
.data 242 242 0 0.0
.data.rel.ro 35184 35184 0 0.0
.dynamic 592 592 0 0.0
.got 3504 3504 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 72143 72143 0 0.0
.text 575314 575314 0 0.0
tv-app debug .bss 216400 216400 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 55568 55568 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 151560 151592 32 0.0
.text 1468146 1468146 0 0.0
bridge-app debug+rpc .bss 52912 52912 0 0.0
.data 976 976 0 0.0
.data.rel.ro 25512 25512 0 0.0
.dynamic 592 592 0 0.0
.got 3944 3944 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110548 110548 0 0.0
.text 1051877 1051877 0 0.0
lighting-app debug+rpc .bss 42232 42232 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 52256 52256 0 0.0
.dynamic 608 608 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 127665 127665 0 0.0
.text 1253026 1253026 0 0.0
mbed lighting-app CY8CPROTO_062_4343W+release .bss 172148 172148 0 0.0
.data 5464 5464 0 0.0
.heap 858832 858832 0 0.0
.text 1220096 1220096 0 0.0
lock-app CY8CPROTO_062_4343W+release .bss 171084 171084 0 0.0
.data 5432 5432 0 0.0
.heap 859928 859928 0 0.0
.text 1198080 1198080 0 0.0
2 builds
platform target config section a56c83e 325b60f change % change
esp32 all-clusters-app c3devkit .dram0.bss 60264 60264 0 0.0
.dram0.data 16232 16232 0 0.0
.flash.rodata 198632 198632 0 0.0
.flash.text 870358 870358 0 0.0
.iram0.text 57330 57330 0 0.0
m5stack .dram0.bss 62768 62768 0 0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 207212 207212 0 0.0
.flash.text 901511 901419 -92 -0.0
.iram0.text 125115 125115 0 0.0
10 builds
platform target config section a56c83e 325b60f change % change
nrfconnect lighting-app nrf52840dk_nrf52840 bss 112320 112320 0 0.0
rodata 97632 97632 0 0.0
text 577824 577824 0 0.0
lock-app nrf52840dk_nrf52840 bss 111352 111352 0 0.0
rodata 94128 94128 0 0.0
text 559264 559264 0 0.0
pigweed-app nrf52840dk_nrf52840 bss 51772 51772 0 0.0
rodata 45772 45772 0 0.0
text 339392 339392 0 0.0
pump-app nrf52840dk_nrf52840 bss 111420 111420 0 0.0
rodata 95112 95112 0 0.0
text 562436 562436 0 0.0
pump-controller-app nrf52840dk_nrf52840 bss 111360 111360 0 0.0
rodata 94188 94188 0 0.0
text 559040 559040 0 0.0
shell nrf52840dk_nrf52840 bss 107320 107320 0 0.0
rodata 71788 71788 0 0.0
text 519308 519308 0 0.0
lighting-app nrf52840dk_nrf52840+rpc bss 108560 108560 0 0.0
rodata 88416 88416 0 0.0
text 551028 551028 0 0.0
nrf5340dk_nrf5340_cpuapp bss 113692 113692 0 0.0
rodata 92872 92872 0 0.0
text 507284 507284 0 0.0
lock-app nrf5340dk_nrf5340_cpuapp bss 112724 112724 0 0.0
rodata 89388 89388 0 0.0
text 488720 488720 0 0.0
shell nrf5340dk_nrf5340_cpuapp bss 108304 108304 0 0.0
rodata 66432 66432 0 0.0
text 439908 439908 0 0.0

saurabhst
saurabhst approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@saurabhst saurabhst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subject to comment resolution based on @msandstedt feedback

@andy31415 andy31415 merged commit 581b57a into project-chip:master Oct 19, 2021
@kkasperczyk-no kkasperczyk-no mentioned this pull request Oct 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@saurabhst saurabhst saurabhst approved these changes

@msandstedt msandstedt msandstedt approved these changes

@LuDuda LuDuda LuDuda approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@shana-apple shana-apple Awaiting requested review from shana-apple

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app darwin lib openthread platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Damian-Nordic @andy31415 @LuDuda @msandstedt @saurabhst @jmartinez-silabs @restyled-commits