Cluster object based reads on the client. #10524

mrjerryjohns · 2021-10-14T18:30:58Z

Like the TypedCommandCallback and InvokeCommand APIs added before,
this adds a TypedReadCallback and ReadAttribute API that utilizes
cluster objects to deliver attribute data to a reader.

This utilizes the attribute type information struct that is
code-generated currently to avoid needing callers to have to specify
static schema information like the Cluster or Attribute Ids.

This also avoids the use of gCallbackMgr and the dynamic dispatch
logic contained within it given it's unsafe usage of reinterpret_casts, and achieves
dispatch compactly and safely within the implementation of the
ReadAttribute API alone in conjunction with the type safety afforded by using
the templated DataModel::Decode methods.

Tests: Added a TestRead unit test that exercises a pseudo end-to-end
flow of a read that is sent from a client, processed by the server, and
a response returned back to the client. It includes both positive and
negative test-cases.

todo · 2021-10-14T18:31:00Z

Figure out why I cannot enable this line below.

connectedhomeip/src/controller/tests/data_model/TestRead.cpp

Lines 226 to 236 in ffe65a7

    
           // TODO: Figure out why I cannot enable this line below. 
        
           // 
        
           //NL_TEST_ASSERT(apSuite, gExchangeManager->GetNumActiveExchanges() == 1); 
        
           chip::app::InteractionModelEngine::GetInstance()->GetReportingEngine().Run(); 
        
           gExchangeManager->OnConnectionExpired(ctx.GetSessionAliceToBob()); 
        
           NL_TEST_ASSERT(apSuite, chip::app::InteractionModelEngine::GetInstance()->GetNumActiveReadHandlers() == 0); 
        
           //

This comment was generated by todo based on a `TODO` comment in `ffe65a7` in #10524. cc @mrjerryjohns.

todo · 2021-10-14T18:31:03Z

Figure out why I cannot enable this line below.

connectedhomeip/src/controller/tests/data_model/TestRead.cpp

Lines 237 to 247 in ffe65a7

    
               // TODO: Figure out why I cannot enable this line below. 
        
               // 
        
               //NL_TEST_ASSERT(apSuite, gExchangeManager->GetNumActiveExchanges() == 0); 
        
           } 
        
           // clang-format off 
        
           const nlTest sTests[] = 
        
           { 
        
               NL_TEST_DEF("TestDataResponse", TestReadInteraction::TestDataResponse), 
        
               NL_TEST_DEF("TestAttributeError", TestReadInteraction::TestAttributeError), 
        
               NL_TEST_DEF("TestReadTimeout", TestReadInteraction::TestReadTimeout),

This comment was generated by todo based on a `TODO` comment in `ffe65a7` in #10524. cc @mrjerryjohns.

Like the TypedCommandCallback and InvokeCommand API added before, this adds a TypedReadCallback and ReadAttribute API that utilizes cluster objects to deliver attribute data to a reader. This utilizes the attribute type information struct that is code-generated currently to avoid needing callers to have to specify static schema information like the Cluster or Attribute Ids. This also avoids the use of gCallbackMgr and the entire dynamic dispatch logic contained within it given it's highly unsafe usage of reinterpret_casts, and achieves dispatch very compactly and safely within the implementation of the ReadAttribute API alone in conjunction with the safety afforded by using the templated DataModel::Decode methods. Tests: Added a TestRead unit test that exercises a pseudo end-to-end flow of a read that is sent from a client, processed by the server, and a response returned back to the client. It includes both positive and negative test-cases.

github-actions · 2021-10-14T19:25:30Z

PR #10524: Size comparison from 2377fea to d80720a

20 builds

platform	target	config	section	`2377fea`	`d80720a`	change
efr32	lighting-app	BRD4161A	.bss	118020	118020	0
			.data	1800	1800	0
			.text	781852	781852	0
	lock-app	BRD4161A	.bss	115892	115892	0
			.data	1760	1760	0
			.text	761124	761124	0
	window-app	BRD4161A	.bss	116212	116212	0
			.data	1764	1764	0
			.text	762032	762032	0
	lighting-app	BRD4161A+rpc	.bss	131348	131348	0
			.data	1852	1852	0
			.text	761592	761592	0
k32w	lock-app	k32w061+debug	.bss	69052	69052	0
			.data	1864	1864	0
			.text	514540	514540	0
	shell	k32w061+debug	.bss	55080	55080	0
			.data	672	672	0
			.text	356808	356808	0
	lighting-app	k32w061+se05x+release	.bss	78568	78568	0
			.data	1900	1900	0
			.text	613216	613216	0
linux	all-clusters-app	debug	.bss	52176	52176	0
			.data	978	978	0
			.data.rel.ro	58416	58416	0
			.dynamic	592	592	0
			.got	4072	4072	0
			.init	27	27	0
			.init_array	512	512	0
			.rodata	135029	135029	0
			.text	`1321298`	`1321298`	0
	chip-tool	debug	.bss	17584	17584	0
			.data	1584	1584	0
			.data.rel.ro	83312	83312	0
			.dynamic	592	592	0
			.got	4328	4328	0
			.init	27	27	0
			.init_array	424	424	0
			.rodata	173792	173792	0
			.text	2422117	`2422149`	32
	ota-provider-app	debug	.bss	37504	37504	0
			.data	752	752	0
			.data.rel.ro	23192	23192	0
			.dynamic	592	592	0
			.got	4008	4008	0
			.init	27	27	0
			.init_array	448	448	0
			.rodata	109080	109080	0
			.text	`1008946`	`1008946`	0
	ota-requestor-app	debug	.bss	205760	205760	0
			.data	752	752	0
			.data.rel.ro	24488	24488	0
			.dynamic	592	592	0
			.got	4136	4136	0
			.init	27	27	0
			.init_array	520	520	0
			.rodata	127152	127152	0
			.text	1128594	1128594	0
	shell	debug	.bss	16104	16104	0
			.data	242	242	0
			.data.rel.ro	35184	35184	0
			.dynamic	592	592	0
			.got	3504	3504	0
			.init	27	27	0
			.init_array	344	344	0
			.rodata	71343	71343	0
			.text	574322	574322	0
	tv-app	debug	.bss	216400	216400	0
			.data	2032	2032	0
			.data.rel.ro	55568	55568	0
			.dynamic	592	592	0
			.got	4408	4408	0
			.init	27	27	0
			.init_array	616	616	0
			.rodata	150792	150792	0
			.text	1466802	1466802	0
	bridge-app	debug+rpc	.bss	52912	52912	0
			.data	976	976	0
			.data.rel.ro	25512	25512	0
			.dynamic	592	592	0
			.got	3944	3944	0
			.init	27	27	0
			.init_array	408	408	0
			.rodata	109748	109748	0
			.text	1050565	1050565	0
	lighting-app	debug+rpc	.bss	42232	42232	0
			.data	1106	1106	0
			.data.rel.ro	52256	52256	0
			.dynamic	608	608	0
			.got	4104	4104	0
			.init	27	27	0
			.init_array	536	536	0
			.rodata	126897	126897	0
			.text	1251714	1251714	0
p6	lock-app	default	.bss	68224	68224	0
			.data	2416	2416	0
			.heap	962704	962704	0
			.text	1125776	1125776	0
qpg	lighting-app	qpg6100+debug	.bss	53536	53536	0
			.data	996	996	0
			.text	485728	485728	0
	lock-app	qpg6100+debug	.bss	52488	52488	0
			.data	952	952	0
			.text	461912	461912	0
	persistent-storage-app	qpg6100+debug	.bss	17778	17778	0
			.data	280	280	0
			.text	102704	102704	0
telink	lighting-app	tlsr9518adk80d	bss	70988	70988	0
			noinit	33216	33216	0
			text	457904	457904	0

2 builds

platform	target	config	section	`2377fea`	`d80720a`
mbed	lighting-app	CY8CPROTO_062_4343W+release	.bss	172148	172148
			.data	5464	5464
			.heap	858832	858832
			.text	1219128	1219128
	lock-app	CY8CPROTO_062_4343W+release	.bss	171084	171084
			.data	5432	5432
			.heap	859928	859928
			.text	1197112	1197112

github-actions · 2021-10-14T19:54:39Z

PR #10524: Size comparison from 2377fea to 0dca07b

20 builds

platform	target	config	section	`2377fea`	`0dca07b`	change
efr32	lighting-app	BRD4161A	.bss	118020	118020	0
			.data	1800	1800	0
			.text	781852	781852	0
	lock-app	BRD4161A	.bss	115892	115892	0
			.data	1760	1760	0
			.text	761124	761124	0
	window-app	BRD4161A	.bss	116212	116212	0
			.data	1764	1764	0
			.text	762032	762032	0
	lighting-app	BRD4161A+rpc	.bss	131348	131348	0
			.data	1852	1852	0
			.text	761592	761592	0
k32w	lock-app	k32w061+debug	.bss	69052	69052	0
			.data	1864	1864	0
			.text	514540	514540	0
	shell	k32w061+debug	.bss	55080	55080	0
			.data	672	672	0
			.text	356808	356808	0
	lighting-app	k32w061+se05x+release	.bss	78568	78568	0
			.data	1900	1900	0
			.text	613216	613216	0
linux	all-clusters-app	debug	.bss	52176	52176	0
			.data	978	978	0
			.data.rel.ro	58416	58416	0
			.dynamic	592	592	0
			.got	4072	4072	0
			.init	27	27	0
			.init_array	512	512	0
			.rodata	135029	135029	0
			.text	`1321298`	`1321298`	0
	chip-tool	debug	.bss	17584	17584	0
			.data	1584	1584	0
			.data.rel.ro	83312	83312	0
			.dynamic	592	592	0
			.got	4328	4328	0
			.init	27	27	0
			.init_array	424	424	0
			.rodata	173792	173792	0
			.text	2422117	`2422149`	32
	ota-provider-app	debug	.bss	37504	37504	0
			.data	752	752	0
			.data.rel.ro	23192	23192	0
			.dynamic	592	592	0
			.got	4008	4008	0
			.init	27	27	0
			.init_array	448	448	0
			.rodata	109080	109080	0
			.text	`1008946`	`1008946`	0
	ota-requestor-app	debug	.bss	205760	205760	0
			.data	752	752	0
			.data.rel.ro	24488	24488	0
			.dynamic	592	592	0
			.got	4136	4136	0
			.init	27	27	0
			.init_array	520	520	0
			.rodata	127152	127152	0
			.text	1128594	1128594	0
	shell	debug	.bss	16104	16104	0
			.data	242	242	0
			.data.rel.ro	35184	35184	0
			.dynamic	592	592	0
			.got	3504	3504	0
			.init	27	27	0
			.init_array	344	344	0
			.rodata	71343	71343	0
			.text	574322	574322	0
	tv-app	debug	.bss	216400	216400	0
			.data	2032	2032	0
			.data.rel.ro	55568	55568	0
			.dynamic	592	592	0
			.got	4408	4408	0
			.init	27	27	0
			.init_array	616	616	0
			.rodata	150792	150792	0
			.text	1466802	1466802	0
	bridge-app	debug+rpc	.bss	52912	52912	0
			.data	976	976	0
			.data.rel.ro	25512	25512	0
			.dynamic	592	592	0
			.got	3944	3944	0
			.init	27	27	0
			.init_array	408	408	0
			.rodata	109748	109748	0
			.text	1050565	1050565	0
	lighting-app	debug+rpc	.bss	42232	42232	0
			.data	1106	1106	0
			.data.rel.ro	52256	52256	0
			.dynamic	608	608	0
			.got	4104	4104	0
			.init	27	27	0
			.init_array	536	536	0
			.rodata	126897	126897	0
			.text	1251714	1251714	0
p6	lock-app	default	.bss	68224	68224	0
			.data	2416	2416	0
			.heap	962704	962704	0
			.text	1125776	1125776	0
qpg	lighting-app	qpg6100+debug	.bss	53536	53536	0
			.data	996	996	0
			.text	485728	485728	0
	lock-app	qpg6100+debug	.bss	52488	52488	0
			.data	952	952	0
			.text	461912	461912	0
	persistent-storage-app	qpg6100+debug	.bss	17778	17778	0
			.data	280	280	0
			.text	102704	102704	0
telink	lighting-app	tlsr9518adk80d	bss	70988	70988	0
			noinit	33216	33216	0
			text	457904	457904	0

2 builds

platform	target	config	section	`2377fea`	`0dca07b`
mbed	lighting-app	CY8CPROTO_062_4343W+release	.bss	172148	172148
			.data	5464	5464
			.heap	858832	858832
			.text	1219128	1219128
	lock-app	CY8CPROTO_062_4343W+release	.bss	171084	171084
			.data	5432	5432
			.heap	859928	859928
			.text	1197112	1197112

12 builds

platform	target	config	section	`2377fea`	`0dca07b`	change
esp32	all-clusters-app	c3devkit	.dram0.bss	60264	60264	0
			.dram0.data	16232	16232	0
			.flash.rodata	198168	198168	0
			.flash.text	869458	869458	0
			.iram0.text	57330	57330	0
		m5stack	.dram0.bss	62768	62768	0
			.dram0.data	32084	32084	0
			.flash.rodata	206756	206756	0
			.flash.text	900459	900551	92
			.iram0.text	125115	125115	0
nrfconnect	lighting-app	nrf52840dk_nrf52840	bss	112320	112320	0
			rodata	97180	97180	0
			text	577324	577324	0
	lock-app	nrf52840dk_nrf52840	bss	111352	111352	0
			rodata	93676	93676	0
			text	558764	558764	0
	pigweed-app	nrf52840dk_nrf52840	bss	51772	51772	0
			rodata	45772	45772	0
			text	339392	339392	0
	pump-app	nrf52840dk_nrf52840	bss	111420	111420	0
			rodata	94660	94660	0
			text	561936	561936	0
	pump-controller-app	nrf52840dk_nrf52840	bss	111360	111360	0
			rodata	93736	93736	0
			text	558540	558540	0
	shell	nrf52840dk_nrf52840	bss	107320	107320	0
			rodata	71336	71336	0
			text	518964	518964	0
	lighting-app	nrf52840dk_nrf52840+rpc	bss	108560	108560	0
			rodata	87960	87960	0
			text	550528	550528	0
		nrf5340dk_nrf5340_cpuapp	bss	113692	113692	0
			rodata	92420	92420	0
			text	506780	506780	0
	lock-app	nrf5340dk_nrf5340_cpuapp	bss	112724	112724	0
			rodata	88936	88936	0
			text	488216	488216	0
	shell	nrf5340dk_nrf5340_cpuapp	bss	108304	108304	0
			rodata	65980	65980	0
			text	439564	439564	0

src/controller/ReadInteraction.h

src/controller/TypedReadCallback.h

src/controller/ReadInteraction.h

msandstedt

I have a few comments inline. But for the most part, this looks great to me.

src/app/InteractionModelEngine.cpp

src/app/InteractionModelEngine.h

src/controller/ReadInteraction.h

src/controller/TypedReadCallback.h

src/controller/tests/data_model/TestRead.cpp

Co-authored-by: Michael Sandstedt <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>

src/app/InteractionModelEngine.h

src/controller/tests/data_model/TestRead.cpp

src/app/InteractionModelEngine.cpp

src/controller/ReadInteraction.h

github-actions · 2021-10-18T20:06:29Z

PR #10524: Size comparison from 4f389d5 to 4c22e99

2 builds

platform	target	config	section	`4f389d5`	`4c22e99`
p6	lock-app	default	.bss	68216	68216
			.data	2416	2416
			.heap	962712	962712
			.text	1126472	1126472
telink	lighting-app	tlsr9518adk80d	bss	71000	71000
			noinit	33216	33216
			text	458220	458220

20 builds

platform	target	config	section	`4f389d5`	`4c22e99`	change
efr32	lighting-app	BRD4161A	.bss	118036	118036	0
			.data	1800	1800	0
			.text	782788	782788	0
	lock-app	BRD4161A	.bss	115892	115892	0
			.data	1760	1760	0
			.text	761932	761932	0
	window-app	BRD4161A	.bss	116212	116212	0
			.data	1764	1764	0
			.text	762840	762840	0
	lighting-app	BRD4161A+rpc	.bss	131364	131364	0
			.data	1852	1852	0
			.text	762532	762532	0
k32w	lock-app	k32w061+debug	.bss	69052	69052	0
			.data	1864	1864	0
			.text	515352	515352	0
	shell	k32w061+debug	.bss	55080	55080	0
			.data	672	672	0
			.text	357332	357332	0
	lighting-app	k32w061+se05x+release	.bss	78576	78576	0
			.data	1900	1900	0
			.text	614136	614136	0
linux	all-clusters-app	debug	.bss	52176	52176	0
			.data	978	978	0
			.data.rel.ro	58688	58688	0
			.dynamic	592	592	0
			.got	4072	4072	0
			.init	27	27	0
			.init_array	512	512	0
			.rodata	136149	136149	0
			.text	1344930	1344930	0
	chip-tool	debug	.bss	17552	17552	0
			.data	1584	1584	0
			.data.rel.ro	86192	86192	0
			.dynamic	592	592	0
			.got	4344	4344	0
			.init	27	27	0
			.init_array	416	416	0
			.rodata	178476	178476	0
			.text	`2859461`	2859541	80
	ota-provider-app	debug	.bss	37472	37472	0
			.data	752	752	0
			.data.rel.ro	23176	23176	0
			.dynamic	592	592	0
			.got	4008	4008	0
			.init	27	27	0
			.init_array	440	440	0
			.rodata	109832	109832	0
			.text	1010354	1010354	0
	ota-requestor-app	debug	.bss	205728	205728	0
			.data	752	752	0
			.data.rel.ro	24488	24488	0
			.dynamic	592	592	0
			.got	4136	4136	0
			.init	27	27	0
			.init_array	512	512	0
			.rodata	128328	128328	0
			.text	1129666	1129666	0
	shell	debug	.bss	16072	16072	0
			.data	242	242	0
			.data.rel.ro	35120	35120	0
			.dynamic	592	592	0
			.got	3496	3496	0
			.init	27	27	0
			.init_array	336	336	0
			.rodata	71855	71855	0
			.text	569858	569858	0
	tv-app	debug	.bss	216400	216400	0
			.data	2032	2032	0
			.data.rel.ro	55872	55872	0
			.dynamic	592	592	0
			.got	4400	4400	0
			.init	27	27	0
			.init_array	608	608	0
			.rodata	151848	151848	0
			.text	1464242	1464242	0
	bridge-app	debug+rpc	.bss	52912	52912	0
			.data	976	976	0
			.data.rel.ro	25784	25784	0
			.dynamic	592	592	0
			.got	3944	3944	0
			.init	27	27	0
			.init_array	400	400	0
			.rodata	110452	110452	0
			.text	1052389	1052389	0
	lighting-app	debug+rpc	.bss	42232	42232	0
			.data	1106	1106	0
			.data.rel.ro	52496	52496	0
			.dynamic	608	608	0
			.got	4104	4104	0
			.init	27	27	0
			.init_array	528	528	0
			.rodata	127665	127665	0
			.text	`1253666`	`1253666`	0
mbed	lighting-app	CY8CPROTO_062_4343W+release	.bss	172164	172164	0
			.data	5464	5464	0
			.heap	858816	858816	0
			.text	1219800	1219800	0
	lock-app	CY8CPROTO_062_4343W+release	.bss	171084	171084	0
			.data	5432	5432	0
			.heap	859928	859928	0
			.text	1197632	1197632	0
qpg	lighting-app	qpg6100+debug	.bss	53552	53552	0
			.data	996	996	0
			.text	486448	486448	0
	lock-app	qpg6100+debug	.bss	52488	52488	0
			.data	952	952	0
			.text	462520	462520	0
	persistent-storage-app	qpg6100+debug	.bss	17778	17778	0
			.data	280	280	0
			.text	102704	102704	0

12 builds

platform	target	config	section	`4f389d5`	`4c22e99`
esp32	all-clusters-app	c3devkit	.dram0.bss	60296	60296
			.dram0.data	16192	16192
			.flash.rodata	198896	198896
			.flash.text	872534	872534
			.iram0.text	57330	57330
		m5stack	.dram0.bss	62792	62792
			.dram0.data	32084	32084
			.flash.rodata	207320	207320
			.flash.text	902815	902815
			.iram0.text	125115	125115
nrfconnect	lighting-app	nrf52840dk_nrf52840	bss	112332	112332
			rodata	97688	97688
			text	577568	577568
	lock-app	nrf52840dk_nrf52840	bss	111348	111348
			rodata	94028	94028
			text	559068	559068
	pigweed-app	nrf52840dk_nrf52840	bss	51772	51772
			rodata	45772	45772
			text	339392	339392
	pump-app	nrf52840dk_nrf52840	bss	111416	111416
			rodata	95008	95008
			text	562224	562224
	pump-controller-app	nrf52840dk_nrf52840	bss	111356	111356
			rodata	94088	94088
			text	558860	558860
	shell	nrf52840dk_nrf52840	bss	107316	107316
			rodata	71640	71640
			text	519032	519032
	lighting-app	nrf52840dk_nrf52840+rpc	bss	108572	108572
			rodata	88480	88480
			text	550772	550772
		nrf5340dk_nrf5340_cpuapp	bss	113704	113704
			rodata	92932	92932
			text	507032	507032
	lock-app	nrf5340dk_nrf5340_cpuapp	bss	112720	112720
			rodata	89284	89284
			text	488528	488528
	shell	nrf5340dk_nrf5340_cpuapp	bss	108300	108300
			rodata	66284	66284
			text	439632	439632

github-actions · 2021-10-18T22:19:45Z

PR #10524: Size comparison from ca22841 to a8de91c

1 build

platform	target	config	section	`ca22841`	`a8de91c`
telink	lighting-app	tlsr9518adk80d	bss	71000	71000
			noinit	33216	33216
			text	458216	458216

17 builds

platform	target	config	section	`ca22841`	`a8de91c`	change
k32w	lock-app	k32w061+debug	.bss	69052	69052	0
			.data	1864	1864	0
			.text	515344	515344	0
	shell	k32w061+debug	.bss	55080	55080	0
			.data	672	672	0
			.text	357332	357332	0
	lighting-app	k32w061+se05x+release	.bss	78576	78576	0
			.data	1900	1900	0
			.text	614128	614128	0
linux	all-clusters-app	debug	.bss	52176	52176	0
			.data	978	978	0
			.data.rel.ro	58688	58688	0
			.dynamic	592	592	0
			.got	4072	4072	0
			.init	27	27	0
			.init_array	512	512	0
			.rodata	136149	136149	0
			.text	1344946	1344946	0
	chip-tool	debug	.bss	17552	17552	0
			.data	1584	1584	0
			.data.rel.ro	86192	86192	0
			.dynamic	592	592	0
			.got	4344	4344	0
			.init	27	27	0
			.init_array	416	416	0
			.rodata	178700	178700	0
			.text	2859717	`2859797`	80
	ota-provider-app	debug	.bss	37472	37472	0
			.data	752	752	0
			.data.rel.ro	23176	23176	0
			.dynamic	592	592	0
			.got	4008	4008	0
			.init	27	27	0
			.init_array	440	440	0
			.rodata	109832	109832	0
			.text	1010370	1010370	0
	ota-requestor-app	debug	.bss	205728	205728	0
			.data	752	752	0
			.data.rel.ro	24488	24488	0
			.dynamic	592	592	0
			.got	4136	4136	0
			.init	27	27	0
			.init_array	512	512	0
			.rodata	128552	128552	0
			.text	`1129922`	`1129922`	0
	shell	debug	.bss	16072	16072	0
			.data	242	242	0
			.data.rel.ro	35120	35120	0
			.dynamic	592	592	0
			.got	3496	3496	0
			.init	27	27	0
			.init_array	336	336	0
			.rodata	71855	71855	0
			.text	569858	569858	0
	tv-app	debug	.bss	216400	216400	0
			.data	2032	2032	0
			.data.rel.ro	55872	55872	0
			.dynamic	592	592	0
			.got	4400	4400	0
			.init	27	27	0
			.init_array	608	608	0
			.rodata	152072	152072	0
			.text	`1464498`	`1464498`	0
	bridge-app	debug+rpc	.bss	52912	52912	0
			.data	976	976	0
			.data.rel.ro	25784	25784	0
			.dynamic	592	592	0
			.got	3944	3944	0
			.init	27	27	0
			.init_array	400	400	0
			.rodata	110452	110452	0
			.text	`1052405`	`1052405`	0
	lighting-app	debug+rpc	.bss	42232	42232	0
			.data	1106	1106	0
			.data.rel.ro	52496	52496	0
			.dynamic	608	608	0
			.got	4104	4104	0
			.init	27	27	0
			.init_array	528	528	0
			.rodata	127665	127665	0
			.text	1253682	1253682	0
mbed	lighting-app	CY8CPROTO_062_4343W+release	.bss	172164	172164	0
			.data	5464	5464	0
			.heap	858816	858816	0
			.text	`1219792`	`1219792`	0
	lock-app	CY8CPROTO_062_4343W+release	.bss	171084	171084	0
			.data	5432	5432	0
			.heap	859928	859928	0
			.text	1197616	1197616	0
p6	lock-app	default	.bss	68216	68216	0
			.data	2416	2416	0
			.heap	962712	962712	0
			.text	1126464	1126464	0
qpg	lighting-app	qpg6100+debug	.bss	53552	53552	0
			.data	996	996	0
			.text	486440	486440	0
	lock-app	qpg6100+debug	.bss	52488	52488	0
			.data	952	952	0
			.text	462512	462512	0
	persistent-storage-app	qpg6100+debug	.bss	17778	17778	0
			.data	280	280	0
			.text	102704	102704	0

4 builds

platform	target	config	section	`ca22841`	`a8de91c`
efr32	lighting-app	BRD4161A	.bss	118036	118036
			.data	1800	1800
			.text	782788	782788
	lock-app	BRD4161A	.bss	115892	115892
			.data	1760	1760
			.text	761924	761924
	window-app	BRD4161A	.bss	116212	116212
			.data	1764	1764
			.text	762840	762840
	lighting-app	BRD4161A+rpc	.bss	131364	131364
			.data	1852	1852
			.text	762540	762540

2 builds

platform	target	config	section	`ca22841`	`a8de91c`	change	% change
esp32	all-clusters-app	c3devkit	.dram0.bss	60296	60296	0	0.0
			.dram0.data	16192	16192	0	0.0
			.flash.rodata	198888	198888	0	0.0
			.flash.text	872530	872530	0	0.0
			.iram0.text	57330	57330	0	0.0
		m5stack	.dram0.bss	62792	62792	0	0.0
			.dram0.data	32084	32084	0	0.0
			.flash.rodata	207312	207312	0	0.0
			.flash.text	902751	902659	-92	-0.0
			.iram0.text	125115	125115	0	0.0

10 builds

platform	target	config	section	`ca22841`	`a8de91c`
nrfconnect	lighting-app	nrf52840dk_nrf52840	bss	112332	112332
			rodata	97684	97684
			text	577572	577572
	lock-app	nrf52840dk_nrf52840	bss	111348	111348
			rodata	94020	94020
			text	559072	559072
	pigweed-app	nrf52840dk_nrf52840	bss	51772	51772
			rodata	45772	45772
			text	339392	339392
	pump-app	nrf52840dk_nrf52840	bss	111416	111416
			rodata	95000	95000
			text	562228	562228
	pump-controller-app	nrf52840dk_nrf52840	bss	111356	111356
			rodata	94080	94080
			text	558864	558864
	shell	nrf52840dk_nrf52840	bss	107316	107316
			rodata	71640	71640
			text	519032	519032
	lighting-app	nrf52840dk_nrf52840+rpc	bss	108572	108572
			rodata	88472	88472
			text	550776	550776
		nrf5340dk_nrf5340_cpuapp	bss	113704	113704
			rodata	92924	92924
			text	507036	507036
	lock-app	nrf5340dk_nrf5340_cpuapp	bss	112720	112720
			rodata	89280	89280
			text	488532	488532
	shell	nrf5340dk_nrf5340_cpuapp	bss	108300	108300
			rodata	66284	66284
			text	439632	439632

github-actions · 2021-10-19T19:52:01Z

PR #10524: Size comparison from ca22841 to 6edc6d1

8 builds (for k32w, p6, qpg, telink)

platform	target	config	section	`ca22841`	`6edc6d1`	change
k32w	lock-app	k32w061+debug	.bss	69052	69052	0
			.data	1864	1864	0
			.text	515344	515520	176
	shell	k32w061+debug	.bss	55080	55080	0
			.data	672	672	0
			.text	357332	357332	0
	lighting-app	k32w061+se05x+release	.bss	78576	78576	0
			.data	1900	1900	0
			.text	614128	614304	176
p6	lock-app	default	.bss	68216	68216	0
			.data	2416	2416	0
			.heap	962712	962712	0
			.text	1126464	1126624	160
qpg	lighting-app	qpg6100+debug	.bss	53552	53552	0
			.data	996	996	0
			.text	486440	486616	176
	lock-app	qpg6100+debug	.bss	52488	52488	0
			.data	952	952	0
			.text	462512	462684	172
	persistent-storage-app	qpg6100+debug	.bss	17778	17778	0
			.data	280	280	0
			.text	102704	102704	0
telink	lighting-app	tlsr9518adk80d	bss	71000	71000	0
			noinit	33216	33216	0
			text	458216	458304	88

14 builds (for efr32, linux, mbed)

platform	target	config	section	`ca22841`	`6edc6d1`	change	% change
efr32	lighting-app	BRD4161A	.bss	118036	118036	0	0.0
			.data	1800	1800	0	0.0
			.text	782788	782944	156	0.0
	lock-app	BRD4161A	.bss	115892	115892	0	0.0
			.data	1760	1760	0	0.0
			.text	761924	762088	164	0.0
	window-app	BRD4161A	.bss	116212	116212	0	0.0
			.data	1764	1764	0	0.0
			.text	762840	763012	172	0.0
	lighting-app	BRD4161A+rpc	.bss	131364	131364	0	0.0
			.data	1852	1852	0	0.0
			.text	762540	762700	160	0.0
linux	all-clusters-app	debug	.bss	52176	52176	0	0.0
			.data	978	978	0	0.0
			.data.rel.ro	58688	58688	0	0.0
			.dynamic	592	592	0	0.0
			.got	4072	4072	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	136149	136373	224	0.2
			.text	1344946	1345186	240	0.0
	chip-tool	debug	.bss	17552	17552	0	0.0
			.data	1584	1584	0	0.0
			.data.rel.ro	86192	86192	0	0.0
			.dynamic	592	592	0	0.0
			.got	4344	4344	0	0.0
			.init	27	27	0	0.0
			.init_array	416	416	0	0.0
			.rodata	178700	178892	192	0.1
			.text	2859717	2860021	304	0.0
	ota-provider-app	debug	.bss	37472	37472	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	23176	23176	0	0.0
			.dynamic	592	592	0	0.0
			.got	4008	4008	0	0.0
			.init	27	27	0	0.0
			.init_array	440	440	0	0.0
			.rodata	109832	110056	224	0.2
			.text	1010370	1010594	224	0.0
	ota-requestor-app	debug	.bss	205728	205728	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	24488	24488	0	0.0
			.dynamic	592	592	0	0.0
			.got	4136	4136	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	128552	128744	192	0.1
			.text	`1129922`	1130130	208	0.0
	shell	debug	.bss	16072	16072	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	35120	35120	0	0.0
			.dynamic	592	592	0	0.0
			.got	3496	3496	0	0.0
			.init	27	27	0	0.0
			.init_array	336	336	0	0.0
			.rodata	71855	71855	0	0.0
			.text	569858	569858	0	0.0
	tv-app	debug	.bss	216400	216400	0	0.0
			.data	2032	2032	0	0.0
			.data.rel.ro	55872	55872	0	0.0
			.dynamic	592	592	0	0.0
			.got	4400	4400	0	0.0
			.init	27	27	0	0.0
			.init_array	608	608	0	0.0
			.rodata	152072	152296	224	0.1
			.text	`1464498`	1464706	208	0.0
	bridge-app	debug+rpc	.bss	52912	52912	0	0.0
			.data	976	976	0	0.0
			.data.rel.ro	25784	25784	0	0.0
			.dynamic	592	592	0	0.0
			.got	3944	3944	0	0.0
			.init	27	27	0	0.0
			.init_array	400	400	0	0.0
			.rodata	110452	110644	192	0.2
			.text	`1052405`	1052629	224	0.0
	lighting-app	debug+rpc	.bss	42232	42232	0	0.0
			.data	1106	1106	0	0.0
			.data.rel.ro	52496	52496	0	0.0
			.dynamic	608	608	0	0.0
			.got	4104	4104	0	0.0
			.init	27	27	0	0.0
			.init_array	528	528	0	0.0
			.rodata	127665	127857	192	0.2
			.text	1253682	1253906	224	0.0
mbed	lighting-app	CY8CPROTO_062_4343W+release	.bss	172164	172164	0	0.0
			.data	5464	5464	0	0.0
			.heap	858816	858816	0	0.0
			.text	`1219792`	1219944	152	0.0
	lock-app	CY8CPROTO_062_4343W+release	.bss	171084	171084	0	0.0
			.data	5432	5432	0	0.0
			.heap	859928	859928	0	0.0
			.text	1197616	1197840	224	0.0

10 builds (for nrfconnect)

platform	target	config	section	`ca22841`	`6edc6d1`	change	% change
nrfconnect	lighting-app	nrf52840dk_nrf52840	bss	112332	112332	0	0.0
			rodata	97684	97776	92	0.1
			text	577572	577652	80	0.0
	lock-app	nrf52840dk_nrf52840	bss	111348	111348	0	0.0
			rodata	94020	94112	92	0.1
			text	559072	559152	80	0.0
	pigweed-app	nrf52840dk_nrf52840	bss	51772	51772	0	0.0
			rodata	45772	45772	0	0.0
			text	339392	339392	0	0.0
	pump-app	nrf52840dk_nrf52840	bss	111416	111416	0	0.0
			rodata	95000	95092	92	0.1
			text	562228	562308	80	0.0
	pump-controller-app	nrf52840dk_nrf52840	bss	111356	111356	0	0.0
			rodata	94080	94172	92	0.1
			text	558864	558944	80	0.0
	shell	nrf52840dk_nrf52840	bss	107316	107316	0	0.0
			rodata	71640	71640	0	0.0
			text	519032	519032	0	0.0
	lighting-app	nrf52840dk_nrf52840+rpc	bss	108572	108572	0	0.0
			rodata	88472	88560	88	0.1
			text	550776	550856	80	0.0
		nrf5340dk_nrf5340_cpuapp	bss	113704	113704	0	0.0
			rodata	92924	93016	92	0.1
			text	507036	507116	80	0.0
	lock-app	nrf5340dk_nrf5340_cpuapp	bss	112720	112720	0	0.0
			rodata	89280	89372	92	0.1
			text	488532	488612	80	0.0
	shell	nrf5340dk_nrf5340_cpuapp	bss	108300	108300	0	0.0
			rodata	66284	66284	0	0.0
			text	439632	439632	0	0.0

2 builds (for esp32)

platform	target	config	section	`ca22841`	`6edc6d1`	change	% change
esp32	all-clusters-app	c3devkit	.dram0.bss	60296	60296	0	0.0
			.dram0.data	16192	16192	0	0.0
			.flash.rodata	198888	199008	120	0.1
			.flash.text	872530	872638	108	0.0
			.iram0.text	57330	57330	0	0.0
		m5stack	.dram0.bss	62792	62792	0	0.0
			.dram0.data	32084	32084	0	0.0
			.flash.rodata	207312	207432	120	0.1
			.flash.text	902751	902831	80	0.0
			.iram0.text	125115	125115	0	0.0

boring-cyborg bot added app controller labels Oct 14, 2021

mrjerryjohns force-pushed the client-read-cluster-objects branch 3 times, most recently from 4890fbc to 09339d0 Compare October 14, 2021 18:41

mrjerryjohns requested review from yunhanw-google, erjiaqing, bzbarsky-apple, andy31415, msandstedt, vivien-apple and yufengwangca October 14, 2021 18:42

mrjerryjohns force-pushed the client-read-cluster-objects branch 2 times, most recently from 84a43b0 to d80720a Compare October 14, 2021 18:52

mrjerryjohns force-pushed the client-read-cluster-objects branch from d80720a to 0dca07b Compare October 14, 2021 19:25