ESP32: Enable extended discovery feature. #10523

sweetymhaiske · 2021-10-14T18:27:23Z

Problem

ESP32 did not have an extended discovery feature
Absence of commissionable node discovery using device type.

Change overview

Add CONFIG option to enable/disable extended discovery.
Add CONFIG option to enable/disable device type.

Testing

Using Chip-tool

If an extended discovery option is enabled, then the chip tool discovers the mdns service, even after commissioning is complete.

(python_env) sweety@sweety-ThinkPad-T490:~/Espressif/connectedhomeip$ ./out/chip-tool discover commissionables
[1634552950.055830][113504:113504] CHIP:CTL: Generating NOC
[1634552950.055918][113504:113504] CHIP:CTL: Generating ICAC
[1634552950.057402][113504:113504] CHIP:DL: AUDIT: ===== RANDOM NUMBER GENERATOR AUDIT START ====
[1634552950.057409][113504:113504] CHIP:DL: AUDIT: * Validate buf1 and buf2 are <<<different every run/boot!>>>
[1634552950.057411][113504:113504] CHIP:DL: AUDIT: * Validate r1 and r2 are <<<different every run/boot!>>>
[1634552950.057414][113504:113504] CHIP:DL: AUDIT: * buf1: 5C79AC9CA773EB517B703D7267BFB90A
[1634552950.057416][113504:113504] CHIP:DL: AUDIT: * buf2: E800AFBC39DF89879D94E929060F583F
[1634552950.057421][113504:113504] CHIP:DL: AUDIT: * r1: 0xE27CECCA r2: 0x957661E0
[1634552950.057422][113504:113504] CHIP:DL: AUDIT: ===== RANDOM NUMBER GENERATOR AUDIT END ====
[1634552950.057520][113504:113504] CHIP:DL: writing settings to file (/tmp/chip_counters.ini-2kOXpP)
[1634552950.057625][113504:113504] CHIP:DL: renamed tmp file to file (/tmp/chip_counters.ini)
[1634552950.057633][113504:113504] CHIP:DL: NVS set: chip-counters/reboot-count = 68 (0x44)
[1634552950.057727][113504:113504] CHIP:DL: Got Ethernet interface: enp0s31f6
[1634552950.057767][113504:113504] CHIP:DL: Found the primary Ethernet interface:enp0s31f6
[1634552950.057808][113504:113504] CHIP:DL: Got WiFi interface: wlp0s20f3
[1634552950.059216][113504:113504] CHIP:DL: Found the primary WiFi interface:wlp0s20f3
[1634552950.059226][113504:113504] CHIP:IN: UDP::Init bind&listen port=5541
[1634552950.059238][113504:113504] CHIP:IN: UDP::Init bound to port=5541
[1634552950.059242][113504:113504] CHIP:IN: UDP::Init bind&listen port=5541
[1634552950.059250][113504:113504] CHIP:IN: UDP::Init bound to port=5541
[1634552950.059253][113504:113504] CHIP:IN: TransportMgr initialized
[1634552950.059262][113504:113504] CHIP:DIS: Init fabric pairing table with server storage
[1634552950.059382][113504:113504] CHIP:DL: writing settings to file (/tmp/chip_counters.ini-oQKrQN)
[1634552950.064928][113504:113504] CHIP:DL: renamed tmp file to file (/tmp/chip_counters.ini)
[1634552950.064944][113504:113504] CHIP:DL: NVS set: chip-counters/GlobalMCTR = 68000 (0x109A0)
[1634552950.064970][113504:113504] CHIP:CTL: System State Initialized...
[1634552950.065103][113504:113504] CHIP:DL: MDNS failed to join multicast group on enp0s31f6 for address type IPv4: ../examples/chip-tool/third_party/connectedhomeip/src/inet/IPEndPointBasis.cpp:426: Inet Error 0x00000110: Address not found
[1634552950.065258][113504:113504] CHIP:ZCL: Using ZAP configuration...
[1634552950.065433][113504:113504] CHIP:DIS: Verifying the received credentials
[1634552950.065844][113504:113504] CHIP:DIS: Added new fabric at index: 1, Initialized: 1
[1634552950.065849][113504:113504] CHIP:DIS: Assigned compressed fabric ID: 0xCDF427F5D65BC128, node ID: 0x000000000001B669
[1634552950.065854][113504:113504] CHIP:CTL: Joined the fabric at index 1. Compressed fabric ID is: 0xCDF427F5D65BC128
[1634552950.065962][113504:113509] CHIP:DL: CHIP task running
[1634552950.066024][113504:113509] CHIP:DIS: Attempt to mDNS broadcast failed:  ../examples/chip-tool/third_party/connectedhomeip/src/inet/IPEndPointBasis.cpp:741: OS Error 0x02000065: Network is unreachable
[1634552950.066067][113504:113509] CHIP:DIS: mDNS broadcast success
[1634552950.066086][113504:113509] CHIP:DIS: mDNS broadcast success
[1634552950.066099][113504:113509] CHIP:DIS: mDNS broadcast success
[1634552950.066107][113504:113509] CHIP:DIS: Attempt to mDNS broadcast failed:  ../examples/chip-tool/third_party/connectedhomeip/src/inet/IPEndPointBasis.cpp:741: OS Error 0x02000065: Network is unreachable
[1634552950.539027][113504:113509] CHIP:DIS: Discovered Node: 
[1634552950.539079][113504:113509] CHIP:DIS: 	Host name:		240AC4C11B5C
[1634552950.539091][113504:113509] CHIP:DIS: 	Port:			5540
[1634552950.539102][113504:113509] CHIP:DIS: 	Long discriminator:	3840
[1634552950.539112][113504:113509] CHIP:DIS: 	Vendor ID:		9050
[1634552950.539122][113504:113509] CHIP:DIS: 	Product ID:		17729
[1634552950.539145][113504:113509] CHIP:DIS: 	Commissioning Mode	0
[1634552950.539158][113504:113509] CHIP:DIS: 	Device Type		0
[1634552950.539174][113504:113509] CHIP:DIS: 	Device Name		
[1634552950.539186][113504:113509] CHIP:DIS: 	Rotating Id		00007C5F6E176CD40F68685D100A1CF8A98B
[1634552950.539208][113504:113509] CHIP:DIS: 	Pairing Instruction	
[1634552950.539244][113504:113509] CHIP:DIS: 	Pairing Hint		0x21
[1634552950.539270][113504:113509] CHIP:DIS: 	Address 0:		fe80::260a:c4ff:fec1:1b5c
[1634552950.539294][113504:113509] CHIP:DIS: 	Address 1:		2409:4042:2d11:5839:260a:c4ff:fec1:1b5c
[1634552950.539314][113504:113509] CHIP:DIS: 	Address 2:		192.168.100.42

If extended discovery is disabled then device stops responding to mdns, after commissioning complete

(python_env) sweety@sweety-ThinkPad-T490:~/Espressif/connectedhomeip$ ./out/chip-tool discover commissionables
[1634555569.222943][124865:124865] CHIP:CTL: Generating NOC
[1634555569.223032][124865:124865] CHIP:CTL: Generating ICAC
[1634555569.224446][124865:124865] CHIP:DL: AUDIT: ===== RANDOM NUMBER GENERATOR AUDIT START ====
[1634555569.224452][124865:124865] CHIP:DL: AUDIT: * Validate buf1 and buf2 are <<<different every run/boot!>>>
[1634555569.224454][124865:124865] CHIP:DL: AUDIT: * Validate r1 and r2 are <<<different every run/boot!>>>
[1634555569.224457][124865:124865] CHIP:DL: AUDIT: * buf1: E61A4964E267D3C37B9011A769B94CC8
[1634555569.224459][124865:124865] CHIP:DL: AUDIT: * buf2: 896850578A67A7961BA1777CE6D66094
[1634555569.224464][124865:124865] CHIP:DL: AUDIT: * r1: 0xF8DDAD4C r2: 0x189B5660
[1634555569.224466][124865:124865] CHIP:DL: AUDIT: ===== RANDOM NUMBER GENERATOR AUDIT END ====
[1634555569.224564][124865:124865] CHIP:DL: writing settings to file (/tmp/chip_counters.ini-NzECnV)
[1634555569.224682][124865:124865] CHIP:DL: renamed tmp file to file (/tmp/chip_counters.ini)
[1634555569.224693][124865:124865] CHIP:DL: NVS set: chip-counters/reboot-count = 75 (0x4B)
[1634555569.224816][124865:124865] CHIP:DL: Got Ethernet interface: enp0s31f6
[1634555569.224874][124865:124865] CHIP:DL: Found the primary Ethernet interface:enp0s31f6
[1634555569.224926][124865:124865] CHIP:DL: Got WiFi interface: wlp0s20f3
[1634555569.226191][124865:124865] CHIP:DL: Found the primary WiFi interface:wlp0s20f3
[1634555569.226205][124865:124865] CHIP:IN: UDP::Init bind&listen port=5541
[1634555569.226219][124865:124865] CHIP:IN: UDP::Init bound to port=5541
[1634555569.226223][124865:124865] CHIP:IN: UDP::Init bind&listen port=5541
[1634555569.226232][124865:124865] CHIP:IN: UDP::Init bound to port=5541
[1634555569.226236][124865:124865] CHIP:IN: TransportMgr initialized
[1634555569.226248][124865:124865] CHIP:DIS: Init fabric pairing table with server storage
[1634555569.226420][124865:124865] CHIP:DL: writing settings to file (/tmp/chip_counters.ini-VUn3ET)
[1634555569.232007][124865:124865] CHIP:DL: renamed tmp file to file (/tmp/chip_counters.ini)
[1634555569.232043][124865:124865] CHIP:DL: NVS set: chip-counters/GlobalMCTR = 75000 (0x124F8)
[1634555569.232092][124865:124865] CHIP:CTL: System State Initialized...
[1634555569.232274][124865:124865] CHIP:DL: MDNS failed to join multicast group on enp0s31f6 for address type IPv4: ../examples/chip-tool/third_party/connectedhomeip/src/inet/IPEndPointBasis.cpp:426: Inet Error 0x00000110: Address not found
[1634555569.232434][124865:124865] CHIP:ZCL: Using ZAP configuration...
[1634555569.232628][124865:124865] CHIP:DIS: Verifying the received credentials
[1634555569.233056][124865:124865] CHIP:DIS: Added new fabric at index: 1, Initialized: 1
[1634555569.233061][124865:124865] CHIP:DIS: Assigned compressed fabric ID: 0xCDF427F5D65BC128, node ID: 0x000000000001B669
[1634555569.233064][124865:124865] CHIP:CTL: Joined the fabric at index 1. Compressed fabric ID is: 0xCDF427F5D65BC128
[1634555569.233197][124865:124870] CHIP:DL: CHIP task running
[1634555569.233273][124865:124870] CHIP:DIS: Attempt to mDNS broadcast failed:  ../examples/chip-tool/third_party/connectedhomeip/src/inet/IPEndPointBasis.cpp:741: OS Error 0x02000065: Network is unreachable
[1634555569.233353][124865:124870] CHIP:DIS: mDNS broadcast success
[1634555569.233390][124865:124870] CHIP:DIS: mDNS broadcast success
[1634555569.233411][124865:124870] CHIP:DIS: mDNS broadcast success
[1634555569.233420][124865:124870] CHIP:DIS: Attempt to mDNS broadcast failed:  ../examples/chip-tool/third_party/connectedhomeip/src/inet/IPEndPointBasis.cpp:741: OS Error 0x02000065: Network is unreachable
[1634555599.233443][124865:124865] CHIP:-: ../examples/chip-tool/commands/common/CHIPCommand.cpp:121: CHIP Error 0x00000032: Timeout at ../examples/chip-tool/commands/common/CHIPCommand.cpp:80
[1634555599.233497][124865:124865] CHIP:TOO: Run command failure: ../examples/chip-tool/commands/common/CHIPCommand.cpp:121: CHIP Error 0x00000032: Timeout
[1634555599.288401][124865:124865] CHIP:CTL: Shutting down the System State, this will teardown the CHIP Stack
[1634555599.288523][124865:124865] CHIP:DL: writing settings to file (/tmp/chip_counters.ini-Juo7CU)
[1634555599.288722][124865:124865] CHIP:DL: renamed tmp file to file (/tmp/chip_counters.ini)
[1634555599.288738][124865:124865] CHIP:DL: NVS set: chip-counters/total-operational-hours = 0 (0x0)
[1634555599.288743][124865:124865] CHIP:DL: Inet Layer shutdown
[1634555599.288817][124865:124865] CHIP:DL: BLE layer shutdown
[1634555599.288822][124865:124865] CHIP:DL: System Layer shutdown

Device type was set to 81 from menuconfig, and once the device gets an Ip then the device was discovered using avahi-browse.

sweety@sweety-ThinkPad-T490:~/Espressif/connectedhomeip$ avahi-browse _T81._sub._matterc._udp -r
+ wlp0s20f3 IPv6 8E0FFCE6A196796F                              _matterc._udp        local
+ wlp0s20f3 IPv6 7A819643E20ACD32                              _matterc._udp        local
+ wlp0s20f3 IPv6 BCEF0AFAE8B61B7E                              _matterc._udp        local
+ wlp0s20f3 IPv4 8E0FFCE6A196796F                              _matterc._udp        local
+ wlp0s20f3 IPv4 7A819643E20ACD32                              _matterc._udp        local
+ wlp0s20f3 IPv4 BCEF0AFAE8B61B7E                              _matterc._udp        local
+ wlp0s20f3 IPv4 C7F32F78F69C1EEA                              _matterc._udp        local
= wlp0s20f3 IPv6 7A819643E20ACD32                              _matterc._udp        local
   hostname = [240AC4C11B5C.local]
   address = [192.168.100.42]
   port = [5540]
   txt = ["PI=" "PH=33" "RI=00007C5F6E176CD40F68685D100A1CF8A98B" "CM=0" "D=3840" "T=1" "CRA=300" "CRI=5000" "DT=81" "VP=9050+17729"]
= wlp0s20f3 IPv4 7A819643E20ACD32                              _matterc._udp        local
   hostname = [240AC4C11B5C.local]
   address = [192.168.100.42]
   port = [5540]
   txt = ["PI=" "PH=33" "RI=00007C5F6E176CD40F68685D100A1CF8A98B" "CM=0" "D=3840" "T=1" "CRA=300" "CRI=5000" "DT=81" "VP=9050+17729"]

github-actions · 2021-10-14T18:58:11Z

PR #10523: Size comparison from 2377fea to c7344d8

20 builds

platform	target	config	section	`2377fea`	`c7344d8`
efr32	lighting-app	BRD4161A	.bss	118020	118020
			.data	1800	1800
			.text	781852	781852
	lock-app	BRD4161A	.bss	115892	115892
			.data	1760	1760
			.text	761124	761124
	window-app	BRD4161A	.bss	116212	116212
			.data	1764	1764
			.text	762032	762032
	lighting-app	BRD4161A+rpc	.bss	131348	131348
			.data	1852	1852
			.text	761592	761592
k32w	lock-app	k32w061+debug	.bss	69052	69052
			.data	1864	1864
			.text	514540	514540
	shell	k32w061+debug	.bss	55080	55080
			.data	672	672
			.text	356808	356808
	lighting-app	k32w061+se05x+release	.bss	78568	78568
			.data	1900	1900
			.text	613216	613216
linux	all-clusters-app	debug	.bss	52176	52176
			.data	978	978
			.data.rel.ro	58416	58416
			.dynamic	592	592
			.got	4072	4072
			.init	27	27
			.init_array	512	512
			.rodata	135029	135029
			.text	`1321298`	`1321298`
	chip-tool	debug	.bss	17584	17584
			.data	1584	1584
			.data.rel.ro	83312	83312
			.dynamic	592	592
			.got	4328	4328
			.init	27	27
			.init_array	424	424
			.rodata	173792	173792
			.text	2422117	2422117
	ota-provider-app	debug	.bss	37504	37504
			.data	752	752
			.data.rel.ro	23192	23192
			.dynamic	592	592
			.got	4008	4008
			.init	27	27
			.init_array	448	448
			.rodata	109080	109080
			.text	`1008946`	`1008946`
	ota-requestor-app	debug	.bss	205760	205760
			.data	752	752
			.data.rel.ro	24488	24488
			.dynamic	592	592
			.got	4136	4136
			.init	27	27
			.init_array	520	520
			.rodata	127152	127152
			.text	1128594	1128594
	shell	debug	.bss	16104	16104
			.data	242	242
			.data.rel.ro	35184	35184
			.dynamic	592	592
			.got	3504	3504
			.init	27	27
			.init_array	344	344
			.rodata	71343	71343
			.text	574322	574322
	tv-app	debug	.bss	216400	216400
			.data	2032	2032
			.data.rel.ro	55568	55568
			.dynamic	592	592
			.got	4408	4408
			.init	27	27
			.init_array	616	616
			.rodata	150792	150792
			.text	1466802	1466802
	bridge-app	debug+rpc	.bss	52912	52912
			.data	976	976
			.data.rel.ro	25512	25512
			.dynamic	592	592
			.got	3944	3944
			.init	27	27
			.init_array	408	408
			.rodata	109748	109748
			.text	1050565	1050565
	lighting-app	debug+rpc	.bss	42232	42232
			.data	1106	1106
			.data.rel.ro	52256	52256
			.dynamic	608	608
			.got	4104	4104
			.init	27	27
			.init_array	536	536
			.rodata	126897	126897
			.text	1251714	1251714
p6	lock-app	default	.bss	68224	68224
			.data	2416	2416
			.heap	962704	962704
			.text	1125776	1125776
qpg	lighting-app	qpg6100+debug	.bss	53536	53536
			.data	996	996
			.text	485728	485728
	lock-app	qpg6100+debug	.bss	52488	52488
			.data	952	952
			.text	461912	461912
	persistent-storage-app	qpg6100+debug	.bss	17778	17778
			.data	280	280
			.text	102704	102704
telink	lighting-app	tlsr9518adk80d	bss	70988	70988
			noinit	33216	33216
			text	457904	457904

2 builds

platform	target	config	section	`2377fea`	`c7344d8`
mbed	lighting-app	CY8CPROTO_062_4343W+release	.bss	172148	172148
			.data	5464	5464
			.heap	858832	858832
			.text	1219128	1219128
	lock-app	CY8CPROTO_062_4343W+release	.bss	171084	171084
			.data	5432	5432
			.heap	859928	859928
			.text	1197112	1197112

12 builds

platform	target	config	section	`2377fea`	`c7344d8`	change	% change
esp32	all-clusters-app	c3devkit	.dram0.bss	60264	60264	0	0.0
			.dram0.data	16232	16240	8	0.0
			.flash.rodata	198168	198496	328	0.2
			.flash.text	869458	869866	408	0.0
			.iram0.text	57330	57330	0	0.0
		m5stack	.dram0.bss	62768	62768	0	0.0
			.dram0.data	32084	32092	8	0.0
			.flash.rodata	206756	207076	320	0.2
			.flash.text	900459	900859	400	0.0
			.iram0.text	125115	125115	0	0.0
nrfconnect	lighting-app	nrf52840dk_nrf52840	bss	112320	112320	0	0.0
			rodata	97180	97180	0	0.0
			text	577324	577324	0	0.0
	lock-app	nrf52840dk_nrf52840	bss	111352	111352	0	0.0
			rodata	93676	93676	0	0.0
			text	558764	558764	0	0.0
	pigweed-app	nrf52840dk_nrf52840	bss	51772	51772	0	0.0
			rodata	45772	45772	0	0.0
			text	339392	339392	0	0.0
	pump-app	nrf52840dk_nrf52840	bss	111420	111420	0	0.0
			rodata	94660	94660	0	0.0
			text	561936	561936	0	0.0
	pump-controller-app	nrf52840dk_nrf52840	bss	111360	111360	0	0.0
			rodata	93736	93736	0	0.0
			text	558540	558540	0	0.0
	shell	nrf52840dk_nrf52840	bss	107320	107320	0	0.0
			rodata	71336	71336	0	0.0
			text	518964	518964	0	0.0
	lighting-app	nrf52840dk_nrf52840+rpc	bss	108560	108560	0	0.0
			rodata	87960	87960	0	0.0
			text	550528	550528	0	0.0
		nrf5340dk_nrf5340_cpuapp	bss	113692	113692	0	0.0
			rodata	92420	92420	0	0.0
			text	506780	506780	0	0.0
	lock-app	nrf5340dk_nrf5340_cpuapp	bss	112724	112724	0	0.0
			rodata	88936	88936	0	0.0
			text	488216	488216	0	0.0
	shell	nrf5340dk_nrf5340_cpuapp	bss	108304	108304	0	0.0
			rodata	65980	65980	0	0.0
			text	439564	439564	0	0.0

dhrishi · 2021-10-15T04:13:54Z

@sweetymhaiske Please add the output of the commands you have tested

config/esp32/components/chip/Kconfig

sweetymhaiske · 2021-10-18T11:44:27Z

@sweetymhaiske Please add the output of the commands you have tested

Added

github-actions · 2021-10-18T11:54:22Z

PR #10523: Size comparison from f0b6cbc to 5e7795e

8 builds

platform	target	config	section	`f0b6cbc`	`5e7795e`
k32w	lock-app	k32w061+debug	.bss	69052	69052
			.data	1864	1864
			.text	515176	515176
	shell	k32w061+debug	.bss	55080	55080
			.data	672	672
			.text	357172	357172
	lighting-app	k32w061+se05x+release	.bss	78560	78560
			.data	1900	1900
			.text	613800	613800
p6	lock-app	default	.bss	68216	68216
			.data	2416	2416
			.heap	962712	962712
			.text	`1126280`	`1126280`
qpg	lighting-app	qpg6100+debug	.bss	53536	53536
			.data	996	996
			.text	486104	486104
	lock-app	qpg6100+debug	.bss	52488	52488
			.data	952	952
			.text	462352	462352
	persistent-storage-app	qpg6100+debug	.bss	17778	17778
			.data	280	280
			.text	102704	102704
telink	lighting-app	tlsr9518adk80d	bss	70984	70984
			noinit	33216	33216
			text	458146	458146

12 builds

platform	target	config	section	`f0b6cbc`	`5e7795e`
efr32	lighting-app	BRD4161A	.bss	118020	118020
			.data	1800	1800
			.text	782420	782420
	lock-app	BRD4161A	.bss	115892	115892
			.data	1760	1760
			.text	761724	761724
	window-app	BRD4161A	.bss	116212	116212
			.data	1764	1764
			.text	762632	762632
	lighting-app	BRD4161A+rpc	.bss	131348	131348
			.data	1852	1852
			.text	762148	762148
linux	all-clusters-app	debug	.bss	52176	52176
			.data	978	978
			.data.rel.ro	58432	58432
			.dynamic	592	592
			.got	4072	4072
			.init	27	27
			.init_array	512	512
			.rodata	135989	135989
			.text	1326066	1326066
	chip-tool	debug	.bss	17552	17552
			.data	1584	1584
			.data.rel.ro	83312	83312
			.dynamic	592	592
			.got	4336	4336
			.init	27	27
			.init_array	416	416
			.rodata	174560	174560
			.text	2422885	2422885
	ota-provider-app	debug	.bss	37472	37472
			.data	752	752
			.data.rel.ro	23176	23176
			.dynamic	592	592
			.got	4008	4008
			.init	27	27
			.init_array	440	440
			.rodata	109848	109848
			.text	1009314	1009314
	ota-requestor-app	debug	.bss	205728	205728
			.data	752	752
			.data.rel.ro	24488	24488
			.dynamic	592	592
			.got	4136	4136
			.init	27	27
			.init_array	512	512
			.rodata	127896	127896
			.text	1128626	1128626
	shell	debug	.bss	16072	16072
			.data	242	242
			.data.rel.ro	35120	35120
			.dynamic	592	592
			.got	3496	3496
			.init	27	27
			.init_array	336	336
			.rodata	71855	71855
			.text	568898	568898
	tv-app	debug	.bss	216368	216368
			.data	2032	2032
			.data.rel.ro	55536	55536
			.dynamic	592	592
			.got	4400	4400
			.init	27	27
			.init_array	608	608
			.rodata	151464	151464
			.text	1462818	1462818
	bridge-app	debug+rpc	.bss	52880	52880
			.data	976	976
			.data.rel.ro	25496	25496
			.dynamic	592	592
			.got	3944	3944
			.init	27	27
			.init_array	400	400
			.rodata	110484	110484
			.text	`1050821`	`1050821`
	lighting-app	debug+rpc	.bss	42200	42200
			.data	1106	1106
			.data.rel.ro	52240	52240
			.dynamic	608	608
			.got	4104	4104
			.init	27	27
			.init_array	528	528
			.rodata	127665	127665
			.text	1252226	1252226

2 builds

platform	target	config	section	`f0b6cbc`	`5e7795e`
mbed	lighting-app	CY8CPROTO_062_4343W+release	.bss	172148	172148
			.data	5464	5464
			.heap	858832	858832
			.text	1219384	1219384
	lock-app	CY8CPROTO_062_4343W+release	.bss	171084	171084
			.data	5432	5432
			.heap	859928	859928
			.text	1197440	1197440

2 builds

platform	target	config	section	`f0b6cbc`	`5e7795e`
esp32	all-clusters-app	c3devkit	.dram0.bss	60280	60280
			.dram0.data	16192	16192
			.flash.rodata	198624	198624
			.flash.text	870142	870142
			.iram0.text	57330	57330
		m5stack	.dram0.bss	62776	62776
			.dram0.data	32084	32084
			.flash.rodata	207056	207056
			.flash.text	900507	900507
			.iram0.text	125115	125115

10 builds

platform	target	config	section	`f0b6cbc`	`5e7795e`
nrfconnect	lighting-app	nrf52840dk_nrf52840	bss	112316	112316
			rodata	97528	97528
			text	577428	577428
	lock-app	nrf52840dk_nrf52840	bss	111348	111348
			rodata	94028	94028
			text	558928	558928
	pigweed-app	nrf52840dk_nrf52840	bss	51772	51772
			rodata	45772	45772
			text	339392	339392
	pump-app	nrf52840dk_nrf52840	bss	111416	111416
			rodata	95008	95008
			text	562084	562084
	pump-controller-app	nrf52840dk_nrf52840	bss	111356	111356
			rodata	94088	94088
			text	558720	558720
	shell	nrf52840dk_nrf52840	bss	107316	107316
			rodata	71640	71640
			text	518908	518908
	lighting-app	nrf52840dk_nrf52840+rpc	bss	108556	108556
			rodata	88320	88320
			text	550632	550632
		nrf5340dk_nrf5340_cpuapp	bss	113688	113688
			rodata	92772	92772
			text	506888	506888
	lock-app	nrf5340dk_nrf5340_cpuapp	bss	112720	112720
			rodata	89284	89284
			text	488380	488380
	shell	nrf5340dk_nrf5340_cpuapp	bss	108300	108300
			rodata	66284	66284
			text	439504	439504

dhrishi · 2021-10-19T05:01:48Z

@sweetymhaiske Can you please rebase and check if the CI Darwin test passes

github-actions · 2021-10-19T07:19:23Z

PR #10523: Size comparison from 4c7f664 to 2a11592

8 builds (for k32w, p6, qpg, telink)

platform	target	config	section	`4c7f664`	`2a11592`
k32w	lock-app	k32w061+debug	.bss	69052	69052
			.data	1864	1864
			.text	515520	515520
	shell	k32w061+debug	.bss	55080	55080
			.data	672	672
			.text	357332	357332
	lighting-app	k32w061+se05x+release	.bss	78576	78576
			.data	1900	1900
			.text	614304	614304
p6	lock-app	default	.bss	68216	68216
			.data	2416	2416
			.heap	962712	962712
			.text	1126624	1126624
qpg	lighting-app	qpg6100+debug	.bss	53552	53552
			.data	996	996
			.text	486616	486616
	lock-app	qpg6100+debug	.bss	52488	52488
			.data	952	952
			.text	462684	462684
	persistent-storage-app	qpg6100+debug	.bss	17778	17778
			.data	280	280
			.text	102704	102704
telink	lighting-app	tlsr9518adk80d	bss	71000	71000
			noinit	33216	33216
			text	458304	458304

14 builds (for efr32, linux, mbed)

platform	target	config	section	`4c7f664`	`2a11592`
efr32	lighting-app	BRD4161A	.bss	118036	118036
			.data	1800	1800
			.text	782944	782944
	lock-app	BRD4161A	.bss	115892	115892
			.data	1760	1760
			.text	762088	762088
	window-app	BRD4161A	.bss	116212	116212
			.data	1764	1764
			.text	763012	763012
	lighting-app	BRD4161A+rpc	.bss	131364	131364
			.data	1852	1852
			.text	762700	762700
linux	all-clusters-app	debug	.bss	52176	52176
			.data	978	978
			.data.rel.ro	58688	58688
			.dynamic	592	592
			.got	4072	4072
			.init	27	27
			.init_array	512	512
			.rodata	136373	136373
			.text	1345186	1345186
	chip-tool	debug	.bss	17552	17552
			.data	1584	1584
			.data.rel.ro	86192	86192
			.dynamic	592	592
			.got	4344	4344
			.init	27	27
			.init_array	416	416
			.rodata	178892	178892
			.text	`2859941`	`2859941`
	ota-provider-app	debug	.bss	37472	37472
			.data	752	752
			.data.rel.ro	23176	23176
			.dynamic	592	592
			.got	4008	4008
			.init	27	27
			.init_array	440	440
			.rodata	110056	110056
			.text	1010594	1010594
	ota-requestor-app	debug	.bss	205728	205728
			.data	752	752
			.data.rel.ro	24488	24488
			.dynamic	592	592
			.got	4136	4136
			.init	27	27
			.init_array	512	512
			.rodata	128744	128744
			.text	1130130	1130130
	shell	debug	.bss	16072	16072
			.data	242	242
			.data.rel.ro	35120	35120
			.dynamic	592	592
			.got	3496	3496
			.init	27	27
			.init_array	336	336
			.rodata	71855	71855
			.text	569858	569858
	tv-app	debug	.bss	216400	216400
			.data	2032	2032
			.data.rel.ro	55872	55872
			.dynamic	592	592
			.got	4400	4400
			.init	27	27
			.init_array	608	608
			.rodata	152264	152264
			.text	1464706	1464706
	bridge-app	debug+rpc	.bss	52912	52912
			.data	976	976
			.data.rel.ro	25784	25784
			.dynamic	592	592
			.got	3944	3944
			.init	27	27
			.init_array	400	400
			.rodata	110644	110644
			.text	1052629	1052629
	lighting-app	debug+rpc	.bss	42232	42232
			.data	1106	1106
			.data.rel.ro	52496	52496
			.dynamic	608	608
			.got	4104	4104
			.init	27	27
			.init_array	528	528
			.rodata	127857	127857
			.text	1253906	1253906
mbed	lighting-app	CY8CPROTO_062_4343W+release	.bss	172164	172164
			.data	5464	5464
			.heap	858816	858816
			.text	1219944	1219944
	lock-app	CY8CPROTO_062_4343W+release	.bss	171084	171084
			.data	5432	5432
			.heap	859928	859928
			.text	1197840	1197840

2 builds (for esp32)

platform	target	config	section	`4c7f664`	`2a11592`	change
esp32	all-clusters-app	c3devkit	.dram0.bss	60296	60296	0
			.dram0.data	16192	16192	0
			.flash.rodata	199008	199008	0
			.flash.text	872638	872638	0
			.iram0.text	57330	57330	0
		m5stack	.dram0.bss	62792	62792	0
			.dram0.data	32084	32084	0
			.flash.rodata	207432	207432	0
			.flash.text	902739	902831	92
			.iram0.text	125115	125115	0

10 builds (for nrfconnect)

platform	target	config	section	`4c7f664`	`2a11592`
nrfconnect	lighting-app	nrf52840dk_nrf52840	bss	112332	112332
			rodata	97776	97776
			text	577652	577652
	lock-app	nrf52840dk_nrf52840	bss	111348	111348
			rodata	94112	94112
			text	559152	559152
	pigweed-app	nrf52840dk_nrf52840	bss	51772	51772
			rodata	45772	45772
			text	339392	339392
	pump-app	nrf52840dk_nrf52840	bss	111416	111416
			rodata	95092	95092
			text	562308	562308
	pump-controller-app	nrf52840dk_nrf52840	bss	111356	111356
			rodata	94172	94172
			text	558944	558944
	shell	nrf52840dk_nrf52840	bss	107316	107316
			rodata	71640	71640
			text	519032	519032
	lighting-app	nrf52840dk_nrf52840+rpc	bss	108572	108572
			rodata	88560	88560
			text	550856	550856
		nrf5340dk_nrf5340_cpuapp	bss	113704	113704
			rodata	93016	93016
			text	507116	507116
	lock-app	nrf5340dk_nrf5340_cpuapp	bss	112720	112720
			rodata	89372	89372
			text	488612	488612
	shell	nrf5340dk_nrf5340_cpuapp	bss	108300	108300
			rodata	66284	66284
			text	439632	439632

github-actions · 2021-10-19T13:01:45Z

PR #10523: Size comparison from 83dfc06 to e45e0e2

1 build (for telink)

platform	target	config	section	`83dfc06`	`e45e0e2`	change
telink	lighting-app	tlsr9518adk80d	bss	71000	71000	0
			noinit	33216	33216	0
			text	458304	458308	4

9 builds (for k32w, mbed, p6, qpg)

platform	target	config	section	`83dfc06`	`e45e0e2`	change
k32w	lock-app	k32w061+debug	.bss	69052	69052	0
			.data	1864	1864	0
			.text	515520	515520	0
	shell	k32w061+debug	.bss	55080	55080	0
			.data	672	672	0
			.text	357332	357332	0
	lighting-app	k32w061+se05x+release	.bss	78576	78576	0
			.data	1900	1900	0
			.text	614304	614304	0
mbed	lighting-app	CY8CPROTO_062_4343W+release	.bss	172164	172164	0
			.data	5464	5464	0
			.heap	858816	858816	0
			.text	1219944	1219944	0
	lock-app	CY8CPROTO_062_4343W+release	.bss	171084	171084	0
			.data	5432	5432	0
			.heap	859928	859928	0
			.text	1197840	1197840	0
p6	lock-app	default	.bss	68216	68216	0
			.data	2416	2416	0
			.heap	962712	962712	0
			.text	1126624	1126640	16
qpg	lighting-app	qpg6100+debug	.bss	53552	53552	0
			.data	996	996	0
			.text	486616	486616	0
	lock-app	qpg6100+debug	.bss	52488	52488	0
			.data	952	952	0
			.text	462684	462692	8
	persistent-storage-app	qpg6100+debug	.bss	17778	17778	0
			.data	280	280	0
			.text	102704	102704	0

12 builds (for efr32, linux)

platform	target	config	section	`83dfc06`	`e45e0e2`	change
efr32	lighting-app	BRD4161A	.bss	118036	118036	0
			.data	1800	1800	0
			.text	782944	782944	0
	lock-app	BRD4161A	.bss	115892	115892	0
			.data	1760	1760	0
			.text	762088	762104	16
	window-app	BRD4161A	.bss	116212	116212	0
			.data	1764	1764	0
			.text	763012	763012	0
	lighting-app	BRD4161A+rpc	.bss	131364	131364	0
			.data	1852	1852	0
			.text	762700	762700	0
linux	all-clusters-app	debug	.bss	52176	52176	0
			.data	978	978	0
			.data.rel.ro	58688	58688	0
			.dynamic	592	592	0
			.got	4072	4072	0
			.init	27	27	0
			.init_array	512	512	0
			.rodata	136373	136373	0
			.text	1345186	1345202	16
	chip-tool	debug	.bss	17552	17552	0
			.data	1584	1584	0
			.data.rel.ro	86192	86192	0
			.dynamic	592	592	0
			.got	4344	4344	0
			.init	27	27	0
			.init_array	416	416	0
			.rodata	178892	178892	0
			.text	`2859941`	`2859941`	0
	ota-provider-app	debug	.bss	37472	37472	0
			.data	752	752	0
			.data.rel.ro	23176	23176	0
			.dynamic	592	592	0
			.got	4008	4008	0
			.init	27	27	0
			.init_array	440	440	0
			.rodata	110056	110056	0
			.text	1010594	1010610	16
	ota-requestor-app	debug	.bss	205728	205728	0
			.data	752	752	0
			.data.rel.ro	24488	24488	0
			.dynamic	592	592	0
			.got	4136	4136	0
			.init	27	27	0
			.init_array	512	512	0
			.rodata	128744	128744	0
			.text	1130130	1130162	32
	shell	debug	.bss	16072	16072	0
			.data	242	242	0
			.data.rel.ro	35120	35120	0
			.dynamic	592	592	0
			.got	3496	3496	0
			.init	27	27	0
			.init_array	336	336	0
			.rodata	71855	71855	0
			.text	569858	569858	0
	tv-app	debug	.bss	216400	216400	0
			.data	2032	2032	0
			.data.rel.ro	55872	55872	0
			.dynamic	592	592	0
			.got	4400	4400	0
			.init	27	27	0
			.init_array	608	608	0
			.rodata	152264	152264	0
			.text	1464706	1464738	32
	bridge-app	debug+rpc	.bss	52912	52912	0
			.data	976	976	0
			.data.rel.ro	25784	25784	0
			.dynamic	592	592	0
			.got	3944	3944	0
			.init	27	27	0
			.init_array	400	400	0
			.rodata	110644	110644	0
			.text	1052629	1052645	16
	lighting-app	debug+rpc	.bss	42232	42232	0
			.data	1106	1106	0
			.data.rel.ro	52496	52496	0
			.dynamic	608	608	0
			.got	4104	4104	0
			.init	27	27	0
			.init_array	528	528	0
			.rodata	127857	127857	0
			.text	1253906	1253922	16

12 builds (for esp32, nrfconnect)

platform	target	config	section	`83dfc06`	`e45e0e2`	change
esp32	all-clusters-app	c3devkit	.dram0.bss	60296	60296	0
			.dram0.data	16192	16192	0
			.flash.rodata	199008	199008	0
			.flash.text	872638	872642	4
			.iram0.text	57330	57330	0
		m5stack	.dram0.bss	62792	62792	0
			.dram0.data	32084	32084	0
			.flash.rodata	207432	207432	0
			.flash.text	902739	902843	104
			.iram0.text	125115	125115	0
nrfconnect	lighting-app	nrf52840dk_nrf52840	bss	112332	112332	0
			rodata	97776	97776	0
			text	577652	577656	4
	lock-app	nrf52840dk_nrf52840	bss	111348	111348	0
			rodata	94112	94112	0
			text	559152	559156	4
	pigweed-app	nrf52840dk_nrf52840	bss	51772	51772	0
			rodata	45772	45772	0
			text	339392	339392	0
	pump-app	nrf52840dk_nrf52840	bss	111416	111416	0
			rodata	95092	95092	0
			text	562308	562312	4
	pump-controller-app	nrf52840dk_nrf52840	bss	111356	111356	0
			rodata	94172	94172	0
			text	558944	558948	4
	shell	nrf52840dk_nrf52840	bss	107316	107316	0
			rodata	71640	71640	0
			text	519032	519032	0
	lighting-app	nrf52840dk_nrf52840+rpc	bss	108572	108572	0
			rodata	88560	88560	0
			text	550856	550860	4
		nrf5340dk_nrf5340_cpuapp	bss	113704	113704	0
			rodata	93016	93016	0
			text	507116	507120	4
	lock-app	nrf5340dk_nrf5340_cpuapp	bss	112720	112720	0
			rodata	89372	89372	0
			text	488612	488616	4
	shell	nrf5340dk_nrf5340_cpuapp	bss	108300	108300	0
			rodata	66284	66284	0
			text	439632	439632	0

github-actions · 2021-10-19T15:14:33Z

PR #10523: Size comparison from bae3e7d to 5a584d7

5 builds (for p6, qpg, telink)

platform	target	config	section	`bae3e7d`	`5a584d7`	change
p6	lock-app	default	.bss	68216	68216	0
			.data	2416	2416	0
			.heap	962712	962712	0
			.text	1126624	1126640	16
qpg	lighting-app	qpg6100+debug	.bss	53552	53552	0
			.data	996	996	0
			.text	486616	486616	0
	lock-app	qpg6100+debug	.bss	52488	52488	0
			.data	952	952	0
			.text	462684	462692	8
	persistent-storage-app	qpg6100+debug	.bss	17778	17778	0
			.data	280	280	0
			.text	102704	102704	0
telink	lighting-app	tlsr9518adk80d	bss	71000	71000	0
			noinit	33216	33216	0
			text	458304	458308	4

15 builds (for efr32, k32w, linux)

platform	target	config	section	`bae3e7d`	`5a584d7`	change
efr32	lighting-app	BRD4161A	.bss	118036	118036	0
			.data	1800	1800	0
			.text	782944	782944	0
	lock-app	BRD4161A	.bss	115892	115892	0
			.data	1760	1760	0
			.text	762088	762104	16
	window-app	BRD4161A	.bss	116212	116212	0
			.data	1764	1764	0
			.text	763012	763012	0
	lighting-app	BRD4161A+rpc	.bss	131364	131364	0
			.data	1852	1852	0
			.text	762700	762700	0
k32w	lock-app	k32w061+debug	.bss	69052	69052	0
			.data	1864	1864	0
			.text	515520	515520	0
	shell	k32w061+debug	.bss	55080	55080	0
			.data	672	672	0
			.text	357332	357332	0
	lighting-app	k32w061+se05x+release	.bss	78576	78576	0
			.data	1900	1900	0
			.text	614304	614304	0
linux	all-clusters-app	debug	.bss	52176	52176	0
			.data	978	978	0
			.data.rel.ro	58688	58688	0
			.dynamic	592	592	0
			.got	4072	4072	0
			.init	27	27	0
			.init_array	512	512	0
			.rodata	136373	136373	0
			.text	1345186	1345202	16
	chip-tool	debug	.bss	17552	17552	0
			.data	1584	1584	0
			.data.rel.ro	86192	86192	0
			.dynamic	592	592	0
			.got	4344	4344	0
			.init	27	27	0
			.init_array	416	416	0
			.rodata	178892	178892	0
			.text	`2859941`	`2859941`	0
	ota-provider-app	debug	.bss	37472	37472	0
			.data	752	752	0
			.data.rel.ro	23176	23176	0
			.dynamic	592	592	0
			.got	4008	4008	0
			.init	27	27	0
			.init_array	440	440	0
			.rodata	110056	110056	0
			.text	1010594	1010610	16
	ota-requestor-app	debug	.bss	205728	205728	0
			.data	752	752	0
			.data.rel.ro	24488	24488	0
			.dynamic	592	592	0
			.got	4136	4136	0
			.init	27	27	0
			.init_array	512	512	0
			.rodata	128744	128744	0
			.text	1130130	1130162	32
	shell	debug	.bss	16072	16072	0
			.data	242	242	0
			.data.rel.ro	35120	35120	0
			.dynamic	592	592	0
			.got	3496	3496	0
			.init	27	27	0
			.init_array	336	336	0
			.rodata	71855	71855	0
			.text	569858	569858	0
	tv-app	debug	.bss	216400	216400	0
			.data	2032	2032	0
			.data.rel.ro	55872	55872	0
			.dynamic	592	592	0
			.got	4400	4400	0
			.init	27	27	0
			.init_array	608	608	0
			.rodata	152264	152264	0
			.text	1464706	1464738	32
	bridge-app	debug+rpc	.bss	52912	52912	0
			.data	976	976	0
			.data.rel.ro	25784	25784	0
			.dynamic	592	592	0
			.got	3944	3944	0
			.init	27	27	0
			.init_array	400	400	0
			.rodata	110644	110644	0
			.text	1052629	1052645	16
	lighting-app	debug+rpc	.bss	42232	42232	0
			.data	1106	1106	0
			.data.rel.ro	52496	52496	0
			.dynamic	608	608	0
			.got	4104	4104	0
			.init	27	27	0
			.init_array	528	528	0
			.rodata	127857	127857	0
			.text	1253906	1253922	16

2 builds (for mbed)

platform	target	config	section	`bae3e7d`	`5a584d7`
mbed	lighting-app	CY8CPROTO_062_4343W+release	.bss	172164	172164
			.data	5464	5464
			.heap	858816	858816
			.text	1219944	1219944
	lock-app	CY8CPROTO_062_4343W+release	.bss	171084	171084
			.data	5432	5432
			.heap	859928	859928
			.text	1197840	1197840

12 builds (for esp32, nrfconnect)

platform	target	config	section	`bae3e7d`	`5a584d7`	change
esp32	all-clusters-app	c3devkit	.dram0.bss	60296	60296	0
			.dram0.data	16192	16192	0
			.flash.rodata	199008	199008	0
			.flash.text	872638	872642	4
			.iram0.text	57330	57330	0
		m5stack	.dram0.bss	62792	62792	0
			.dram0.data	32084	32084	0
			.flash.rodata	207432	207432	0
			.flash.text	902831	902843	12
			.iram0.text	125115	125115	0
nrfconnect	lighting-app	nrf52840dk_nrf52840	bss	112332	112332	0
			rodata	97776	97776	0
			text	577652	577656	4
	lock-app	nrf52840dk_nrf52840	bss	111348	111348	0
			rodata	94112	94112	0
			text	559152	559156	4
	pigweed-app	nrf52840dk_nrf52840	bss	51772	51772	0
			rodata	45772	45772	0
			text	339392	339392	0
	pump-app	nrf52840dk_nrf52840	bss	111416	111416	0
			rodata	95092	95092	0
			text	562308	562312	4
	pump-controller-app	nrf52840dk_nrf52840	bss	111356	111356	0
			rodata	94172	94172	0
			text	558944	558948	4
	shell	nrf52840dk_nrf52840	bss	107316	107316	0
			rodata	71640	71640	0
			text	519032	519032	0
	lighting-app	nrf52840dk_nrf52840+rpc	bss	108572	108572	0
			rodata	88560	88560	0
			text	550856	550860	4
		nrf5340dk_nrf5340_cpuapp	bss	113704	113704	0
			rodata	93016	93016	0
			text	507116	507120	4
	lock-app	nrf5340dk_nrf5340_cpuapp	bss	112720	112720	0
			rodata	89372	89372	0
			text	488612	488616	4
	shell	nrf5340dk_nrf5340_cpuapp	bss	108300	108300	0
			rodata	66284	66284	0
			text	439632	439632	0

github-actions · 2021-10-19T16:17:11Z

Size increase report for "nrfconnect-example-build" from bae3e7d

File	Section	File	VM
chip-lock.elf	text	4	4
chip-lock.elf	device_handles	-4	-4

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.strtab,0,135
.symtab,0,32
text,4,4
.shstrtab,0,1
device_handles,-4,-4

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

github-actions · 2021-10-19T16:17:34Z

Size increase report for "esp32-example-build" from bae3e7d

File	Section	File	VM
chip-all-clusters-app.elf	.flash.text	4	4

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.strtab,0,135
.symtab,0,16
.flash.text,4,4
.shstrtab,0,-3
.debug_info,0,-4
.debug_loc,0,-4
[Unmapped],0,-4

dhrishi · 2021-10-20T03:33:14Z

@woody-apple Can we merge this?

boring-cyborg bot added config esp32 platform labels Oct 14, 2021

pullapprove bot requested review from wbschiller, woody-apple, yufengwangca and yunhanw-google October 14, 2021 18:28

pullapprove bot added the review - pending label Oct 14, 2021

bzbarsky-apple approved these changes Oct 15, 2021

View reviewed changes

dhrishi reviewed Oct 15, 2021

View reviewed changes

config/esp32/components/chip/Kconfig Outdated Show resolved Hide resolved

andy31415 approved these changes Oct 15, 2021

View reviewed changes

sweetymhaiske force-pushed the extended_discovery branch from c7344d8 to 5e7795e Compare October 18, 2021 11:32

dhrishi approved these changes Oct 18, 2021

View reviewed changes

sweetymhaiske force-pushed the extended_discovery branch from 5e7795e to 2a11592 Compare October 19, 2021 06:56

sweetymhaiske force-pushed the extended_discovery branch from 2a11592 to e45e0e2 Compare October 19, 2021 12:46

ESP32: Enable extended advertising feature.

5a584d7

sweetymhaiske force-pushed the extended_discovery branch from e45e0e2 to 5a584d7 Compare October 19, 2021 14:56

msandstedt approved these changes Oct 20, 2021

View reviewed changes

pullapprove bot added review - approved and removed review - pending labels Oct 20, 2021

andy31415 merged commit ff6f5b1 into project-chip:master Oct 20, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ESP32: Enable extended discovery feature. #10523

ESP32: Enable extended discovery feature. #10523

sweetymhaiske commented Oct 14, 2021 •

edited

Loading

github-actions bot commented Oct 14, 2021 •

edited

Loading

dhrishi commented Oct 15, 2021

sweetymhaiske commented Oct 18, 2021

github-actions bot commented Oct 18, 2021 •

edited

Loading

dhrishi commented Oct 19, 2021

github-actions bot commented Oct 19, 2021 •

edited

Loading

github-actions bot commented Oct 19, 2021 •

edited

Loading

github-actions bot commented Oct 19, 2021 •

edited

Loading

github-actions bot commented Oct 19, 2021

github-actions bot commented Oct 19, 2021

dhrishi commented Oct 20, 2021

ESP32: Enable extended discovery feature. #10523

ESP32: Enable extended discovery feature. #10523

Conversation

sweetymhaiske commented Oct 14, 2021 • edited Loading

Problem

Change overview

Testing

github-actions bot commented Oct 14, 2021 • edited Loading

dhrishi commented Oct 15, 2021

sweetymhaiske commented Oct 18, 2021

github-actions bot commented Oct 18, 2021 • edited Loading

dhrishi commented Oct 19, 2021

github-actions bot commented Oct 19, 2021 • edited Loading

github-actions bot commented Oct 19, 2021 • edited Loading

github-actions bot commented Oct 19, 2021 • edited Loading

github-actions bot commented Oct 19, 2021

github-actions bot commented Oct 19, 2021

dhrishi commented Oct 20, 2021

sweetymhaiske commented Oct 14, 2021 •

edited

Loading

github-actions bot commented Oct 14, 2021 •

edited

Loading

github-actions bot commented Oct 18, 2021 •

edited

Loading

github-actions bot commented Oct 19, 2021 •

edited

Loading

github-actions bot commented Oct 19, 2021 •

edited

Loading

github-actions bot commented Oct 19, 2021 •

edited

Loading