Use ObjectLifeCycle for InetLayer #10522

kpschoedel · 2021-10-14T18:19:46Z

Problem

Working toward #7715 Virtualize System and Inet interfaces

Change overview

Revise ObjectLifeCycle and use it for InetLayer

Testing

CI; no changes to visibile functionality intended.

#### Problem Working toward project-chip#7715 Virtualize System and Inet interfaces #### Change overview Revise ObjectLifeCycle and use it for InetLayer #### Testing CI; no changes to visibile functionality intended.

kpschoedel · 2021-10-14T18:19:55Z

Split off from PR #10450

github-actions · 2021-10-14T18:41:30Z

PR #10522: Size comparison from 2377fea to 25aeb72

8 builds

platform	target	config	section	`2377fea`	25aeb721	change
k32w	lock-app	k32w061+debug	.bss	69052	69052	0
			.data	1864	1864	0
			.text	514540	514572	32
	shell	k32w061+debug	.bss	55080	55080	0
			.data	672	672	0
			.text	356808	356840	32
	lighting-app	k32w061+se05x+release	.bss	78568	78568	0
			.data	1900	1900	0
			.text	613216	613248	32
p6	lock-app	default	.bss	68224	68224	0
			.data	2416	2416	0
			.heap	962704	962704	0
			.text	1125776	1125808	32
qpg	lighting-app	qpg6100+debug	.bss	53536	53536	0
			.data	996	996	0
			.text	485728	485760	32
	lock-app	qpg6100+debug	.bss	52488	52488	0
			.data	952	952	0
			.text	461912	461944	32
	persistent-storage-app	qpg6100+debug	.bss	17778	17778	0
			.data	280	280	0
			.text	102704	102728	24
telink	lighting-app	tlsr9518adk80d	bss	70988	70988	0
			noinit	33216	33216	0
			text	457904	457952	48

14 builds

platform	target	config	section	`2377fea`	25aeb721	change	% change
efr32	lighting-app	BRD4161A	.bss	118020	118020	0	0.0
			.data	1800	1800	0	0.0
			.text	781852	781868	16	0.0
	lock-app	BRD4161A	.bss	115892	115892	0	0.0
			.data	1760	1760	0	0.0
			.text	761124	761140	16	0.0
	window-app	BRD4161A	.bss	116212	116212	0	0.0
			.data	1764	1764	0	0.0
			.text	762032	762048	16	0.0
	lighting-app	BRD4161A+rpc	.bss	131348	131348	0	0.0
			.data	1852	1852	0	0.0
			.text	761592	761624	32	0.0
linux	all-clusters-app	debug	.bss	52176	52176	0	0.0
			.data	978	978	0	0.0
			.data.rel.ro	58416	58416	0	0.0
			.dynamic	592	592	0	0.0
			.got	4072	4072	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	135029	135029	0	0.0
			.text	`1321298`	`1321650`	352	0.0
	chip-tool	debug	.bss	17584	17584	0	0.0
			.data	1584	1584	0	0.0
			.data.rel.ro	83312	83312	0	0.0
			.dynamic	592	592	0	0.0
			.got	4328	4328	0	0.0
			.init	27	27	0	0.0
			.init_array	424	424	0	0.0
			.rodata	173792	173792	0	0.0
			.text	2422117	2422469	352	0.0
	ota-provider-app	debug	.bss	37504	37504	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	23192	23192	0	0.0
			.dynamic	592	592	0	0.0
			.got	4008	4008	0	0.0
			.init	27	27	0	0.0
			.init_array	448	448	0	0.0
			.rodata	109080	109080	0	0.0
			.text	`1008946`	`1009298`	352	0.0
	ota-requestor-app	debug	.bss	205760	205760	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	24488	24488	0	0.0
			.dynamic	592	592	0	0.0
			.got	4136	4136	0	0.0
			.init	27	27	0	0.0
			.init_array	520	520	0	0.0
			.rodata	127152	127152	0	0.0
			.text	1128594	1128946	352	0.0
	shell	debug	.bss	16104	16104	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	35184	35184	0	0.0
			.dynamic	592	592	0	0.0
			.got	3504	3504	0	0.0
			.init	27	27	0	0.0
			.init_array	344	344	0	0.0
			.rodata	71343	71343	0	0.0
			.text	574322	574674	352	0.1
	tv-app	debug	.bss	216400	216400	0	0.0
			.data	2032	2032	0	0.0
			.data.rel.ro	55568	55568	0	0.0
			.dynamic	592	592	0	0.0
			.got	4408	4408	0	0.0
			.init	27	27	0	0.0
			.init_array	616	616	0	0.0
			.rodata	150792	150792	0	0.0
			.text	1466802	1467154	352	0.0
	bridge-app	debug+rpc	.bss	52912	52912	0	0.0
			.data	976	976	0	0.0
			.data.rel.ro	25512	25512	0	0.0
			.dynamic	592	592	0	0.0
			.got	3944	3944	0	0.0
			.init	27	27	0	0.0
			.init_array	408	408	0	0.0
			.rodata	109748	109748	0	0.0
			.text	1050565	`1050917`	352	0.0
	lighting-app	debug+rpc	.bss	42232	42232	0	0.0
			.data	1106	1106	0	0.0
			.data.rel.ro	52256	52256	0	0.0
			.dynamic	608	608	0	0.0
			.got	4104	4104	0	0.0
			.init	27	27	0	0.0
			.init_array	536	536	0	0.0
			.rodata	126897	126897	0	0.0
			.text	1251714	`1252066`	352	0.0
mbed	lighting-app	CY8CPROTO_062_4343W+release	.bss	172148	172148	0	0.0
			.data	5464	5464	0	0.0
			.heap	858832	858832	0	0.0
			.text	1219128	1219128	0	0.0
	lock-app	CY8CPROTO_062_4343W+release	.bss	171084	171084	0	0.0
			.data	5432	5432	0	0.0
			.heap	859928	859928	0	0.0
			.text	1197112	1197112	0	0.0

2 builds

platform	target	config	section	`2377fea`	25aeb721	change
esp32	all-clusters-app	c3devkit	.dram0.bss	60264	60264	0
			.dram0.data	16232	16232	0
			.flash.rodata	198168	198168	0
			.flash.text	869458	869486	28
			.iram0.text	57330	57330	0
		m5stack	.dram0.bss	62768	62768	0
			.dram0.data	32084	32084	0
			.flash.rodata	206756	206756	0
			.flash.text	900459	900563	104
			.iram0.text	125115	125115	0

10 builds

platform	target	config	section	`2377fea`	25aeb721	change
nrfconnect	lighting-app	nrf52840dk_nrf52840	bss	112320	112320	0
			rodata	97180	97180	0
			text	577324	577344	20
	lock-app	nrf52840dk_nrf52840	bss	111352	111352	0
			rodata	93676	93676	0
			text	558764	558788	24
	pigweed-app	nrf52840dk_nrf52840	bss	51772	51772	0
			rodata	45772	45772	0
			text	339392	339392	0
	pump-app	nrf52840dk_nrf52840	bss	111420	111420	0
			rodata	94660	94660	0
			text	561936	561956	20
	pump-controller-app	nrf52840dk_nrf52840	bss	111360	111360	0
			rodata	93736	93736	0
			text	558540	558564	24
	shell	nrf52840dk_nrf52840	bss	107320	107320	0
			rodata	71336	71336	0
			text	518964	518988	24
	lighting-app	nrf52840dk_nrf52840+rpc	bss	108560	108560	0
			rodata	87960	87960	0
			text	550528	550548	20
		nrf5340dk_nrf5340_cpuapp	bss	113692	113692	0
			rodata	92420	92420	0
			text	506780	506804	24
	lock-app	nrf5340dk_nrf5340_cpuapp	bss	112724	112724	0
			rodata	88936	88936	0
			text	488216	488240	24
	shell	nrf5340dk_nrf5340_cpuapp	bss	108304	108304	0
			rodata	65980	65980	0
			text	439564	439588	24

github-actions · 2021-10-14T19:22:39Z

Size increase report for "esp32-example-build" from 2377fea

File	Section	File	VM
chip-all-clusters-app.elf	.flash.text	28	28

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_str,0,824
.debug_line,0,407
.debug_loc,0,134
.flash.text,28,28
.riscv.attributes,0,1
.debug_aranges,0,-24
[Unmapped],0,-28
.debug_frame,0,-44
.debug_ranges,0,-216
.debug_abbrev,0,-3990
.debug_info,0,-6752

src/lib/support/ObjectLifeCycle.h

github-actions · 2021-10-20T14:32:04Z

PR #10522: Size comparison from 1c0ded5 to 8ae9322

12 builds (for efr32, k32w, p6, qpg, telink)

platform	target	config	section	`1c0ded5`	`8ae9322`	change
efr32	lighting-app	BRD4161A	.bss	118036	118036	0
			.data	1800	1800	0
			.text	782896	782912	16
	lock-app	BRD4161A	.bss	115892	115892	0
			.data	1760	1760	0
			.text	762040	762072	32
	window-app	BRD4161A	.bss	116212	116212	0
			.data	1764	1764	0
			.text	762948	762980	32
	lighting-app	BRD4161A+rpc	.bss	131364	131364	0
			.data	1852	1852	0
			.text	762636	762652	16
k32w	lock-app	k32w061+debug	.bss	69052	69052	0
			.data	1864	1864	0
			.text	515536	515568	32
	shell	k32w061+debug	.bss	55080	55080	0
			.data	672	672	0
			.text	357332	357364	32
	lighting-app	k32w061+se05x+release	.bss	78576	78576	0
			.data	1900	1900	0
			.text	614304	614336	32
p6	lock-app	default	.bss	68216	68216	0
			.data	2416	2416	0
			.heap	962712	962712	0
			.text	1126560	1126592	32
qpg	lighting-app	qpg6100+debug	.bss	53552	53552	0
			.data	996	996	0
			.text	486624	486656	32
	lock-app	qpg6100+debug	.bss	52488	52488	0
			.data	952	952	0
			.text	462692	462724	32
	persistent-storage-app	qpg6100+debug	.bss	17778	17778	0
			.data	280	280	0
			.text	102704	102728	24
telink	lighting-app	tlsr9518adk80d	bss	71000	71000	0
			noinit	33216	33216	0
			text	458318	458366	48

10 builds (for linux, mbed)

platform	target	config	section	`1c0ded5`	`8ae9322`	change	% change
linux	all-clusters-app	debug	.bss	52176	52176	0	0.0
			.data	978	978	0	0.0
			.data.rel.ro	58688	58688	0	0.0
			.dynamic	592	592	0	0.0
			.got	4080	4080	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	136373	136373	0	0.0
			.text	`1343298`	`1343650`	352	0.0
	chip-tool	debug	.bss	17552	17552	0	0.0
			.data	1584	1584	0	0.0
			.data.rel.ro	86320	86320	0	0.0
			.dynamic	592	592	0	0.0
			.got	4344	4344	0	0.0
			.init	27	27	0	0.0
			.init_array	416	416	0	0.0
			.rodata	179564	179564	0	0.0
			.text	2887061	2887413	352	0.0
	ota-provider-app	debug	.bss	37472	37472	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	23176	23176	0	0.0
			.dynamic	592	592	0	0.0
			.got	4008	4008	0	0.0
			.init	27	27	0	0.0
			.init_array	440	440	0	0.0
			.rodata	110056	110056	0	0.0
			.text	1009682	1010034	352	0.0
	ota-requestor-app	debug	.bss	205728	205728	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	24488	24488	0	0.0
			.dynamic	592	592	0	0.0
			.got	4136	4136	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	128744	128744	0	0.0
			.text	`1129266`	1129618	352	0.0
	shell	debug	.bss	16072	16072	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	35120	35120	0	0.0
			.dynamic	592	592	0	0.0
			.got	3496	3496	0	0.0
			.init	27	27	0	0.0
			.init_array	336	336	0	0.0
			.rodata	71855	71855	0	0.0
			.text	569858	570210	352	0.1
	tv-app	debug	.bss	216400	216400	0	0.0
			.data	2032	2032	0	0.0
			.data.rel.ro	55872	55872	0	0.0
			.dynamic	592	592	0	0.0
			.got	4400	4400	0	0.0
			.init	27	27	0	0.0
			.init_array	608	608	0	0.0
			.rodata	152296	152296	0	0.0
			.text	`1461586`	1461938	352	0.0
	bridge-app	debug+rpc	.bss	52912	52912	0	0.0
			.data	976	976	0	0.0
			.data.rel.ro	25784	25784	0	0.0
			.dynamic	592	592	0	0.0
			.got	3944	3944	0	0.0
			.init	27	27	0	0.0
			.init_array	400	400	0	0.0
			.rodata	110644	110644	0	0.0
			.text	1051077	1051413	336	0.0
	lighting-app	debug+rpc	.bss	42232	42232	0	0.0
			.data	1106	1106	0	0.0
			.data.rel.ro	52496	52496	0	0.0
			.dynamic	608	608	0	0.0
			.got	4104	4104	0	0.0
			.init	27	27	0	0.0
			.init_array	528	528	0	0.0
			.rodata	127857	127857	0	0.0
			.text	`1251298`	1251650	352	0.0
mbed	lighting-app	CY8CPROTO_062_4343W+release	.bss	172164	172164	0	0.0
			.data	5464	5464	0	0.0
			.heap	858816	858816	0	0.0
			.text	1219944	1219944	0	0.0
	lock-app	CY8CPROTO_062_4343W+release	.bss	171084	171084	0	0.0
			.data	5432	5432	0	0.0
			.heap	859928	859928	0	0.0
			.text	1197840	1197840	0	0.0

github-actions · 2021-10-20T15:25:57Z

PR #10522: Size comparison from 1c0ded5 to 78535d5

16 builds (for k32w, linux, p6, qpg, telink)

platform	target	config	section	`1c0ded5`	`78535d5`	change	% change
k32w	lock-app	k32w061+debug	.bss	69052	69052	0	0.0
			.data	1864	1864	0	0.0
			.text	515536	515568	32	0.0
	shell	k32w061+debug	.bss	55080	55080	0	0.0
			.data	672	672	0	0.0
			.text	357332	357364	32	0.0
	lighting-app	k32w061+se05x+release	.bss	78576	78576	0	0.0
			.data	1900	1900	0	0.0
			.text	614304	614336	32	0.0
linux	all-clusters-app	debug	.bss	52176	52176	0	0.0
			.data	978	978	0	0.0
			.data.rel.ro	58688	58688	0	0.0
			.dynamic	592	592	0	0.0
			.got	4080	4080	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	136373	136373	0	0.0
			.text	`1343298`	1343698	400	0.0
	chip-tool	debug	.bss	17552	17552	0	0.0
			.data	1584	1584	0	0.0
			.data.rel.ro	86320	86320	0	0.0
			.dynamic	592	592	0	0.0
			.got	4344	4344	0	0.0
			.init	27	27	0	0.0
			.init_array	416	416	0	0.0
			.rodata	179564	179564	0	0.0
			.text	2887061	2887429	368	0.0
	ota-provider-app	debug	.bss	37472	37472	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	23176	23176	0	0.0
			.dynamic	592	592	0	0.0
			.got	4008	4008	0	0.0
			.init	27	27	0	0.0
			.init_array	440	440	0	0.0
			.rodata	110056	110024	-32	-0.0
			.text	1009682	1010098	416	0.0
	ota-requestor-app	debug	.bss	205728	205728	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	24488	24488	0	0.0
			.dynamic	592	592	0	0.0
			.got	4136	4136	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	128744	128744	0	0.0
			.text	`1129266`	1129682	416	0.0
	shell	debug	.bss	16072	16072	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	35120	35120	0	0.0
			.dynamic	592	592	0	0.0
			.got	3496	3496	0	0.0
			.init	27	27	0	0.0
			.init_array	336	336	0	0.0
			.rodata	71855	71823	-32	-0.0
			.text	569858	570226	368	0.1
	tv-app	debug	.bss	216400	216400	0	0.0
			.data	2032	2032	0	0.0
			.data.rel.ro	55872	55872	0	0.0
			.dynamic	592	592	0	0.0
			.got	4400	4400	0	0.0
			.init	27	27	0	0.0
			.init_array	608	608	0	0.0
			.rodata	152296	152264	-32	-0.0
			.text	`1461586`	1462002	416	0.0
	bridge-app	debug+rpc	.bss	52912	52912	0	0.0
			.data	976	976	0	0.0
			.data.rel.ro	25784	25784	0	0.0
			.dynamic	592	592	0	0.0
			.got	3944	3944	0	0.0
			.init	27	27	0	0.0
			.init_array	400	400	0	0.0
			.rodata	110644	110620	-24	-0.0
			.text	1051077	1051477	400	0.0
	lighting-app	debug+rpc	.bss	42232	42232	0	0.0
			.data	1106	1106	0	0.0
			.data.rel.ro	52496	52496	0	0.0
			.dynamic	608	608	0	0.0
			.got	4104	4104	0	0.0
			.init	27	27	0	0.0
			.init_array	528	528	0	0.0
			.rodata	127857	127825	-32	-0.0
			.text	`1251298`	1251698	400	0.0
p6	lock-app	default	.bss	68216	68216	0	0.0
			.data	2416	2416	0	0.0
			.heap	962712	962712	0	0.0
			.text	1126560	1126568	8	0.0
qpg	lighting-app	qpg6100+debug	.bss	53552	53552	0	0.0
			.data	996	996	0	0.0
			.text	486624	486656	32	0.0
	lock-app	qpg6100+debug	.bss	52488	52488	0	0.0
			.data	952	952	0	0.0
			.text	462692	462724	32	0.0
	persistent-storage-app	qpg6100+debug	.bss	17778	17778	0	0.0
			.data	280	280	0	0.0
			.text	102704	102728	24	0.0
telink	lighting-app	tlsr9518adk80d	bss	71000	71000	0	0.0
			noinit	33216	33216	0	0.0
			text	458318	458366	48	0.0

6 builds (for efr32, mbed)

platform	target	config	section	`1c0ded5`	`78535d5`	change
efr32	lighting-app	BRD4161A	.bss	118036	118036	0
			.data	1800	1800	0
			.text	782896	782912	16
	lock-app	BRD4161A	.bss	115892	115892	0
			.data	1760	1760	0
			.text	762040	762072	32
	window-app	BRD4161A	.bss	116212	116212	0
			.data	1764	1764	0
			.text	762948	762980	32
	lighting-app	BRD4161A+rpc	.bss	131364	131364	0
			.data	1852	1852	0
			.text	762636	762652	16
mbed	lighting-app	CY8CPROTO_062_4343W+release	.bss	172164	172164	0
			.data	5464	5464	0
			.heap	858816	858816	0
			.text	1219944	1220144	200
	lock-app	CY8CPROTO_062_4343W+release	.bss	171084	171084	0
			.data	5432	5432	0
			.heap	859928	859928	0
			.text	1197840	1198040	200

12 builds (for esp32, nrfconnect)

platform	target	config	section	`1c0ded5`	`78535d5`	change	% change
esp32	all-clusters-app	c3devkit	.dram0.bss	60296	60296	0	0.0
			.dram0.data	16192	16192	0	0.0
			.flash.rodata	199016	198992	-24	-0.0
			.flash.text	873178	873218	40	0.0
			.iram0.text	57330	57330	0	0.0
		m5stack	.dram0.bss	62792	62792	0	0.0
			.dram0.data	32084	32084	0	0.0
			.flash.rodata	207432	207736	304	0.1
			.flash.text	903219	904439	1220	0.1
			.iram0.text	125115	125115	0	0.0
nrfconnect	lighting-app	nrf52840dk_nrf52840	bss	112332	112332	0	0.0
			rodata	97776	97776	0	0.0
			text	577660	577680	20	0.0
	lock-app	nrf52840dk_nrf52840	bss	111348	111348	0	0.0
			rodata	94112	94112	0	0.0
			text	559160	559180	20	0.0
	pigweed-app	nrf52840dk_nrf52840	bss	51772	51772	0	0.0
			rodata	45772	45772	0	0.0
			text	339392	339392	0	0.0
	pump-app	nrf52840dk_nrf52840	bss	111416	111416	0	0.0
			rodata	95092	95092	0	0.0
			text	562312	562336	24	0.0
	pump-controller-app	nrf52840dk_nrf52840	bss	111356	111356	0	0.0
			rodata	94172	94172	0	0.0
			text	558952	558972	20	0.0
	shell	nrf52840dk_nrf52840	bss	107316	107316	0	0.0
			rodata	71640	71640	0	0.0
			text	519032	519052	20	0.0
	lighting-app	nrf52840dk_nrf52840+rpc	bss	108572	108572	0	0.0
			rodata	88560	88560	0	0.0
			text	550864	550884	20	0.0
		nrf5340dk_nrf5340_cpuapp	bss	113704	113704	0	0.0
			rodata	93016	93016	0	0.0
			text	507124	507148	24	0.0
	lock-app	nrf5340dk_nrf5340_cpuapp	bss	112720	112720	0	0.0
			rodata	89372	89372	0	0.0
			text	488616	488640	24	0.0
	shell	nrf5340dk_nrf5340_cpuapp	bss	108300	108300	0	0.0
			rodata	66284	66284	0	0.0
			text	439632	439656	24	0.0

…inet-3b-state

github-actions · 2021-10-20T22:07:13Z

PR #10522: Size comparison from 60b44c4 to d934c7d

1 build (for p6)

platform	target	config	section	`60b44c4`	`d934c7d`	change
p6	lock-app	default	.bss	68208	68208	0
			.data	2416	2416	0
			.heap	962720	962720	0
			.text	1126552	1126568	16

17 builds (for k32w, linux, mbed, qpg, telink)

platform	target	config	section	`60b44c4`	`d934c7d`	change	% change
k32w	lock-app	k32w061+debug	.bss	69052	69052	0	0.0
			.data	1864	1864	0	0.0
			.text	515536	515568	32	0.0
	shell	k32w061+debug	.bss	55080	55080	0	0.0
			.data	672	672	0	0.0
			.text	357332	357364	32	0.0
	lighting-app	k32w061+se05x+release	.bss	78576	78576	0	0.0
			.data	1900	1900	0	0.0
			.text	614320	614352	32	0.0
linux	all-clusters-app	debug	.bss	52144	52144	0	0.0
			.data	978	978	0	0.0
			.data.rel.ro	58688	58688	0	0.0
			.dynamic	592	592	0	0.0
			.got	4080	4080	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	136373	136373	0	0.0
			.text	1343330	1343714	384	0.0
	chip-tool	debug	.bss	17520	17520	0	0.0
			.data	1584	1584	0	0.0
			.data.rel.ro	89344	89344	0	0.0
			.dynamic	592	592	0	0.0
			.got	4344	4344	0	0.0
			.init	27	27	0	0.0
			.init_array	416	416	0	0.0
			.rodata	184604	184604	0	0.0
			.text	3428261	3428645	384	0.0
	ota-provider-app	debug	.bss	37440	37440	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	23176	23176	0	0.0
			.dynamic	592	592	0	0.0
			.got	4008	4008	0	0.0
			.init	27	27	0	0.0
			.init_array	440	440	0	0.0
			.rodata	110024	110024	0	0.0
			.text	1009730	1010114	384	0.0
	ota-requestor-app	debug	.bss	205696	205696	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	24488	24488	0	0.0
			.dynamic	592	592	0	0.0
			.got	4136	4136	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	128776	128776	0	0.0
			.text	1129522	1129906	384	0.0
	shell	debug	.bss	16072	16072	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	35120	35120	0	0.0
			.dynamic	592	592	0	0.0
			.got	3496	3496	0	0.0
			.init	27	27	0	0.0
			.init_array	336	336	0	0.0
			.rodata	71823	71823	0	0.0
			.text	569842	570226	384	0.1
	tv-app	debug	.bss	216368	216368	0	0.0
			.data	2032	2032	0	0.0
			.data.rel.ro	55872	55872	0	0.0
			.dynamic	592	592	0	0.0
			.got	4400	4400	0	0.0
			.init	27	27	0	0.0
			.init_array	608	608	0	0.0
			.rodata	152296	152296	0	0.0
			.text	1463186	1463570	384	0.0
	bridge-app	debug+rpc	.bss	52880	52880	0	0.0
			.data	976	976	0	0.0
			.data.rel.ro	25784	25784	0	0.0
			.dynamic	592	592	0	0.0
			.got	3944	3944	0	0.0
			.init	27	27	0	0.0
			.init_array	400	400	0	0.0
			.rodata	110620	110620	0	0.0
			.text	1051109	1051493	384	0.0
	lighting-app	debug+rpc	.bss	42200	42200	0	0.0
			.data	1106	1106	0	0.0
			.data.rel.ro	52496	52496	0	0.0
			.dynamic	608	608	0	0.0
			.got	4104	4104	0	0.0
			.init	27	27	0	0.0
			.init_array	528	528	0	0.0
			.rodata	127825	127825	0	0.0
			.text	1251346	1251714	368	0.0
mbed	lighting-app	CY8CPROTO_062_4343W+release	.bss	172092	172092	0	0.0
			.data	5464	5464	0	0.0
			.heap	858888	858888	0	0.0
			.text	1220144	1220144	0	0.0
	lock-app	CY8CPROTO_062_4343W+release	.bss	171012	171012	0	0.0
			.data	5432	5432	0	0.0
			.heap	860000	860000	0	0.0
			.text	1198040	1198040	0	0.0
qpg	lighting-app	qpg6100+debug	.bss	53552	53552	0	0.0
			.data	996	996	0	0.0
			.text	486624	486656	32	0.0
	lock-app	qpg6100+debug	.bss	52488	52488	0	0.0
			.data	952	952	0	0.0
			.text	462700	462732	32	0.0
	persistent-storage-app	qpg6100+debug	.bss	17778	17778	0	0.0
			.data	280	280	0	0.0
			.text	102704	102728	24	0.0
telink	lighting-app	tlsr9518adk80d	bss	70992	70992	0	0.0
			noinit	33216	33216	0	0.0
			text	458322	458370	48	0.0

4 builds (for efr32)

platform	target	config	section	`60b44c4`	`d934c7d`	change
efr32	lighting-app	BRD4161A	.bss	118028	118028	0
			.data	1800	1800	0
			.text	782896	782928	32
	lock-app	BRD4161A	.bss	115884	115884	0
			.data	1760	1760	0
			.text	762056	762072	16
	window-app	BRD4161A	.bss	116204	116204	0
			.data	1764	1764	0
			.text	762964	762980	16
	lighting-app	BRD4161A+rpc	.bss	131356	131356	0
			.data	1852	1852	0
			.text	762636	762668	32

2 builds (for esp32)

platform	target	config	section	`60b44c4`	`d934c7d`	change	% change
esp32	all-clusters-app	c3devkit	.dram0.bss	60288	60288	0	0.0
			.dram0.data	16192	16192	0	0.0
			.flash.rodata	198992	198992	0	0.0
			.flash.text	873190	873218	28	0.0
			.iram0.text	57330	57330	0	0.0
		m5stack	.dram0.bss	62792	62792	0	0.0
			.dram0.data	32084	32084	0	0.0
			.flash.rodata	207736	207736	0	0.0
			.flash.text	904435	904363	-72	-0.0
			.iram0.text	125115	125115	0	0.0

10 builds (for nrfconnect)

platform	target	config	section	`60b44c4`	`d934c7d`	change
nrfconnect	lighting-app	nrf52840dk_nrf52840	bss	112476	112476	0
			rodata	97776	97776	0
			text	577788	577812	24
	lock-app	nrf52840dk_nrf52840	bss	111540	111540	0
			rodata	94112	94112	0
			text	559276	559300	24
	pigweed-app	nrf52840dk_nrf52840	bss	51824	51824	0
			rodata	45772	45772	0
			text	339456	339456	0
	pump-app	nrf52840dk_nrf52840	bss	111612	111612	0
			rodata	95092	95092	0
			text	562432	562452	20
	pump-controller-app	nrf52840dk_nrf52840	bss	111552	111552	0
			rodata	94172	94172	0
			text	559068	559092	24
	shell	nrf52840dk_nrf52840	bss	107316	107316	0
			rodata	71640	71640	0
			text	519032	519052	20
	lighting-app	nrf52840dk_nrf52840+rpc	bss	108716	108716	0
			rodata	88560	88560	0
			text	550988	551012	24
		nrf5340dk_nrf5340_cpuapp	bss	113852	113852	0
			rodata	93016	93016	0
			text	507252	507276	24
	lock-app	nrf5340dk_nrf5340_cpuapp	bss	112916	112916	0
			rodata	89372	89372	0
			text	488736	488760	24
	shell	nrf5340dk_nrf5340_cpuapp	bss	108300	108300	0
			rodata	66284	66284	0
			text	439632	439656	24

github-actions · 2021-10-20T22:16:46Z

Size increase report for "gn_qpg-example-build" from 60b44c4

File	Section	File	VM
chip-qpg6100-lighting-example.out	.text	32	32

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-qpg6100-lighting-example.out and ./pull_artifact/chip-qpg6100-lighting-example.out:

sections,vmsize,filesize
.debug_str,0,963
.debug_loc,0,704
.debug_ranges,0,328
.debug_line,0,156
.strtab,0,56
.symtab,0,48
.text,32,32
.debug_frame,0,20
.debug_aranges,0,8
[Unmapped],0,-32
.debug_abbrev,0,-2003
.debug_info,0,-10152

Comparing ./master_artifact/chip-qpg6100-lighting-example.out.map and ./pull_artifact/chip-qpg6100-lighting-example.out.map:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: unknown file type for file './pull_artifact/chip-qpg6100-lighting-example.out.map'

github-actions · 2021-10-20T23:11:26Z

Size increase report for "nrfconnect-example-build" from 60b44c4

File	Section	File	VM
chip-lock.elf	text	24	24
chip-lock.elf	device_handles	-8	-8
chip-shell.elf	text	20	20
chip-shell.elf	device_handles	-4	-4

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_str,0,964
.debug_loc,0,928
.debug_ranges,0,344
.debug_line,0,88
.strtab,0,56
.symtab,0,48
.debug_frame,0,24
text,24,24
.debug_aranges,0,8
device_handles,-8,-8
.debug_abbrev,0,-1649
.debug_info,0,-5787

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.debug_loc,0,976
.debug_str,0,964
.debug_ranges,0,344
.debug_line,0,209
.strtab,0,56
.symtab,0,48
.debug_frame,0,24
text,20,20
.debug_aranges,0,8
device_handles,-4,-4
.debug_abbrev,0,-1187
.debug_info,0,-1986

andy31415 · 2021-10-21T13:18:53Z

@msandstedt could you take another look? I believe your comment was addressed.

msandstedt · 2021-10-21T15:52:29Z

@pullapprove pullapprove — reviewers-espressif team was not found on this repository

I think this likely means we need to merge top of master branch into this PR.

github-actions · 2021-10-21T17:13:07Z

PR #10522: Size comparison from b5ad57f to 7c3c9c5

5 builds (for p6, qpg, telink)

platform	target	config	section	`b5ad57f`	`7c3c9c5`	change
p6	lock-app	default	.bss	68208	68208	0
			.data	2416	2416	0
			.heap	962720	962720	0
			.text	1126664	1126680	16
qpg	lighting-app	qpg6100+debug	.bss	53552	53552	0
			.data	996	996	0
			.text	486716	486748	32
	lock-app	qpg6100+debug	.bss	52496	52496	0
			.data	952	952	0
			.text	462792	462824	32
	persistent-storage-app	qpg6100+debug	.bss	17778	17778	0
			.data	280	280	0
			.text	102732	102756	24
telink	lighting-app	tlsr9518adk80d	bss	70992	70992	0
			noinit	33216	33216	0
			text	458412	458460	48

17 builds (for efr32, k32w, linux, mbed)

platform	target	config	section	`b5ad57f`	`7c3c9c5`	change	% change
efr32	lighting-app	BRD4161A	.bss	118028	118028	0	0.0
			.data	1800	1800	0	0.0
			.text	783016	783048	32	0.0
	lock-app	BRD4161A	.bss	115884	115884	0	0.0
			.data	1760	1760	0	0.0
			.text	762152	762184	32	0.0
	window-app	BRD4161A	.bss	116204	116204	0	0.0
			.data	1764	1764	0	0.0
			.text	763068	763084	16	0.0
	lighting-app	BRD4161A+rpc	.bss	131356	131356	0	0.0
			.data	1852	1852	0	0.0
			.text	762732	762764	32	0.0
k32w	lock-app	k32w061+debug	.bss	69060	69060	0	0.0
			.data	1864	1864	0	0.0
			.text	515752	515784	32	0.0
	shell	k32w061+debug	.bss	55080	55080	0	0.0
			.data	672	672	0	0.0
			.text	357384	357416	32	0.0
	lighting-app	k32w061+se05x+release	.bss	78584	78584	0	0.0
			.data	1900	1900	0	0.0
			.text	614536	614568	32	0.0
linux	all-clusters-app	debug	.bss	52176	52176	0	0.0
			.data	978	978	0	0.0
			.data.rel.ro	59072	59072	0	0.0
			.dynamic	592	592	0	0.0
			.got	4080	4080	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	136245	136245	0	0.0
			.text	1341378	1341746	368	0.0
	chip-tool	debug	.bss	17520	17520	0	0.0
			.data	1584	1584	0	0.0
			.data.rel.ro	91920	91920	0	0.0
			.dynamic	592	592	0	0.0
			.got	4344	4344	0	0.0
			.init	27	27	0	0.0
			.init_array	416	416	0	0.0
			.rodata	184004	184004	0	0.0
			.text	3456773	3457157	384	0.0
	ota-provider-app	debug	.bss	37440	37440	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	23176	23176	0	0.0
			.dynamic	592	592	0	0.0
			.got	4008	4008	0	0.0
			.init	27	27	0	0.0
			.init_array	440	440	0	0.0
			.rodata	110024	110024	0	0.0
			.text	1009346	1009730	384	0.0
	ota-requestor-app	debug	.bss	205696	205696	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	24488	24488	0	0.0
			.dynamic	592	592	0	0.0
			.got	4136	4136	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	128776	128776	0	0.0
			.text	1129250	1129634	384	0.0
	shell	debug	.bss	16072	16072	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	35120	35120	0	0.0
			.dynamic	592	592	0	0.0
			.got	3496	3496	0	0.0
			.init	27	27	0	0.0
			.init_array	336	336	0	0.0
			.rodata	71823	71823	0	0.0
			.text	569778	570146	368	0.1
	tv-app	debug	.bss	216560	216560	0	0.0
			.data	2032	2032	0	0.0
			.data.rel.ro	56096	56096	0	0.0
			.dynamic	592	592	0	0.0
			.got	4400	4400	0	0.0
			.init	27	27	0	0.0
			.init_array	608	608	0	0.0
			.rodata	153384	153384	0	0.0
			.text	1443842	1444226	384	0.0
	bridge-app	debug+rpc	.bss	52880	52880	0	0.0
			.data	976	976	0	0.0
			.data.rel.ro	25784	25784	0	0.0
			.dynamic	592	592	0	0.0
			.got	3944	3944	0	0.0
			.init	27	27	0	0.0
			.init_array	400	400	0	0.0
			.rodata	110620	110620	0	0.0
			.text	1050485	`1050853`	368	0.0
	lighting-app	debug+rpc	.bss	42200	42200	0	0.0
			.data	1106	1106	0	0.0
			.data.rel.ro	52496	52496	0	0.0
			.dynamic	608	608	0	0.0
			.got	4104	4104	0	0.0
			.init	27	27	0	0.0
			.init_array	528	528	0	0.0
			.rodata	127793	127793	0	0.0
			.text	1250674	`1251058`	384	0.0
mbed	lighting-app	CY8CPROTO_062_4343W+release	.bss	172092	172092	0	0.0
			.data	5464	5464	0	0.0
			.heap	858888	858888	0	0.0
			.text	1220280	1220280	0	0.0
	lock-app	CY8CPROTO_062_4343W+release	.bss	171012	171012	0	0.0
			.data	5432	5432	0	0.0
			.heap	860000	860000	0	0.0
			.text	1198176	1198176	0	0.0

12 builds (for esp32, nrfconnect)

platform	target	config	section	`b5ad57f`	`7c3c9c5`	change
esp32	all-clusters-app	c3devkit	.dram0.bss	60288	60288	0
			.dram0.data	16200	16200	0
			.flash.rodata	199128	199128	0
			.flash.text	872942	872974	32
			.iram0.text	57330	57330	0
		m5stack	.dram0.bss	62792	62792	0
			.dram0.data	32084	32084	0
			.flash.rodata	207872	207872	0
			.flash.text	903923	903947	24
			.iram0.text	125115	125115	0
nrfconnect	lighting-app	nrf52840dk_nrf52840	bss	113172	113172	0
			rodata	97780	97780	0
			text	577864	577884	20
	lock-app	nrf52840dk_nrf52840	bss	112240	112240	0
			rodata	94116	94116	0
			text	559352	559372	20
	pigweed-app	nrf52840dk_nrf52840	bss	51824	51824	0
			rodata	45776	45776	0
			text	339456	339456	0
	pump-app	nrf52840dk_nrf52840	bss	112308	112308	0
			rodata	95096	95096	0
			text	562504	562528	24
	pump-controller-app	nrf52840dk_nrf52840	bss	112248	112248	0
			rodata	94176	94176	0
			text	559144	559164	20
	shell	nrf52840dk_nrf52840	bss	109068	109068	0
			rodata	71644	71644	0
			text	519084	519104	20
	lighting-app	nrf52840dk_nrf52840+rpc	bss	109416	109416	0
			rodata	88564	88564	0
			text	551064	551084	20
		nrf5340dk_nrf5340_cpuapp	bss	114548	114548	0
			rodata	93020	93020	0
			text	507332	507356	24
	lock-app	nrf5340dk_nrf5340_cpuapp	bss	113612	113612	0
			rodata	89376	89376	0
			text	488812	488836	24
	shell	nrf5340dk_nrf5340_cpuapp	bss	110052	110052	0
			rodata	66288	66288	0
			text	439696	439720	24

kpschoedel · 2021-10-21T17:22:00Z

~~Latest merge seems to have introduced a problem with TestPlatformMgr.~~

Use ObjectLifeCycle for InetLayer

25aeb72

#### Problem Working toward project-chip#7715 Virtualize System and Inet interfaces #### Change overview Revise ObjectLifeCycle and use it for InetLayer #### Testing CI; no changes to visibile functionality intended.

boring-cyborg bot added inet lib system labels Oct 14, 2021

pullapprove bot requested review from shana-apple, vivien-apple, wbschiller, woody-apple, yufengwangca and yunhanw-google October 14, 2021 18:20

pullapprove bot added the review - pending label Oct 14, 2021

andy31415 approved these changes Oct 15, 2021

View reviewed changes

Merge remote-tracking branch 'origin/master' into x7715-inet-3b-state

8ae9322

msandstedt reviewed Oct 20, 2021

View reviewed changes

src/lib/support/ObjectLifeCycle.h Show resolved Hide resolved

Damian-Nordic approved these changes Oct 20, 2021

View reviewed changes

change Reset() to expect Shutdown state

78535d5

Merge remote-tracking branch 'refs/remotes/origin/master' into x7715-…

d934c7d

…inet-3b-state

msandstedt approved these changes Oct 21, 2021

View reviewed changes

Merge remote-tracking branch 'origin/master' into x7715-inet-3b-state

7c3c9c5

pullapprove bot added review - approved and removed review - pending labels Oct 21, 2021

andy31415 merged commit a5bc5cd into project-chip:master Oct 21, 2021

kpschoedel deleted the x7715-inet-3b-state branch October 21, 2021 18:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use ObjectLifeCycle for InetLayer #10522

Use ObjectLifeCycle for InetLayer #10522

kpschoedel commented Oct 14, 2021

kpschoedel commented Oct 14, 2021

github-actions bot commented Oct 14, 2021 •

edited

Loading

github-actions bot commented Oct 14, 2021

github-actions bot commented Oct 20, 2021 •

edited

Loading

github-actions bot commented Oct 20, 2021 •

edited

Loading

github-actions bot commented Oct 20, 2021 •

edited

Loading

github-actions bot commented Oct 20, 2021

github-actions bot commented Oct 20, 2021

andy31415 commented Oct 21, 2021

msandstedt commented Oct 21, 2021

github-actions bot commented Oct 21, 2021 •

edited

Loading

kpschoedel commented Oct 21, 2021 •

edited

Loading

Use ObjectLifeCycle for InetLayer #10522

Use ObjectLifeCycle for InetLayer #10522

Conversation

kpschoedel commented Oct 14, 2021

Problem

Change overview

Testing

kpschoedel commented Oct 14, 2021

github-actions bot commented Oct 14, 2021 • edited Loading

github-actions bot commented Oct 14, 2021

github-actions bot commented Oct 20, 2021 • edited Loading

github-actions bot commented Oct 20, 2021 • edited Loading

github-actions bot commented Oct 20, 2021 • edited Loading

github-actions bot commented Oct 20, 2021

github-actions bot commented Oct 20, 2021

andy31415 commented Oct 21, 2021

msandstedt commented Oct 21, 2021

github-actions bot commented Oct 21, 2021 • edited Loading

kpschoedel commented Oct 21, 2021 • edited Loading

github-actions bot commented Oct 14, 2021 •

edited

Loading

github-actions bot commented Oct 20, 2021 •

edited

Loading

github-actions bot commented Oct 20, 2021 •

edited

Loading

github-actions bot commented Oct 20, 2021 •

edited

Loading

github-actions bot commented Oct 21, 2021 •

edited

Loading

kpschoedel commented Oct 21, 2021 •

edited

Loading