Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to enum class in src/inet #10504

Merged
merged 10 commits into from
Oct 21, 2021
Merged

Convert to enum class in src/inet #10504

merged 10 commits into from
Oct 21, 2021

Conversation

kpschoedel
Copy link
Contributor

Problem

Working toward #7715 Virtualize System and Inet interfaces

Change overview

  • Convert enum to enum class, and use BitFlags for flag sets.
    • DNSResolver::State
    • IPAddressType
    • IPv6MulticastFlag
    • IPEndPointBasis::State
    • TCPEndPoint::State
  • Rename kMaxIPAddressStringLength to IPAddress::kMaxStringLength

Testing

CI; no changes to functionality intended.

@kpschoedel
Convert to enum class in src/inet
819451b 
#### Problem

Working toward project-chip#7715 Virtualize System and Inet interfaces

#### Change overview

- Convert `enum` to `enum class`, and use `BitFlags` for flag sets.
  - DNSResolver::State
  - IPAddressType
  - IPv6MulticastFlag
  - IPEndPointBasis::State
  - TCPEndPoint::State
- Rename `kMaxIPAddressStringLength` to `IPAddress::kMaxStringLength`

#### Testing

CI; no changes to functionality intended.
@restyled-io restyled-io bot mentioned this pull request Oct 14, 2021
Closed
@kpschoedel
Copy link
Contributor Author

kpschoedel commented Oct 14, 2021 •
edited
Loading

Split off from PR #10450

Pending consensus, keeping the k prefix because it's much easier to remove by search & replace than to add.

@github-actions
Copy link

github-actions bot commented Oct 14, 2021 •
edited
Loading

PR #10504: Size comparison from 05f1974 to 819451b

1 build
platform target config section 05f1974 819451b change % change
telink lighting-app tlsr9518adk80d bss 70972 70972 0 0.0
noinit 33216 33216 0 0.0
text 457428 457454 26 0.0
19 builds
platform target config section 05f1974 819451b change % change
efr32 lighting-app BRD4161A .bss 118004 118004 0 0.0
.data 1800 1800 0 0.0
.text 780924 780924 0 0.0
lock-app BRD4161A .bss 115876 115876 0 0.0
.data 1760 1760 0 0.0
.text 760172 760172 0 0.0
window-app BRD4161A .bss 116196 116196 0 0.0
.data 1764 1764 0 0.0
.text 761088 761088 0 0.0
lighting-app BRD4161A+rpc .bss 131332 131332 0 0.0
.data 1852 1852 0 0.0
.text 760656 760656 0 0.0
k32w lock-app k32w061+debug .bss 69036 69036 0 0.0
.data 1864 1864 0 0.0
.text 514056 514056 0 0.0
shell k32w061+debug .bss 55080 55080 0 0.0
.data 672 672 0 0.0
.text 356808 356808 0 0.0
lighting-app k32w061+se05x+release .bss 78552 78552 0 0.0
.data 1900 1900 0 0.0
.text 612732 612732 0 0.0
linux all-clusters-app debug .bss 52144 52144 0 0.0
.data 978 978 0 0.0
.data.rel.ro 58352 58352 0 0.0
.dynamic 592 592 0 0.0
.got 4072 4072 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 134773 134773 0 0.0
.text 1318226 1318034 -192 -0.0
chip-tool debug .bss 17584 17584 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 77392 77392 0 0.0
.dynamic 592 592 0 0.0
.got 4328 4328 0 0.0
.init 27 27 0 0.0
.init_array 416 416 0 0.0
.rodata 173664 173664 0 0.0
.text 2425109 2425093 -16 -0.0
ota-provider-app debug .bss 37472 37472 0 0.0
.data 752 752 0 0.0
.data.rel.ro 23112 23112 0 0.0
.dynamic 592 592 0 0.0
.got 4008 4008 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 108824 108824 0 0.0
.text 1005410 1005202 -208 -0.0
ota-requestor-app debug .bss 205728 205728 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24408 24408 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 126864 126864 0 0.0
.text 1125042 1124834 -208 -0.0
shell debug .bss 16104 16104 0 0.0
.data 242 242 0 0.0
.data.rel.ro 35184 35184 0 0.0
.dynamic 592 592 0 0.0
.got 3504 3504 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 71343 71343 0 0.0
.text 574322 574258 -64 -0.0
tv-app debug .bss 216368 216368 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 55536 55536 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 150536 150536 0 0.0
.text 1463730 1463490 -240 -0.0
bridge-app debug+rpc .bss 52880 52880 0 0.0
.data 976 976 0 0.0
.data.rel.ro 25480 25480 0 0.0
.dynamic 592 592 0 0.0
.got 3944 3944 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 109492 109492 0 0.0
.text 1047493 1047301 -192 -0.0
lighting-app debug+rpc .bss 42200 42200 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 52192 52192 0 0.0
.dynamic 608 608 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 126641 126641 0 0.0
.text 1248642 1248450 -192 -0.0
p6 lock-app default .bss 68208 68208 0 0.0
.data 2416 2416 0 0.0
.heap 962720 962720 0 0.0
.text 1124840 1124840 0 0.0
qpg lighting-app qpg6100+debug .bss 53520 53520 0 0.0
.data 996 996 0 0.0
.text 485252 485252 0 0.0
lock-app qpg6100+debug .bss 52472 52472 0 0.0
.data 952 952 0 0.0
.text 461436 461436 0 0.0
persistent-storage-app qpg6100+debug .bss 17778 17778 0 0.0
.data 280 280 0 0.0
.text 102704 102704 0 0.0
2 builds
platform target config section 05f1974 819451b change % change
mbed lighting-app CY8CPROTO_062_4343W+release .bss 172132 172132 0 0.0
.data 5464 5464 0 0.0
.heap 858848 858848 0 0.0
.text 1218656 1218656 0 0.0
lock-app CY8CPROTO_062_4343W+release .bss 171068 171068 0 0.0
.data 5432 5432 0 0.0
.heap 859944 859944 0 0.0
.text 1196648 1196648 0 0.0
12 builds
platform target config section 05f1974 819451b change % change
esp32 all-clusters-app c3devkit .dram0.bss 60248 60216 -32 -0.1
.dram0.data 16232 16232 0 0.0
.flash.rodata 198144 198144 0 0.0
.flash.text 868962 869050 88 0.0
.iram0.text 57330 57330 0 0.0
m5stack .dram0.bss 62752 62720 -32 -0.1
.dram0.data 32084 32084 0 0.0
.flash.rodata 206732 206732 0 0.0
.flash.text 900095 900059 -36 -0.0
.iram0.text 125115 125115 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 bss 112304 112304 0 0.0
rodata 97160 97160 0 0.0
text 576856 576856 0 0.0
lock-app nrf52840dk_nrf52840 bss 111336 111336 0 0.0
rodata 93656 93656 0 0.0
text 558300 558300 0 0.0
pigweed-app nrf52840dk_nrf52840 bss 51772 51772 0 0.0
rodata 45772 45772 0 0.0
text 339392 339392 0 0.0
pump-app nrf52840dk_nrf52840 bss 111404 111404 0 0.0
rodata 94640 94640 0 0.0
text 561468 561468 0 0.0
pump-controller-app nrf52840dk_nrf52840 bss 111344 111344 0 0.0
rodata 93716 93716 0 0.0
text 558076 558076 0 0.0
shell nrf52840dk_nrf52840 bss 107320 107320 0 0.0
rodata 71336 71336 0 0.0
text 518964 518964 0 0.0
lighting-app nrf52840dk_nrf52840+rpc bss 108544 108544 0 0.0
rodata 87940 87940 0 0.0
text 550060 550060 0 0.0
nrf5340dk_nrf5340_cpuapp bss 113676 113676 0 0.0
rodata 92400 92400 0 0.0
text 506316 506316 0 0.0
lock-app nrf5340dk_nrf5340_cpuapp bss 112708 112708 0 0.0
rodata 88916 88916 0 0.0
text 487752 487752 0 0.0
shell nrf5340dk_nrf5340_cpuapp bss 108304 108304 0 0.0
rodata 65980 65980 0 0.0
text 439564 439564 0 0.0

@github-actions
Copy link

github-actions bot commented Oct 14, 2021 •
edited
Loading

PR #10504: Size comparison from 05f1974 to 5da011d

Increases above 1.0% from 5da011d to 05f1974:

platform target config section 05f1974 5da011d change % change
linux chip-tool debug .data.rel.ro 77392 83312 5920 7.6
.init_array 416 424 8 1.9
16 builds
platform target config section 05f1974 5da011d change % change
k32w lock-app k32w061+debug .bss 69036 69052 16 0.0
.data 1864 1864 0 0.0
.text 514056 514540 484 0.1
shell k32w061+debug .bss 55080 55080 0 0.0
.data 672 672 0 0.0
.text 356808 356808 0 0.0
lighting-app k32w061+se05x+release .bss 78552 78568 16 0.0
.data 1900 1900 0 0.0
.text 612732 613216 484 0.1
linux all-clusters-app debug .bss 52144 52176 32 0.1
.data 978 978 0 0.0
.data.rel.ro 58352 58416 64 0.1
.dynamic 592 592 0 0.0
.got 4072 4072 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 134773 135029 256 0.2
.text 1318226 1321106 2880 0.2
chip-tool debug .bss 17584 17584 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 77392 83312 5920 7.6
.dynamic 592 592 0 0.0
.got 4328 4328 0 0.0
.init 27 27 0 0.0
.init_array 416 424 8 1.9
.rodata 173664 173792 128 0.1
.text 2425109 2422117 -2992 -0.1
ota-provider-app debug .bss 37472 37504 32 0.1
.data 752 752 0 0.0
.data.rel.ro 23112 23192 80 0.3
.dynamic 592 592 0 0.0
.got 4008 4008 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 108824 109080 256 0.2
.text 1005410 1008754 3344 0.3
ota-requestor-app debug .bss 205728 205760 32 0.0
.data 752 752 0 0.0
.data.rel.ro 24408 24488 80 0.3
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 126864 127152 288 0.2
.text 1125042 1128386 3344 0.3
shell debug .bss 16104 16104 0 0.0
.data 242 242 0 0.0
.data.rel.ro 35184 35184 0 0.0
.dynamic 592 592 0 0.0
.got 3504 3504 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 71343 71343 0 0.0
.text 574322 574258 -64 -0.0
tv-app debug .bss 216368 216400 32 0.0
.data 2032 2032 0 0.0
.data.rel.ro 55536 55568 32 0.1
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 150536 150792 256 0.2
.text 1463730 1466562 2832 0.2
bridge-app debug+rpc .bss 52880 52912 32 0.1
.data 976 976 0 0.0
.data.rel.ro 25480 25512 32 0.1
.dynamic 592 592 0 0.0
.got 3944 3944 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 109492 109748 256 0.2
.text 1047493 1050373 2880 0.3
lighting-app debug+rpc .bss 42200 42232 32 0.1
.data 1106 1106 0 0.0
.data.rel.ro 52192 52256 64 0.1
.dynamic 608 608 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 126641 126897 256 0.2
.text 1248642 1251522 2880 0.2
p6 lock-app default .bss 68208 68224 16 0.0
.data 2416 2416 0 0.0
.heap 962720 962704 -16 -0.0
.text 1124840 1125792 952 0.1
qpg lighting-app qpg6100+debug .bss 53520 53536 16 0.0
.data 996 996 0 0.0
.text 485252 485728 476 0.1
lock-app qpg6100+debug .bss 52472 52488 16 0.0
.data 952 952 0 0.0
.text 461436 461912 476 0.1
persistent-storage-app qpg6100+debug .bss 17778 17778 0 0.0
.data 280 280 0 0.0
.text 102704 102704 0 0.0
telink lighting-app tlsr9518adk80d bss 70972 70988 16 0.0
noinit 33216 33216 0 0.0
text 457428 457930 502 0.1
6 builds
platform target config section 05f1974 5da011d change % change
efr32 lighting-app BRD4161A .bss 118004 118020 16 0.0
.data 1800 1800 0 0.0
.text 780924 781868 944 0.1
lock-app BRD4161A .bss 115876 115892 16 0.0
.data 1760 1760 0 0.0
.text 760172 761124 952 0.1
window-app BRD4161A .bss 116196 116212 16 0.0
.data 1764 1764 0 0.0
.text 761088 762032 944 0.1
lighting-app BRD4161A+rpc .bss 131332 131348 16 0.0
.data 1852 1852 0 0.0
.text 760656 761608 952 0.1
mbed lighting-app CY8CPROTO_062_4343W+release .bss 172132 172148 16 0.0
.data 5464 5464 0 0.0
.heap 858848 858832 -16 -0.0
.text 1218656 1219128 472 0.0
lock-app CY8CPROTO_062_4343W+release .bss 171068 171084 16 0.0
.data 5432 5432 0 0.0
.heap 859944 859928 -16 -0.0
.text 1196648 1197112 464 0.0
2 builds
platform target config section 05f1974 5da011d change % change
esp32 all-clusters-app c3devkit .dram0.bss 60248 60232 -16 -0.0
.dram0.data 16232 16232 0 0.0
.flash.rodata 198144 198168 24 0.0
.flash.text 868962 869542 580 0.1
.iram0.text 57330 57330 0 0.0
m5stack .dram0.bss 62752 62736 -16 -0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 206732 206756 24 0.0
.flash.text 900095 900615 520 0.1
.iram0.text 125115 125115 0 0.0
10 builds
platform target config section 05f1974 5da011d change % change
nrfconnect lighting-app nrf52840dk_nrf52840 bss 112304 112320 16 0.0
rodata 97160 97180 20 0.0
text 576856 577324 468 0.1
lock-app nrf52840dk_nrf52840 bss 111336 111352 16 0.0
rodata 93656 93676 20 0.0
text 558300 558764 464 0.1
pigweed-app nrf52840dk_nrf52840 bss 51772 51772 0 0.0
rodata 45772 45772 0 0.0
text 339392 339392 0 0.0
pump-app nrf52840dk_nrf52840 bss 111404 111420 16 0.0
rodata 94640 94660 20 0.0
text 561468 561936 468 0.1
pump-controller-app nrf52840dk_nrf52840 bss 111344 111360 16 0.0
rodata 93716 93736 20 0.0
text 558076 558540 464 0.1
shell nrf52840dk_nrf52840 bss 107320 107320 0 0.0
rodata 71336 71336 0 0.0
text 518964 518964 0 0.0
lighting-app nrf52840dk_nrf52840+rpc bss 108544 108560 16 0.0
rodata 87940 87960 20 0.0
text 550060 550528 468 0.1
nrf5340dk_nrf5340_cpuapp bss 113676 113692 16 0.0
rodata 92400 92420 20 0.0
text 506316 506780 464 0.1
lock-app nrf5340dk_nrf5340_cpuapp bss 112708 112724 16 0.0
rodata 88916 88936 20 0.0
text 487752 488216 464 0.1
shell nrf5340dk_nrf5340_cpuapp bss 108304 108304 0 0.0
rodata 65980 65980 0 0.0
text 439564 439564 0 0.0

@kpschoedel
Copy link
Contributor Author

Increases above 1.0% from 5da011d to 05f1974:

Unexpected; investigating.

@github-actions
Copy link

github-actions bot commented Oct 14, 2021 •
edited
Loading

PR #10504: Size comparison from 05f1974 to 1fa1b6f

Increases above 1.0% from 1fa1b6f to 05f1974:

platform target config section 05f1974 1fa1b6f change % change
linux chip-tool debug .data.rel.ro 77392 83312 5920 7.6
.init_array 416 424 8 1.9
ota-provider-app debug .rodata 108824 109960 1136 1.0
shell debug .rodata 71343 72239 896 1.3
bridge-app debug+rpc .rodata 109492 110644 1152 1.1
22 builds
platform target config section 05f1974 1fa1b6f change % change
efr32 lighting-app BRD4161A .bss 118004 118020 16 0.0
.data 1800 1800 0 0.0
.text 780924 782636 1712 0.2
lock-app BRD4161A .bss 115876 115892 16 0.0
.data 1760 1760 0 0.0
.text 760172 761908 1736 0.2
window-app BRD4161A .bss 116196 116212 16 0.0
.data 1764 1764 0 0.0
.text 761088 762800 1712 0.2
lighting-app BRD4161A+rpc .bss 131332 131348 16 0.0
.data 1852 1852 0 0.0
.text 760656 762380 1724 0.2
k32w lock-app k32w061+debug .bss 69036 69052 16 0.0
.data 1864 1864 0 0.0
.text 514056 515268 1212 0.2
shell k32w061+debug .bss 55080 55080 0 0.0
.data 672 672 0 0.0
.text 356808 357520 712 0.2
lighting-app k32w061+se05x+release .bss 78552 78568 16 0.0
.data 1900 1900 0 0.0
.text 612732 613944 1212 0.2
linux all-clusters-app debug .bss 52144 52176 32 0.1
.data 978 978 0 0.0
.data.rel.ro 58352 58416 64 0.1
.dynamic 592 592 0 0.0
.got 4072 4072 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 134773 135893 1120 0.8
.text 1318226 1322146 3920 0.3
chip-tool debug .bss 17584 17584 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 77392 83312 5920 7.6
.dynamic 592 592 0 0.0
.got 4328 4328 0 0.0
.init 27 27 0 0.0
.init_array 416 424 8 1.9
.rodata 173664 174656 992 0.6
.text 2425109 2423141 -1968 -0.1
ota-provider-app debug .bss 37472 37504 32 0.1
.data 752 752 0 0.0
.data.rel.ro 23112 23192 80 0.3
.dynamic 592 592 0 0.0
.got 4008 4008 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 108824 109960 1136 1.0
.text 1005410 1009794 4384 0.4
ota-requestor-app debug .bss 205728 205760 32 0.0
.data 752 752 0 0.0
.data.rel.ro 24408 24488 80 0.3
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 126864 128032 1168 0.9
.text 1125042 1129410 4368 0.4
shell debug .bss 16104 16104 0 0.0
.data 242 242 0 0.0
.data.rel.ro 35184 35184 0 0.0
.dynamic 592 592 0 0.0
.got 3504 3504 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 71343 72239 896 1.3
.text 574322 575298 976 0.2
tv-app debug .bss 216368 216400 32 0.0
.data 2032 2032 0 0.0
.data.rel.ro 55536 55568 32 0.1
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 150536 151656 1120 0.7
.text 1463730 1467602 3872 0.3
bridge-app debug+rpc .bss 52880 52912 32 0.1
.data 976 976 0 0.0
.data.rel.ro 25480 25512 32 0.1
.dynamic 592 592 0 0.0
.got 3944 3944 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 109492 110644 1152 1.1
.text 1047493 1051413 3920 0.4
lighting-app debug+rpc .bss 42200 42232 32 0.1
.data 1106 1106 0 0.0
.data.rel.ro 52192 52256 64 0.1
.dynamic 608 608 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 126641 127761 1120 0.9
.text 1248642 1252562 3920 0.3
mbed lighting-app CY8CPROTO_062_4343W+release .bss 172132 172148 16 0.0
.data 5464 5464 0 0.0
.heap 858848 858832 -16 -0.0
.text 1218656 1219840 1184 0.1
lock-app CY8CPROTO_062_4343W+release .bss 171068 171084 16 0.0
.data 5432 5432 0 0.0
.heap 859944 859928 -16 -0.0
.text 1196648 1197824 1176 0.1
p6 lock-app default .bss 68208 68224 16 0.0
.data 2416 2416 0 0.0
.heap 962720 962704 -16 -0.0
.text 1124840 1126560 1720 0.2
qpg lighting-app qpg6100+debug .bss 53520 53536 16 0.0
.data 996 996 0 0.0
.text 485252 486272 1020 0.2
lock-app qpg6100+debug .bss 52472 52488 16 0.0
.data 952 952 0 0.0
.text 461436 462464 1028 0.2
persistent-storage-app qpg6100+debug .bss 17778 17778 0 0.0
.data 280 280 0 0.0
.text 102704 102704 0 0.0
telink lighting-app tlsr9518adk80d bss 70972 70988 16 0.0
noinit 33216 33216 0 0.0
text 457428 458220 792 0.2
12 builds
platform target config section 05f1974 1fa1b6f change % change
esp32 all-clusters-app c3devkit .dram0.bss 60248 60232 -16 -0.0
.dram0.data 16232 16232 0 0.0
.flash.rodata 198144 198632 488 0.2
.flash.text 868962 869846 884 0.1
.iram0.text 57330 57330 0 0.0
m5stack .dram0.bss 62752 62736 -16 -0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 206732 207212 480 0.2
.flash.text 900095 900835 740 0.1
.iram0.text 125115 125115 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 bss 112304 112320 16 0.0
rodata 97160 97632 472 0.5
text 576856 577592 736 0.1
lock-app nrf52840dk_nrf52840 bss 111336 111352 16 0.0
rodata 93656 94128 472 0.5
text 558300 559032 732 0.1
pigweed-app nrf52840dk_nrf52840 bss 51772 51772 0 0.0
rodata 45772 45772 0 0.0
text 339392 339392 0 0.0
pump-app nrf52840dk_nrf52840 bss 111404 111420 16 0.0
rodata 94640 95112 472 0.5
text 561468 562204 736 0.1
pump-controller-app nrf52840dk_nrf52840 bss 111344 111360 16 0.0
rodata 93716 94188 472 0.5
text 558076 558808 732 0.1
shell nrf52840dk_nrf52840 bss 107320 107320 0 0.0
rodata 71336 71788 452 0.6
text 518964 519232 268 0.1
lighting-app nrf52840dk_nrf52840+rpc bss 108544 108560 16 0.0
rodata 87940 88416 476 0.5
text 550060 550796 736 0.1
nrf5340dk_nrf5340_cpuapp bss 113676 113692 16 0.0
rodata 92400 92872 472 0.5
text 506316 507048 732 0.1
lock-app nrf5340dk_nrf5340_cpuapp bss 112708 112724 16 0.0
rodata 88916 89388 472 0.5
text 487752 488484 732 0.2
shell nrf5340dk_nrf5340_cpuapp bss 108304 108304 0 0.0
rodata 65980 66432 452 0.7
text 439564 439832 268 0.1

bzbarsky-apple
bzbarsky-apple approved these changes Oct 15, 2021
View reviewed changes
src/inet/DNSResolver.h Outdated Show resolved Hide resolved
src/inet/IPAddress.h Outdated Show resolved Hide resolved
@boring-cyborg boring-cyborg bot added the lib label Oct 20, 2021
@github-actions
Copy link

github-actions bot commented Oct 20, 2021 •
edited
Loading

PR #10504: Size comparison from 1c0ded5 to e024cd8

1 build (for telink)
platform target config section 1c0ded5 e024cd8 change % change
telink lighting-app tlsr9518adk80d bss 71000 71000 0 0.0
noinit 33216 33216 0 0.0
text 458318 458344 26 0.0
10 builds (for linux, mbed)
platform target config section 1c0ded5 e024cd8 change % change
linux all-clusters-app debug .bss 52176 52176 0 0.0
.data 978 978 0 0.0
.data.rel.ro 58688 58688 0 0.0
.dynamic 592 592 0 0.0
.got 4080 4080 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 136373 136373 0 0.0
.text 1343298 1343090 -208 -0.0
chip-tool debug .bss 17552 17552 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 86320 86320 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 416 416 0 0.0
.rodata 179564 179564 0 0.0
.text 2887061 2887045 -16 -0.0
ota-provider-app debug .bss 37472 37472 0 0.0
.data 752 752 0 0.0
.data.rel.ro 23176 23176 0 0.0
.dynamic 592 592 0 0.0
.got 4008 4008 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110056 110056 0 0.0
.text 1009682 1009490 -192 -0.0
ota-requestor-app debug .bss 205728 205728 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24488 24488 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 128744 128744 0 0.0
.text 1129266 1129058 -208 -0.0
shell debug .bss 16072 16072 0 0.0
.data 242 242 0 0.0
.data.rel.ro 35120 35120 0 0.0
.dynamic 592 592 0 0.0
.got 3496 3496 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 71855 71855 0 0.0
.text 569858 569794 -64 -0.0
tv-app debug .bss 216400 216400 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 55872 55872 0 0.0
.dynamic 592 592 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 152296 152296 0 0.0
.text 1461586 1461346 -240 -0.0
bridge-app debug+rpc .bss 52912 52912 0 0.0
.data 976 976 0 0.0
.data.rel.ro 25784 25784 0 0.0
.dynamic 592 592 0 0.0
.got 3944 3944 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 110644 110644 0 0.0
.text 1051077 1050869 -208 -0.0
lighting-app debug+rpc .bss 42232 42232 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 52496 52496 0 0.0
.dynamic 608 608 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 127857 127857 0 0.0
.text 1251298 1251106 -192 -0.0
mbed lighting-app CY8CPROTO_062_4343W+release .bss 172164 172164 0 0.0
.data 5464 5464 0 0.0
.heap 858816 858816 0 0.0
.text 1219944 1220168 224 0.0
lock-app CY8CPROTO_062_4343W+release .bss 171084 171084 0 0.0
.data 5432 5432 0 0.0
.heap 859928 859928 0 0.0
.text 1197840 1198064 224 0.0

@github-actions
Copy link

github-actions bot commented Oct 20, 2021 •
edited
Loading

PR #10504: Size comparison from 7c7e5c7 to 49e69b5

8 builds (for k32w, p6, qpg, telink)
platform target config section 7c7e5c7 49e69b5 change % change
k32w lock-app k32w061+debug .bss 69052 69052 0 0.0
.data 1864 1864 0 0.0
.text 515536 515536 0 0.0
shell k32w061+debug .bss 55080 55080 0 0.0
.data 672 672 0 0.0
.text 357332 357332 0 0.0
lighting-app k32w061+se05x+release .bss 78576 78576 0 0.0
.data 1900 1900 0 0.0
.text 614304 614304 0 0.0
p6 lock-app default .bss 68216 68216 0 0.0
.data 2416 2416 0 0.0
.heap 962712 962712 0 0.0
.text 1126552 1126552 0 0.0
qpg lighting-app qpg6100+debug .bss 53552 53552 0 0.0
.data 996 996 0 0.0
.text 486624 486624 0 0.0
lock-app qpg6100+debug .bss 52488 52488 0 0.0
.data 952 952 0 0.0
.text 462692 462692 0 0.0
persistent-storage-app qpg6100+debug .bss 17778 17778 0 0.0
.data 280 280 0 0.0
.text 102704 102704 0 0.0
telink lighting-app tlsr9518adk80d bss 71000 71000 0 0.0
noinit 33216 33216 0 0.0
text 458318 458344 26 0.0
12 builds (for efr32, linux)
platform target config section 7c7e5c7 49e69b5 change % change
efr32 lighting-app BRD4161A .bss 118036 118036 0 0.0
.data 1800 1800 0 0.0
.text 782896 782912 16 0.0
lock-app BRD4161A .bss 115892 115892 0 0.0
.data 1760 1760 0 0.0
.text 762040 762056 16 0.0
window-app BRD4161A .bss 116212 116212 0 0.0
.data 1764 1764 0 0.0
.text 762948 762964 16 0.0
lighting-app BRD4161A+rpc .bss 131364 131364 0 0.0
.data 1852 1852 0 0.0
.text 762636 762636 0 0.0
linux all-clusters-app debug .bss 52176 52176 0 0.0
.data 978 978 0 0.0
.data.rel.ro 58688 58688 0 0.0
.dynamic 592 592 0 0.0
.got 4080 4080 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 136373 136373 0 0.0
.text 1343314 1343122 -192 -0.0
chip-tool debug .bss 17552 17552 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 86320 86320 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 416 416 0 0.0
.rodata 179564 179564 0 0.0
.text 2887045 2887045 0 0.0
ota-provider-app debug .bss 37472 37472 0 0.0
.data 752 752 0 0.0
.data.rel.ro 23176 23176 0 0.0
.dynamic 592 592 0 0.0
.got 4008 4008 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110024 110024 0 0.0
.text 1009714 1009522 -192 -0.0
ota-requestor-app debug .bss 205728 205728 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24488 24488 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 128744 128744 0 0.0
.text 1129298 1129090 -208 -0.0
shell debug .bss 16072 16072 0 0.0
.data 242 242 0 0.0
.data.rel.ro 35120 35120 0 0.0
.dynamic 592 592 0 0.0
.got 3496 3496 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 71823 71823 0 0.0
.text 569842 569794 -48 -0.0
tv-app debug .bss 216400 216400 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 55872 55872 0 0.0
.dynamic 592 592 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 152264 152264 0 0.0
.text 1461618 1461378 -240 -0.0
bridge-app debug+rpc .bss 52912 52912 0 0.0
.data 976 976 0 0.0
.data.rel.ro 25784 25784 0 0.0
.dynamic 592 592 0 0.0
.got 3944 3944 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 110620 110620 0 0.0
.text 1051093 1050901 -192 -0.0
lighting-app debug+rpc .bss 42232 42232 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 52496 52496 0 0.0
.dynamic 608 608 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 127825 127825 0 0.0
.text 1251314 1251138 -176 -0.0
2 builds (for mbed)
platform target config section 7c7e5c7 49e69b5 change % change
mbed lighting-app CY8CPROTO_062_4343W+release .bss 172164 172164 0 0.0
.data 5464 5464 0 0.0
.heap 858816 858816 0 0.0
.text 1220144 1220144 0 0.0
lock-app CY8CPROTO_062_4343W+release .bss 171084 171084 0 0.0
.data 5432 5432 0 0.0
.heap 859928 859928 0 0.0
.text 1198040 1198040 0 0.0
2 builds (for esp32)
platform target config section 7c7e5c7 49e69b5 change % change
esp32 all-clusters-app c3devkit .dram0.bss 60296 60264 -32 -0.1
.dram0.data 16192 16192 0 0.0
.flash.rodata 198992 198992 0 0.0
.flash.text 873186 873274 88 0.0
.iram0.text 57330 57330 0 0.0
m5stack .dram0.bss 62792 62760 -32 -0.1
.dram0.data 32084 32084 0 0.0
.flash.rodata 207736 207736 0 0.0
.flash.text 904335 904395 60 0.0
.iram0.text 125115 125115 0 0.0
10 builds (for nrfconnect)
platform target config section 7c7e5c7 49e69b5 change % change
nrfconnect lighting-app nrf52840dk_nrf52840 bss 112332 112332 0 0.0
rodata 97776 97776 0 0.0
text 577660 577660 0 0.0
lock-app nrf52840dk_nrf52840 bss 111348 111348 0 0.0
rodata 94112 94112 0 0.0
text 559160 559160 0 0.0
pigweed-app nrf52840dk_nrf52840 bss 51772 51772 0 0.0
rodata 45772 45772 0 0.0
text 339392 339392 0 0.0
pump-app nrf52840dk_nrf52840 bss 111416 111416 0 0.0
rodata 95092 95092 0 0.0
text 562312 562312 0 0.0
pump-controller-app nrf52840dk_nrf52840 bss 111356 111356 0 0.0
rodata 94172 94172 0 0.0
text 558952 558952 0 0.0
shell nrf52840dk_nrf52840 bss 107316 107316 0 0.0
rodata 71640 71640 0 0.0
text 519032 519032 0 0.0
lighting-app nrf52840dk_nrf52840+rpc bss 108572 108572 0 0.0
rodata 88560 88560 0 0.0
text 550864 550864 0 0.0
nrf5340dk_nrf5340_cpuapp bss 113704 113704 0 0.0
rodata 93016 93016 0 0.0
text 507124 507124 0 0.0
lock-app nrf5340dk_nrf5340_cpuapp bss 112720 112720 0 0.0
rodata 89372 89372 0 0.0
text 488616 488616 0 0.0
shell nrf5340dk_nrf5340_cpuapp bss 108300 108300 0 0.0
rodata 66284 66284 0 0.0
text 439632 439632 0 0.0

@github-actions
Copy link

github-actions bot commented Oct 20, 2021 •
edited
Loading

PR #10504: Size comparison from b51852b to fd9f32a

8 builds (for k32w, p6, qpg, telink)
platform target config section b51852b fd9f32a change % change
k32w lock-app k32w061+debug .bss 69052 69052 0 0.0
.data 1864 1864 0 0.0
.text 515536 515536 0 0.0
shell k32w061+debug .bss 55080 55080 0 0.0
.data 672 672 0 0.0
.text 357332 357332 0 0.0
lighting-app k32w061+se05x+release .bss 78576 78576 0 0.0
.data 1900 1900 0 0.0
.text 614320 614320 0 0.0
p6 lock-app default .bss 68208 68208 0 0.0
.data 2416 2416 0 0.0
.heap 962720 962720 0 0.0
.text 1126552 1126568 16 0.0
qpg lighting-app qpg6100+debug .bss 53552 53552 0 0.0
.data 996 996 0 0.0
.text 486624 486624 0 0.0
lock-app qpg6100+debug .bss 52488 52488 0 0.0
.data 952 952 0 0.0
.text 462700 462700 0 0.0
persistent-storage-app qpg6100+debug .bss 17778 17778 0 0.0
.data 280 280 0 0.0
.text 102704 102704 0 0.0
telink lighting-app tlsr9518adk80d bss 70992 70992 0 0.0
noinit 33216 33216 0 0.0
text 458322 458348 26 0.0
14 builds (for efr32, linux, mbed)
platform target config section b51852b fd9f32a change % change
efr32 lighting-app BRD4161A .bss 118028 118028 0 0.0
.data 1800 1800 0 0.0
.text 782896 782912 16 0.0
lock-app BRD4161A .bss 115884 115884 0 0.0
.data 1760 1760 0 0.0
.text 762056 762056 0 0.0
window-app BRD4161A .bss 116204 116204 0 0.0
.data 1764 1764 0 0.0
.text 762964 762964 0 0.0
lighting-app BRD4161A+rpc .bss 131356 131356 0 0.0
.data 1852 1852 0 0.0
.text 762636 762636 0 0.0
linux all-clusters-app debug .bss 52144 52144 0 0.0
.data 978 978 0 0.0
.data.rel.ro 58688 58688 0 0.0
.dynamic 592 592 0 0.0
.got 4080 4080 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 136373 136373 0 0.0
.text 1343330 1343138 -192 -0.0
chip-tool debug .bss 17520 17520 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 89344 89344 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 416 416 0 0.0
.rodata 184604 184604 0 0.0
.text 3428261 3428261 0 0.0
ota-provider-app debug .bss 37440 37440 0 0.0
.data 752 752 0 0.0
.data.rel.ro 23176 23176 0 0.0
.dynamic 592 592 0 0.0
.got 4008 4008 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110024 110024 0 0.0
.text 1009730 1009538 -192 -0.0
ota-requestor-app debug .bss 205696 205696 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24488 24488 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 128776 128776 0 0.0
.text 1129522 1129314 -208 -0.0
shell debug .bss 16072 16072 0 0.0
.data 242 242 0 0.0
.data.rel.ro 35120 35120 0 0.0
.dynamic 592 592 0 0.0
.got 3496 3496 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 71823 71823 0 0.0
.text 569842 569794 -48 -0.0
tv-app debug .bss 216368 216368 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 55872 55872 0 0.0
.dynamic 592 592 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 152296 152296 0 0.0
.text 1463186 1462946 -240 -0.0
bridge-app debug+rpc .bss 52880 52880 0 0.0
.data 976 976 0 0.0
.data.rel.ro 25784 25784 0 0.0
.dynamic 592 592 0 0.0
.got 3944 3944 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 110620 110620 0 0.0
.text 1051109 1050917 -192 -0.0
lighting-app debug+rpc .bss 42200 42200 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 52496 52496 0 0.0
.dynamic 608 608 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 127825 127825 0 0.0
.text 1251346 1251154 -192 -0.0
mbed lighting-app CY8CPROTO_062_4343W+release .bss 172092 172092 0 0.0
.data 5464 5464 0 0.0
.heap 858888 858888 0 0.0
.text 1220144 1220144 0 0.0
lock-app CY8CPROTO_062_4343W+release .bss 171012 171012 0 0.0
.data 5432 5432 0 0.0
.heap 860000 860000 0 0.0
.text 1198040 1198040 0 0.0
10 builds (for nrfconnect)
platform target config section b51852b fd9f32a change % change
nrfconnect lighting-app nrf52840dk_nrf52840 bss 112476 112476 0 0.0
rodata 97776 97776 0 0.0
text 577788 577788 0 0.0
lock-app nrf52840dk_nrf52840 bss 111540 111540 0 0.0
rodata 94112 94112 0 0.0
text 559276 559276 0 0.0
pigweed-app nrf52840dk_nrf52840 bss 51824 51824 0 0.0
rodata 45772 45772 0 0.0
text 339456 339456 0 0.0
pump-app nrf52840dk_nrf52840 bss 111612 111612 0 0.0
rodata 95092 95092 0 0.0
text 562432 562432 0 0.0
pump-controller-app nrf52840dk_nrf52840 bss 111552 111552 0 0.0
rodata 94172 94172 0 0.0
text 559068 559068 0 0.0
shell nrf52840dk_nrf52840 bss 107316 107316 0 0.0
rodata 71640 71640 0 0.0
text 519032 519032 0 0.0
lighting-app nrf52840dk_nrf52840+rpc bss 108716 108716 0 0.0
rodata 88560 88560 0 0.0
text 550988 550988 0 0.0
nrf5340dk_nrf5340_cpuapp bss 113852 113852 0 0.0
rodata 93016 93016 0 0.0
text 507252 507252 0 0.0
lock-app nrf5340dk_nrf5340_cpuapp bss 112916 112916 0 0.0
rodata 89372 89372 0 0.0
text 488736 488736 0 0.0
shell nrf5340dk_nrf5340_cpuapp bss 108300 108300 0 0.0
rodata 66284 66284 0 0.0
text 439632 439632 0 0.0
2 builds (for esp32)
platform target config section b51852b fd9f32a change % change
esp32 all-clusters-app c3devkit .dram0.bss 60288 60256 -32 -0.1
.dram0.data 16192 16192 0 0.0
.flash.rodata 198992 198992 0 0.0
.flash.text 873190 873274 84 0.0
.iram0.text 57330 57330 0 0.0
m5stack .dram0.bss 62792 62760 -32 -0.1
.dram0.data 32084 32084 0 0.0
.flash.rodata 207736 207736 0 0.0
.flash.text 904435 904495 60 0.0
.iram0.text 125115 125115 0 0.0

@github-actions
Copy link

Size increase report for "esp32-example-build" from b51852b

File Section File VM
chip-all-clusters-app.elf .flash.text 84 84
chip-all-clusters-app.elf .dram0.bss 0 -32
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,63915
.debug_str,0,1417
.debug_abbrev,0,968
.flash.text,84,84
.strtab,0,10
.riscv.attributes,0,2
.shstrtab,0,2
.dram0.bss,-32,0
.debug_ranges,0,-48
[Unmapped],0,-84
.debug_line,0,-371
.debug_loc,0,-491

@andy31415 andy31415 merged commit 77b0603 into project-chip:master Oct 21, 2021
@kpschoedel kpschoedel deleted the x7715-inet-3a-enum branch October 21, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@msandstedt msandstedt msandstedt approved these changes

@andy31415 andy31415 andy31415 approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@shana-apple shana-apple Awaiting requested review from shana-apple

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app controller examples inet lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kpschoedel @tcarmelveilleux @andy31415 @msandstedt @bzbarsky-apple