-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IM] Use DataModel::Encode in EncodeScalarAttributeWritePayload for complex types #10386
[IM] Use DataModel::Encode in EncodeScalarAttributeWritePayload for complex types #10386
Conversation
c989231
to
6ace986
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is at least not wrong now, though I still think the compare should be against the actual data we meant to send (i.e. the string) not an intermediate representation (the CharSpan), if it's possible....
By the way it might be worth using CharSpan instead of Span in general....
Problem
Need to support writing complex types.
Change overview
Testing