Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging for minMdns #10319

Merged

Conversation

tcarmelveilleux
Copy link
Contributor

Problem

  • minmdns has Replying to DNS-SD service listing request log that is not actually
    correct: it occurs even if no messages get sent, and too frequently, in a way that is
    not helpful.
  • Identity of querier that caused the query to be processed is missing, but very useful
    to understand network patterns.

Change overview

  • Remove duplicate log lines that falsely indicated
    sending when it was just building responses
  • When responding, clarify the identity of the querier
    that caused the response to be generated and sent

Testing

  • Unit tests ran
  • Ran unit tests and all-clusters-app commissioning on Linux

- Remove duplicate log lines that falsely indicated
  sending when it was just building responses
- When responding, clarify the identity of the querier
  that caused the response to be generated and sent

Testing done:

- Ran unit tests and all-clusters-app commissioning on Linux
@boring-cyborg boring-cyborg bot added the lib label Oct 7, 2021
@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Size increase report for "esp32-example-build" from c0ba6b1

File Section File VM
chip-all-clusters-app.elf .flash.text 4 4
chip-all-clusters-app.elf .flash.rodata -24 -24
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,245
.debug_loc,0,183
.debug_line,0,101
.debug_ranges,0,48
.debug_abbrev,0,36
[Unmapped],0,20
.debug_str,0,17
.flash.text,4,4
.riscv.attributes,0,2
.debug_frame,0,-4
.flash.rodata,-24,-24


@bzbarsky-apple bzbarsky-apple merged commit 5e25589 into project-chip:master Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants