Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP32: Read WiFi Network Diagnostics at runtime #10313

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

sweetymhaiske
Copy link
Contributor

Problem

  • Actual value from the platform is not populated at runtime for WiFi Network diagnostics attributes.

Change overview

  • Read WiFi Network Diagnostic attributes from a platform at runtime

Testing

  • All clusters app is compiled and checked using python controller.

@sweetymhaiske sweetymhaiske marked this pull request as ready for review October 8, 2021 13:38
@bzbarsky-apple
Copy link
Contributor

@sweetymhaiske Please address the restyle issues so pullapprove will request reviews?

@sweetymhaiske
Copy link
Contributor Author

@sweetymhaiske Please address the restyle issues so pullapprove will request reviews?

Done.

@github-actions
Copy link

Size increase report for "esp32-example-build" from 52b4ac6

File Section File VM
chip-all-clusters-app.elf .flash.text 236 236
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,12110
.debug_line,0,862
.debug_loc,0,822
.debug_str,0,754
.strtab,0,753
.debug_ranges,0,248
.flash.text,236,236
.debug_frame,0,196
.symtab,0,160
.debug_abbrev,0,132
.debug_aranges,0,40
.shstrtab,0,-1
[Unmapped],0,-236


@bzbarsky-apple
Copy link
Contributor

@woody-apple
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple merged commit a56c83e into project-chip:master Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants