-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP32: Read WiFi Network Diagnostics at runtime #10313
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
sweetymhaiske:wifi_diagnostics
Oct 15, 2021
Merged
ESP32: Read WiFi Network Diagnostics at runtime #10313
bzbarsky-apple
merged 1 commit into
project-chip:master
from
sweetymhaiske:wifi_diagnostics
Oct 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sweetymhaiske
force-pushed
the
wifi_diagnostics
branch
from
October 8, 2021 13:36
92e4359
to
c41650d
Compare
bzbarsky-apple
approved these changes
Oct 9, 2021
@sweetymhaiske Please address the restyle issues so pullapprove will request reviews? |
sweetymhaiske
force-pushed
the
wifi_diagnostics
branch
from
October 11, 2021 04:54
c41650d
to
b1b21d0
Compare
sweetymhaiske
force-pushed
the
wifi_diagnostics
branch
from
October 11, 2021 04:57
b1b21d0
to
70107de
Compare
pullapprove
bot
requested review from
andy31415,
austinh0,
chrisdecenzo,
Damian-Nordic,
erjiaqing,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
mlepage-google,
msandstedt,
mspang,
saurabhst,
yufengwangca and
yunhanw-google
October 11, 2021 04:57
Done. |
sweetymhaiske
force-pushed
the
wifi_diagnostics
branch
from
October 11, 2021 12:04
70107de
to
72b5e8e
Compare
sweetymhaiske
force-pushed
the
wifi_diagnostics
branch
from
October 11, 2021 12:06
72b5e8e
to
675c1eb
Compare
Size increase report for "esp32-example-build" from 52b4ac6
Full report output
|
@yufengwangca @Damian-Nordic @LuDuda @jepenven-silabs @jmartinez-silabs @chrisdecenzo Please take a look? |
jmartinez-silabs
approved these changes
Oct 11, 2021
woody-apple
approved these changes
Oct 11, 2021
yufengwangca
approved these changes
Oct 14, 2021
dhrishi
approved these changes
Oct 14, 2021
andy31415
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
Testing