Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ethernet network enable. #10311

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

cecille
Copy link
Contributor

@cecille cecille commented Oct 7, 2021

Problem

On-network devices do not actually have to have their network enabled (they are already enabled by definition). An enable call to enable an ethernet network was added previously to kick the device into operational advertising as a workaround. Now that operational certificate provisioning puts the device into operational advertising mode, this is no longer needed.

Change overview

Remove EnableNewtork call with magic code.

Testing

Commissioned on-network device, saw no enable call, device properly finished provisioning and was visible on the network.

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Size increase report for "gn_qpg-example-build" from 05f6882

File Section File VM
chip-qpg6100-lighting-example.out .text -120 -120
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-qpg6100-lighting-example.out and ./pull_artifact/chip-qpg6100-lighting-example.out:

sections,vmsize,filesize
[Unmapped],0,120
.debug_frame,0,-4
.symtab,0,-16
.debug_str,0,-23
.debug_abbrev,0,-40
.debug_line,0,-45
.debug_loc,0,-72
.text,-120,-120
.debug_info,0,-392

Comparing ./master_artifact/chip-qpg6100-lighting-example.out.map and ./pull_artifact/chip-qpg6100-lighting-example.out.map:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: unknown file type for file './pull_artifact/chip-qpg6100-lighting-example.out.map'


Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see that ETH0 thing go away!

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Size increase report for "nrfconnect-example-build" from 05f6882

File Section File VM
chip-lock.elf device_handles 4 4
chip-lock.elf text -52 -52
chip-lock.elf rodata -56 -60
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
device_handles,4,4
.debug_loc,0,3
.debug_frame,0,-4
.debug_line,0,-15
.symtab,0,-16
.debug_abbrev,0,-20
.debug_str,0,-23
text,-52,-52
rodata,-60,-56
.debug_info,0,-77

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize


@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Size increase report for "esp32-example-build" from 05f6882

File Section File VM
chip-all-clusters-app.elf .flash.rodata -48 -48
chip-all-clusters-app.elf .flash.text -56 -56
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
[Unmapped],0,104
.debug_loc,0,75
.riscv.attributes,0,1
.debug_abbrev,0,-20
.debug_str,0,-23
.flash.rodata,-48,-48
.flash.text,-56,-56
.debug_line,0,-74
.debug_info,0,-95


@tcarmelveilleux tcarmelveilleux merged commit a4b965e into project-chip:master Oct 8, 2021
@cecille cecille deleted the remove_magic_code branch November 24, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants