-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zcl remove old reporting code #10304
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
vivien-apple:ZCL_RemoveOldReportingCode
Oct 12, 2021
Merged
Zcl remove old reporting code #10304
bzbarsky-apple
merged 2 commits into
project-chip:master
from
vivien-apple:ZCL_RemoveOldReportingCode
Oct 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
Damian-Nordic,
emargolis,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
shana-apple and
tcarmelveilleux
October 7, 2021 09:35
vivien-apple
force-pushed
the
ZCL_RemoveOldReportingCode
branch
2 times, most recently
from
October 7, 2021 11:23
27bb0b7
to
c405ca7
Compare
bzbarsky-apple
approved these changes
Oct 7, 2021
andy31415
approved these changes
Oct 8, 2021
yunhanw-google
approved these changes
Oct 8, 2021
vivien-apple
force-pushed
the
ZCL_RemoveOldReportingCode
branch
from
October 11, 2021 08:48
c405ca7
to
08226e3
Compare
Size increase report for "gn_qpg-example-build" from 52b4ac6
Full report output
|
Size increase report for "nrfconnect-example-build" from 52b4ac6
Full report output
|
Size increase report for "esp32-example-build" from 52b4ac6
Full report output
|
@msandstedt @saurabhst @jepenven-silabs @jmartinez-silabs @Damian-Nordic Please take a look? |
woody-apple
approved these changes
Oct 11, 2021
msandstedt
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Since reporting has been converted to
SubscribeInteraction
the old ZCL code is not needed anymore and is just dead code.Change overview
InteractionModelReportingAttributeChangeCallback
toMatterReportingAttributeChangeCallback
Testing
This code should not be used...