Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zcl remove old reporting code #10304

Merged

Conversation

vivien-apple
Copy link
Contributor

Problem

Since reporting has been converted to SubscribeInteraction the old ZCL code is not needed anymore and is just dead code.

Change overview

  • Remove dead reporting code
  • Rename InteractionModelReportingAttributeChangeCallback to MatterReportingAttributeChangeCallback

Testing

This code should not be used...

@pullapprove pullapprove bot requested review from turon and woody-apple October 7, 2021 09:35
@vivien-apple vivien-apple force-pushed the ZCL_RemoveOldReportingCode branch 2 times, most recently from 27bb0b7 to c405ca7 Compare October 7, 2021 11:23
@vivien-apple vivien-apple force-pushed the ZCL_RemoveOldReportingCode branch from c405ca7 to 08226e3 Compare October 11, 2021 08:48
@github-actions
Copy link

Size increase report for "gn_qpg-example-build" from 52b4ac6

File Section File VM
chip-qpg6100-lighting-example.out .heap 0 544
chip-qpg6100-lighting-example.out .bss 0 -544
chip-qpg6100-lighting-example.out .text -3372 -3372
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-qpg6100-lighting-example.out.map and ./pull_artifact/chip-qpg6100-lighting-example.out.map:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: unknown file type for file './pull_artifact/chip-qpg6100-lighting-example.out.map'

Comparing ./master_artifact/chip-qpg6100-lighting-example.out and ./pull_artifact/chip-qpg6100-lighting-example.out:

sections,vmsize,filesize
[Unmapped],0,3372
.heap,544,0
.shstrtab,0,2
.debug_aranges,0,-240
.bss,-544,0
.debug_frame,0,-832
.debug_ranges,0,-952
.symtab,0,-1056
.strtab,0,-1126
.debug_str,0,-3225
.text,-3372,-3372
.debug_loc,0,-5404
.debug_abbrev,0,-7277
.debug_line,0,-12719
.debug_info,0,-86023


@github-actions
Copy link

Size increase report for "nrfconnect-example-build" from 52b4ac6

File Section File VM
chip-lock.elf device_handles 8 8
chip-lock.elf bss 0 -96
chip-lock.elf rodata -640 -644
chip-lock.elf text -2664 -2664
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
device_handles,8,8
.shstrtab,0,-2
bss,-96,0
.debug_aranges,0,-240
rodata,-644,-640
.debug_frame,0,-804
.debug_ranges,0,-912
.symtab,0,-1232
.strtab,0,-1290
text,-2664,-2664
.debug_str,0,-3164
.debug_loc,0,-5316
.debug_abbrev,0,-7556
.debug_line,0,-11980
.debug_info,0,-92188


@github-actions
Copy link

Size increase report for "esp32-example-build" from 52b4ac6

File Section File VM
chip-all-clusters-app.elf .flash.rodata -2256 -2256
chip-all-clusters-app.elf .flash.text -3616 -3616
chip-all-clusters-app.elf .dram0.bss 0 -4592
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
[Unmapped],0,1784
.shstrtab,0,1
.dram0.data,0,-8
.debug_aranges,0,-232
.symtab,0,-512
.debug_frame,0,-908
.debug_ranges,0,-1040
.strtab,0,-1589
.flash.rodata,-2256,-2256
.debug_str,0,-3135
.flash.text,-3616,-3616
.debug_loc,0,-4453
.dram0.bss,-4592,0
.debug_abbrev,0,-10378
.debug_line,0,-18565
.debug_info,0,-266793


@bzbarsky-apple
Copy link
Contributor

@woody-apple
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple merged commit 28faab3 into project-chip:master Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants