Update chip-build Dockerfile (#10149) #10289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem `gh_report.py` doesn't run in the `chip-build` container. #### Change overview Add python package `tabulate`. #### Testing Local run of `gh_report.py` in the updated container, configured to actually post github comments.
|
Apologies for the churn. I hadn't known that pip packages could have dynamic dependencies. |
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
Damian-Nordic,
erjiaqing,
franck-apple,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
shana-apple,
tcarmelveilleux,
turon and
vivien-apple
bzbarsky-apple
approved these changes
Oct 6, 2021
saurabhst
approved these changes
Oct 6, 2021
woody-apple
approved these changes
Oct 7, 2021
andy31415
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
gh_report.pydoesn't run in thechip-buildcontainer.Change overview
Add python package
tabulate.Testing
Local run of
gh_report.pyin the updated container,configured to actually post github comments.